Skip to content
Python

fix(auto-approve): reviewer before shadow evaluation in Settings, drop the '(for measuring)' note (OPE-224)

Devika Vermac4f75a274030
diff --git a/surfaces/gui/src/components/SettingsView.tsx b/surfaces/gui/src/components/SettingsView.tsx
index b37498d1..2b69d441 100644
--- a/surfaces/gui/src/components/SettingsView.tsx
+++ b/surfaces/gui/src/components/SettingsView.tsx
@@ -1493,6 +1493,58 @@ function AutoApproveCard() {
</span>
</span>
</label>
+ {/* Which reviewer judges the checks (OPE-224). Shown only when something uses it:
+ Auto-approve mode, or shadow evaluation, which records that reviewer's verdicts. */}
+ {(on || shadow) && (
+ <div className="pt-3 pl-7" data-testid="auto-approve-reviewer">
+ <div className="flex items-center gap-2.5">
+ <span className="text-ui text-ink">{t("settingsx.auto_approve.reviewer_title")}</span>
+ <select
+ value={reviewer}
+ data-testid="auto-approve-reviewer-select"
+ className="px-2 py-1.5 rounded-lg border border-line bg-paper text-ui text-ink outline-none focus:border-accent"
+ onChange={(e) => saveReviewer(e.target.value as ReviewerChoice)}
+ >
+ {choices.map((c) => (
+ <option key={c} value={c}>
+ {t(`settingsx.auto_approve.reviewer_${choiceKey(c)}`)}
+ </option>
+ ))}
+ </select>
+ </div>
+ <div className={FIELD_HELP}>{t(`settingsx.auto_approve.reviewer_${choiceKey(reviewer)}_desc`)}</div>
+ {reviewer !== "session" && (
+ <div className="pt-2" data-testid="auto-approve-reviewer-key">
+ <div className="text-meta text-muted pb-1">{t("settingsx.auto_approve.reviewer_no_reasons")}</div>
+ {keys[reviewer] ? (
+ <div className="text-meta text-ok">{t("settingsx.auto_approve.reviewer_key_set")}</div>
+ ) : (
+ <div className="flex items-center gap-2">
+ <input
+ type="password"
+ autoComplete="off"
+ className={INPUT}
+ data-testid="auto-approve-reviewer-key-input"
+ placeholder={t(`settingsx.auto_approve.reviewer_key_placeholder_${choiceKey(reviewer)}`)}
+ value={keyDraft}
+ onChange={(e) => setKeyDraft(e.target.value)}
+ />
+ <button
+ type="button"
+ className={BTN_ACCENT}
+ data-testid="auto-approve-reviewer-key-save"
+ disabled={!keyDraft.trim()}
+ onClick={saveKey}
+ >
+ {t("settingsx.auto_approve.reviewer_key_save")}
+ </button>
+ </div>
+ )}
+ {keyError && <div className="text-meta text-danger pt-1">{keyError}</div>}
+ </div>
+ )}
+ </div>
+ )}
<label className="flex items-start gap-3 py-2 pl-7">
<input
type="checkbox"
@@ -1551,58 +1603,6 @@ function AutoApproveCard() {
)}
</div>
)}
- {/* Which reviewer judges the checks (OPE-224). Shown only when something uses it:
- Auto-approve mode, or shadow evaluation, which records that reviewer's verdicts. */}
- {(on || shadow) && (
- <div className="pt-3 pl-7" data-testid="auto-approve-reviewer">
- <div className="flex items-center gap-2.5">
- <span className="text-ui text-ink">{t("settingsx.auto_approve.reviewer_title")}</span>
- <select
- value={reviewer}
- data-testid="auto-approve-reviewer-select"
- className="px-2 py-1.5 rounded-lg border border-line bg-paper text-ui text-ink outline-none focus:border-accent"
- onChange={(e) => saveReviewer(e.target.value as ReviewerChoice)}
- >
- {choices.map((c) => (
- <option key={c} value={c}>
- {t(`settingsx.auto_approve.reviewer_${choiceKey(c)}`)}
- </option>
- ))}
- </select>
- </div>
- <div className={FIELD_HELP}>{t(`settingsx.auto_approve.reviewer_${choiceKey(reviewer)}_desc`)}</div>
- {reviewer !== "session" && (
- <div className="pt-2" data-testid="auto-approve-reviewer-key">
- <div className="text-meta text-muted pb-1">{t("settingsx.auto_approve.reviewer_no_reasons")}</div>
- {keys[reviewer] ? (
- <div className="text-meta text-ok">{t("settingsx.auto_approve.reviewer_key_set")}</div>
- ) : (
- <div className="flex items-center gap-2">
- <input
- type="password"
- autoComplete="off"
- className={INPUT}
- data-testid="auto-approve-reviewer-key-input"
- placeholder={t(`settingsx.auto_approve.reviewer_key_placeholder_${choiceKey(reviewer)}`)}
- value={keyDraft}
- onChange={(e) => setKeyDraft(e.target.value)}
- />
- <button
- type="button"
- className={BTN_ACCENT}
- data-testid="auto-approve-reviewer-key-save"
- disabled={!keyDraft.trim()}
- onClick={saveKey}
- >
- {t("settingsx.auto_approve.reviewer_key_save")}
- </button>
- </div>
- )}
- {keyError && <div className="text-meta text-danger pt-1">{keyError}</div>}
- </div>
- )}
- </div>
- )}
</div>
);
}
diff --git a/surfaces/gui/src/locales/en.json b/surfaces/gui/src/locales/en.json
index a51825fa..595455f0 100644
--- a/surfaces/gui/src/locales/en.json
+++ b/surfaces/gui/src/locales/en.json
@@ -2487,7 +2487,7 @@
"title": "Auto-approve (experimental)",
"enable": "Enable Auto-approve mode",
"enable_desc": "Adds an <em>Auto-approve</em> option to the mode picker. In that mode, the reviewer you choose below checks each action that would normally need approval and clears the routine ones; anything doubtful still asks you. It can never allow something the rules block. One extra model call per check, billed to your usage.",
- "shadow_title": "Shadow evaluation <faint>(for measuring)</faint>",
+ "shadow_title": "Shadow evaluation",
"shadow_desc": "On any mode, the reviewer records what it <em>would</em> have decided next to your own choice — without changing anything. Lets you see how it would behave before trusting it. Also costs one model call per approval.",
"reviewer_title": "Reviewer",
"reviewer_session": "Session’s own model (default)",
diff --git a/surfaces/gui/src/locales/zh.json b/surfaces/gui/src/locales/zh.json
index 28225154..143d652f 100644
--- a/surfaces/gui/src/locales/zh.json
+++ b/surfaces/gui/src/locales/zh.json
@@ -2443,7 +2443,7 @@
"title": "自动审批(实验性)",
"enable": "启用自动审批模式",
"enable_desc": "在模式选择器中添加<em>自动审批</em>选项。在该模式下,你在下方选择的审查器会检查每个通常需要审批的操作,并放行常规操作;拿不准的仍会询问你。它永远无法允许规则禁止的操作。每次检查多一次模型调用,计入你的用量。",
- "shadow_title": "影子评估 <faint>(用于衡量)</faint>",
+ "shadow_title": "影子评估",
"shadow_desc": "在任何模式下,审查器都会在你自己的选择旁记录它<em>本会</em>做出的决定 —— 不改变任何事情。让你在信任它之前先看看它的表现。每次审批同样多一次模型调用。",
"reviewer_title": "审查器",
"reviewer_session": "会话自身的模型(默认)",