Python
Refresh team approvals and streamline background activity and navigation
Rohit C Prasadf3c5977eff70
diff --git a/coworker/agent.py b/coworker/agent.pyindex ef87c512..6e6606f1 100644--- a/coworker/agent.py+++ b/coworker/agent.py@@ -714,6 +714,7 @@ def build_engine(if auto_approve_shadow is not Noneelse getattr(config, "auto_approve_shadow", False))+ engine.reviewer_enabled = bool(live_on)if live_on or shadow_on:from .reviewer import Reviewer@@ -723,8 +724,8 @@ def build_engine(known_world=engine.session_facts.world.render(),)# Shadow evaluation (Part 6 step 3): with only the shadow flag on, the reviewer is- # attached but the LIVE path stays off unless the session is actually in- # Mode.AUTO_APPROVE — shadow verdicts are recorded on approval cards in any mode.+ # attached but the LIVE path stays off unless the live feature flag is also on+ # and the session is in Mode.AUTO_APPROVE. Shadow verdicts never clear actions.engine.reviewer_shadow = bool(shadow_on)engine.audit_context = {"session_id": session_id or "",diff --git a/coworker/engine.py b/coworker/engine.pyindex 93a7f0c3..a973e970 100644--- a/coworker/engine.py+++ b/coworker/engine.py@@ -224,6 +224,9 @@ class TurnEngine:# the owner-hit 2026-08-24 was a 2-denial cumulative trip silently downgrading a# long agentic turn to hand-approval for everything after one over-strict pair.self.reviewer: Optional[Any] = None+ self.reviewer_enabled = True # standalone injected reviewers; manager supplies live flag+ self.reviewer_settings_epoch = 0+ self.reviewer_settings_key = Noneself._reviewer_denials = 0self._reviewer_verdicts: dict[str, Any] = {}# (c) How each consequential call got cleared, keyed by tool_call id:@@ -1166,6 +1169,7 @@ class TurnEngine:return (self.reviewer is not None+ and self.reviewer_enabledand self.permissions.mode is Mode.AUTO_APPROVEand self.is_attended is not Noneand self.is_attended()@@ -1265,9 +1269,11 @@ class TurnEngine:if not pending:returnrequest, history = self._user_history()+ consulted_reviewer = self.reviewer+ settings_epoch = self.reviewer_settings_epochverdicts = await asyncio.gather(*[- self.reviewer.review(+ consulted_reviewer.review(request=request,history=history,tool_name=tc.name,@@ -1278,6 +1284,10 @@ class TurnEngine:])for tc, verdict in zip(pending, verdicts):+ if (self.reviewer is not consulted_reviewer+ or self.reviewer_settings_epoch != settings_epoch+ or not self._reviewer_active()):+ verdict = replace(verdict, verdict="unsure", reason="Approval settings changed during review; a human decision is required.")self._reviewer_verdicts[tc.id] = verdictasync def _consult_reviewer(self, tool_call: ToolCall) -> Any:@@ -1492,7 +1502,13 @@ class TurnEngine:# configs, unscopable writes) skip the reviewer entirely: their floor is that# a PERSON sees them, and a verdict here would be that floor's bypass.consulted_live = True+ consulted_reviewer = self.reviewer+ settings_epoch = self.reviewer_settings_epochverdict = await self._consult_reviewer(tool_call)+ if (self.reviewer is not consulted_reviewer+ or self.reviewer_settings_epoch != settings_epoch+ or not self._reviewer_active()):+ verdict = replace(verdict, verdict="unsure", reason="Approval settings changed during review; a human decision is required.")self._audit(tool_call,stage="reviewer_verdict",diff --git a/coworker/server/app.py b/coworker/server/app.pyindex a75384c1..995e3eaf 100644--- a/coworker/server/app.py+++ b/coworker/server/app.py@@ -3087,6 +3087,7 @@ def create_app(manager: SessionManager) -> FastAPI:# records it, Recents doesn't reorder. The next real turn's# checkpoint save bumps recency as usual.manager.save(session_id, engine, touch=False)+ manager.sync_cached_reviewers()await manager.broadcast_session(session_id,{"type": "mode_notice", "data": notice_data},diff --git a/coworker/server/manager.py b/coworker/server/manager.pyindex db1e0b26..c5b4fcb7 100644--- a/coworker/server/manager.py+++ b/coworker/server/manager.py@@ -1081,6 +1081,7 @@ class SessionManager:lead hears about it on the board. Read at every engine use, never copied."""lead_mode = self.lead_mode_for(session_id)if lead_mode is None:+ self.sync_reviewer(engine)# Not a worker: a configuration-spawned auto-approve session still counts as# attended for the reviewer (§11.5) — unless a live client already decides.if engine.is_attended is None and self.reviewer_opted(session_id):@@ -1088,12 +1089,40 @@ class SessionManager:returnmode = self._mode_value(lead_mode)if mode is None:+ self.sync_reviewer(engine)returnif mode in (Mode.DISCUSS, Mode.PLAN):mode = Mode.INTERACTIVE # read-only leads still let their workers work, with approvalengine.permissions.mode = mode+ self.sync_reviewer(engine)engine.is_attended = lambda: self._mode_value(self.lead_mode_for(session_id) or "") is Mode.AUTO_APPROVE+ def sync_reviewer(self, engine: TurnEngine) -> None:+ """Hot-apply feature availability without rebuilding a running engine.++ Does not resolve parked prompts or reset the per-turn denial guard.+ """+ live, shadow = self.auto_approve(), self.auto_approve_shadow()+ key = (live, shadow, engine.permissions.mode)+ if engine.reviewer_settings_key != key:+ engine.reviewer_settings_epoch += 1+ engine.reviewer_settings_key = key+ engine._reviewer_verdicts.clear()+ engine.reviewer_enabled = live+ engine.reviewer_shadow = shadow+ if not live and not shadow:+ engine.reviewer = None+ elif engine.reviewer is None:+ from ..reviewer import Reviewer+ engine.reviewer = Reviewer(+ provider=engine.provider, model=engine.model,+ known_world=engine.session_facts.world.render() if engine.session_facts else "",+ )++ def sync_cached_reviewers(self) -> None:+ for sid, engine in list(self._engines.items()):+ self.sync_worker_mode(sid, engine)+def decide_worker_call(self, lead_session_id: str, worker: str, call_id: str, decision: str, note: str = "") -> dict[str, Any]:"""The lead's `decide_worker_call` (spec §11.6): resolve one of ITS workers'parked tool calls. The tool call that got here already passed the lead's own@@ -4462,6 +4491,7 @@ class SessionManager:def set_auto_approve(self, on: Any) -> dict[str, Any]:self._prefs["auto_approve"] = bool(on)self._save_prefs()+ self.sync_cached_reviewers()return {"ok": True,"auto_approve": self.auto_approve(),@@ -4471,6 +4501,7 @@ class SessionManager:def set_auto_approve_shadow(self, on: Any) -> dict[str, Any]:self._prefs["auto_approve_shadow"] = bool(on)self._save_prefs()+ self.sync_cached_reviewers()return {"ok": True,"auto_approve": self.auto_approve(),@@ -5863,6 +5894,13 @@ class SessionManager:if board_delivery and activity["board_text"]:message = activity["board_text"]source = {**source, "text": message, "board": {"rows": activity["board_rows"]}}+ elif wake is not None and wake.kind == "timer":+ team = self.teams.for_lead_session(session_id)+ if team is not None:+ # Display-only tagging: keep timer receipt and cancellation+ # semantics intact while grouping check-ins in the transcript.+ source = self._board_source(team, message, rows=activity["board_rows"])+ source["board"]["check_in"] = Trueasync for event in engine.run(message, source=source, activity=activity):# Stream every event to any socket viewing this session, so a background turn# (channel delivery, self-wake, durable resume) is seen live — not just on reselect.diff --git a/surfaces/gui/e2e/team-view.spec.ts b/surfaces/gui/e2e/team-view.spec.tsindex 1adfead1..54e7b42b 100644--- a/surfaces/gui/e2e/team-view.spec.ts+++ b/surfaces/gui/e2e/team-view.spec.ts@@ -1,5 +1,35 @@import { expect, test } from "@playwright/test";+for (const theme of ["light", "dark"]) {+ test(`right panel opens team tabs and workers beside the lead (${theme})`, async ({ page }) => {+ await page.addInitScript((value) => {+ localStorage.setItem("coworker:rail-hidden:v1", "0");+ localStorage.setItem("openwork-theme", value);+ }, theme);+ await page.setViewportSize({ width: 1440, height: 1000 });+ await page.goto("/?scenario=team-view-5#/s/scn-team-view-5");+ const toggle = page.getByTestId("rail-toggle-team");+ await expect(toggle).toBeVisible();+ await toggle.click();+ await expect(page.getByTestId("team-chat-off")).toBeVisible();+ await page.getByTestId("rail-open-team-view").click();+ const pane = page.getByTestId("team-view");+ await expect(pane.getByRole("tab")).toHaveCount(3);+ await pane.getByRole("button", { name: "Close team view" }).click();+ await page.screenshot({ path: `test-results/team-rail-${theme}.png` });+ await page.getByTestId("team-row-sam").click();+ await expect(pane.getByRole("heading", { name: "sam", exact: true })).toBeVisible();+ await expect(page).toHaveURL(/#\/s\/scn-team-view-5$/);+ await expect(page.getByTestId("session-title")).toHaveText("Refund rounding · Acme");+ await expect.poll(() => page.locator(".sidebar").evaluate(el => el.getBoundingClientRect().right)).toBeLessThanOrEqual(1);+ await page.screenshot({ path: `test-results/team-rail-worker-${theme}.png` });+ await pane.getByRole("button", { name: "Open full session" }).click();+ await expect(page).toHaveURL(/#\/s\/scn-team-view-5-sam$/);+ await page.getByRole("button", { name: "Back to lead" }).click();+ await expect(page).toHaveURL(/#\/s\/scn-team-view-5$/);+ });+}+test("a directly opened worker retains a route back to its lead after reload", async ({ page }) => {await page.goto("/?scenario=team-view-5#/s/scn-team-view-5-sam");await expect(page.getByTestId("session-title")).toHaveText("sam");@@ -137,6 +167,9 @@ test("quick look is keyboard controlled and does not move the composer", async (});const composer = page.getByPlaceholder(/Ask the coworker/);const before = await composer.boundingBox();+ const iconBox = await icon.boundingBox();+ const textInset = await composer.evaluate(el => parseFloat(getComputedStyle(el).paddingLeft));+ expect(Math.abs(iconBox!.x - before!.x - textInset)).toBeLessThanOrEqual(1);await icon.hover();expect(await composer.boundingBox()).toEqual(before);await icon.focus();diff --git a/surfaces/gui/e2e/team.spec.ts b/surfaces/gui/e2e/team.spec.tsindex b4f61994..4ad42f77 100644--- a/surfaces/gui/e2e/team.spec.ts+++ b/surfaces/gui/e2e/team.spec.ts@@ -203,9 +203,11 @@ test("approval creates the team; members live in the drawer, RECENT keeps one enawait expect(panel.getByTestId("team-row-webb")).toContainText("idle");await expect(panel.getByTestId("team-row-checks")).toContainText("#4 blocked");- // A member row is the escape hatch — clicking opens that worker's session, where- // the drawer is a plain worker drawer again (Progress back, no Team panel).+ // Worker inspection keeps the lead alongside; full navigation is explicit.await panel.getByTestId("team-row-nia").click();+ await expect(page.getByTestId("team-view")).toBeVisible();+ await expect(page.getByTestId("session-title")).toHaveText("Build the statements page");+ await page.getByRole("button", { name: "Open full session" }).click();await expect(page.getByTestId("rail-toggle-progress")).toBeVisible();await expect(page.getByTestId("rail-toggle-team")).toHaveCount(0);await page.getByRole("button", { name: "Back to lead" }).click();diff --git a/surfaces/gui/src/App.tsx b/surfaces/gui/src/App.tsxindex f74829c3..4a4d118c 100644--- a/surfaces/gui/src/App.tsx+++ b/surfaces/gui/src/App.tsx@@ -394,6 +394,7 @@ export function App() {boardSessionRef.current = sessionId;const [boardOwner, setBoardOwner] = useState("");const [teamViewOpen, setTeamViewOpen] = useState(false);+ const [teamWorkerId, setTeamWorkerId] = useState<string | null>(null);const [teamSummary, setTeamSummary] = useState<TeamSummary | null>(null);// A rail row click deep-opens the overlay on that item's detail pane.const [boardDetailId, setBoardDetailId] = useState<number | null>(null);@@ -487,7 +488,7 @@ export function App() {const show = () => {setRailHidden(false);setBoardRailKey((k) => k + 1);- setBoardDetailId(null); setTeamViewOpen(true);+ setBoardDetailId(null); setTeamWorkerId(null); setTeamViewOpen(true);};window.addEventListener("ocw-open-board", show);return () => window.removeEventListener("ocw-open-board", show);@@ -1246,7 +1247,7 @@ export function App() {const open = (e: Event) => {const d = (e as CustomEvent).detail;if (d?.sessionId !== sessionId || d.space !== board?.space || !board?.items.some(i => i.id === d.id)) return;- setBoardDetailId(d.id); setBoardRailKey(k => k + 1); setTeamViewOpen(true); setRailHidden(false);+ setBoardDetailId(d.id); setTeamWorkerId(null); setBoardRailKey(k => k + 1); setTeamViewOpen(true); setRailHidden(false);};window.addEventListener(OPEN_TASK_EVENT, open);return () => window.removeEventListener(OPEN_TASK_EVENT, open);@@ -1266,7 +1267,7 @@ export function App() {(s) => s.team?.role === "worker" && s.team.lead_session === sessionId,);- useEffect(() => { setTeamViewOpen(false); setBoardDetailId(null); setTeamSummary(null); }, [sessionId]);+ useEffect(() => { setTeamViewOpen(false); setBoardDetailId(null); setTeamWorkerId(null); setTeamSummary(null); }, [sessionId]);const activeTeamId = curSession?.team?.team_id;useEffect(() => {if (!activeTeamId || surface !== "session") { setTeamSummary(null); return; }@@ -1276,7 +1277,7 @@ export function App() {}).catch(() => { if (!canceled) setTeamSummary(null); });return () => { canceled = true; };}, [sessionId, activeTeamId, surface, sessions, browserRefreshKey, running]);- const openTeamView = (id?: number) => { setBoardDetailId(id ?? null); setBoardRailKey(k => k + 1); setTeamViewOpen(true); setRailHidden(false); };+ const openTeamView = (id?: number) => { setBoardDetailId(id ?? null); setTeamWorkerId(null); setBoardRailKey(k => k + 1); setTeamViewOpen(true); setRailHidden(false); };// Keep the active session's pending Inbox items fresh (answer-in-context card). Loads on session// change + after each turn, plus a slow poll so an unattended agent's new question surfaces.@@ -2473,7 +2474,7 @@ export function App() {/></div><RightRail- teamView={teamViewOpen ? <TeamView openKey={boardRailKey} board={boardOwner === sessionId ? board : null} summary={teamSummary?.lead_session === sessionId ? teamSummary : null} initialItem={boardDetailId} sessionId={sessionId} sessions={sessions} machine={machine} machineName={curSession?.machine_name} onClose={() => { setTeamViewOpen(false); setBoardDetailId(null); }} onRefresh={() => { void refreshBoard(); setBrowserRefreshKey(k => k + 1); }} /> : undefined}+ teamView={teamViewOpen ? <TeamView openKey={boardRailKey} board={boardOwner === sessionId ? board : null} summary={teamSummary?.lead_session === sessionId ? teamSummary : null} initialItem={boardDetailId} initialWorkerId={teamWorkerId} onOpenFullSession={(id) => { const w = sessions.find(s => s.session_id === id); if (w) void selectSession(w.session_id, w.workspace, w.agent); }} sessionId={sessionId} sessions={sessions} machine={machine} machineName={curSession?.machine_name} onClose={() => { setTeamViewOpen(false); setBoardDetailId(null); setTeamWorkerId(null); }} onRefresh={() => { void refreshBoard(); setBrowserRefreshKey(k => k + 1); }} /> : undefined}active={surface === "session" && agent !== "chat" && !railHidden}sessionId={sessionId}refreshKey={browserRefreshKey}@@ -2492,11 +2493,9 @@ export function App() {openAccessKey={accessKey}onOpenIntegrations={() => openSettings("connectors")}board={board}- onExpandBoard={() => setTeamViewOpen(true)}- onOpenBoardItem={(id) => {- setBoardDetailId(id);- setTeamViewOpen(true);- }}+ onExpandBoard={() => openTeamView()}+ onOpenBoardItem={openTeamView}+ onOpenTeamView={() => openTeamView()}/* team serializes as {} for plain sessions — lead-ness needs an actualrole, else every solo session loses its Progress panel (owner-hit2026-08-21: the rail showed nothing but "More"). */@@ -2509,7 +2508,7 @@ export function App() {teamChatUnread={curSession?.team?.chat_unread || 0}teamUsage={teamMembers.length ? teamUsage(usage, teamMembers) : undefined}onOpenTeamChat={() => setChatTeam(curSession?.team?.team_id || "")}- onOpenWorker={(w) => void selectSession(w.session_id, w.workspace, w.agent)}+ onOpenWorker={(w) => { setBoardDetailId(null); setTeamWorkerId(w.session_id); setBoardRailKey(k => k + 1); setTeamViewOpen(true); setRailHidden(false); }}openBoardKey={boardRailKey}/>diff --git a/surfaces/gui/src/api.ts b/surfaces/gui/src/api.tsindex e8851980..3c406976 100644--- a/surfaces/gui/src/api.ts+++ b/surfaces/gui/src/api.ts@@ -328,7 +328,7 @@ export interface MessageSource {text: string; // the RAW message (what the card shows)// Board wakes only (connector === "board"): the digest as structured rows, so// the BoardWakeCard renders collapsed summaries instead of re-parsing prose.- board?: { rows: BoardWakeRow[] };+ board?: { rows: BoardWakeRow[]; check_in?: boolean };}// One digest event on a board wake. `note` is a UI-clamped excerpt of a hand-offdiff --git a/surfaces/gui/src/components/RightRail.tsx b/surfaces/gui/src/components/RightRail.tsxindex e8144cb3..ed04ca89 100644--- a/surfaces/gui/src/components/RightRail.tsx+++ b/surfaces/gui/src/components/RightRail.tsx@@ -85,6 +85,7 @@ interface Props {teamUsage?: SessionUsage;onOpenTeamChat?: () => void;onOpenWorker?: (s: SessionInfo) => void;+ onOpenTeamView?: () => void;// Bumped when a [.](board:) chip in the transcript is clicked — expands the Board section.openBoardKey?: number;}@@ -116,6 +117,7 @@ export function RightRail({teamUsage,onOpenTeamChat,onOpenWorker,+ onOpenTeamView,openBoardKey = 0,}: Props) {const { t } = useTranslation();@@ -299,13 +301,16 @@ export function RightRail({count={String(teamMembers.length)}><div className="rail-team" data-testid="team-panel">+ {onOpenTeamView && <button className="rail-team-row" data-testid="rail-open-team-view" onClick={onOpenTeamView}>+ <Icon name="panelOpen" size={13} /> {t("teamview.open_view")}+ </button>}{teamMembers.map((w) => (<buttonclassName="rail-team-row"key={w.session_id}data-testid={`team-row-${w.team?.actor || w.session_id}`}onClick={() => onOpenWorker?.(w)}- title={t("rail.team_open_session", { name: w.team?.actor || t("rail.team_worker") })}+ title={t("teamview.open_worker_pane", { name: w.team?.actor || t("rail.team_worker") })}><span className={"team-dot " + (w.team?.status || "idle")} /><span className="rail-team-name">{w.team?.actor || w.agent}</span>@@ -320,6 +325,7 @@ export function RightRail({{teamChatUnread > 0 && <span className="team-chat-badge">{teamChatUnread}</span>}</button>)}+ {!teamChatEnabled && <p className="team-totals" data-testid="team-chat-off">{t("teamview.chat_off")}</p>}{teamUsage && totalTokens(teamUsage) > 0 && (/* Tokens for the whole tree (lead + workers), by model. Counts only —no dollars (owner ruling, spec §5). */diff --git a/surfaces/gui/src/components/TeamUpdateLine.tsx b/surfaces/gui/src/components/TeamUpdateLine.tsxindex 644802ea..8ad52e3c 100644--- a/surfaces/gui/src/components/TeamUpdateLine.tsx+++ b/surfaces/gui/src/components/TeamUpdateLine.tsx@@ -69,14 +69,27 @@ export function foldTeamUpdates(next.source.connector === "board" &&next.source.channel_id === item.source.channel_id) {- steps.push(...items.slice(end + 1, j));sources.push(next.source);end = j;continue;}- if (next.kind === "tool") continue;- if (next.kind === "assistant" && !next.text.trim() && !next.reasoning)+ if (next.kind === "tool") {+ steps.push(next);+ end = j;continue;+ }+ if (next.kind === "assistant") {+ // Narration preceding a tool belongs to the background check. A terminal+ // answer, decision, human message, or pending approval remains visible.+ const following = items[j + 1];+ const verdict = following?.kind === "tool" && following.name === "transition"+ && ["review", "done", "canceled"].includes(String(following.args.to));+ if ((!next.text.trim() && !next.reasoning) || (following?.kind === "tool" && !verdict)) {+ steps.push(next);+ end = j;+ continue;+ }+ }break;}out.push({ item, sources, steps });@@ -111,7 +124,7 @@ export function TeamUpdateLine({<summary className="team-update-head transcript-disclosure"><Icon name="chevronDown" size={12} /><span>- {rows.length+ {rows.length || sources.length > 1? t(sources.length > 1 ? "teamview.updates" : "teamview.update", {count: sources.length,}) + " · "@@ -128,6 +141,7 @@ export function TeamUpdateLine({)}</summary><div className="team-update-body">+ {sources.filter(s => s.board?.check_in).map((s, i) => <p key={`check-in-${i}`}>{s.text}</p>)}{[...groups].map(([key, group]) => {const last = group[group.length - 1],moves = group.filter((r) => r.kind === "moved");diff --git a/surfaces/gui/src/components/TeamView.test.tsx b/surfaces/gui/src/components/TeamView.test.tsxindex facd6cb4..bb1a5530 100644--- a/surfaces/gui/src/components/TeamView.test.tsx+++ b/surfaces/gui/src/components/TeamView.test.tsx@@ -89,6 +89,29 @@ describe("team update lines", () => {]),).toHaveLength(2);});+ it("folds routine narration and trailing steps but preserves the final answer", () => {+ const narration: Item = { kind: "assistant", text: "I will check the board." };+ const answer: Item = { kind: "assistant", text: "The release is ready." };+ const result = foldTeamUpdates([wake, narration, tool, wake, tool, answer]);+ expect(result).toHaveLength(2);+ expect(result[0].sources).toHaveLength(2);+ expect(result[0].steps).toEqual([narration, tool, tool]);+ expect(result[1].item).toBe(answer);+ });+ it("does not hide a verdict before a final board transition or a pending approval", () => {+ const answer: Item = { kind: "assistant", text: "The tests pass. Accepted." };+ const transition: Item = { ...tool, name: "transition", args: { to: "done" } };+ expect(foldTeamUpdates([wake, answer, transition])[1].item).toBe(answer);+ const approval: Item = { kind: "approval", name: "run_shell", args: {}, reason: "Review" };+ expect(foldTeamUpdates([wake, tool, approval, wake])).toHaveLength(3);+ });+ it("retains a typed timer reminder when expanded, including on replay", () => {+ const timer = { ...source, text: "Check the verification result", board: { rows: [], check_in: true } };+ render(<TeamUpdateLine sources={[timer]} />);+ expect(screen.getByTestId("team-update").textContent).toContain(timer.text);+ const replay = itemsFromMessages([{ role: "user", content: timer.text, source: timer }]);+ expect(foldTeamUpdates([...replay, tool, wake])[0].sources).toHaveLength(2);+ });it("renders a quiet disclosure and no worker note", () => {render(<TeamUpdateLinediff --git a/surfaces/gui/src/components/TeamView.tsx b/surfaces/gui/src/components/TeamView.tsxindex 2bdb86c1..ed581624 100644--- a/surfaces/gui/src/components/TeamView.tsx+++ b/surfaces/gui/src/components/TeamView.tsx@@ -681,6 +681,8 @@ export function TeamView({summary,board,initialItem,+ initialWorkerId,+ onOpenFullSession,openKey = 0,sessionId,sessions,@@ -693,6 +695,8 @@ export function TeamView({openKey?: number;board?: Board | null;initialItem?: number | null;+ initialWorkerId?: string | null;+ onOpenFullSession?: (id: string) => void;sessionId: string;sessions: SessionInfo[];machine?: string | null;@@ -703,11 +707,11 @@ export function TeamView({const { t } = useTranslation();const [tab, setTab] = useState<"work" | "workers" | "stats">("work");const [selected, setSelected] = useState<number | null>(initialItem ?? null);- const [selectedWorker, setSelectedWorker] = useState<TeamWorker | null>(null);+ const [selectedWorker, setSelectedWorker] = useState<string | null>(initialWorkerId ?? null);useEffect(() => {setSelected(initialItem ?? null);- setSelectedWorker(null);- }, [initialItem, sessionId, openKey]);+ setSelectedWorker(initialWorkerId ?? null);+ }, [initialItem, initialWorkerId, sessionId, openKey]);const fallbackItems: TeamTask[] = (board?.items || []).map((i) => ({...i,group: i.waiting@@ -745,14 +749,14 @@ export function TeamView({}),);const worker = workers.find(- (w) => w.session_id === selectedWorker?.session_id,+ (w) => w.session_id === selectedWorker,);const goBack = () => {setSelected(null);setSelectedWorker(null);};const openWorker = (w: TeamWorker) => {- setSelectedWorker(w);+ setSelectedWorker(w.session_id);setSelected(null);};const openTask = (id: number) => {@@ -799,6 +803,9 @@ export function TeamView({))}</div>)}+ {worker && onOpenFullSession && <button className="team-full-session" onClick={() => onOpenFullSession(worker.session_id)}>+ {t("teamview.full_session")}+ </button>}<buttonclassName="team-close"onClick={onClose}diff --git a/surfaces/gui/src/locales/en.json b/surfaces/gui/src/locales/en.jsonindex 48554f0b..a523b8e8 100644--- a/surfaces/gui/src/locales/en.json+++ b/surfaces/gui/src/locales/en.json@@ -253,7 +253,7 @@"team_open_session": "Open {{name}}'s session","team_worker": "worker","team_sleeping": "sleeping",- "team_open": "open ↗",+ "team_open": "View","team_chat": "team chat","back_to": "Back to {{name}}","crumb_files": "Files",@@ -2369,6 +2369,10 @@"linked_tasks": "Assigned tasks ({{count}})","related_conversations": "Related worker conversations","send": "Send",- "worker_offline": "Worker connection unavailable. Messages are disabled until reconnected."+ "worker_offline": "Worker connection unavailable. Messages are disabled until reconnected.",+ "open_view": "Open team view",+ "open_worker_pane": "View {{name}} beside the lead",+ "full_session": "Open full session",+ "chat_off": "Team chat is off for this team"}}diff --git a/surfaces/gui/src/locales/zh.json b/surfaces/gui/src/locales/zh.jsonindex e98337f4..24812e2c 100644--- a/surfaces/gui/src/locales/zh.json+++ b/surfaces/gui/src/locales/zh.json@@ -250,7 +250,7 @@"team_open_session": "打开 {{name}} 的会话","team_worker": "成员","team_sleeping": "休眠",- "team_open": "打开 ↗",+ "team_open": "查看","team_chat": "团队聊天","back_to": "返回{{name}}","crumb_files": "文件",@@ -2329,6 +2329,10 @@"linked_tasks": "已分配的任务({{count}})","related_conversations": "相关协作者会话","send": "发送",- "worker_offline": "成员连接不可用,重新连接之前无法发送消息。"+ "worker_offline": "成员连接不可用,重新连接之前无法发送消息。",+ "open_view": "打开团队视图",+ "open_worker_pane": "在主代理旁查看 {{name}}",+ "full_session": "打开完整会话",+ "chat_off": "此团队未启用团队聊天"}}diff --git a/surfaces/gui/src/styles.css b/surfaces/gui/src/styles.cssindex 03325d52..26a4b12b 100644--- a/surfaces/gui/src/styles.css+++ b/surfaces/gui/src/styles.css@@ -2222,14 +2222,14 @@ html[data-platform="linux"] ::-webkit-scrollbar-thumb:hover { background-color:.team-task-row .board-dot.work,.task-chip .board-dot.work { background:var(--accent); }.team-task-row .board-dot.blocked,.task-chip .board-dot.blocked { background:#cc941f; }-.team-icon-row { height:24px; margin-bottom:6px; position:relative; z-index:15; }+.team-icon-row { height:24px; margin-bottom:6px; padding-left:15px; position:relative; z-index:15; }.team-icon-button { display:flex; gap:5px; align-items:center; height:24px; border:0; background:none; color:var(--muted); cursor:pointer; padding:0; }.team-presence { width:6px; height:6px; border-radius:50%; background:var(--faint); flex:none; }.team-presence.working { background:var(--accent); animation:team-pulse 2s ease-out infinite; }.team-presence.attention { background:var(--warn-ink); }@keyframes team-pulse { 50% { box-shadow:0 0 0 4px color-mix(in srgb, var(--accent) 15%, transparent); } }@media (prefers-reduced-motion:reduce) { .team-presence.working { animation:none; } }-.team-hover-line { position:absolute; left:40px; display:flex; gap:8px; align-items:center; color:var(--muted); opacity:0; pointer-events:none; white-space:nowrap; font-size:var(--fs-meta); }+.team-hover-line { position:absolute; left:55px; display:flex; gap:8px; align-items:center; color:var(--muted); opacity:0; pointer-events:none; white-space:nowrap; font-size:var(--fs-meta); }.team-icon-button:hover .team-hover-line,.team-icon-button:focus-visible .team-hover-line { opacity:1; }.team-quick-look { position:absolute; bottom:26px; left:0; width:min(560px,100%); padding:14px 12px 8px; background:var(--panel); border:1px solid var(--line-strong); box-shadow:0 12px 36px -16px #0006; border-radius:12px; max-height:min(65vh,620px); overflow:auto; }.team-quick-look h3 { margin:0 4px 4px; font-size:var(--fs-body); font-weight:600; color:var(--ink); }@@ -2248,6 +2248,8 @@ html[data-platform="linux"] ::-webkit-scrollbar-thumb:hover { background-color:.team-tabs button { background:none; border:0; border-radius:6px; padding:6px 10px; color:var(--muted); cursor:pointer; }.team-tabs [aria-selected="true"],.team-tabs [aria-pressed="true"] { color:var(--ink); background:var(--chrome-hover); font-weight:500; }.team-close { margin-left:auto; font-size:var(--fs-title)!important; }+.team-pane-header .team-full-session { margin-left:auto; font-size:var(--fs-meta); }+.team-full-session + .team-close { margin-left:0; }.team-attention-count { margin-left:6px; background:var(--warn-soft); color:var(--warn-ink); border-radius:9px; padding:1px 5px; font-size:var(--fs-label); }.team-pane-body { flex:1; min-height:0; overflow:auto; padding:20px; }.team-pane-body h2,.team-worker-header h2 { font-size:var(--fs-title); font-weight:600; letter-spacing:-.01em; margin:0 0 4px; }diff --git a/tests/test_auto_approve.py b/tests/test_auto_approve.pyindex d2ac4c7d..8ff7afaf 100644--- a/tests/test_auto_approve.py+++ b/tests/test_auto_approve.py@@ -560,6 +560,37 @@ def test_reviewer_allow_runs_without_a_card(tmp_path):assert verdict_rows[0]["status"] == "allow"[email protected]("preconsult", [True, False])[email protected]("change", ["disable", "detach", "manual", "off-on"])+def test_settings_change_during_review_cannot_apply_stale_allow(tmp_path, change, preconsult):+ engine, rows, approvals = _engine(+ tmp_path,+ [_tool_turn(("run_shell", {"command": "pytest -q"})), AssistantTurn(text="done", finish_reason="stop")],+ )++ class ChangingReviewer:+ async def review(self, **kwargs):+ if change == "disable":+ engine.reviewer_enabled = False+ elif change == "detach":+ engine.reviewer = None+ elif change == "manual":+ engine.permissions.mode = Mode.INTERACTIVE+ else:+ engine.reviewer_settings_epoch += 2+ return reviewer_mod.Verdict("allow", "an obsolete verdict")++ engine.reviewer = ChangingReviewer()+ if not preconsult:+ async def skip_preconsult(calls):+ pass+ engine._preconsult_reviewer = skip_preconsult+ events = _run(engine)+ assert approvals == ["run_shell"]+ assert any(e.type == EventType.PERMISSION_REQUIRED for e in events)+ assert not any(r.get("stage") == "reviewer_verdict" and r.get("status") == "allow" for r in rows)++def test_reviewer_deny_blocks_with_terse_agent_message(tmp_path):engine, rows, approvals = _engine(tmp_path,diff --git a/tests/test_idle_checkins.py b/tests/test_idle_checkins.pyindex 43866775..8da54352 100644--- a/tests/test_idle_checkins.py+++ b/tests/test_idle_checkins.py@@ -92,6 +92,19 @@ def test_busy_timer_defers_instead_of_steering_or_being_lost(manager):assert len(manager.wakes.due()) == 1+def test_lead_timer_has_replayable_display_source_without_changing_receipt(manager):+ manager.provider = ScriptedProvider([_text_turn("Checked")])+ wake = timer(manager, -1, "Check verifier evidence")+ asyncio.run(manager._resume_wake(wake))+ message = next(m for m in manager.session_store.load("lead").messages if m["role"] == "user")+ assert message["source"]["connector"] == "board"+ assert message["source"]["board"]["check_in"] is True+ assert "Check verifier evidence" in message["source"]["text"]+ assert message["source"]["text"] == message["content"]+ assert wake.id in message["_activity"]["wake_ids"]+ assert not manager.wakes.pending("lead")++def test_due_timer_and_board_produce_one_turn(manager):manager.provider = ScriptedProvider([_text_turn("Checked")])review(manager)diff --git a/tests/test_team_live_gaps.py b/tests/test_team_live_gaps.pyindex 85e457f3..7bd3b924 100644--- a/tests/test_team_live_gaps.py+++ b/tests/test_team_live_gaps.py@@ -53,6 +53,43 @@ def request_for(manager):return original, request+def test_reviewer_settings_hot_apply_to_cached_lead_and_worker(manager):+ from coworker.permissions import Mode++ manager.provider = ScriptedProvider([])+ lead = manager.get_engine("lead", agent="swe-lead")+ worker = manager.get_engine("worker", agent="swe-worker")+ assert lead.reviewer is None and worker.reviewer is None+ original, _ = request_for(manager)+ worker._reviewer_denials = 1+ lead.permissions.mode = Mode.AUTO_APPROVE+ manager.save("lead", lead, touch=False)++ manager.set_auto_approve(True)+ assert manager.get_engine("worker") is worker+ assert lead.reviewer is not None and worker.reviewer is not None+ assert worker.permissions.mode is Mode.AUTO_APPROVE+ assert worker._reviewer_active()+ assert worker._reviewer_denials == 1+ assert original.state == "pending" # never retroactively clear a parked action+ reviewer = worker.reviewer+ manager.sync_cached_reviewers()+ assert worker.reviewer is reviewer++ manager.set_auto_approve_shadow(True)+ manager.set_auto_approve(False)+ assert worker.reviewer is reviewer and worker.reviewer_shadow+ assert not worker._reviewer_active() # shadow does not grant live approval+ manager.set_auto_approve_shadow(False)+ assert lead.reviewer is None and worker.reviewer is None+ manager.set_auto_approve(True)+ lead.permissions.mode = Mode.INTERACTIVE+ manager.save("lead", lead, touch=False)+ manager.sync_cached_reviewers()+ assert worker.permissions.mode is Mode.INTERACTIVE+ assert not worker._reviewer_active()++@pytest.mark.parametrize("resolve_first", [False, True])@pytest.mark.parametrize("answer", ["allow", "deny"])def test_worker_resolution_retires_linked_gate_before_or_after_creation(