Skip to content

Free, open-source Windows optimization tool for performance, privacy, and simplicity.

fix(customize): notify unsupported settings header on count change

fatDuck36acf585ae12
diff --git a/optimizerDuck.Test/UI/ViewModels/CustomizeCategoryViewModelTests.cs b/optimizerDuck.Test/UI/ViewModels/CustomizeCategoryViewModelTests.cs
new file mode 100644
index 0000000..8003e31
--- /dev/null
+++ b/optimizerDuck.Test/UI/ViewModels/CustomizeCategoryViewModelTests.cs
@@ -0,0 +1,53 @@
+using System.Collections.ObjectModel;
+using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Logging.Abstractions;
+using optimizerDuck.Domain.Abstractions;
+using optimizerDuck.Domain.Customize.Models;
+using optimizerDuck.Domain.UI;
+using optimizerDuck.Services.System;
+using optimizerDuck.UI.ViewModels.Pages;
+using Wpf.Ui.Controls;
+
+namespace optimizerDuck.Test.UI.ViewModels;
+
+public sealed class CustomizeCategoryViewModelTests
+{
+ private sealed class FakeCategory : ICustomizeCategory
+ {
+ public string Name => "Test";
+ public string Description => "Test";
+ public SymbolRegular Icon { get; init; } = SymbolRegular.Settings24;
+ public CustomizeOrder Order { get; init; }
+ public ObservableCollection<ICustomizeSetting> Features { get; init; } = [];
+ }
+
+ private sealed class FakeRegistryWatcher : IRegistryWatcher
+ {
+ public event EventHandler<string>? RegistryKeyChanged;
+
+ public void Watch(string registryPath) { }
+
+ public void Unwatch(string registryPath) { }
+
+ public void Dispose() { }
+ }
+
+ [Fact]
+ public void SettingCountNotifiesHeader()
+ {
+ var vm = new CustomizeCategoryViewModel(
+ new FakeCategory(),
+ NullLoggerFactory.Instance,
+ new FakeRegistryWatcher(),
+ new SystemInfoService(NullLogger<SystemInfoService>.Instance)
+ );
+
+ var notified = new List<string>();
+ vm.PropertyChanged += (_, e) => notified.Add(e.PropertyName!);
+
+ vm.UnsupportedSettingsCount = 1;
+
+ Assert.Contains(nameof(CustomizeCategoryViewModel.UnsupportedSettingsHeader), notified);
+ Assert.Contains("(1)", vm.UnsupportedSettingsHeader);
+ }
+}
diff --git a/optimizerDuck/Domain/Optimizations/Categories/Gpu.cs b/optimizerDuck/Domain/Optimizations/Categories/Gpu.cs
index f24039d..4ae254d 100644
--- a/optimizerDuck/Domain/Optimizations/Categories/Gpu.cs
+++ b/optimizerDuck/Domain/Optimizations/Categories/Gpu.cs
@@ -114,8 +114,7 @@ public class Gpu : LocalizedObject, IOptimizationCategory
/// </code>
/// </example>
/// <exception cref="ArgumentNullException">
- /// Thrown if <paramref name="deviceId" /> is <c>null</c>, but this method uses <c>string.IsNullOrWhiteSpace</c>
- /// and returns <c>false</c> instead for consistency with TryParse pattern.
+ /// Returns false instead of throwing when <paramref name="deviceId" /> is null or whitespace.
/// </exception>
/// <seealso cref="GpuInfo.DeviceId" />
/// <seealso href="https://learn.microsoft.com/en-us/windows/win32/cimwin32prov/win32-videocontroller">
diff --git a/optimizerDuck/UI/ViewModels/Pages/CustomizeCategoryViewModel.cs b/optimizerDuck/UI/ViewModels/Pages/CustomizeCategoryViewModel.cs
index 04f0ef6..d48b945 100644
--- a/optimizerDuck/UI/ViewModels/Pages/CustomizeCategoryViewModel.cs
+++ b/optimizerDuck/UI/ViewModels/Pages/CustomizeCategoryViewModel.cs
@@ -48,6 +48,7 @@ public partial class CustomizeCategoryViewModel : ViewModel
private bool _hasUnsupportedSettings;
[ObservableProperty]
+ [NotifyPropertyChangedFor(nameof(UnsupportedSettingsHeader))]
private int _unsupportedSettingsCount;
public string UnsupportedSettingsHeader =>