Free, open-source Windows optimization tool for performance, privacy, and simplicity.
C# csharpdebloatdotnetgamingopen-sourceoptimizationoptimizeroptimizerduckperformanceprivacytweakertweakswindowswinui
fix(services): treat protected-service access-denied as skippable
fatDuck4240ca8e8b62
diff --git a/optimizerDuck.Test/Services/OptimizationServices/ServiceProcessServiceTests.cs b/optimizerDuck.Test/Services/OptimizationServices/ServiceProcessServiceTests.csindex 2c6ccaa..23c72c8 100644--- a/optimizerDuck.Test/Services/OptimizationServices/ServiceProcessServiceTests.cs+++ b/optimizerDuck.Test/Services/OptimizationServices/ServiceProcessServiceTests.cs@@ -224,4 +224,192 @@ public class ServiceProcessServiceTestsAssert.True(notFound);}++ // =============================================+ // Integration tests: ChangeServiceStartupTypeAsync (real sc.exe)+ // =============================================++ private const string TestServiceName = "odTestSvc";++ private static bool IsElevated()+ {+ using var identity = System.Security.Principal.WindowsIdentity.GetCurrent();+ return new System.Security.Principal.WindowsPrincipal(identity).IsInRole(+ System.Security.Principal.WindowsBuiltInRole.Administrator+ );+ }++ private static async Task EnsureTestServiceAsync()+ {+ var (startType, notFound) = await ServiceProcessService.GetStartupTypeAsync(+ TestServiceName+ );+ if (notFound)+ {+ var (exitCode, _) = await RunScAsync(+ $"create {TestServiceName} binPath= \"C:\\Windows\\System32\\svchost.exe -k test\" start= demand"+ );+ Assert.Equal(0, exitCode);+ }+ else if (startType != ServiceStartupType.Manual)+ {+ var (exitCode, _) = await RunScAsync($"config {TestServiceName} start= demand");+ Assert.Equal(0, exitCode);+ }+ }++ private static async Task<(int ExitCode, string Stdout)> RunScAsync(string arguments)+ {+ using var process = System.Diagnostics.Process.Start(+ new System.Diagnostics.ProcessStartInfo+ {+ FileName = "sc.exe",+ Arguments = arguments,+ RedirectStandardOutput = true,+ RedirectStandardError = true,+ UseShellExecute = false,+ CreateNoWindow = true,+ }+ );+ Assert.NotNull(process);++ var stdoutTask = process.StandardOutput.ReadToEndAsync();+ var stderrTask = process.StandardError.ReadToEndAsync();++ using var cts = new CancellationTokenSource(TimeSpan.FromSeconds(30));+ try+ {+ await process.WaitForExitAsync(cts.Token);+ }+ catch (OperationCanceledException)+ {+ try+ {+ process.Kill();+ }+ catch { }+ Assert.Fail($"sc.exe timed out after 30s: {arguments}");+ }++ var stdout = await stdoutTask;+ await stderrTask;+ return (process.ExitCode, stdout);+ }++ private static async Task DeleteTestServiceBestEffortAsync()+ {+ try+ {+ await RunScAsync($"delete {TestServiceName}");+ }+ catch+ {+ // Cleanup must never mask the test assertion.+ }+ }++ private static async Task StripChangeConfigFromAdminsAsync(string serviceName)+ {+ var (_, output) = await RunScAsync($"sdshow {serviceName}");+ var sddl = System+ .Text.RegularExpressions.Regex.Match(+ output,+ @"D:\(.+\)",+ System.Text.RegularExpressions.RegexOptions.Compiled+ )+ .Value;+ Assert.StartsWith("D:", sddl);++ // Remove DC (SERVICE_CHANGE_CONFIG) from the BA (BUILTIN\Administrators) ACE.+ var patched = System.Text.RegularExpressions.Regex.Replace(+ sddl,+ @"\(A;;[A-Z]*DC[A-Z]*;;;BA\)",+ m => m.Value.Replace("DC", string.Empty),+ System.Text.RegularExpressions.RegexOptions.Compiled+ );+ Assert.NotEqual(sddl, patched);++ var (_, set) = await RunScAsync($"sdset {serviceName} {patched}");+ Assert.Contains("SUCCESS", set, StringComparison.OrdinalIgnoreCase);+ }++ [Fact]+ public async Task ChangeServiceStartupTypeAsync_AlreadyConfigured_SkipsChange_ReturnsAlreadyConfigured()+ {+ if (!IsElevated())+ Assert.Skip("Service creation requires an elevated test host.");+ await EnsureTestServiceAsync();+ try+ {+ var (startType, _) = await ServiceProcessService.GetStartupTypeAsync(TestServiceName);+ Assert.NotNull(startType);++ var result = await ServiceProcessService.ChangeServiceStartupTypeAsync(+ new ServiceItem(TestServiceName, startType.Value)+ );++ Assert.Equal(ServiceChangeResult.AlreadyConfigured, result);+ }+ finally+ {+ await DeleteTestServiceBestEffortAsync();+ }+ }++ [Fact]+ public async Task ChangeServiceStartupTypeAsync_Success_ChangesType_ReturnsSuccess()+ {+ if (!IsElevated())+ Assert.Skip("Service creation requires an elevated test host.");+ await EnsureTestServiceAsync();+ try+ {+ var result = await ServiceProcessService.ChangeServiceStartupTypeAsync(+ new ServiceItem(TestServiceName, ServiceStartupType.Disabled)+ );++ Assert.Equal(ServiceChangeResult.Success, result);+ var (startType, _) = await ServiceProcessService.GetStartupTypeAsync(TestServiceName);+ Assert.Equal(ServiceStartupType.Disabled, startType);+ }+ finally+ {+ await DeleteTestServiceBestEffortAsync();+ }+ }++ [Fact]+ public async Task ChangeServiceStartupTypeAsync_NonexistentService_ReturnsNotFound()+ {+ var result = await ServiceProcessService.ChangeServiceStartupTypeAsync(+ new ServiceItem(+ "OptimizerDuckTest_Nonexistent_Service_12345",+ ServiceStartupType.Manual+ )+ );++ Assert.Equal(ServiceChangeResult.NotFound, result);+ }++ [Fact]+ public async Task ChangeServiceStartupTypeAsync_ProtectedServiceDacl_ReturnsAccessDenied()+ {+ if (!IsElevated())+ Assert.Skip("Service creation requires an elevated test host.");+ await EnsureTestServiceAsync();+ try+ {+ await StripChangeConfigFromAdminsAsync(TestServiceName);++ var result = await ServiceProcessService.ChangeServiceStartupTypeAsync(+ new ServiceItem(TestServiceName, ServiceStartupType.Disabled)+ );++ Assert.Equal(ServiceChangeResult.AccessDenied, result);+ }+ finally+ {+ await DeleteTestServiceBestEffortAsync();+ }+ }}diff --git a/optimizerDuck/Domain/Optimizations/Categories/BloatwareAndServices.cs b/optimizerDuck/Domain/Optimizations/Categories/BloatwareAndServices.csindex 7e4dc6f..5cb0e5c 100644--- a/optimizerDuck/Domain/Optimizations/Categories/BloatwareAndServices.cs+++ b/optimizerDuck/Domain/Optimizations/Categories/BloatwareAndServices.cs@@ -314,6 +314,7 @@ public class BloatwareAndServices : LocalizedObject, IOptimizationCategorynew("wuauserv", ServiceStartupType.Manual),};+ var tally = new Dictionary<ServiceChangeResult, int>();for (var i = 0; i < servicesToChange.Count; i++){var service = servicesToChange[i];@@ -329,12 +330,18 @@ public class BloatwareAndServices : LocalizedObject, IOptimizationCategoryTotal = servicesToChange.Count,});- await ServiceProcessService.ChangeServiceStartupTypeAsync(service);+ var result = await ServiceProcessService.ChangeServiceStartupTypeAsync(service);+ tally[result] = tally.GetValueOrDefault(result) + 1;}context.Logger.LogInformation(- "Optimized service startup for {Count} services",- servicesToChange.Count+ "Service startup configuration: {Total} services, {Changed} changed, {AlreadyConfigured} already configured, {NotFound} not found, {AccessDenied} access denied, {Failed} failed",+ servicesToChange.Count,+ tally.GetValueOrDefault(ServiceChangeResult.Success),+ tally.GetValueOrDefault(ServiceChangeResult.AlreadyConfigured),+ tally.GetValueOrDefault(ServiceChangeResult.NotFound),+ tally.GetValueOrDefault(ServiceChangeResult.AccessDenied),+ tally.GetValueOrDefault(ServiceChangeResult.Failed));return CompleteFromScope();}diff --git a/optimizerDuck/Domain/Optimizations/Models/Services/ServiceChangeResult.cs b/optimizerDuck/Domain/Optimizations/Models/Services/ServiceChangeResult.csnew file mode 100644index 0000000..338460d--- /dev/null+++ b/optimizerDuck/Domain/Optimizations/Models/Services/ServiceChangeResult.cs@@ -0,0 +1,24 @@+namespace optimizerDuck.Domain.Optimizations.Models.Services;++/// <summary>Outcome of a service startup type change request.</summary>+public enum ServiceChangeResult+{+ /// <summary>The startup type was changed successfully.</summary>+ Success,++ /// <summary>The service does not exist on this system.</summary>+ NotFound,++ /// <summary>The service already has the requested startup type; no change was needed.</summary>+ AlreadyConfigured,++ /// <summary>+ /// Windows denied the change (ERROR_ACCESS_DENIED). Some protected services+ /// (AppXSvc, ClipSVC, wscsvc...) have a DACL that does not grant+ /// SERVICE_CHANGE_CONFIG to Administrators. Retrying cannot succeed.+ /// </summary>+ AccessDenied,++ /// <summary>The change failed for a recoverable reason (transient error, timeout).</summary>+ Failed,+}diff --git a/optimizerDuck/Domain/Revert/Steps/ServiceRevertStep.cs b/optimizerDuck/Domain/Revert/Steps/ServiceRevertStep.csindex b591c46..8ba3296 100644--- a/optimizerDuck/Domain/Revert/Steps/ServiceRevertStep.cs+++ b/optimizerDuck/Domain/Revert/Steps/ServiceRevertStep.cs@@ -37,13 +37,17 @@ public class ServiceRevertStep : IRevertStepnew ServiceItem { Name = ServiceName, StartupType = OriginalStartupType });- if (!result)- {- var error = ServiceProcessService.LastError ?? Description;- throw new StepExecutionException(error, ServiceProcessService.LastErrorDetail);- }+ if (+ result+ is ServiceChangeResult.Success+ or ServiceChangeResult.NotFound+ or ServiceChangeResult.AlreadyConfigured+ or ServiceChangeResult.AccessDenied+ )+ return true;- return true;+ var error = ServiceProcessService.LastError ?? Description;+ throw new StepExecutionException(error, ServiceProcessService.LastErrorDetail);}/// <inheritdoc />diff --git a/optimizerDuck/Resources/Languages/Translations.Designer.cs b/optimizerDuck/Resources/Languages/Translations.Designer.csindex 78a0346..9588ac0 100644--- a/optimizerDuck/Resources/Languages/Translations.Designer.cs+++ b/optimizerDuck/Resources/Languages/Translations.Designer.cs@@ -5510,6 +5510,24 @@ namespace optimizerDuck.Resources.Languages {}}+ /// <summary>+ /// Looks up a localized string similar to Service '{0}' is already set to {1} (skipped).+ /// </summary>+ internal static string Service_Service_Info_AlreadyConfigured {+ get {+ return ResourceManager.GetString("Service.Service.Info.AlreadyConfigured", resourceCulture);+ }+ }++ /// <summary>+ /// Looks up a localized string similar to Access to service '{0}' is denied by Windows (skipped).+ /// </summary>+ internal static string Service_Service_Info_SkippedAccessDenied {+ get {+ return ResourceManager.GetString("Service.Service.Info.SkippedAccessDenied", resourceCulture);+ }+ }+/// <summary>/// Looks up a localized string similar to Service '{0}' not found (skipped)./// </summary>diff --git a/optimizerDuck/Resources/Languages/Translations.ar-SA.resx b/optimizerDuck/Resources/Languages/Translations.ar-SA.resxindex 60d1e0f..b962079 100644--- a/optimizerDuck/Resources/Languages/Translations.ar-SA.resx+++ b/optimizerDuck/Resources/Languages/Translations.ar-SA.resx@@ -1700,6 +1700,12 @@<data name="Service.Service.Info.SkippedNotFound" xml:space="preserve"><value>الخدمة «{0}» غير موجودة (تم تخطّيها)</value></data>+ <data name="Service.Service.Info.AlreadyConfigured" xml:space="preserve">+ <value>الخدمة '{0}' مضبوطة بالفعل على {1} (تم التخطي)</value>+ </data>+ <data name="Service.Service.Info.SkippedAccessDenied" xml:space="preserve">+ <value>تم رفض الوصول إلى الخدمة '{0}' من قبل Windows (تم التخطي)</value>+ </data><data name="Service.Service.Name" xml:space="preserve"><value>خدمة</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.de-DE.resx b/optimizerDuck/Resources/Languages/Translations.de-DE.resxindex 1be2e04..15bc610 100644--- a/optimizerDuck/Resources/Languages/Translations.de-DE.resx+++ b/optimizerDuck/Resources/Languages/Translations.de-DE.resx@@ -446,6 +446,12 @@<data name="Service.Service.Info.SkippedNotFound" xml:space="preserve"><value>Dienst "{0}" nicht gefunden (übersprungen)</value></data>+ <data name="Service.Service.Info.AlreadyConfigured" xml:space="preserve">+ <value>Dienst '{0}' ist bereits auf {1} festgelegt (übersprungen)</value>+ </data>+ <data name="Service.Service.Info.SkippedAccessDenied" xml:space="preserve">+ <value>Der Zugriff auf Dienst '{0}' wird von Windows verweigert (übersprungen)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>Starttyp für Dienst konnte nicht geändert werden</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.es-ES.resx b/optimizerDuck/Resources/Languages/Translations.es-ES.resxindex 2908313..4e69505 100644--- a/optimizerDuck/Resources/Languages/Translations.es-ES.resx+++ b/optimizerDuck/Resources/Languages/Translations.es-ES.resx@@ -770,6 +770,12 @@<value>Servicio '{0}' no encontrado (omitido)</value></data>+ <data name="Service.Service.Info.AlreadyConfigured" xml:space="preserve">+ <value>El servicio '{0}' ya está configurado como {1} (omitido)</value>+ </data>+ <data name="Service.Service.Info.SkippedAccessDenied" xml:space="preserve">+ <value>Windows denegó el acceso al servicio '{0}' (omitido)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve">diff --git a/optimizerDuck/Resources/Languages/Translations.fr-FR.resx b/optimizerDuck/Resources/Languages/Translations.fr-FR.resxindex 61d9f98..a6529cc 100644--- a/optimizerDuck/Resources/Languages/Translations.fr-FR.resx+++ b/optimizerDuck/Resources/Languages/Translations.fr-FR.resx@@ -389,6 +389,12 @@<data name="Service.Service.Info.SkippedNotFound" xml:space="preserve"><value>Service '{0}' introuvable (ignoré)</value></data>+ <data name="Service.Service.Info.AlreadyConfigured" xml:space="preserve">+ <value>Le service '{0}' est déjà défini sur {1} (ignoré)</value>+ </data>+ <data name="Service.Service.Info.SkippedAccessDenied" xml:space="preserve">+ <value>L'accès au service '{0}' est refusé par Windows (ignoré)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>Impossible de modifier le type de démarrage du service</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.he-IL.resx b/optimizerDuck/Resources/Languages/Translations.he-IL.resxindex 39c9101..d3b2d08 100644--- a/optimizerDuck/Resources/Languages/Translations.he-IL.resx+++ b/optimizerDuck/Resources/Languages/Translations.he-IL.resx@@ -446,6 +446,12 @@<data name="Service.Service.Info.SkippedNotFound" xml:space="preserve"><value>השירות '{0}' לא נמצא (דילוג)</value></data>+ <data name="Service.Service.Info.AlreadyConfigured" xml:space="preserve">+ <value>השירות '{0}' כבר מוגדר ל-{1} (דילוג)</value>+ </data>+ <data name="Service.Service.Info.SkippedAccessDenied" xml:space="preserve">+ <value>הגישה לשירות '{0}' נדחתה על ידי Windows (דילוג)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>שינוי סוג ההפעלה של השירות נכשל</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.id-ID.resx b/optimizerDuck/Resources/Languages/Translations.id-ID.resxindex 2b684f8..3d3e513 100644--- a/optimizerDuck/Resources/Languages/Translations.id-ID.resx+++ b/optimizerDuck/Resources/Languages/Translations.id-ID.resx@@ -440,6 +440,12 @@<data name="Service.Service.Info.SkippedNotFound" xml:space="preserve"><value>Layanan '{0}' tidak ditemukan (dilewati)</value></data>+ <data name="Service.Service.Info.AlreadyConfigured" xml:space="preserve">+ <value>Layanan '{0}' sudah diatur ke {1} (dilewati)</value>+ </data>+ <data name="Service.Service.Info.SkippedAccessDenied" xml:space="preserve">+ <value>Akses ke layanan '{0}' ditolak oleh Windows (dilewati)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>Gagal mengubah tipe startup untuk layanan</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.it-IT.resx b/optimizerDuck/Resources/Languages/Translations.it-IT.resxindex e3a3689..ed607dd 100644--- a/optimizerDuck/Resources/Languages/Translations.it-IT.resx+++ b/optimizerDuck/Resources/Languages/Translations.it-IT.resx@@ -382,6 +382,12 @@<data name="Service.Service.Info.SkippedNotFound" xml:space="preserve"><value>Servizio '{0}' non trovato (ignorato)</value></data>+ <data name="Service.Service.Info.AlreadyConfigured" xml:space="preserve">+ <value>Il servizio '{0}' è già impostato su {1} (ignorato)</value>+ </data>+ <data name="Service.Service.Info.SkippedAccessDenied" xml:space="preserve">+ <value>L'accesso al servizio '{0}' è negato da Windows (ignorato)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>Impossibile modificare il tipo di avvio del servizio</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.ja-JP.resx b/optimizerDuck/Resources/Languages/Translations.ja-JP.resxindex 61d51d2..77bdaad 100644--- a/optimizerDuck/Resources/Languages/Translations.ja-JP.resx+++ b/optimizerDuck/Resources/Languages/Translations.ja-JP.resx@@ -387,6 +387,12 @@<data name="Service.Service.Info.SkippedNotFound" xml:space="preserve"><value>サービス '{0}' が見つかりません(スキップ)</value></data>+ <data name="Service.Service.Info.AlreadyConfigured" xml:space="preserve">+ <value>サービス '{0}' は既に {1} に設定されています(スキップ)</value>+ </data>+ <data name="Service.Service.Info.SkippedAccessDenied" xml:space="preserve">+ <value>サービス '{0}' へのアクセスが Windows によって拒否されました(スキップ)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>サービスの開始タイプを変更できませんでした</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.ko-KR.resx b/optimizerDuck/Resources/Languages/Translations.ko-KR.resxindex 6915856..894f4cb 100644--- a/optimizerDuck/Resources/Languages/Translations.ko-KR.resx+++ b/optimizerDuck/Resources/Languages/Translations.ko-KR.resx@@ -387,6 +387,12 @@<data name="Service.Service.Info.SkippedNotFound" xml:space="preserve"><value>'{0}' 서비스를 찾을 수 없습니다 (건너뜀)</value></data>+ <data name="Service.Service.Info.AlreadyConfigured" xml:space="preserve">+ <value>'{0}' 서비스가 이미 {1}로 설정되어 있습니다 (건너뜀)</value>+ </data>+ <data name="Service.Service.Info.SkippedAccessDenied" xml:space="preserve">+ <value>Windows에서 '{0}' 서비스에 대한 액세스를 거부했습니다 (건너뜀)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>서비스 시작 유형을 변경하지 못했습니다</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.pl-PL.resx b/optimizerDuck/Resources/Languages/Translations.pl-PL.resxindex a7cc88a..8802fc5 100644--- a/optimizerDuck/Resources/Languages/Translations.pl-PL.resx+++ b/optimizerDuck/Resources/Languages/Translations.pl-PL.resx@@ -388,6 +388,12 @@<data name="Service.Service.Info.SkippedNotFound" xml:space="preserve"><value>Nie znaleziono usługi '{0}' (pominięto)</value></data>+ <data name="Service.Service.Info.AlreadyConfigured" xml:space="preserve">+ <value>Usługa '{0}' jest już ustawiona na {1} (pominięto)</value>+ </data>+ <data name="Service.Service.Info.SkippedAccessDenied" xml:space="preserve">+ <value>Dostęp do usługi '{0}' został zablokowany przez Windows (pominięto)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>Nie udało się zmienić typu uruchamiania usługi</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.pt-BR.resx b/optimizerDuck/Resources/Languages/Translations.pt-BR.resxindex 16ecbcb..271ade3 100644--- a/optimizerDuck/Resources/Languages/Translations.pt-BR.resx+++ b/optimizerDuck/Resources/Languages/Translations.pt-BR.resx@@ -388,6 +388,12 @@<data name="Service.Service.Info.SkippedNotFound" xml:space="preserve"><value>Serviço '{0}' não encontrado (pulado)</value></data>+ <data name="Service.Service.Info.AlreadyConfigured" xml:space="preserve">+ <value>O serviço '{0}' já está definido como {1} (pulado)</value>+ </data>+ <data name="Service.Service.Info.SkippedAccessDenied" xml:space="preserve">+ <value>O acesso ao serviço '{0}' foi negado pelo Windows (pulado)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>Falha ao mudar o tipo de inicialização para o serviço</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.resx b/optimizerDuck/Resources/Languages/Translations.resxindex 18ee64e..4bc123f 100644--- a/optimizerDuck/Resources/Languages/Translations.resx+++ b/optimizerDuck/Resources/Languages/Translations.resx@@ -446,6 +446,12 @@<data name="Service.Service.Info.SkippedNotFound" xml:space="preserve"><value>Service '{0}' not found (skipped)</value></data>+ <data name="Service.Service.Info.AlreadyConfigured" xml:space="preserve">+ <value>Service '{0}' is already set to {1} (skipped)</value>+ </data>+ <data name="Service.Service.Info.SkippedAccessDenied" xml:space="preserve">+ <value>Access to service '{0}' is denied by Windows (skipped)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>Failed to change startup type for service</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.ru-RU.resx b/optimizerDuck/Resources/Languages/Translations.ru-RU.resxindex 8ff3a52..cb40869 100644--- a/optimizerDuck/Resources/Languages/Translations.ru-RU.resx+++ b/optimizerDuck/Resources/Languages/Translations.ru-RU.resx@@ -388,6 +388,12 @@<data name="Service.Service.Info.SkippedNotFound" xml:space="preserve"><value>Служба '{0}' не найдена (пропущена)</value></data>+ <data name="Service.Service.Info.AlreadyConfigured" xml:space="preserve">+ <value>Служба '{0}' уже имеет тип запуска {1} (пропущена)</value>+ </data>+ <data name="Service.Service.Info.SkippedAccessDenied" xml:space="preserve">+ <value>Доступ к службе '{0}' запрещен Windows (пропущена)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>Не удалось изменить тип запуска службы</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.tr-TR.resx b/optimizerDuck/Resources/Languages/Translations.tr-TR.resxindex 00e8b04..e8913dc 100644--- a/optimizerDuck/Resources/Languages/Translations.tr-TR.resx+++ b/optimizerDuck/Resources/Languages/Translations.tr-TR.resx@@ -387,6 +387,12 @@<data name="Service.Service.Info.SkippedNotFound" xml:space="preserve"><value>'{0}' servisi bulunamadı (atlandı)</value></data>+ <data name="Service.Service.Info.AlreadyConfigured" xml:space="preserve">+ <value>'{0}' servisi zaten {1} olarak ayarlı (atlandı)</value>+ </data>+ <data name="Service.Service.Info.SkippedAccessDenied" xml:space="preserve">+ <value>Windows, '{0}' servisine erişimi reddetti (atlandı)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>Servis başlangıç türü değiştirilemedi</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.vi-VN.resx b/optimizerDuck/Resources/Languages/Translations.vi-VN.resxindex 2e376dd..d3b0cae 100644--- a/optimizerDuck/Resources/Languages/Translations.vi-VN.resx+++ b/optimizerDuck/Resources/Languages/Translations.vi-VN.resx@@ -385,6 +385,12 @@<data name="Service.Service.Info.SkippedNotFound" xml:space="preserve"><value>Không tìm thấy dịch vụ '{0}' (đã bỏ qua)</value></data>+ <data name="Service.Service.Info.AlreadyConfigured" xml:space="preserve">+ <value>Dịch vụ '{0}' đã có kiểu khởi động {1} (bỏ qua)</value>+ </data>+ <data name="Service.Service.Info.SkippedAccessDenied" xml:space="preserve">+ <value>Truy cập vào dịch vụ '{0}' bị Windows từ chối (đã bỏ qua)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>Không thể thay đổi kiểu khởi động cho dịch vụ</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.zh-CN.resx b/optimizerDuck/Resources/Languages/Translations.zh-CN.resxindex bf552db..1c362f1 100644--- a/optimizerDuck/Resources/Languages/Translations.zh-CN.resx+++ b/optimizerDuck/Resources/Languages/Translations.zh-CN.resx@@ -388,6 +388,12 @@<data name="Service.Service.Info.SkippedNotFound" xml:space="preserve"><value>未找到服务 '{0}'(已跳过)</value></data>+ <data name="Service.Service.Info.AlreadyConfigured" xml:space="preserve">+ <value>服务 '{0}' 已是 {1}(已跳过)</value>+ </data>+ <data name="Service.Service.Info.SkippedAccessDenied" xml:space="preserve">+ <value>Windows 拒绝访问服务 '{0}'(已跳过)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>更改服务启动类型失败</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.zh-TW.resx b/optimizerDuck/Resources/Languages/Translations.zh-TW.resxindex f77de49..f8f29d0 100644--- a/optimizerDuck/Resources/Languages/Translations.zh-TW.resx+++ b/optimizerDuck/Resources/Languages/Translations.zh-TW.resx@@ -360,6 +360,12 @@<data name="Service.Service.Info.SkippedNotFound" xml:space="preserve"><value>找不到服務 '{0}'(已跳過)</value></data>+ <data name="Service.Service.Info.AlreadyConfigured" xml:space="preserve">+ <value>服務 '{0}' 已是 {1}(已跳過)</value>+ </data>+ <data name="Service.Service.Info.SkippedAccessDenied" xml:space="preserve">+ <value>Windows 拒絕存取服務 '{0}'(已跳過)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>變更服務啟動類型失敗</value></data>diff --git a/optimizerDuck/Services/Optimization/Providers/ServiceProcessService.cs b/optimizerDuck/Services/Optimization/Providers/ServiceProcessService.csindex 2fc6b0c..c3fe765 100644--- a/optimizerDuck/Services/Optimization/Providers/ServiceProcessService.cs+++ b/optimizerDuck/Services/Optimization/Providers/ServiceProcessService.cs@@ -13,6 +13,8 @@ public static class ServiceProcessService{private const int ErrorServiceDoesNotExist = 1060;+ private const int ErrorAccessDenied = 5;+private static readonly AsyncLocal<string?> _lastError = new();private static readonly AsyncLocal<string?> _lastErrorDetail = new();@@ -128,8 +130,8 @@ public static class ServiceProcessService/// <summary>Changes the startup type of a single Windows service via <c>sc.exe config</c>. Records a revert step if the original type differs.</summary>/// <param name="item">The service item with the target startup type.</param>- /// <returns><see langword="true"/> if the change succeeded, otherwise <see langword="false"/>.</returns>- public static async Task<bool> ChangeServiceStartupTypeAsync(ServiceItem item)+ /// <returns>The outcome of the change request.</returns>+ public static async Task<ServiceChangeResult> ChangeServiceStartupTypeAsync(ServiceItem item){_lastError.Value = _lastErrorDetail.Value = null;@@ -159,7 +161,7 @@ public static class ServiceProcessServicetrue,null);- return true;+ return ServiceChangeResult.NotFound;}if (originalStartupType == null)@@ -175,9 +177,35 @@ public static class ServiceProcessServiceLoc.Invariant["Service.Service.Name"],description,false,+ null,+ _lastError.Value,+ () => RetryChangeServiceStartupTypeAsync(item),+ _lastErrorDetail.Value+ );+ return ServiceChangeResult.Failed;+ }++ if (originalStartupType.Value == item.StartupType)+ {+ sw.Stop();+ var alreadyDescription = Loc.Invariant[+ "Service.Service.Info.AlreadyConfigured",+ item.Name,+ item.StartupType+ ];+ ExecutionScope.LogInfo(+ "[SERVICE][{Name}] already {StartupType}, skipping",+ item.Name,+ item.StartupType+ );+ ExecutionScope.Track(nameof(ChangeServiceStartupTypeAsync), true);+ ExecutionScope.RecordStep(+ Loc.Invariant["Service.Service.Name"],+ alreadyDescription,+ true,null);- return false;+ return ServiceChangeResult.AlreadyConfigured;}var scType = item.StartupType switch@@ -225,7 +253,28 @@ public static class ServiceProcessServicetrue,revertStep);- return true;+ return ServiceChangeResult.Success;+ }++ if (exitCode == ErrorAccessDenied)+ {+ _lastError.Value = Loc.Invariant[+ "Service.Service.Info.SkippedAccessDenied",+ item.Name+ ];+ ExecutionScope.LogInfo(+ "[SERVICE][{Name}][SKIP][D={Duration}] access denied, Windows protects this service",+ item.Name,+ sw.Elapsed.FormatTime()+ );+ ExecutionScope.Track(nameof(ChangeServiceStartupTypeAsync), true);+ ExecutionScope.RecordStep(+ Loc.Invariant["Service.Service.Name"],+ _lastError.Value,+ true,+ null+ );+ return ServiceChangeResult.AccessDenied;}_lastError.Value = Loc.Invariant["Service.Service.Error.ChangeStartupTypeFailed"];@@ -242,10 +291,10 @@ public static class ServiceProcessServicefalse,null,_lastError.Value,- () => ChangeServiceStartupTypeAsync(item),+ () => RetryChangeServiceStartupTypeAsync(item),_lastErrorDetail.Value);- return false;+ return ServiceChangeResult.Failed;}catch (Exception ex){@@ -269,13 +318,19 @@ public static class ServiceProcessServicefalse,null,_lastError.Value,- () => ChangeServiceStartupTypeAsync(item),+ () => RetryChangeServiceStartupTypeAsync(item),_lastErrorDetail.Value);- return false;+ return ServiceChangeResult.Failed;}}+ private static async Task<bool> RetryChangeServiceStartupTypeAsync(ServiceItem item)+ {+ var result = await ChangeServiceStartupTypeAsync(item);+ return result != ServiceChangeResult.Failed;+ }+private static async Task<(int ExitCode, string Stdout, string Stderr)> RunScExeAsync(string arguments,int timeoutMs