Free, open-source Windows optimization tool for performance, privacy, and simplicity.
C# csharpdebloatdotnetgamingopen-sourceoptimizationoptimizeroptimizerduckperformanceprivacytweakertweakswindowswinui
fix: now treat missing services as success
fatDuck46b5c15a4b08
diff --git a/.codegraph/daemon.pid b/.codegraph/daemon.pidnew file mode 100644index 0000000..d17cb87--- /dev/null+++ b/.codegraph/daemon.pid@@ -0,0 +1,6 @@+{+ "pid": 17880,+ "version": "0.9.9",+ "socketPath": "\\\\.\\pipe\\codegraph-2ee028a0b3d441bd",+ "startedAt": 1781273598902+}diff --git a/optimizerDuck/Resources/Languages/Translations.Designer.cs b/optimizerDuck/Resources/Languages/Translations.Designer.csindex 2a48839..b921e1c 100644--- a/optimizerDuck/Resources/Languages/Translations.Designer.cs+++ b/optimizerDuck/Resources/Languages/Translations.Designer.cs@@ -4412,6 +4412,15 @@ namespace optimizerDuck.Resources.Languages {}}+ /// <summary>+ /// Looks up a localized string similar to Service '{0}' not found (skipped).+ /// </summary>+ internal static string Service_Service_Info_SkippedNotFound {+ get {+ return ResourceManager.GetString("Service.Service.Info.SkippedNotFound", resourceCulture);+ }+ }+/// <summary>/// Looks up a localized string similar to Failed to change startup type for service./// </summary>diff --git a/optimizerDuck/Resources/Languages/Translations.es-ES.resx b/optimizerDuck/Resources/Languages/Translations.es-ES.resxindex 5b0654c..5dc33b9 100644--- a/optimizerDuck/Resources/Languages/Translations.es-ES.resx+++ b/optimizerDuck/Resources/Languages/Translations.es-ES.resx@@ -436,6 +436,9 @@<data name="Service.Service.Error.NotFound" xml:space="preserve"><value>Servicio no encontrado</value></data>+ <data name="Service.Service.Info.SkippedNotFound" xml:space="preserve">+ <value>Servicio '{0}' no encontrado (omitido)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>No se pudo aplicar el tipo de inicio de servicio</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.fr-FR.resx b/optimizerDuck/Resources/Languages/Translations.fr-FR.resxindex 54e4c8f..fc7c740 100644--- a/optimizerDuck/Resources/Languages/Translations.fr-FR.resx+++ b/optimizerDuck/Resources/Languages/Translations.fr-FR.resx@@ -437,6 +437,9 @@<data name="Service.Service.Error.NotFound" xml:space="preserve"><value>Service introuvable</value></data>+ <data name="Service.Service.Info.SkippedNotFound" xml:space="preserve">+ <value>Service '{0}' introuvable (ignoré)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>Impossible de modifier le type de démarrage du service</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.ja-JP.resx b/optimizerDuck/Resources/Languages/Translations.ja-JP.resxindex d151661..809cbc6 100644--- a/optimizerDuck/Resources/Languages/Translations.ja-JP.resx+++ b/optimizerDuck/Resources/Languages/Translations.ja-JP.resx@@ -386,6 +386,9 @@<data name="Service.Service.Error.NotFound" xml:space="preserve"><value>サービスが見つかりません</value></data>+ <data name="Service.Service.Info.SkippedNotFound" xml:space="preserve">+ <value>サービス '{0}' が見つかりません(スキップ)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>サービスの開始タイプを変更できませんでした</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.ko-KR.resx b/optimizerDuck/Resources/Languages/Translations.ko-KR.resxindex 5e16ab4..a3a43cf 100644--- a/optimizerDuck/Resources/Languages/Translations.ko-KR.resx+++ b/optimizerDuck/Resources/Languages/Translations.ko-KR.resx@@ -384,6 +384,9 @@</data><data name="Service.Service.Error.NotFound" xml:space="preserve"><value>서비스를 찾을 수 없습니다</value>+</data>+ <data name="Service.Service.Info.SkippedNotFound" xml:space="preserve">+ <value>'{0}' 서비스를 찾을 수 없습니다 (건너뜀)</value></data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>서비스 시작 유형을 변경하지 못했습니다</value>diff --git a/optimizerDuck/Resources/Languages/Translations.pl-PL.resx b/optimizerDuck/Resources/Languages/Translations.pl-PL.resxindex b05a286..ad46cf8 100644--- a/optimizerDuck/Resources/Languages/Translations.pl-PL.resx+++ b/optimizerDuck/Resources/Languages/Translations.pl-PL.resx@@ -436,6 +436,9 @@<data name="Service.Service.Error.NotFound" xml:space="preserve"><value>Nie znaleziono usługi</value></data>+ <data name="Service.Service.Info.SkippedNotFound" xml:space="preserve">+ <value>Nie znaleziono usługi '{0}' (pominięto)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>Nie udało się zmienić typu uruchamiania usługi</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.resx b/optimizerDuck/Resources/Languages/Translations.resxindex 63c8a13..146f61c 100644--- a/optimizerDuck/Resources/Languages/Translations.resx+++ b/optimizerDuck/Resources/Languages/Translations.resx@@ -436,6 +436,9 @@<data name="Service.Service.Error.NotFound" xml:space="preserve"><value>Service not found</value></data>+ <data name="Service.Service.Info.SkippedNotFound" xml:space="preserve">+ <value>Service '{0}' not found (skipped)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>Failed to change startup type for service</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.ru-RU.resx b/optimizerDuck/Resources/Languages/Translations.ru-RU.resxindex f4a4926..37ba430 100644--- a/optimizerDuck/Resources/Languages/Translations.ru-RU.resx+++ b/optimizerDuck/Resources/Languages/Translations.ru-RU.resx@@ -436,6 +436,9 @@<data name="Service.Service.Error.NotFound" xml:space="preserve"><value>Служба не найдена</value></data>+ <data name="Service.Service.Info.SkippedNotFound" xml:space="preserve">+ <value>Служба '{0}' не найдена (пропущена)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>Не удалось изменить тип запуска службы</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.vi-VN.resx b/optimizerDuck/Resources/Languages/Translations.vi-VN.resxindex a924e85..2188dd4 100644--- a/optimizerDuck/Resources/Languages/Translations.vi-VN.resx+++ b/optimizerDuck/Resources/Languages/Translations.vi-VN.resx@@ -433,6 +433,9 @@<data name="Service.Service.Error.NotFound" xml:space="preserve"><value>Không tìm thấy dịch vụ</value></data>+ <data name="Service.Service.Info.SkippedNotFound" xml:space="preserve">+ <value>Không tìm thấy dịch vụ '{0}' (đã bỏ qua)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>Không thể thay đổi kiểu khởi động cho dịch vụ</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.zh-CN.resx b/optimizerDuck/Resources/Languages/Translations.zh-CN.resxindex 419eb5c..880a18c 100644--- a/optimizerDuck/Resources/Languages/Translations.zh-CN.resx+++ b/optimizerDuck/Resources/Languages/Translations.zh-CN.resx@@ -436,6 +436,9 @@<data name="Service.Service.Error.NotFound" xml:space="preserve"><value>未找到服务</value></data>+ <data name="Service.Service.Info.SkippedNotFound" xml:space="preserve">+ <value>未找到服务 '{0}'(已跳过)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>更改服务启动类型失败</value></data>diff --git a/optimizerDuck/Resources/Languages/Translations.zh-TW.resx b/optimizerDuck/Resources/Languages/Translations.zh-TW.resxindex 9b9b3b1..8da3a30 100644--- a/optimizerDuck/Resources/Languages/Translations.zh-TW.resx+++ b/optimizerDuck/Resources/Languages/Translations.zh-TW.resx@@ -408,6 +408,9 @@<data name="Service.Service.Error.NotFound" xml:space="preserve"><value>找不到服務</value></data>+ <data name="Service.Service.Info.SkippedNotFound" xml:space="preserve">+ <value>找不到服務 '{0}'(已跳過)</value>+ </data><data name="Service.Service.Error.ChangeStartupTypeFailed" xml:space="preserve"><value>變更服務啟動類型失敗</value></data>diff --git a/optimizerDuck/Services/Optimization/Providers/ServiceProcessService.cs b/optimizerDuck/Services/Optimization/Providers/ServiceProcessService.csindex 15973b3..ac4d7c5 100644--- a/optimizerDuck/Services/Optimization/Providers/ServiceProcessService.cs+++ b/optimizerDuck/Services/Optimization/Providers/ServiceProcessService.cs@@ -10,6 +10,8 @@ namespace optimizerDuck.Services.Optimization.Providers;public static class ServiceProcessService{+ private const int ErrorServiceDoesNotExist = 1060;+private static readonly AsyncLocal<string?> _lastError = new();private static readonly AsyncLocal<string?> _lastErrorDetail = new();@@ -28,8 +30,13 @@ public static class ServiceProcessService/// <summary>Retrieves the current startup type of a Windows service by running <c>sc.exe qc</c>.</summary>/// <param name="serviceName">The internal service name.</param>- /// <returns>The <see cref="ServiceStartupType"/> if parsed successfully, otherwise <see langword="null"/>.</returns>- public static async Task<ServiceStartupType?> GetStartupTypeAsync(string serviceName)+ /// <returns>+ /// A tuple. <c>StartupType</c> is the type if parsed successfully.+ /// <c>NotFound</c> is <see langword="true"/> when the service does not exist (exit code 1060),+ /// <see langword="false"/> for other errors.+ /// </returns>+ public static async Task<(ServiceStartupType? StartupType, bool NotFound)> GetStartupTypeAsync(+ string serviceName){try{@@ -37,13 +44,14 @@ public static class ServiceProcessServiceif (exitCode != 0){+ var notFound = exitCode == ErrorServiceDoesNotExist;ExecutionScope.LogWarning("[SERVICE][{Name}] sc.exe qc failed with exit code {ExitCode}: {Stderr}",serviceName,exitCode,stderr);- return null;+ return (null, notFound);}var startMatch = _startTypeRegex.Match(stdout);@@ -53,20 +61,21 @@ public static class ServiceProcessService"[SERVICE][{Name}] Could not parse START_TYPE from sc.exe qc output",serviceName);- return null;+ return (null, false);}var startValue = int.Parse(startMatch.Groups[1].Value);- return startValue switch+ var result = startValue switch{2 => _delayedRegex.IsMatch(stdout)? ServiceStartupType.AutomaticDelayedStart: ServiceStartupType.Automatic,3 => ServiceStartupType.Manual,4 => ServiceStartupType.Disabled,- _ => null,+ _ => (ServiceStartupType?)null,};+ return (result, false);}catch (Exception ex){@@ -75,7 +84,7 @@ public static class ServiceProcessService"Failed to get startup type for {ServiceName}",serviceName);- return null;+ return (null, false);}}@@ -95,7 +104,46 @@ public static class ServiceProcessServicetry{- var originalStartupType = await GetStartupTypeAsync(item.Name);+ var (originalStartupType, notFound) = await GetStartupTypeAsync(item.Name);++ if (notFound)+ {+ sw.Stop();+ var skipDescription = string.Format(+ Translations.Service_Service_Info_SkippedNotFound,+ item.Name+ );+ ExecutionScope.LogInfo(+ "[SERVICE][{Name}] not found, skipping",+ item.Name+ );+ ExecutionScope.Track(nameof(ChangeServiceStartupTypeAsync), true);+ ExecutionScope.RecordStep(+ Translations.Service_Service_Name,+ skipDescription,+ true,+ null+ );+ return true;+ }++ if (originalStartupType == null)+ {+ sw.Stop();+ ExecutionScope.LogInfo(+ "[SERVICE][{Name}][FAIL][D={Duration}] could not query startup type",+ item.Name,+ sw.Elapsed.FormatTime()+ );+ ExecutionScope.Track(nameof(ChangeServiceStartupTypeAsync), false);+ ExecutionScope.RecordStep(+ Translations.Service_Service_Name,+ description,+ false,+ null,+ );+ return false;+ }var scType = item.StartupType switch{@@ -121,7 +169,7 @@ public static class ServiceProcessServiceif (success){ServiceRevertStep? revertStep = null;- if (originalStartupType.HasValue && originalStartupType.Value != item.StartupType)+ if (originalStartupType.Value != item.StartupType)revertStep = new ServiceRevertStep{ServiceName = item.Name,