Free, open-source Windows optimization tool for performance, privacy, and simplicity.
C# csharpdebloatdotnetgamingopen-sourceoptimizationoptimizeroptimizerduckperformanceprivacytweakertweakswindowswinui
fix(ui): hide the cleanup path when the item has none
fatDuck8f570019b9bb
diff --git a/optimizerDuck.Test/Common/Converters/ValueConditionToVisibilityConverterTests.cs b/optimizerDuck.Test/Common/Converters/ValueConditionToVisibilityConverterTests.csnew file mode 100644index 0000000..f8d10b7--- /dev/null+++ b/optimizerDuck.Test/Common/Converters/ValueConditionToVisibilityConverterTests.cs@@ -0,0 +1,30 @@+using System.Globalization;+using System.Windows;+using optimizerDuck.Common.Converters;++namespace optimizerDuck.Test.Common.Converters;++public class ValueConditionToVisibilityConverterTests+{+ private static readonly ValueConditionToVisibilityConverter NotEmpty = new()+ {+ ConditionType = ValueConditionType.IsNotNullOrEmpty,+ };++ [Theory]+ [InlineData(null, Visibility.Collapsed)]+ [InlineData("", Visibility.Collapsed)]+ [InlineData(" ", Visibility.Collapsed)]+ [InlineData(@"C:\Windows\Temp", Visibility.Visible)]+ public void Convert_NotNullOrEmpty_ReportsVisibility(string? value, Visibility expected)+ {+ var actual = NotEmpty.Convert(+ value,+ typeof(Visibility),+ null,+ CultureInfo.InvariantCulture+ );++ Assert.Equal(expected, actual);+ }+}diff --git a/optimizerDuck/Common/Converters/ValueConditionToVisibilityConverter.cs b/optimizerDuck/Common/Converters/ValueConditionToVisibilityConverter.csindex b827939..45f01c0 100644--- a/optimizerDuck/Common/Converters/ValueConditionToVisibilityConverter.cs+++ b/optimizerDuck/Common/Converters/ValueConditionToVisibilityConverter.cs@@ -8,13 +8,14 @@ public enum ValueConditionType{IsNull,IsNotNull,+ IsNotNullOrEmpty,IsZero,IsNotZero,IsGreaterThanZero,IsLessThanZero,}-/// <summary>Shows or hides a control based on a value condition (null, zero, or sign).</summary>+/// <summary>Shows or hides a control based on a value condition (null, empty text, zero, or sign).</summary>public class ValueConditionToVisibilityConverter : IValueConverter{public ValueConditionType ConditionType { get; set; } = ValueConditionType.IsNull;@@ -29,6 +30,8 @@ public class ValueConditionToVisibilityConverter : IValueConverter{ValueConditionType.IsNull => value is null,ValueConditionType.IsNotNull => value is not null,+ ValueConditionType.IsNotNullOrEmpty => value is string text+ && !string.IsNullOrWhiteSpace(text),ValueConditionType.IsZero => value is 0,ValueConditionType.IsNotZero => value is not 0,ValueConditionType.IsGreaterThanZero => value is > 0,diff --git a/optimizerDuck/UI/Pages/DiskCleanupPage.xaml b/optimizerDuck/UI/Pages/DiskCleanupPage.xamlindex e5f98f3..03da8c6 100644--- a/optimizerDuck/UI/Pages/DiskCleanupPage.xaml+++ b/optimizerDuck/UI/Pages/DiskCleanupPage.xaml@@ -268,7 +268,8 @@Foreground="{DynamicResource TextFillColorDisabledBrush}"Text="{Binding Path}"TextTrimming="CharacterEllipsis"- ToolTip="{Binding Path}" />+ ToolTip="{Binding Path}"+ Visibility="{Binding Path, Converter={StaticResource NotEmptyToVisibilityConverter}}" /><!-- Size Badge --><Borderdiff --git a/optimizerDuck/UI/Styles/Converters.xaml b/optimizerDuck/UI/Styles/Converters.xamlindex 2220e23..ed1ddf9 100644--- a/optimizerDuck/UI/Styles/Converters.xaml+++ b/optimizerDuck/UI/Styles/Converters.xaml@@ -26,6 +26,7 @@ComparisonType="Equal"Threshold="0" /><converters:ValueConditionToVisibilityConverter x:Key="NotNullToVisibilityConverter" ConditionType="IsNotNull" />+ <converters:ValueConditionToVisibilityConverter x:Key="NotEmptyToVisibilityConverter" ConditionType="IsNotNullOrEmpty" /><!-- Legacy key: existing consumers (AppliedAt, Error, Model) expect visible-when-non-null --><converters:ValueConditionToVisibilityConverter x:Key="NullToVisibilityConverter" ConditionType="IsNotNull" /><converters:EmptyWhileNotLoadingConverter x:Key="EmptyWhileNotLoadingConverter" />