Skip to content

Free, open-source Windows optimization tool for performance, privacy, and simplicity.

fix(services): fetch locatable WMI instances for the USB power write

fatDuck9f3cc6672658
diff --git a/optimizerDuck.Test/Services/OptimizationServices/UsbPowerServiceTests.cs b/optimizerDuck.Test/Services/OptimizationServices/UsbPowerServiceTests.cs
index 8a4fe79..94a41d4 100644
--- a/optimizerDuck.Test/Services/OptimizationServices/UsbPowerServiceTests.cs
+++ b/optimizerDuck.Test/Services/OptimizationServices/UsbPowerServiceTests.cs
@@ -1,3 +1,4 @@
+using optimizerDuck.Services.System;
using optimizerDuck.Services.System.Primitives;
namespace optimizerDuck.Test.Services.OptimizationServices;
@@ -54,4 +55,33 @@ public class UsbPowerServiceTests
Assert.NotNull(result);
Assert.Equal(0, result.ChangedCount);
}
+
+ [Fact]
+ public void WriteQuery_ReturnsLocatableInstances()
+ {
+ // ManagementObject.Put() needs a complete object path. A partial property select leaves
+ // __PATH empty, which the provider refuses as "Invalid object" (verified on 2026-09-14),
+ // so the write query has to request whole instances. Read only: no device state changes.
+ var locatable = new List<bool>();
+
+ var rows = WmiHelper.Query(
+ UsbPowerService.DeviceQuery,
+ items =>
+ {
+ foreach (var device in items)
+ locatable.Add(!string.IsNullOrEmpty(device["__PATH"] as string));
+ return items.Count;
+ },
+ @"root\wmi"
+ );
+
+ if (rows is not > 0)
+ Assert.Skip("This host exposes no root\\wmi power rows, so there is nothing to pin.");
+
+ Assert.All(
+ locatable,
+ hasPath =>
+ Assert.True(hasPath, "the USB write query returned an instance without __PATH")
+ );
+ }
}
diff --git a/optimizerDuck/Services/System/Primitives/UsbPowerService.cs b/optimizerDuck/Services/System/Primitives/UsbPowerService.cs
index 46d064e..f86ec7f 100644
--- a/optimizerDuck/Services/System/Primitives/UsbPowerService.cs
+++ b/optimizerDuck/Services/System/Primitives/UsbPowerService.cs
@@ -1,4 +1,4 @@
-using System.Management;
+using System.Management;
using System.Runtime.Versioning;
namespace optimizerDuck.Services.System.Primitives;
@@ -16,7 +16,12 @@ public static class UsbPowerService
{
private const string NamespacePath = @"root\wmi";
private const string RootHubMarker = @"USB\ROOT";
- private const string DeviceQuery = "SELECT InstanceName, Enable FROM MSPower_DeviceEnable";
+
+ // SELECT * on purpose: with a partial property select, System.Management returns objects
+ // whose __PATH is empty (EnumerationOptions.EnsureLocatable defaults to false), and
+ // ManagementObject.Put() then fails with "Invalid object". Verified against live root\wmi on
+ // 2026-09-14: the partial select failed the write, the full select succeeded.
+ internal const string DeviceQuery = "SELECT * FROM MSPower_DeviceEnable";
/// <summary>One device and the USB power-management state Windows reports for it.</summary>
/// <param name="InstanceName">The WMI device instance name (used to match on revert).</param>