Skip to content

Free, open-source Windows optimization tool for performance, privacy, and simplicity.

fix: remove debug optimization tests in UserExperience.cs optimization and update tests

fatDucka45c13366b76
diff --git a/optimizerDuck.Test/Services/OptimizationServiceTests.cs b/optimizerDuck.Test/Services/OptimizationServiceTests.cs
index c593294..6faff9f 100644
--- a/optimizerDuck.Test/Services/OptimizationServiceTests.cs
+++ b/optimizerDuck.Test/Services/OptimizationServiceTests.cs
@@ -1,4 +1,4 @@
-using Microsoft.Extensions.Logging.Abstractions;
+using Microsoft.Extensions.Logging.Abstractions;
using Newtonsoft.Json;
using optimizerDuck.Common.Helpers;
using optimizerDuck.Domain.Abstractions;
@@ -94,7 +94,7 @@ public class OptimizationServiceTests
var result = await service.ApplyAsync(optimization, progress);
- Assert.Equal(OptimizationSuccessResult.Failed, result.Status);
+ Assert.Equal(OptimizationSuccessResult.PartialSuccess, result.Status);
Assert.True(File.Exists(revertPath));
}
finally
@@ -597,7 +597,8 @@ public class OptimizationServiceTests
public Func<
(IProgress<ProcessingProgress> progress, OptimizationContext context),
Task<ApplyResult>
- > ApplyImpl { get; init; } = _ => Task.FromResult(ApplyResult.True());
+ > ApplyImpl
+ { get; init; } = _ => Task.FromResult(ApplyResult.True());
public Guid Id { get; } = Guid.NewGuid();
public OptimizationRisk Risk { get; } = OptimizationRisk.Safe;
diff --git a/optimizerDuck/Domain/Optimizations/Categories/UserExperience.cs b/optimizerDuck/Domain/Optimizations/Categories/UserExperience.cs
index cd79f99..af2dcff 100644
--- a/optimizerDuck/Domain/Optimizations/Categories/UserExperience.cs
+++ b/optimizerDuck/Domain/Optimizations/Categories/UserExperience.cs
@@ -1,8 +1,7 @@
-using System.Collections.ObjectModel;
+using System.Collections.ObjectModel;
using Microsoft.Extensions.Logging;
using optimizerDuck.Domain.Abstractions;
using optimizerDuck.Domain.Attributes;
-using optimizerDuck.Domain.Execution;
using optimizerDuck.Domain.Optimizations.Models;
using optimizerDuck.Domain.Optimizations.Models.Services;
using optimizerDuck.Domain.UI;
@@ -79,67 +78,4 @@ public class UserExperience : IOptimizationCategory
return Task.FromResult(CompleteFromScope());
}
}
-
- [Optimization(
- Id = "11111111-1111-1111-1111-111111111111",
- Risk = OptimizationRisk.Safe,
- Tags = OptimizationTags.System
- )]
- public sealed class TestPass : BaseOptimization
- {
- public override Task<ApplyResult> ApplyAsync(
- IProgress<ProcessingProgress> progress,
- OptimizationContext context
- )
- {
- ExecutionScope.RecordStep("Test", "Step 1 — succeeds", true);
- ExecutionScope.RecordStep("Test", "Step 2 — succeeds", true);
- context.Logger.LogInformation("Test: all steps pass");
- return Task.FromResult(CompleteFromScope());
- }
- }
-
- [Optimization(
- Id = "22222222-2222-2222-2222-222222222222",
- Risk = OptimizationRisk.Moderate,
- Tags = OptimizationTags.System
- )]
- public sealed class TestAllFail : BaseOptimization
- {
- public override Task<ApplyResult> ApplyAsync(
- IProgress<ProcessingProgress> progress,
- OptimizationContext context
- )
- {
- ExecutionScope.RecordStep("Test", "Step 1 — fails", false, null, "Something went wrong");
- ExecutionScope.RecordStep("Test", "Step 2 — also fails", false, null, "Access denied");
- context.Logger.LogInformation("Test: all steps fail");
- return Task.FromResult(CompleteFromScope());
- }
- }
-
- [Optimization(
- Id = "33333333-3333-3333-3333-333333333333",
- Risk = OptimizationRisk.Risky,
- Tags = OptimizationTags.System | OptimizationTags.Performance
- )]
- public sealed class TestPartialFail : BaseOptimization
- {
- public override Task<ApplyResult> ApplyAsync(
- IProgress<ProcessingProgress> progress,
- OptimizationContext context
- )
- {
- ExecutionScope.RecordStep("Test", "Step 1 — succeeds", true);
- ExecutionScope.RecordStep("Test", "Step 2 — fails", false, null,
- "Something went wrong", null,
- "System.UnauthorizedAccessException: Access to the registry path is denied.\n at Microsoft.Win32.RegistryKey.Win32Error(Int32 errorCode, String str)\n at optimizerDuck.Services.OptimizationServices.RegistryService.Write(RegistryItem item)");
- ExecutionScope.RecordStep("Test", "Step 3 — succeeds", true);
- ExecutionScope.RecordStep("Test", "Step 4 — fails", false, null,
- "Access denied", null,
- "System.UnauthorizedAccessException: Access is not granted.\n at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)\n at optimizerDuck.Services.OptimizationServices.RegistryService.DeleteValue(RegistryItem item)");
- context.Logger.LogInformation("Test: partial steps fail");
- return Task.FromResult(CompleteFromScope());
- }
- }
}