Skip to content

Free, open-source Windows optimization tool for performance, privacy, and simplicity.

fix: use directly serilog logger in ConfigManager and fix wrong condition in fetching system info

fatDuckdd5f025600d3
diff --git a/optimizerDuck/App.xaml.cs b/optimizerDuck/App.xaml.cs
index 73796d4..bb3b0da 100644
--- a/optimizerDuck/App.xaml.cs
+++ b/optimizerDuck/App.xaml.cs
@@ -304,7 +304,10 @@ public partial class App : Application
.UseSerilog()
.ConfigureAppConfiguration(c =>
{
- ConfigManager.ValidateConfig();
+ using var loggerFactory = LoggerFactory.Create(b => b.AddSerilog(Log.Logger));
+ ConfigManager.ValidateConfig(
+ loggerFactory.CreateLogger(typeof(ConfigManager))
+ );
c.AddJsonFile(Path.Combine(Shared.RootDirectory, "appsettings.json"), false, true);
})
.ConfigureServices(
diff --git a/optimizerDuck/Services/Configuration/ConfigManager.cs b/optimizerDuck/Services/Configuration/ConfigManager.cs
index 96bd9b1..4d1c79f 100644
--- a/optimizerDuck/Services/Configuration/ConfigManager.cs
+++ b/optimizerDuck/Services/Configuration/ConfigManager.cs
@@ -410,7 +410,7 @@ public class ConfigManager(IConfiguration configuration, ILogger<ConfigManager>
/// <summary>
/// Validates and ensures the config file exists and is valid JSON.
/// </summary>
- public static void ValidateConfig()
+ public static void ValidateConfig(ILogger logger)
{
var configPath = Path.Combine(Shared.RootDirectory, "appsettings.json");
@@ -419,10 +419,7 @@ public class ConfigManager(IConfiguration configuration, ILogger<ConfigManager>
if (!File.Exists(configPath))
{
File.WriteAllText(configPath, "{}");
- global::System.Diagnostics.Trace.TraceInformation(
- "Created default empty config file: {Path}",
- configPath
- );
+ logger.LogInformation("Created default empty config file: {Path}", configPath);
return;
}
@@ -430,10 +427,7 @@ public class ConfigManager(IConfiguration configuration, ILogger<ConfigManager>
if (string.IsNullOrWhiteSpace(content))
{
File.WriteAllText(configPath, "{}");
- global::System.Diagnostics.Trace.TraceWarning(
- "Config file was empty, reset to empty: {Path}",
- configPath
- );
+ logger.LogWarning("Config file was empty, reset to empty: {Path}", configPath);
return;
}
@@ -442,7 +436,7 @@ public class ConfigManager(IConfiguration configuration, ILogger<ConfigManager>
if (!trimmed.StartsWith('{') || !trimmed.EndsWith('}'))
{
File.WriteAllText(configPath, "{}");
- global::System.Diagnostics.Trace.TraceWarning(
+ logger.LogWarning(
"Config file was not valid JSON, reset to empty: {Path}",
configPath
);
@@ -454,10 +448,7 @@ public class ConfigManager(IConfiguration configuration, ILogger<ConfigManager>
catch
{
File.WriteAllText(configPath, "{}");
- global::System.Diagnostics.Trace.TraceWarning(
- "Config file was corrupted, reset to empty: {Path}",
- configPath
- );
+ logger.LogWarning("Config file was corrupted, reset to empty: {Path}", configPath);
}
}
}
diff --git a/optimizerDuck/UI/ViewModels/Pages/DashboardViewModel.cs b/optimizerDuck/UI/ViewModels/Pages/DashboardViewModel.cs
index cb4fcf1..a1cb9c5 100644
--- a/optimizerDuck/UI/ViewModels/Pages/DashboardViewModel.cs
+++ b/optimizerDuck/UI/ViewModels/Pages/DashboardViewModel.cs
@@ -84,6 +84,7 @@ public partial class DashboardViewModel : ViewModel
protected override async Task InitializeOnceAsync()
{
+ await LoadSystemInfoAsync();
_systemInfoService.LogSummary();
var (result, version) = await _updaterService.CheckForUpdatesAsync();
if (result)