Free, open-source Windows optimization tool for performance, privacy, and simplicity.
C# csharpdebloatdotnetgamingopen-sourceoptimizationoptimizeroptimizerduckperformanceprivacytweakertweakswindowswinui
fix: use global timer to handle memory leak
itsfatducke896aff7151e
diff --git a/.github/assets/app.png b/.github/assets/app.pngindex 8d5c828..1263d18 100644Binary files a/.github/assets/app.png and b/.github/assets/app.png differdiff --git a/optimizerDuck/Core/Models/UI/OptimizationState.cs b/optimizerDuck/Core/Models/UI/OptimizationState.csindex 26b4d19..01e7044 100644--- a/optimizerDuck/Core/Models/UI/OptimizationState.cs+++ b/optimizerDuck/Core/Models/UI/OptimizationState.cs@@ -7,7 +7,9 @@ namespace optimizerDuck.Core.Models.UI;public partial class OptimizationState : ObservableObject{- private readonly DispatcherTimer _timer;+ private static readonly DispatcherTimer _globalTimer;+ private static readonly System.Collections.Generic.List<WeakReference<OptimizationState>> _instances = [];+private int _lastDisplayedSeconds = -1;[ObservableProperty] private DateTime? appliedAt;@@ -16,16 +18,41 @@ public partial class OptimizationState : ObservableObject[ObservableProperty] private OptimizationRisk risk;- public OptimizationState()+ static OptimizationState(){- _timer = new DispatcherTimer(- TimeSpan.FromMilliseconds(250),+ _globalTimer = new DispatcherTimer(+ TimeSpan.FromSeconds(1),DispatcherPriority.Render,- (s, e) => UpdateRelativeTime(),- Application.Current?.Dispatcher- ?? Dispatcher.CurrentDispatcher+ (s, e) => UpdateAllRelativeTimes(),+ Application.Current?.Dispatcher ?? Dispatcher.CurrentDispatcher);- _timer.Start();+ _globalTimer.Start();+ }++ private static void UpdateAllRelativeTimes()+ {+ lock (_instances)+ {+ for (var i = _instances.Count - 1; i >= 0; i--)+ {+ if (_instances[i].TryGetTarget(out var instance))+ {+ instance.UpdateRelativeTime();+ }+ else+ {+ _instances.RemoveAt(i);+ }+ }+ }+ }++ public OptimizationState()+ {+ lock (_instances)+ {+ _instances.Add(new WeakReference<OptimizationState>(this));+ }}private void UpdateRelativeTime()diff --git a/optimizerDuck/Services/StartupManagerService.cs b/optimizerDuck/Services/StartupManagerService.csindex 02050d1..ab57476 100644--- a/optimizerDuck/Services/StartupManagerService.cs+++ b/optimizerDuck/Services/StartupManagerService.cs@@ -229,7 +229,7 @@ public class StartupManagerService(ILogger<StartupManagerService> logger){var result = await ShellService.PowerShellAsync(@"Get-ScheduledTask |- Where-Object { $_.Triggers.CimClass.CimClassName -match 'LogonTrigger' -and $_.TaskPath -notmatch '\\Microsoft\\' } |+ Where-Object { $_.Triggers.CimClass.CimClassName -match 'LogonTrigger' -and $_.TaskPath -notlike '\\Microsoft\\*' } |Select-Object TaskName, TaskPath, State, Description |ConvertTo-Json -Depth 2");@@ -238,11 +238,18 @@ public class StartupManagerService(ILogger<StartupManagerService> logger)try{using var doc = JsonDocument.Parse(result.Stdout);- if (doc.RootElement.ValueKind == JsonValueKind.Array)- foreach (var el in doc.RootElement.EnumerateArray())- ParseTaskElement(el, tasks);- else if (doc.RootElement.ValueKind == JsonValueKind.Object)- ParseTaskElement(doc.RootElement, tasks);+ switch (doc.RootElement.ValueKind)+ {+ case JsonValueKind.Array:+ {+ foreach (var el in doc.RootElement.EnumerateArray())+ ParseTaskElement(el, tasks);+ break;+ }+ case JsonValueKind.Object:+ ParseTaskElement(doc.RootElement, tasks);+ break;+ }}catch (Exception parserEx){diff --git a/optimizerDuck/UI/ViewModels/Optimizer/OptimizationCategoryViewModel.cs b/optimizerDuck/UI/ViewModels/Optimizer/OptimizationCategoryViewModel.csindex db583ac..194c46d 100644--- a/optimizerDuck/UI/ViewModels/Optimizer/OptimizationCategoryViewModel.cs+++ b/optimizerDuck/UI/ViewModels/Optimizer/OptimizationCategoryViewModel.cs@@ -136,9 +136,7 @@ public partial class OptimizationCategoryViewModel : ViewModel};var filtered = query.ToList();- Optimizations.Clear();- foreach (var item in filtered)- Optimizations.Add(item);+ Optimizations = new ObservableCollection<IOptimization>(filtered);OnPropertyChanged(nameof(HasAppliedOptimizations));}