Skip to content

Free, open-source Windows optimization tool for performance, privacy, and simplicity.

docs: update contributing.md (+ locales)

fatDuckf0badfbf1224
diff --git a/AGENTS.md b/AGENTS.md
index 06474d1..1942e15 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -4,54 +4,99 @@
- **Windows-only**: Build/run/test only on Windows. Target framework: `net10.0-windows10.0.17763.0` with `UseWPF=true`. `CA1416` (platform compatibility) is silenced — all code is Windows-only.
- **Runs as admin**: `app.manifest` sets `requireAdministrator` UAC level. Tests that modify system settings or registry need admin too.
- **Solution format**: `.slnx` (not `.sln`).
-- **Data directory**: `%LocalAppData%\optimizerDuck\` — holds revert files, resources, downloads, assets.
+- **Data directory**: `%LocalAppData%\optimizerDuck\` — holds revert files (`Revert/`), resources (`Resources/`), downloads (`Resources/Downloads/`), assets (`Resources/Assets/`), crash logs (`Crashes/`).
+- **Version**: Currently 2.24.2 (defined in `optimizerDuck.csproj`).
## Build, Test, Run Commands
- `dotnet restore optimizerDuck.slnx` — restore dependencies.
- `dotnet build optimizerDuck.slnx --configuration Release --no-restore` — CI-aligned build.
- `dotnet test optimizerDuck.Test/optimizerDuck.Test.csproj --configuration Release --no-build` — run all tests.
- `dotnet test optimizerDuck.Test/optimizerDuck.Test.csproj --configuration Release --no-build --filter "FullyQualifiedName~TestName"` — run a single test.
-- `dotnet run --project optimizerDuck/optimizerDuck.csproj` — run locally.
+- `dotnet run --project optimizerDuck/optimizerDuck.csproj` — run locally (needs admin).
- `publish.bat portable` or `publish.bat single --skip-tests` — create release artifacts.
+- `dotnet csharpier .` — format all code with CSharpier.
## Project Structure
- `optimizerDuck/` — WPF app (single project, no sub-projects):
- `Domain/` — models, interfaces, attributes (no UI deps)
- - `Services/` — business logic: `Configuration/`, `Customize/`, `Optimization/`, `Revert/`, `System/`, `UI/`
+ - `Abstractions/` — `IOptimization`, `ICustomizeSetting`, `IRevertStep`, `ICustomizeCategory`, `IOptimizationCategory`, `IWindow`
+ - `Attributes/` — `[Optimization]`, `[CustomizeSetting]`, `[OptimizationCategory]`, `[CustomizeCategory]`
+ - `Execution/` — `ExecutionScope` (ambient `AsyncLocal`-based step tracking)
+ - `Customize/Categories/` — Desktop, Gaming, Preferences, SystemFeatures (nested setting classes)
+ - `Optimizations/Categories/` — Performance, SecurityAndPrivacy, Gpu, PowerManagement, BloatwareAndServices, UserExperience (nested optimization classes)
+ - `Optimizations/Models/` — `BaseOptimization`, `ApplyResult`, `OptimizationContext`
+ - `Optimizations/Models/Services/` — `RegistryItem`, `ServiceItem` (+ `ServiceStartupType`), `ShellResult`
+ - `Optimizations/Models/Bloatware/` — `AppXPackage`
+ - `Optimizations/Models/Cleanup/` — `CleanupItem`
+ - `Optimizations/Models/ScheduledTask/` — `ScheduledTaskModel`
+ - `Optimizations/Models/StartupManager/` — `StartupApp`, `StartupTask`
+ - `Customize/Models/` — `BaseCustomizeSetting`, `RegistryToggle`, `CustomizeRefreshScope`, `SettingOption`, `CustomizeControlType`, `RecommendationState`, `CustomizeRecommendationResult`
+ - `Revert/` — `RevertData`, `RevertResult`
+ - `Revert/Steps/` — `RegistryRevertStep`, `ServiceRevertStep`, `ScheduledTaskRevertStep`, `ShellRevertStep`, `UsbPowerRevertStep`
+ - `Configuration/` — `AppSettings`
+ - `UI/` — enums: `OptimizationRisk`, `OptimizationTags` (flags), `OptimizationCategoryOrder`, `CustomizeOrder`, `OptimizationSuccessResult`, `OptimizationState` (ObservableObject with relative-time display), `RiskVisual`, `ProcessingProgress`, `LanguageOption`
+ - `Services/` — business logic:
+ - `Configuration/` — `ConfigManager`, `LanguageManager`
+ - `Customize/` — `CustomizeRegistry` (reflection-based discovery)
+ - `Optimization/` — `OptimizationRegistry`, `OptimizationService`
+ - `Optimization/Providers/` — static: `RegistryService`, `ShellService` (+ `ShellPolicy`), `ScheduledTaskService`, `ServiceProcessService`
+ - `Revert/` — `RevertManager` (atomic file-based revert data persistence)
+ - `System/` — `RegistryWatcher` (+ `IRegistryWatcher`), `SystemInfoService`, `StreamService`, `UpdaterService`
+ - `UI/` — `BloatwareService`, `DiskCleanupService`, `StartupManagerService`
- `UI/` — XAML pages, ViewModels, windows, controls, dialogs, styles
- - `Common/` — extensions, helpers, converters
- - `Resources/` — images, embedded assets, localization (`Resources/Languages/Translations.resx`)
-- `optimizerDuck.Test/` — xUnit v3 tests (single test project)
+ - `Common/` — extensions, helpers, converters:
+ - `Helpers/` — `Shared.cs` (constants, paths, SafeApps/CautionApps sets), `ReflectionHelper.cs`, `SystemRefreshService.cs` (P/Invoke for Windows refresh), `EmbeddedResourceHelper.cs`, `WmiHelper.cs`, `GitHubSourceHelper.cs`, `ThemeResource.cs`
+ - `Converters/` — 20+ WPF value converters
+ - `Extensions/` — `StringExtensions`, `CustomizePageRegistryExtensions`, `OptimizationPageRegistryExtensions`, `LanguageExtensions`
+ - `Resources/` — images, embedded assets, locale files
+ - `Languages/` — `Translations.resx` (default) + 11 locale variants (vi-VN, es-ES, fr-FR, zh-TW, zh-CN, ru-RU, ko-KR, ja-JP, pl-PL, tr-TR, pt-BR)
+- `optimizerDuck.Test/` — xUnit v3 tests (single test project with `InternalsVisibleTo`)
- Do **not** create top-level directories outside these two project folders.
## Key NuGet Packages
-- `CommunityToolkit.Mvvm` 8.x — MVVM source generators (`[ObservableProperty]`, `[RelayCommand]`)
-- `WPF-UI` + `WPF-UI.DependencyInjection` 4.x — Fluent Design controls + navigation
-- `Microsoft.Extensions.Hosting` 10.x — DI / hosted service wiring
-- `xunit.v3` 3.x — test framework (with global using `Xunit` in test csproj)
+- `CommunityToolkit.Mvvm` 8.4.2 — MVVM source generators (`[ObservableProperty]`, `[RelayCommand]`)
+- `WPF-UI` + `WPF-UI.DependencyInjection` 4.3.0 — Fluent Design controls + navigation
+- `Microsoft.Extensions.Hosting` 10.0.9 — DI / hosted service wiring
+- `Newtonsoft.Json` 13.0.4 — JSON serialization for revert data
+- `Serilog` 4.3.1 + sinks — structured logging
+- `TaskScheduler` 2.12.2 — Windows scheduled task management
+- `System.Management.Automation` 7.6.3 — PowerShell host integration
+- `xunit.v3` 3.2.2 — test framework (with global using `Xunit` in test csproj)
## Optimization & Customize Discovery (Reflection, No Manual Registration)
- **New optimizations**: Create a **nested class** inside the relevant category class (e.g., `Domain/Optimizations/Categories/Performance.cs`), extend `BaseOptimization`, decorate with `[Optimization(Id = "guid", Risk = ..., Tags = ...)]`.
-- **New customize settings**: Same nesting pattern inside `Domain/Customize/Categories/`, extend `BaseCustomizeSetting`, decorate with `[CustomizeSetting(Section = ..., Icon = ..., Recommendation = ...)]`. `Icon` is required (`SymbolRegular` enum). `Section` can be a string or enum value.
+- **New customize settings**: Same nesting pattern inside `Domain/Customize/Categories/`, extend `BaseCustomizeSetting`, decorate with `[CustomizeSetting(Section = ..., Icon = ..., Recommendation = ...)]`. `Icon` is required (`SymbolRegular` enum). `Section` can be a string or enum value. `Recommendation` can be `On`, `Off`, `Depends`, `Experimental`, or `None`.
- **Category classes**: Decorate with `[OptimizationCategory(typeof(PageClass))]` or `[CustomizeCategory(PageType = typeof(PageClass))]`.
-- **Discovery**: `ReflectionHelper.FindImplementationsInLoadedAssemblies<T>()` scans assemblies whose name starts with `optimizerDuck` — no DI registration array to update.
+- **Discovery**: `ReflectionHelper.FindImplementationsInLoadedAssemblies<T>()` scans assemblies whose name starts with `optimizerDuck` — no DI registration array to update. Results are cached in `_implementationCache`.
- **Static provider services**: `RegistryService`, `ServiceProcessService`, `ScheduledTaskService`, `ShellService` are **static classes** (not DI-registered). They capture revert steps into the ambient `ExecutionScope`.
- **`CompleteFromScope()`**: Optimizations call `BaseOptimization.CompleteFromScope()` to build the `ApplyResult` from steps recorded in the ambient `ExecutionScope`. Do not manually construct `ApplyResult`.
+- **Preloading**: `OptimizationRegistry.StartPreload()` runs discovery on a background thread at startup. The Optimizations page calls `EnsurePreloadedAsync()` before binding.
+- **Customize discovery**: `CustomizeRegistry` uses the same reflection pattern for `ICustomizeSetting` implementations nested inside `ICustomizeCategory` classes.
## Revert System
- **File-based**: Each applied optimization creates `%LocalAppData%\optimizerDuck\Revert\{optimizationId}.json`. Applied state is inferred from file presence on disk.
- **Atomic writes**: `RevertManager` writes to `.tmp` then `File.Replace` for crash safety.
+- **Concurrent access**: Per-file `SemaphoreSlim` locks with 30-second timeout prevent race conditions.
- **Step types**: `RegistryRevertStep`, `ServiceRevertStep`, `ScheduledTaskRevertStep`, `ShellRevertStep`, `UsbPowerRevertStep`.
- **`ExecutionScope`**: Uses `AsyncLocal<ExecutionScope?>` for ambient step tracking — no need to pass context through parameters.
+- **Scope variants**: `ExecutionScope.Begin()` (creates persistable scope), `ExecutionScope.BeginForLogging()` (logging only, no persistence), `ExecutionScope.BeginForCapture()` (for retry, `OptimizationId = Guid.Empty`).
+- **`ExecutionScope.RecordStep()`**: Auto-incremented index. Records name, description, success/fail status, revert step, error, retry action, error detail.
+- **`ExecutionScope.RecordStepAtIndex()`**: For retry — preserves original index layout in revert files.
+- **`ExecutionScope.Track()`**: Tracks service-level success/fail counts for summary logging.
+- **Step registry**: Revert step deserialization uses reflection-based `_stepRegistry` (`ConcurrentDictionary`). New step types auto-register by implementing `IRevertStep` with a static `FromData(JObject)` method.
+- **Upsert**: `RevertManager.UpsertRevertStepAtIndexAsync()` can add/replace revert steps at specific indices (used during retry to persist recovered steps).
+- **Key methods**: `SaveRevertDataAsync()`, `RevertAsync()`, `IsAppliedAsync(id)`, `GetRevertDataAsync(id)`, `ClearAllRevertData()`.
## Coding & Style
- Nullable enabled, file-scoped namespaces, implicit usings.
- Indent: 4 spaces. PascalCase types/members, `_camelCase` private fields, `camelCase` locals/params.
- Max line length: 100 characters (enforced by `.editorconfig`).
- **No hardcoded UI strings** — use `Loc.Instance["Key"]` (C#) or `Translations.KeyName` (XAML bindings). Add new keys to `Resources/Languages/Translations.resx`.
-- **Keep comments sparse** — existing code has none; do not add them.
-- DI via `Microsoft.Extensions.Hosting` + `CommunityToolkit.Mvvm`. Pages + ViewModels registered as singletons.
+- **Keep comments sparse** — existing code has almost none; do not add unnecessary ones.
+- DI via `Microsoft.Extensions.Hosting` + `CommunityToolkit.Mvvm`. Pages + ViewModels registered as singletons in `App.xaml.cs`.
- `optimizerDuck.csproj` has `<InternalsVisibleTo Include="optimizerDuck.Test" />` — test project can access internal members.
+- Category pages auto-register via `services.AddAllCustomizeCategoryPages()` and `services.AddAllOptimizationPages()`.
+- ShellService must be initialized at startup: `ShellService.Init(appOptionsMonitor)`.
## Testing (xUnit v3, Integration-Style)
- **No mocking libraries** — all test doubles are hand-written (`FakeOptimization`, `TestOptimization`, etc.) implementing interfaces directly.
@@ -59,15 +104,62 @@
- **STA thread**: Tests involving WPF components must use `RunInStaThreadAsync` helper (STA thread + `TaskCompletionSource`). The test project itself defines this helper — add it if missing.
- **Logging**: Use `NullLogger<T>.Instance` / `NullLoggerFactory.Instance` for DI logging parameters.
- **Test naming**: `{Method}_{Scenario}_{ExpectedResult}` (e.g., `ApplyAsync_Success_PersistsRevertDataFile`).
-- **Cleanup**: Use `try/finally` or `IDisposable` for test artifact cleanup (revert files, registry keys).
+- **Cleanup**: Use `try/finally` or `IDisposable` for test artifact cleanup (revert files, registry keys). Tests that create revert data must clean up both `{id}.json` and `{id}.json.tmp`.
- **No coverage gate** — prioritize meaningful unit coverage for changed logic.
- **CI test command** uses `--blame-hang --blame-hang-timeout 30s` — tests must not hang longer than 30s.
+- **Test project packages**: `Microsoft.NET.Test.Sdk` 18.6.0, `xunit.v3` 3.2.2, `coverlet.collector` 10.0.1.
+
+## Shell Service Details
+- `ShellService.CMD()` and `CMDAsync()` run commands in cmd.exe.
+- `ShellService.PowerShell()` and `PowerShellAsync()` run commands with `-EncodedCommand` for safe encoding.
+- Both sync and async variants accept an optional `ShellRevertStep` (from `revertCommand` string or `Func<string>`) that gets saved for undo.
+- `ShellPolicy` class provides customizable success criteria (default: exit code 0). Use `ShellPolicy.SuccessExitCodes()` or `ShellPolicy.SuccessExitCodeRange()` for non-standard exit codes.
+- Default timeout: 120 seconds (configurable via `AppSettings.Optimize.ShellTimeoutMs`).
+- UTF-8 encoding is forced for both stdout and stderr.
+
+## Registry Service Details
+- Supports multiple root key prefixes: HKLM, HKLM:, HKEY_LOCAL_MACHINE, HKCU, HKCU:, HKEY_CURRENT_USER, HKCR, HKCR:, HKEY_CLASSES_ROOT, HKU, HKU:, HKEY_USERS, HKCC, HKCC:, HKEY_CURRENT_CONFIG.
+- `Write()` — writes a value, backing up the previous value for revert. Supports params array for batch writes. Can create missing subkeys.
+- `Read<T>()` — reads with type conversion (supports bool, int, string, string[], byte[], enum). Uses `DoNotExpandEnvironmentNames`.
+- `DeleteValue()` — deletes a value with backup for revert.
+- `CreateSubKey()` — creates a subkey, tracking created intermediate keys for revert cleanup.
+- `DeleteSubKeyTree()` — deletes an entire key tree, backing up all values/subkeys first (max depth 15, max 5000 items).
+- `KeyExists()` — checks if a registry key exists.
+- `CleanupEmptyKeys()` — removes empty keys that were created during apply (sorts by depth, child-first).
+- `Write(params RegistryItem[] items)` and `DeleteValue(params RegistryItem[] items)` — batch variants that deduplicate.
+
+## Service Process Service Details
+- `GetStartupTypeAsync(serviceName)` — queries current startup type via `sc.exe qc`. Returns `(ServiceStartupType?, bool NotFound)`. Uses locale-independent regex parsing of `sc qc` output.
+- `ChangeServiceStartupTypeAsync(ServiceItem)` — changes via `sc.exe config`. Records `ServiceRevertStep` only if the startup type actually changed.
+- `ChangeServiceStartupTypeAsync(params ServiceItem[])` — batch variant for multiple services.
+- `ServiceStartupType` enum: `Automatic`, `AutomaticDelayedStart`, `Manual`, `Disabled`. Note: Boot (0) and System (1) startup types are not used in this app.
+- Uses `sc.exe` with timeouts: 15s for queries, 30s for config changes.
+
+## Scheduled Task Service Details
+- Uses `Microsoft.Win32.TaskScheduler` library (TaskScheduler NuGet package).
+- `DisableTask(fullPath)` / `EnableTask(fullPath)` — toggle task state with revert step recording.
+- `IsTaskEnabled(fullPath)` — checks if a task exists and is enabled.
+- `DeleteTask(fullPath)` — deletes a task.
+- `GetAllTasks()` — enumerates all tasks recursively with icon extraction via `StartupManagerService.ExtractIcon`.
+- `GetStartupTasks()` — filtered to tasks with LogonTrigger or BootTrigger.
+- `RegisterTask(folderPath, model)` — registers a new task from `ScheduledTaskModel`.
+- `RunTask(fullPath)` / `StopTask(fullPath)` — controls task execution.
+- `GetTaskState(fullPath)` — returns current task state string.
+
+## Revert Step Types
+- `RegistryRevertStep` — actions: `RestorePrevious`, `NoPreviousValue`, `RestoreKey`, `RestoreKeyTree`. Tracks created subkeys for cleanup.
+- `ServiceRevertStep` — stores `ServiceName` and `OriginalStartupType`.
+- `ScheduledTaskRevertStep` — stores `FullPath` and `OriginalEnabled` state.
+- `ShellRevertStep` — stores `ShellType` (CMD/PowerShell) and `Command`.
+- `UsbPowerRevertStep` — stores list of `DeviceState` (InstanceName + Enable) for USB power settings.
## Commit & PR
- Conventional Commits: `feat:`, `fix:`, `refactor:`, `docs:`, `test:`, `i18n:`, `chore:`.
- Branch from `master`: `feature/<name>` or `fix/<issue-id>`.
- PRs: clear description, linked issue (`Closes #123`), passing CI (build + test), screenshot for UI changes.
- Never commit secrets or machine-specific paths.
+- Run `dotnet csharpier .` before committing.
+- Verify with: `dotnet build`, `dotnet test`, `dotnet csharpier .` before push.
<!-- rtk-instructions v2 -->
# RTK — Always Prefix Shell Commands with `rtk`
diff --git a/CONTRIBUTING.ja-JP.md b/CONTRIBUTING.ja-JP.md
index 8d796e5..db221ff 100644
--- a/CONTRIBUTING.ja-JP.md
+++ b/CONTRIBUTING.ja-JP.md
@@ -20,6 +20,7 @@
- ドキュメントやガイドの改善
- 翻訳の追加や修正
- コードの貢献:最適化、カスタマイズ設定、サービス、UI の改善
+- テストの追加や既存テストのレビュー
---
@@ -87,15 +88,13 @@ publish.bat single --skip-tests # Skip tests for quick iteration
publish.bat portable --no-pause # Don't pause at the end (CI-friendly)
```
-公開プロファイルは `Properties/PublishProfiles/` で定義されています。
-
<h3 id="quick-start-checklist">5. クイックスタートチェックリスト</h3>
初めて貢献する前に:
- [ ] リポジトリをフォークしてクローンする
- [ ] `dotnet build` が成功する(エラー 0 件)
-- [ ] `dotnet test` が通る(166 件以上のテストがすべて成功)
+- [ ] `dotnet test` が通る(すべてのテストが成功)
- [ ] `dotnet csharpier .` がエラーなくフォーマットできる
- [ ] 下記の [アーキテクチャ概要](#architecture-overview) を読む
@@ -110,48 +109,54 @@ optimizerDuck.slnx # Solution file (.slnx format)
├── optimizerDuck/ # Main WPF app (net10.0-windows)
│ ├── App.xaml.cs # DI registration, startup, theme, logging
│ ├── optimizerDuck.csproj # TFM: net10.0-windows10.0.17763.0, UseWPF=true
+│ ├── app.manifest # requireAdministrator UAC level
│ │
│ ├── Domain/ # Pure models, interfaces, attributes (no WPF deps)
-│ │ ├── Abstractions/ # IOptimization, ICustomizeSetting, IRevertStep, etc.
-│ │ ├── Attributes/ # [Optimization], [CustomizeSetting], [OptimizationCategory]
+│ │ ├── Abstractions/ # IOptimization, ICustomizeSetting, IRevertStep, IWindow, ICustomizeCategory, IOptimizationCategory
+│ │ ├── Attributes/ # [Optimization], [CustomizeSetting], [OptimizationCategory], [CustomizeCategory]
│ │ ├── Configuration/ # AppSettings model
│ │ ├── Execution/ # ExecutionScope — ambient step tracking via AsyncLocal
│ │ ├── Customize/ # Customize settings (Desktop, Gaming, Preferences, System)
│ │ │ ├── Categories/ # Category classes with nested setting classes
-│ │ │ └── Models/ # BaseCustomizeSetting, RegistryToggle, RefreshScope
+│ │ │ └── Models/ # BaseCustomizeSetting, RegistryToggle, RefreshScope, SettingOption, CustomizeControlType, RecommendationState
│ │ ├── Optimizations/ # Optimizations (Performance, Privacy, GPU, etc.)
│ │ │ ├── Categories/ # Category classes with nested optimization classes
-│ │ │ └── Models/ # BaseOptimization, ApplyResult, OptimizationContext
+│ │ │ └── Models/ # BaseOptimization, ApplyResult, OptimizationContext, ServiceItem, RegistryItem
+│ │ │ ├── Bloatware/ # AppXPackage model
+│ │ │ ├── Cleanup/ # CleanupItem
+│ │ │ ├── ScheduledTask/ # ScheduledTaskModel
+│ │ │ ├── Services/ # RegistryItem, ServiceItem, ShellResult, ServiceStartupType
+│ │ │ └── StartupManager/ # StartupApp, StartupTask
│ │ ├── Revert/ # RevertData, RevertResult, revert step types
-│ │ │ └── Steps/ # RegistryRevertStep, ServiceRevertStep, etc.
-│ │ └── UI/ # Enums: OptimizationRisk, OptimizationTags, CategoryOrder
+│ │ │ └── Steps/ # RegistryRevertStep, ServiceRevertStep, ScheduledTaskRevertStep, ShellRevertStep, UsbPowerRevertStep
+│ │ └── UI/ # Enums: OptimizationRisk, OptimizationTags, OptimizationCategoryOrder, CustomizeOrder, LanguageOption, OptimizationState, RiskVisual, ProcessingProgress
│ │
│ ├── Common/ # Shared helpers, extensions, converters
-│ │ ├── Extensions/ # StringExtensions, CustomizePageRegistryExtensions
-│ │ ├── Converters/ # WPF value converters
-│ │ └── Helpers/ # Shared.cs, ReflectionHelper.cs, SystemRefreshService.cs
+│ │ ├── Converters/ # 20+ WPF value converters
+│ │ ├── Extensions/ # StringExtensions, CustomizePageRegistryExtensions, OptimizationPageRegistryExtensions, LanguageExtensions
+│ │ ├── Helpers/ # Shared.cs, ReflectionHelper.cs, SystemRefreshService.cs, EmbeddedResourceHelper.cs, GitHubSourceHelper.cs, WmiHelper.cs, ThemeResource.cs
+│ │ └── Native/ # Native interop helpers
│ │
-│ ├── Services/ # Business logic
+│ ├── Services/ # Business logic layer
│ │ ├── Configuration/ # ConfigManager, LanguageManager
-│ │ ├── Customize/ # CustomizeRegistry (discovery via reflection)
-│ │ ├── Managers/ # BloatwareService, DiskCleanupService,
-│ │ │ # StartupManagerService, SystemInfoService,
-│ │ │ # StreamService, UpdaterService
+│ │ ├── Customize/ # CustomizeRegistry (reflection-based discovery)
│ │ ├── Optimization/ # OptimizationRegistry, OptimizationService
-│ │ │ └── Providers/ # Static: RegistryService, ShellService,
-│ │ │ # ScheduledTaskService, ServiceProcessService
-│ │ ├── Revert/ # RevertManager (writes/reads revert JSON files)
-│ │ ├── System/ # RegistryWatcher
-│ │ └── UI/ # ContentDialogService, etc.
+│ │ │ └── Providers/ # Static: RegistryService, ShellService, ScheduledTaskService, ServiceProcessService
+│ │ ├── Revert/ # RevertManager (atomic write/read of revert JSON files)
+│ │ ├── System/ # RegistryWatcher, StreamService, SystemInfoService, UpdaterService
+│ │ └── UI/ # BloatwareService, DiskCleanupService, StartupManagerService
│ │
│ ├── UI/ # WPF pages, ViewModels, controls, styles
-│ │ ├── Controls/ # Custom WPF controls
-│ │ ├── Dialogs/ # Dialog windows (ProcessingDialog, OptimizationResultDialog)
-│ │ ├── Pages/ # App pages + sub-folders (Optimize/, Customize/)
-│ │ ├── Styles/ # Fluent design styles
+│ │ ├── Behaviors/ # SmoothScrollBehavior
+│ │ ├── Controls/ # FilledNavigationViewItem
+│ │ ├── Dialogs/ # ProcessingDialog, OptimizationDetailsDialog, OptimizationResultDialog, RestorePointDialog, LegalDialog, BloatwareConfirmationDialog, ScheduledTaskCreateDialog, ScheduledTaskDetailsDialog, StartupTaskDetailsPanel
+│ │ ├── Pages/ # Dashboard, Optimize, Customize, Settings, Bloatware, DiskCleanup, StartupManager, ScheduledTasks + sub-folders
+│ │ │ ├── Customize/ # CustomizePage + Categories/
+│ │ │ └── Optimize/ # OptimizePage + Categories/
+│ │ ├── Styles/ # FluentDesign.xaml, NavigationViewOverride.xaml, ToolTipOverride.xaml
│ │ ├── ViewModels/ # Page and dialog ViewModels
-│ │ │ ├── Customize/ # CustomizeItemViewModel, CustomizeGroupViewModel
-│ │ │ ├── Dialogs/ # ProcessingViewModel, OptimizationResultDialogViewModel
+│ │ │ ├── Customize/ # CustomizeItemViewModel, CustomizeCategoryViewModel
+│ │ │ ├── Dialogs/ # ProcessingViewModel, OptimizationDetailsViewModel, etc.
│ │ │ ├── Optimizer/ # OptimizationCategoryViewModel
│ │ │ ├── Pages/ # Dashboard, Optimize, Customize, Settings, etc.
│ │ │ └── Windows/ # MainWindowViewModel
@@ -160,18 +165,9 @@ optimizerDuck.slnx # Solution file (.slnx format)
│ └── Resources/ # Images, embedded assets, localization
│ ├── Embedded/ # Power plans, icons
│ ├── Images/ # Duck.png, logos
-│ └── Languages/ # Translations.resx + 7 locale variants
+│ └── Languages/ # Translations.resx + 11 locale variants
│
-└── optimizerDuck.Test/ # xUnit v3 test project (166+ tests)
- ├── Common/Helpers/
- ├── Domain/
- │ ├── Customize/
- │ ├── Exceptions/
- │ ├── Optimizations/
- │ └── Revert/Steps/
- └── Services/
- ├── Managers/
- └── OptimizationServices/
+└── optimizerDuck.Test/ # xUnit v3 test project
```
<h3 id="key-design-decisions">主要な設計判断</h3>
@@ -183,6 +179,8 @@ optimizerDuck.slnx # Solution file (.slnx format)
| **ファイルベースのリバート追跡** | 適用状態 = ディスク上にファイルが存在する(`%localappdata%\optimizerDuck\Revert\{id}.json`)。データベースは使用しません。`File.Replace()` によるアトミック書き込み。 |
| **統合スタイルのテスト** | 実際のファイルシステム、実際のレジストリ(`HKCU\Software\TestOptimizerDuck*` 配下)、実際のプロセス実行。モックライブラリは使用せず、手書きのテストダブルのみ。 |
| **非同期サービスメソッド** | 外部プロセスを実行するプロバイダーメソッドは非同期(`*Async` サフィックス)です。最適化の `ApplyAsync` メソッドでは `async`/`await` を使用して UI の応答性を保ってください。 |
+| **静的な WMI ヘルパー** | `WmiHelper.Initialize()` が起動時に実行され、異常終了時の WMI イベントクリーンアップハンドラを登録します。 |
+| **保留中の変更トラッキング** | `App.HasPendingChanges` プロパティが未リバートの最適化を追跡します。アプリ終了時に PC/Explorer 再起動または終了のオプションを表示します。 |
---
@@ -196,6 +194,7 @@ optimizerDuck.slnx # Solution file (.slnx format)
| **バグ修正** | クラッシュ修正、ロジックエラー、UI の問題 | 任意の場所 |
| **翻訳** | 新しい言語の追加や既存翻訳の修正 | `Resources/Languages/Translations.*.resx` |
| **ドキュメント** | README、CONTRIBUTING など | `*.md` ファイル |
+| **テスト** | 新規・既存のテストの追加・レビュー | `optimizerDuck.Test/` |
---
@@ -209,6 +208,8 @@ optimizerDuck.slnx # Solution file (.slnx format)
2. `IOptimizationCategory` を実装するすべてのクラスを見つける
3. 各カテゴリについて、`IOptimization` を実装する**ネストされた public クラス**をスキャンする
4. 検出されたすべての最適化がインスタンス化され、`OwnerType` が自動的に割り当てられる
+5. `OptimizationService.UpdateOptimizationStateAsync` がディスク上のリバートファイルをスキャンし、各最適化を適用済み/未適用としてマークする
+6. `OptimizationRegistry.StartPreload()` が起動時にバックグラウンドスレッドでこれを実行する
**あなたの作業**:カテゴリ内にネストされたクラスを作成し、`BaseOptimization` を継承し、`[Optimization]` を付与する。以上です。
@@ -218,12 +219,12 @@ optimizerDuck.slnx # Solution file (.slnx format)
| ファイル | 属性 | 対象 |
|---|---|---|
-| `Performance.cs` | `[OptimizationCategory(typeof(PerformanceOptimizerPage))]` | RAM 調整、プロセス優先度、キーボードレイテンシ、マルチメディアスケジューラ |
-| `SecurityAndPrivacy.cs` | `[OptimizationCategory(typeof(SecurityAndPrivacyOptimizerPage))]` | テレメトリ、エラー報告、広告 ID、位置情報、Cortana、Copilot |
-| `Gpu.cs` | `[OptimizationCategory(typeof(GpuOptimizerPage))]` | AMD/NVIDIA/Intel レジストリ調整、電源状態、クロックゲーティング |
-| `PowerManagement.cs` | `[OptimizationCategory(typeof(PowerManagementOptimizerPage))]` | 休止状態、高速スタートアップ、USB 選択的サスペンド、カスタム電源プラン |
-| `BloatwareAndServices.cs` | `[OptimizationCategory(typeof(BloatwareAndServicesOptimizerPage))]` | OEM 再インストールのブロック、200 以上の Windows サービス起動タイプ |
-| `UserExperience.cs` | `[OptimizationCategory(typeof(UserExperienceOptimizerPage))]` | メニュー遅延、視覚効果、タスクバーアニメーション、透明度 |
+| `Performance.cs` | `[OptimizationCategory(typeof(PerformanceOptimizerPage))]` | RAM 調整、プロセス優先度、キーボードレイテンシ、マルチメディアスケジューラ、アクセシビリティホットキー |
+| `SecurityAndPrivacy.cs` | `[OptimizationCategory(typeof(SecurityAndPrivacyOptimizerPage))]` | テレメトリ、エラー報告、広告 ID、位置情報、Cortana、Copilot、コンテンツ配信マネージャー、アクティビティ履歴、AutoLogger |
+| `Gpu.cs` | `[OptimizationCategory(typeof(GpuOptimizerPage))]` | AMD/NVIDIA/Intel レジストリ調整、電源状態、クロックゲーティング、ASPM、非同期フリップ |
+| `PowerManagement.cs` | `[OptimizationCategory(typeof(PowerManagementOptimizerPage))]` | 休止状態、高速スタートアップ、USB 選択的サスペンド、カスタム電源プランのインストール、省電力設定の無効化 |
+| `BloatwareAndServices.cs` | `[OptimizationCategory(typeof(BloatwareAndServicesOptimizerPage))]` | OEM プリインストールアプリのブロック、170 以上の Windows サービス起動タイプ最適化 |
+| `UserExperience.cs` | `[OptimizationCategory(typeof(UserExperienceOptimizerPage))]` | メニュー遅延、視覚効果、タスクバーアニメーション、透明度、スタートメニューの Web 検索 |
<h3 id="step-by-step-add-to-existing-category">ステップバイステップ:既存カテゴリへの追加</h3>
@@ -274,6 +275,8 @@ public class Performance : IOptimizationCategory
| **進捗を報告する** | `progress.Report(new ProcessingProgress { ... })` を使用して UI ダイアログを更新する |
| **すべての例外をキャッチしない** | 例外は上位に伝播させる。`ExecutionScope` が成功/失敗を追跡する。`OptimizationService` レイヤーが例外を処理する |
| **リバートステップを手動で作成しない** | 静的プロバイダーサービスが `ExecutionScope.RecordStep()` 経由で自動的に行う |
+| **`context.Logger` を使用する** | 最適化コンテキストはロガーを提供します。重要な診断情報の記録に使用します |
+| **`context.Snapshot` をチェックする** | `OptimizationContext.Snapshot` がシステム情報(RAM、GPU、CPU)を提供します。条件付きロジックに使用できます |
<h3 id="available-service-providers">利用可能なサービスプロバイダー</h3>
@@ -281,29 +284,40 @@ public class Performance : IOptimizationCategory
| サービス | 主要メソッド | 使用理由 |
|---|---|---|
-| **`RegistryService`** | `Write()`、`Read<T>()`、`DeleteValue()`、`CreateSubKey()`、`DeleteSubKeyTree()` | レジストリキーの読み書き/削除。リバート用に元の値をバックアップする。 |
-| **`ShellService`** | `CMDAsync()`**、`PowerShellAsync()`** | CMD または PowerShell コマンドの実行。常に非同期バリアントを使用する。 |
+| **`RegistryService`** | `Write()`、`Read<T>()`、`DeleteValue()`、`CreateSubKey()`、`DeleteSubKeyTree()`、`KeyExists()` | レジストリキーの読み書き/削除。リバート用に元の値をバックアップする。複数の RegistryItem を一度に書き込み可能。 |
+| **`ShellService`** | `CMDAsync()`、`PowerShellAsync()`、`CMD()`(同期)、`PowerShell()`(同期) | CMD または PowerShell コマンドの実行。常に非同期バリアントを使用する。`revertCommand` パラメータで元に戻すコマンドを指定可能。 |
| **`ScheduledTaskService`** | `DisableTask()`、`EnableTask()`、`IsTaskEnabled()`、`DeleteTask()` | Windows スケジュールタスクの管理。 |
-| **`ServiceProcessService`** | `ChangeServiceStartupTypeAsync()`**、`GetStartupTypeAsync()`** | Windows サービスの管理。常に非同期バリアントを使用する。 |
-
-> **`**` が付いたメソッドは非同期です。** 最適化の `ApplyAsync` 内で `await` を使用して呼び出してください。
+| **`ServiceProcessService`** | `ChangeServiceStartupTypeAsync()`、`GetStartupTypeAsync()` | Windows サービスの管理。常に非同期バリアントを使用する。複数のサービスを一度に変更可能。 |
使用例:
```csharp
-// Sync registry writes
-RegistryService.Write(new RegistryItem(@"HKLM\...", "Value", 1));
+// Sync registry writes — multiple items at once
+RegistryService.Write(
+ new RegistryItem(@"HKLM\...", "Value1", 1),
+ new RegistryItem(@"HKLM\...", "Value2", 0)
+);
RegistryService.DeleteValue(new RegistryItem(@"HKCU\...", "OldValue"));
-// Async service changes
+// Async service changes — multiple services at once
await ServiceProcessService.ChangeServiceStartupTypeAsync(
- new ServiceItem("DiagTrack", ServiceStartupType.Disabled));
+ new ServiceItem("DiagTrack", ServiceStartupType.Disabled),
+ new ServiceItem("dmwappushservice", ServiceStartupType.Disabled)
+);
+
+// Async shell commands with revert command
+var result = await ShellService.CMDAsync(
+ "powercfg /h off",
+ "powercfg /h on" // revert command stored for undo
+);
-// Async shell commands
-var result = await ShellService.PowerShellAsync("Some-Command");
+// Async PowerShell
+var usbStates = await ShellService.PowerShellAsync(
+ "Get-CimInstance -Namespace root\\wmi -ClassName MSPower_DeviceEnable"
+);
```
-<h3 id="create-a-new-category">新しいカテゴリの作成</h3>
+<h3 id="new-category-and-helper-class">新しいカテゴリとヘルパーベースクラスの作成</h3>
最適化が既存のカテゴリに当てはまらない場合のみ。過度に細かいカテゴリは避けてください。
@@ -313,6 +327,26 @@ var result = await ShellService.PowerShellAsync("Some-Command");
4. `Domain/UI/OptimizationCategoryOrder.cs` の `OptimizationCategoryOrder` 列挙型にメンバーを追加する
5. XAML ページは `App.xaml.cs` の `services.AddAllOptimizationPages()` 経由で自動登録される
+複数の最適化が同じ構造を共有する場合(例:GPU ツイーク)、抽象中間クラスを作成します:
+
+```csharp
+public abstract class GpuRegistryOptimization : BaseOptimization
+{
+ protected abstract GpuVendor Vendor { get; }
+ protected abstract IReadOnlyList<RegistryItem> CreateItems(string registryPath);
+
+ public override Task<ApplyResult> ApplyAsync(...)
+ {
+ foreach (var gpu in context.Snapshot.Gpus.Where(g => g.Vendor == Vendor))
+ {
+ var path = $@"HKLM\...\{index:D4}";
+ RegistryService.Write(CreateItems(path).ToArray());
+ }
+ return Task.FromResult(CompleteFromScope());
+ }
+}
+```
+
<h3 id="localization-keys-optimization">ローカライズキー</h3>
すべての最適化には `Translations.resx` へのエントリが必要です。キーは厳格な規則に従います:
@@ -339,10 +373,10 @@ Optimizer.{CategoryName}.{OptimizationKey}.Error.{CustomKey}
| ファイル | 属性 | 対象 |
|---|---|---|
-| `Desktop.cs` | `[CustomizeCategory(PageType = typeof(DesktopFeatureCategory))]` | デスクトップアイコン(PC、ごみ箱、ネットワーク)、ショートカットオーバーレイ |
-| `Preferences.cs` | `[CustomizeCategory(PageType = typeof(PreferencesFeatureCategory))]` | タスクバーの配置、ウィジェット、ダークモード、ファイル拡張子、隠しファイルなど |
-| `Gaming.cs` | `[CustomizeCategory(PageType = typeof(GamingFeatureCategory))]` | ゲームモード、ゲームバー、マウス加速度、フルスクリーン最適化、GPU スケジューリング |
-| `SystemFeatures.cs` | `[CustomizeCategory(PageType = typeof(SystemFeatureCategory))]` | 起動時の Num Lock |
+| `Desktop.cs` | `[CustomizeCategory(PageType = typeof(DesktopFeatureCategory))]` | デスクトップアイコン(PC、ごみ箱、ネットワーク、ユーザーファイル)、ショートカットオーバーレイ |
+| `Preferences.cs` | `[CustomizeCategory(PageType = typeof(PreferencesFeatureCategory))]` | タスクバーの配置、ウィジェット、ダークモード、ファイル拡張子、隠しファイル、クリップボード履歴、検索モード、秒表示、Bing 検索、クラシックコンテキストメニュー |
+| `Gaming.cs` | `[CustomizeCategory(PageType = typeof(GamingFeatureCategory))]` | ゲームモード、ゲームバー、バックグラウンド録画、マウス加速度、フルスクリーン最適化、GPU スケジューリング |
+| `SystemFeatures.cs` | `[CustomizeCategory(PageType = typeof(SystemFeatureCategory))]` | 起動時の Num Lock、開発者モード、LongPaths、バッテリー残量表示 |
<h3 id="step-by-step-simple-registry-toggle">ステップバイステップ:シンプルなレジストリトグル</h3>
@@ -389,37 +423,27 @@ public class TaskbarAlignment : BaseCustomizeSetting
| `TreatMissingAsDefault` | `bool` | `false` | `true` の場合、キーが存在しないときは「オフ」ではなく `DefaultValue` を使用 |
| `ValueKind` | `RegistryValueKind` | `DWord` | レジストリ値の型(DWord、String など) |
-**状態検出ロジック**:`GetState()`(`BaseCustomizeSetting` 内)がすべての非オプションの `RegistryToggles` を収集し、**すべて**の必須トグルが `OnValue` と一致する場合にのみ `true` を返します。
-
<h3 id="control-types">コントロールタイプ</h3>
| 型 | 表示形式 | 用途 |
|---|---|---|
| `Toggle` | ON/OFF スイッチ | ほとんどの設定(デフォルト) |
-| `Dropdown` | コンボボックス | 複数選択(例:電源プラン) |
+| `Dropdown` | コンボボックス | 複数選択(例:電源プラン、検索ボックスモード) |
| `Option` | ラジオボタングループ | 排他的な視覚オプション(例:左/中央揃え) |
| `NumberInt` | 整数テキスト入力 | 数値(例:秒数) |
| `NumberFloat` | 小数テキスト入力 | 精度の高い値 |
| `String` | テキスト入力 | 自由形式のテキスト |
-`ControlType` をオーバーライドして UI コントロールを変更します:
-
-```csharp
-public override CustomizeControlType ControlType => CustomizeControlType.Dropdown;
-```
-
<h3 id="dropdown-with-options">オプション付きドロップダウン</h3>
-複数の選択肢がある設定の場合:
-
```csharp
public override CustomizeControlType ControlType => CustomizeControlType.Dropdown;
public override IReadOnlyList<SettingOption>? Options =>
[
- Option("Never", 0), // Option() helper reads from Translations.resx:
- Option("Battery", 1), // Customize.{Category}.{Feature}.Options.Never
- Option("Always", 2), // Customize.{Category}.{Feature}.Options.Battery
+ Option("Never", 0), // Option() helper reads from Translations.resx
+ Option("Battery", 1),
+ Option("Always", 2),
];
public override async Task ApplyAsync(object? value)
@@ -430,9 +454,23 @@ public override async Task ApplyAsync(object? value)
}
```
-<h3 id="custom-logic-override">カスタムロジック(GetStateAsync / ApplyAsync のオーバーライド)</h3>
+<h3 id="dynamic-options">動的オプション(プラットフォーム対応)</h3>
+
+Windows バージョンに応じてオプションを条件付きで表示できます:
-シンプルなレジストリトグルではない設定の場合(例:マウス加速度は 3 つのレジストリ値を組み合わせる):
+```csharp
+public override IReadOnlyList<SettingOption>? Options
+{
+ get
+ {
+ if (Shared.IsWindows11OrGreater)
+ return [Option("Hidden", 0), Option("Icon", 1), Option("IconAndLabel", 2), Option("SearchBox", 3)];
+ return [Option("Hidden", 0), Option("Icon", 1), Option("SearchBox", 2)];
+ }
+}
+```
+
+<h3 id="custom-logic-override">カスタムロジック(GetStateAsync / ApplyAsync のオーバーライド)</h3>
```csharp
[CustomizeSetting(
@@ -444,7 +482,6 @@ public class MouseAcceleration : BaseCustomizeSetting
{
private const string Path = @"HKCU\Control Panel\Mouse";
- // Watched paths let the UI auto-refresh when external changes occur
protected override IReadOnlyList<string> GetWatchedRegistryPaths() => [Path];
public override Task<bool> GetStateAsync()
@@ -473,16 +510,40 @@ public class MouseAcceleration : BaseCustomizeSetting
}
```
+<h3 id="recommendation-system">レコメンデーションシステム</h3>
+
+各カスタマイズ設定はレコメンデーションを宣言できます:
+
+```csharp
+[CustomizeSetting(..., Recommendation = RecommendationState.On)]
+// Available: On, Off, Depends, Experimental, None
+```
+
+レコメンデーションの理由はローカライズキーで追加:`Customize.{Category}.{Feature}.Recommendation.Reason`
+
+<h3 id="embedded-resource-extraction">埋め込みリソースの抽出</h3>
+
+設定によってはアセンブリから埋め込みリソースを抽出する必要があります:
+
+```csharp
+var outputPath = Path.Combine(Shared.AssetsDirectory, nameof(Desktop), "blank.ico");
+EmbeddedResourceHelper.TryExtract("Icons.blank.ico", outputPath);
+RegistryService.Write(new RegistryItem(Path, "29", outputPath));
+```
+
<h3 id="what-to-override-per-pattern">パターンごとのオーバーライド</h3>
| シナリオ | オーバーライド |
|---|---|
| シンプルなレジストリトグル | `RegistryToggles` + `RefreshScope` |
| 複数のレジストリトグル | `RegistryToggles`(すべてリストする) |
-| ドロップダウン/オプション | `ControlType` → `Dropdown`、`Options`、カスタム `ApplyAsync` |
-| 複数値ロジック(例:マウス加速度) | `GetStateAsync()` + `ApplyAsync()` + `GetWatchedRegistryPaths()` |
+| ドロップダウン/オプション | `ControlType` → `Dropdown`、`Options`、カスタム `ApplyAsync`、`CurrentValue` |
+| 複数値ロジック | `GetStateAsync()` + `ApplyAsync()` + `GetWatchedRegistryPaths()` |
| レジストリ操作のない設定 | `GetStateAsync()` + `ApplyAsync()`(完全カスタム) |
-| カスタムリフレッシュ動作 | `RefreshScope`(フラグのみ変更の場合)または `ExecutePostActionAsync()`(完全オーバーライド) |
+| カスタムリフレッシュ動作 | `RefreshScope` または `ExecutePostActionAsync()` |
+| 収束チェック付き状態検出 | `GetStateWithRetryAsync()`(組み込み — オーバーライド不要) |
+| Windows バージョンごとの動的オプション | `Options` ゲッターを条件付きでオーバーライド |
+| 埋め込みリソース抽出 | `EmbeddedResourceHelper.TryExtract()` |
<h3 id="create-a-new-customize-category">新しいカテゴリの作成</h3>
@@ -506,44 +567,28 @@ Customize.{CategoryName}.Section.{SectionName} (for section heade
<h1 id="the-refresh-scope-system">リフレッシュスコープシステム</h1>
-カスタマイズ設定の状態が変更されると、異なる Windows サーフェスに異なるリフレッシュ戦略が必要になります。`CustomizeRefreshScope` [Flags] 列挙型がこれを細かく制御します。
-
<h3 id="available-flags">利用可能なフラグ</h3>
| メンバー | 値 | 効果 | P/Invoke |
|---|---|---|---|
| `None` | `0` | リフレッシュなし | — |
-| `Settings` | `1 << 0` | `WM_SETTINGCHANGE` をブロードキャストしてアプリがレジストリを再読み込み | `SendMessageTimeout(HWND_BROADCAST, WM_SETTINGCHANGE)` |
-| `Associations` | `1 << 1` | ファイル関連付けやアイコンキャッシュの変更をシェルに通知 | `SHChangeNotify(SHCNE_ASSOCCHANGED)` |
-| `Desktop` | `1 << 2` | デスクトップアイコンリスト(`SysListView32`)の再描画を強制 | `LVM_REFRESH` + `LVM_UPDATE` |
-| `Taskbar` | `1 << 3` | タスクバー向けの `WM_SETTINGCHANGE`("TraySettings")をブロードキャスト | `SendMessageTimeout(HWND_BROADCAST, WM_SETTINGCHANGE, "TraySettings")` |
-| `PolicyUpdate` | `1 << 4` | ユーザーごとのパラメータに `SPIF_SENDCHANGE` 付きで `SystemParametersInfo` をプッシュ | `SystemParametersInfo(SPI_SETDESKWALLPAPER)` |
-| `Theme` | `1 << 5` | テーマ/視覚調整用に `WM_THEMECHANGED` をブロードキャスト | `SendMessageTimeout(HWND_BROADCAST, WM_THEMECHANGED)` |
-| `DesktopIconCache` | `1 << 6` | HideIcons レジストリを切り替え + デスクトップに `WM_COMMAND 0x7402` を送信 | Registry read + `SendMessage(Progman, WM_COMMAND)` |
+| `Settings` | `1 << 0` | `WM_SETTINGCHANGE` をブロードキャスト | `SendMessageTimeout(HWND_BROADCAST, WM_SETTINGCHANGE)` |
+| `Associations` | `1 << 1` | ファイル関連付け変更をシェルに通知 | `SHChangeNotify(SHCNE_ASSOCCHANGED)` |
+| `Desktop` | `1 << 2` | デスクトップアイコンリストの再描画を強制 | `LVM_REFRESH` + `LVM_UPDATE` |
+| `Taskbar` | `1 << 3` | タスクバー向け `WM_SETTINGCHANGE` | `SendMessageTimeout(HWND_BROADCAST, WM_SETTINGCHANGE, "TraySettings")` |
+| `PolicyUpdate` | `1 << 4` | `SystemParametersInfo` をプッシュ | `SystemParametersInfo(SPI_SETDESKWALLPAPER)` |
+| `Theme` | `1 << 5` | `WM_THEMECHANGED` をブロードキャスト | `SendMessageTimeout(HWND_BROADCAST, WM_THEMECHANGED)` |
+| `DesktopIconCache` | `1 << 6` | HideIcons レジストリ + `WM_COMMAND 0x7402` | Registry read + `SendMessage(Progman, WM_COMMAND)` |
<h3 id="named-composites">名前付きコンポジット</h3>
| 名前 | 構成 | 使用例 |
|---|---|---|
| `Default` | `Settings \| Associations` | 一般的なエクスプローラーレベルの設定 |
-| `DesktopIcons` | `Settings \| Desktop` | 個別のデスクトップアイコンの表示/非表示(PC、ごみ箱) |
-| `HideDesktopIcons` | `Settings \| DesktopIconCache` | グローバルな「すべてのデスクトップアイコンを非表示」トグル |
-| `TaskbarSettings` | `Settings \| Taskbar` | タスクバーの配置、ウィジェット、タスクビュー、タスクの終了 |
-| `ExplorerView` | `Settings \| Associations \| PolicyUpdate` | ファイル拡張子、隠しファイル、コンパクト表示 |
-
-<h3 id="how-refresh-flows">リフレッシュの流れ</h3>
-
-```
-Setting toggle → BaseCustomizeSetting.ApplyAsync(value)
- ├─ Writes RegistryToggles (if any)
- ├─ Checks NeedsPostAction (true if RefreshScope != None)
- └─ Task.Run → ExecutePostActionAsync()
- ├─ Checks each CustomizeRefreshScope flag
- ├─ Calls SystemRefreshService methods (P/Invoke)
- └─ Win32 notifications sent to Windows
-```
-
-`ApplyAsync` をオーバーライドする場合、リフレッシュをトリガーするために**必ず** `await ExecutePostActionAsync()` を自分で呼び出してください。基底クラスは、デフォルトの `RegistryToggles` ベースの適用を使用する場合にのみ自動的にこれを行います。
+| `DesktopIcons` | `Settings \| Desktop` | 個別のデスクトップアイコンの表示/非表示 |
+| `HideDesktopIcons` | `Settings \| DesktopIconCache` | 「すべてのデスクトップアイコンを非表示」トグル |
+| `TaskbarSettings` | `Settings \| Taskbar` | タスクバー設定 |
+| `ExplorerView` | `Settings \| Associations \| PolicyUpdate` | ファイル拡張子、隠しファイル |
---
@@ -551,60 +596,44 @@ Setting toggle → BaseCustomizeSetting.ApplyAsync(value)
新しいページやツール(例:「ネットワークモニター」)を追加する場合:
-1. **まず GitHub Issue を作成する** — 機能、ユースケース、設計を説明する。メンテナーのフィードバックを待つ。
-2. **実装順序**:
+1. **まず GitHub Issue を作成する** — 機能、ユースケース、設計を説明する。
+2. **実装順序**:Service → ViewModel → XAML Page → App.xaml.cs に登録
```csharp
-// 1. Service layer in Services/Managers/YourService.cs
-public class YourService(ILogger<YourService> logger) { ... }
-
-// 2. ViewModel in UI/ViewModels/Pages/YourViewModel.cs
-// Extends ViewModel (which extends ObservableValidator + INavigationAware)
-
-// 3. XAML Page in UI/Pages/YourPage.xaml (+ code-behind)
-
-// 4. Register as singletons in App.xaml.cs
+// DI Registration Pattern (from App.xaml.cs)
services.AddSingleton<YourViewModel>();
services.AddSingleton<YourPage>();
-```
-
-- ViewModel と Page は `App.xaml.cs` で**シングルトンとして登録する必要があります**
-- ナビゲーションは WPF UI(`INavigationService`)が処理します
-- 既存のパターンに従う — `DashboardPage`、`OptimizePage` などを参照してください
-
-<h3 id="di-registration-pattern">DI 登録パターン(App.xaml.cs より)</h3>
-
-```csharp
-// Pages + ViewModels — one pair per feature
-services.AddSingleton<DashboardViewModel>();
-services.AddSingleton<DashboardPage>();
-
-services.AddSingleton<OptimizeViewModel>();
-services.AddSingleton<OptimizePage>();
-
-// Managers
services.AddSingleton<ConfigManager>();
services.AddSingleton<RevertManager>();
-
-// Services
services.AddSingleton<OptimizationRegistry>();
services.AddSingleton<CustomizeRegistry>();
services.AddSingleton<OptimizationService>();
+services.AddSingleton<BloatwareService>();
+services.AddSingleton<DiskCleanupService>();
+services.AddSingleton<StartupManagerService>();
+services.AddSingleton<SystemInfoService>();
+services.AddSingleton<StreamService>();
services.AddSingleton<UpdaterService>();
services.AddSingleton<IRegistryWatcher, RegistryWatcher>();
-
-// Automatic page registration (category pages only)
-services.AddAllCustomizeCategoryPages(); // scans [CustomizeCategory] attributes
-services.AddAllOptimizationPages(); // scans [OptimizationCategory] attributes
```
+<h3 id="system-services">システムサービスリファレンス</h3>
+
+| サービス | 目的 |
+|---|---|
+| `SystemInfoService` | CPU、RAM、GPU 情報を含む `SystemSnapshot` を提供 |
+| `StreamService` | リモートリソースのダウンロード |
+| `UpdaterService` | GitHub リリースの更新確認 |
+| `RegistryWatcher` | レジストリキーの監視と UI 更新 |
+| `BloatwareService` | プリインストール AppX パッケージの一覧表示 |
+| `DiskCleanupService` | ディスククリーンアップのスキャン |
+| `StartupManagerService` | スタートアップアプリとタスクの管理 |
+
---
<h1 id="revert-system">リバートシステム</h1>
-適用されたすべての最適化は、`%localappdata%\optimizerDuck\Revert\{optimizationId}.json` に JSON ファイルを作成します。
-
-<h3 id="how-it-works">仕組み</h3>
+<h3 id="how-it-works-jp">仕組み</h3>
```
ApplyAsync()
@@ -620,382 +649,235 @@ ApplyAsync()
└─ ExecutionScope disposes → RevertManager.SaveRevertDataAsync()
```
-<h3 id="step-types">ステップタイプ</h3>
+<h3 id="step-types-jp">ステップタイプ</h3>
| ステップタイプ | 記録内容 | 自動作成元 |
|---|---|---|
-| **`RegistryRevertStep`** | 変更前の元のレジストリ値 | `RegistryService.Write()`、`RegistryService.DeleteValue()`、`RegistryService.CreateSubKey()`、`RegistryService.DeleteSubKeyTree()` |
+| **`RegistryRevertStep`** | 変更前の元のレジストリ値 | `RegistryService.Write()`、`DeleteValue()`、`CreateSubKey()`、`DeleteSubKeyTree()` |
| **`ServiceRevertStep`** | 元のサービス起動タイプ | `ServiceProcessService.ChangeServiceStartupTypeAsync()` |
-| **`ScheduledTaskRevertStep`** | 元のタスク状態(有効/無効) | `ScheduledTaskService.DisableTask()`、`ScheduledTaskService.EnableTask()` |
-| **`ShellRevertStep`** | 変更を元に戻すシェルコマンド | `ShellService.CMDAsync()`、`ShellService.PowerShellAsync()` |
-| **`UsbPowerRevertStep`** | USB 電源設定 | USB 関連の最適化 |
+| **`ScheduledTaskRevertStep`** | 元のタスク状態(有効/無効) | `ScheduledTaskService.DisableTask()`、`EnableTask()` |
+| **`ShellRevertStep`** | 元に戻すシェルコマンド | `ShellService.CMDAsync()`、`PowerShellAsync()` — `revertCommand` パラメータを渡す |
+| **`UsbPowerRevertStep`** | USB 電源設定(デバイス別) | USB 関連の最適化(手動で `ExecutionScope.RecordStep()`) |
-<h3 id="revert-data-format">リバートデータ形式</h3>
+リバートコマンドをシェル呼び出しに追加する:
-```json
-{
- "SchemaVersion": 1,
- "OptimizationId": "guid",
- "OptimizationName": "DisableTelemetry",
- "AppliedAt": "2026-06-02T12:00:00Z",
- "Steps": [
- { "Index": 0, "Type": "Registry", "Data": { ... } },
- null, // null gap = failed step at this index
- { "Index": 2, "Type": "Service", "Data": { ... } }
- ]
-}
+```csharp
+await ShellService.CMDAsync("powercfg /h off", "powercfg /h on"); // revertCommand
```
-<h3 id="key-details">重要な詳細</h3>
+<h3 id="key-details-jp">重要な詳細</h3>
-- **適用状態**はディスク上のファイルの存在から推論される(`RevertManager.IsAppliedAsync(id)`)
-- **アトミック書き込み**:`.tmp` に書き込んでから `File.Replace()` — クラッシュに安全
-- **`ExecutionScope`** はアンビエントなステップ追跡に `AsyncLocal<ExecutionScope?>` を使用。パラメータ経由でコンテキストを渡す必要はない
-- **リバートは逆順でステップを実行する**(最後に適用されたものが最初にリバートされる)
-- **部分的成功**:一部のステップが失敗してもリバートは続行される。失敗したステップにはリトライアクションが記録される
-- **リトライ**:`OptimizationService.RetryFailedStepsAsync()` で個別の失敗ステップをリトライできる
-
-> **重要**:プロバイダーサービス(`RegistryService.Write`、`ShellService.CMDAsync` など)を呼び出すと、リバートステップは自動的に記録されます。リバートステップを手動で作成しないでください。
+- **適用状態**はディスク上のファイルの存在から推論される
+- **アトミック書き込み**:`.tmp` に書き込んでから `File.Replace()`
+- **同時アクセス**:ファイルごとの `SemaphoreSlim` ロック、30秒タイムアウト
+- **リバートは逆順で実行**(最後に適用 = 最初にリバート)
+- **部分的成功**:一部のステップが失敗しても続行
+- **リトライ**:`OptimizationService.RetryFailedStepsAsync()`
+- **Upsert**:`RevertManager.UpsertRevertStepAtIndexAsync()` で特定インデックスのリバートステップを追加/置換
+- **ステップレジストリ**:`IRevertStep` を実装 + 静的な `FromData(JObject)` メソッドで自動登録
---
<h1 id="testing">テスト</h1>
-テストは **xUnit v3** を使用し、実際の I/O を伴う統合スタイルのアプローチに従います。
-
-<h3 id="test-patterns">テストパターン</h3>
+<h3 id="test-patterns-jp">テストパターン</h3>
| パターン | 詳細 |
|---|---|
-| **モックライブラリなし** | すべてのテストダブルはインターフェースを実装する手書きクラス |
-| **実際の I/O** | 実際のファイルシステム(リバート JSON ファイル)、実際のレジストリ(`HKCU\Software\TestOptimizerDuck*`)、実際のプロセス実行(CMD、PowerShell) |
-| **クリーンアップ** | テスト成果物のクリーンアップに `try/finally` または `IDisposable` を使用 |
-| **命名** | `{Method}_{Scenario}_{ExpectedResult}` — 例:`ApplyAsync_Success_PersistsRevertDataFile` |
-| **ログ記録** | DI ログパラメータに `NullLogger<T>.Instance` / `NullLoggerFactory.Instance` を使用 |
-| **STA スレッド** | `ContentDialogService` や WPF コンポーネントを含むテストは `RunInStaThreadAsync` ヘルパーを使用する必要がある |
-
-<h3 id="test-structure">テスト構成</h3>
-
-```
-optimizerDuck.Test/
-├── Common/Helpers/
-│ └── SystemRefreshServiceTests.cs
-├── Domain/
-│ ├── Customize/
-│ │ └── BaseCustomizeSettingTests.cs
-│ ├── Exceptions/
-│ │ └── StepExecutionExceptionTests.cs
-│ ├── Optimizations/
-│ │ ├── PowerManagementTests.cs
-│ │ └── Models/Services/RegistryItemKindDetectionTests.cs
-│ └── Revert/Steps/
-│ ├── ScheduledTaskRevertStepTests.cs
-│ └── RevertStepSerializationTests.cs
-└── Services/
- ├── ApplyRevertComprehensiveTests.cs
- ├── OptimizationServiceTests.cs
- ├── OptimizationServiceIntegrationTests.cs
- ├── OptimizationExecutionContextTests.cs
- ├── OptimizationServices/
- │ ├── RegistryServiceTests.cs
- │ ├── ShellServiceTests.cs
- │ └── ShellPolicyTests.cs
- ├── Managers/
- │ └── RevertManagerTests.cs
- ├── RegistryWatcherTests.cs
- └── SystemInfoServiceTests.cs
-```
-
-<h3 id="running-tests">テストの実行</h3>
+| **モックライブラリなし** | すべてのテストダブルは手書きクラス |
+| **実際の I/O** | 実際のファイルシステム、レジストリ、プロセス実行 |
+| **クリーンアップ** | `try/finally` または `IDisposable` |
+| **命名** | `{Method}_{Scenario}_{ExpectedResult}` |
+| **ログ記録** | `NullLogger<T>.Instance` |
+| **STA スレッド** | WPF コンポーネントを含むテストは `RunInStaThreadAsync` ヘルパーを使用 |
```bash
-# After building
+# Running tests
dotnet test optimizerDuck.Test/optimizerDuck.Test.csproj --configuration Release --no-build
-
-# Build + test in one step
-dotnet test optimizerDuck.Test/optimizerDuck.Test.csproj --configuration Release
```
-<h3 id="writing-tests-for-provider-services">プロバイダーサービスのテスト作成</h3>
-
-```csharp
-public class MyOptimizationTests
-{
- [Fact]
- public async Task ApplyAsync_Success_PersistsRevertDataFile()
- {
- var optimization = new TestOptimization
- {
- ApplyImpl = _ =>
- {
- ExecutionScope.RecordStep("Test", "Step 1", true, ...);
- return Task.FromResult(ApplyResult.True());
- },
- };
-
- var service = CreateService();
- var result = await service.ApplyAsync(optimization, new Progress<ProcessingProgress>());
+<h3 id="ci-integration-jp">CI 統合</h3>
- Assert.Equal(OptimizationSuccessResult.Success, result.Status);
- }
+CI パイプライン(`ci.yml`)は以下のコマンドを実行します:
- private static OptimizationService CreateService()
- {
- return new OptimizationService(
- new RevertManager(NullLogger<RevertManager>.Instance, NullLoggerFactory.Instance),
- NullLoggerFactory.Instance,
- new SystemInfoService(NullLogger<SystemInfoService>.Instance),
- new StreamService(NullLogger<StreamService>.Instance),
- null!,
- NullLogger<OptimizationService>.Instance
- );
- }
-}
+```bash
+dotnet restore optimizerDuck.slnx
+dotnet build optimizerDuck.slnx --configuration Release --no-restore
+dotnet test optimizerDuck.Test/optimizerDuck.Test.csproj --configuration Release --no-build --blame-hang --blame-hang-timeout 30s
```
---
<h1 id="coding-standards">コーディング規約</h1>
-<h3 id="language-features">言語機能</h3>
+<h3 id="language-features-jp">言語機能</h3>
| 機能 | 使用 | 備考 |
|---|---|---|
| ファイルスコープ名前空間 | はい | `namespace X.Y;` |
-| コレクション式 | はい | 空は `[]`、リストは `[item1, item2]` |
+| コレクション式 | はい | `[]`、`[item1, item2]` |
| プライマリコンストラクタ | 一部 | シンプルな型で使用 |
| 暗黙的 using | はい | `.csproj` で有効 |
-| Null 許容参照型 | はい | `<Nullable>enable</Nullable>` — null を適切に処理する |
-| 拡張メソッド(`extension(T type)`) | はい | C# 13 機能、`OptimizationTagsToDisplay` で使用 |
+| Null 許容参照型 | はい | `<Nullable>enable</Nullable>` |
+| 拡張メソッド(`extension(T type)`) | はい | C# 13 機能 |
-<h3 id="naming-conventions">命名規則</h3>
+<h3 id="naming-conventions-jp">命名規則</h3>
| 要素 | 規則 | 例 |
|---|---|---|
-| クラス、列挙型、インターフェース、メソッド、プロパティ | `PascalCase` | `RegistryService`、`ApplyAsync` |
-| プライベートフィールド | `_camelCase` | `_lastError`、`registryService` |
-| ローカル変数、パラメータ | `camelCase` | `progress`、`serviceName` |
-| 非同期メソッド | `*Async` サフィックス | `ChangeServiceStartupTypeAsync`、`CMDAsync` |
-| public 定数 | `PascalCase` | `MaxRetries` |
-| private 定数 | `_PascalCase` | `_defaultTimeout` |
+| クラス、列挙型、メソッド、プロパティ | `PascalCase` | `RegistryService` |
+| プライベートフィールド | `_camelCase` | `_lastError` |
+| ローカル変数、パラメータ | `camelCase` | `progress` |
+| 非同期メソッド | `*Async` サフィックス | `ChangeServiceStartupTypeAsync` |
+| 定数 | `PascalCase` / `_PascalCase` | `MaxRetries` / `_defaultTimeout` |
-<h3 id="formatting">フォーマット</h3>
+<h3 id="formatting-jp">フォーマット</h3>
| 設定 | 値 |
|---|---|
-| インデント | 4 スペース(タブなし) |
-| 改行コード | LF |
-| エンコーディング | UTF-8 |
+| インデント | 4 スペース |
| 最大行長 | 100 文字 |
-| 末尾の空白 | トリミング |
-| 最終改行 | 必須 |
-| フォーマッター | **CSharpier** — コミット前に `dotnet csharpier .` を実行 |
-| CA1416 | `.editorconfig` で抑制 — すべてのコードは Windows 専用 |
-
-<h3 id="code-style">コードスタイル</h3>
+| フォーマッター | **CSharpier** — `dotnet csharpier .` |
-- **ハードコードされた文字列は禁止** — 常に `Translations.KeyName` または `Loc.Instance["Key"]` を使用する
-- **コメントは最小限に** — 既存のコードにはほとんどコメントがない。不要なコメントは追加しない
-- **型エラーの抑制は禁止** — C# には `as any` / `@ts-ignore` に相当するものはない。型を適切に処理する
-- **新しい依存関係より既存のライブラリを優先する**
-- **大規模なリファクタリングより小さく焦点を絞った変更を優先する**
+<h3 id="code-style-jp">コードスタイル</h3>
-<h3 id="dependency-injection">依存性注入</h3>
+- **ハードコードされた文字列は禁止** — 常に `Translations.KeyName` または `Loc.Instance["Key"]`
+- **コメントは最小限に**
+- **既存のライブラリを優先**
+- **`@formatter:off` / `@formatter:on`** を使用して大きなレジストリ書き込みブロックの自動フォーマットを抑制可能
-- サービス、ViewModel、Page は `App.xaml.cs` でシングルトンとして登録される
-- コンストラクタインジェクションを使用する:`public class Foo(Bar bar, Baz baz)`
-- 静的プロバイダーサービス(`RegistryService`、`ShellService` など)は注入されない — 直接アクセスする
-- テストダブルは手書き(Moq などのモックライブラリは使用しない)
-
-<h3 id="error-handling">エラー処理</h3>
+<h3 id="error-handling-jp">エラー処理</h3>
| レイヤー | プラクティス |
|---|---|
-| **最適化** | 例外をスローする代わりに `ApplyResult.False("reason")` を返す。ステップレベルの失敗追跡は `ExecutionScope` に任せる |
-| **プロバイダーサービス** | システム呼び出しの周りに try/catch を使用し、`ExecutionScope.LogError` 経由でエラーをログに記録する。リトライアクション付きで失敗ステップを記録する |
-| **ViewModel** | コマンドハンドラーで例外をキャッチし、ユーザーフレンドリーなスナックバーを表示する |
-| **禁止事項** | 処理できない例外をキャッチしない。すべての例外を黙って飲み込まない |
+| **最適化** | `ApplyResult.False("reason")` を返す。例外はスローしない |
+| **プロバイダーサービス** | try/catch + `ExecutionScope.LogError` |
+| **ViewModel** | コマンドハンドラーで例外をキャッチ、スナックバー表示 |
+| **グローバル** | App.xaml.cs で 3 つのグローバル例外ハンドラを登録。クラッシュは `%localappdata%\optimizerDuck\Crashes\crash_*.log` に記録 |
---
<h1 id="localization">ローカライズ</h1>
-<h3 id="resx-files">RESX ファイル</h3>
+<h3 id="resx-files-jp">RESX ファイル</h3>
-すべてのユーザー向け文字列は `Resources/Languages/Translations.resx` に格納されています。C# では型安全な `Translations` クラス、または動的ルックアップには `Loc.Instance["Key"]` を使用します。
+すべてのユーザー向け文字列は `Resources/Languages/Translations.resx` に格納されています。
-- `Translations.Designer.cs` は自動生成されるため、**直接編集しない**
-- [ResXManager](https://marketplace.visualstudio.com/items?itemName=TomEnglert.ResXManager)(VS)または Rider の組み込みリソースエディターを使用する
+- `Translations.Designer.cs` は直接編集しない
- `{0}`、`{1}` などのフォーマットパラメータは正確に保持する
-- 文字列は簡潔に — 一部の UI カードには幅の制限がある
-<h3 id="available-locales">利用可能なロケール</h3>
+<h3 id="available-locales-jp">利用可能なロケール(11 言語 + 英語)</h3>
| 言語 | ファイル |
|---|---|
| English | `Translations.resx` (default) |
| Vietnamese | `Translations.vi-VN.resx` |
+| Spanish | `Translations.es-ES.resx` |
| French | `Translations.fr-FR.resx` |
| Traditional Chinese | `Translations.zh-TW.resx` |
| Simplified Chinese | `Translations.zh-CN.resx` |
| Russian | `Translations.ru-RU.resx` |
| Korean | `Translations.ko-KR.resx` |
-| Polish | `Translations.pl-PL.resx` |
| Japanese | `Translations.ja-JP.resx` |
+| Polish | `Translations.pl-PL.resx` |
+| Turkish | `Translations.tr-TR.resx` |
+| Portuguese (Brazil) | `Translations.pt-BR.resx` |
-<h3 id="adding-a-new-language">新しい言語の追加</h3>
-
-1. `Translations.{locale}.resx`(例:`Translations.ja-JP.resx`)を作成し、`Translations.resx` と同じキーをすべて含める
-2. `UI/ViewModels/Pages/SettingsViewModel.cs` で言語を登録する:
-
-```csharp
-new() { DisplayName = "日本語", Culture = new CultureInfo("ja-JP") },
-```
-
-<h3 id="hardcoded-string-rule">ハードコード文字列のルール</h3>
-
-**文字列をハードコードしない**。常に以下を使用する:
+<h3 id="hardcoded-string-rule-jp">文字列ハードコードの禁止</h3>
```csharp
-// Strongly typed (recommended)
string title = Translations.Features_Desktop_Name;
-
-// With format args
-string msg = string.Format(Translations.Dashboard_SystemInfo_Storage_DiskInfo, used, total, percent);
-
-// Dynamic key lookup (for convention-based keys)
string title = Loc.Instance[$"Optimizer.{category}.{key}.Name"];
```
-XAML では:
+XAML:
```xml
-<!-- Without args -->
<ui:TextBlock Text="{ext:Loc Dashboard.Header.Title}" />
-
-<!-- With bound args -->
-<ui:TextBlock Text="{ext:Loc Dashboard.UpdateInfoBar.Message, {Binding ViewModel.LatestVersion}}" />
```
---
<h1 id="pull-request-process">プルリクエストの手順</h1>
-1. **`master` からブランチを作成する** — master で直接作業しない:
-
- ```bash
- git checkout -b feature/your-feature-name
- # or
- git checkout -b fix/issue-number
- ```
-
-2. **Conventional Commits でコミットする**:
-
- | プレフィックス | 使用タイミング |
- |---|---|
- | `feat:` | 新しい最適化や機能 |
- | `fix:` | バグ修正 |
- | `refactor:` | 動作変更のないコード再構成 |
- | `docs:` | ドキュメントの更新 |
- | `test:` | テストの追加や修正 |
- | `i18n:` | 翻訳の更新 |
- | `chore:` | メンテナンス、ビルド設定、依存関係 |
-
-3. **プッシュ前に確認する**:
-
- ```bash
- # 1. Build
- dotnet build optimizerDuck.slnx --configuration Release
-
- # 2. Test
- dotnet test optimizerDuck.Test/optimizerDuck.Test.csproj --configuration Release --no-build
-
- # 3. Format
- dotnet csharpier .
-
- # 4. Check git status — make sure only intended files are staged
- git status
- git diff --cached
- ```
+1. `master` からブランチを作成:`feature/name` または `fix/issue-id`
+2. Conventional Commits:`feat:`、`fix:`、`refactor:`、`docs:`、`test:`、`i18n:`、`chore:`
+3. プッシュ前に確認:
-4. **PR を作成する**:
- - **何が**変更され、**なぜ**変更されたかを説明する
- - UI の変更がある場合は、**スクリーンショットを含める**
- - 関連 Issue をリンクする:`Closes #42`
- - 作業中の場合はドラフトとしてマークする
+```bash
+dotnet build optimizerDuck.slnx --configuration Release
+dotnet test optimizerDuck.Test/optimizerDuck.Test.csproj --configuration Release --no-build
+dotnet csharpier .
+```
-5. **レビュー**:メンテナーがレビューします。フィードバックを受け入れ、迅速に対応してください。
+4. PR を作成:変更内容と理由を説明、UI 変更のスクリーンショットを含める、関連 Issue を `Closes #42` でリンク
-<h3 id="pr-checklist">PR チェックリスト</h3>
+<h3 id="pr-checklist-jp">PR チェックリスト</h3>
-- [ ] コードが既存のパターンに従っている(検出、属性、非同期命名)
-- [ ] 最低限 `Translations.resx` にローカライズキーが追加されている
-- [ ] `dotnet build` が成功する(エラー 0 件)
-- [ ] `dotnet test` が通る(すべてのテストが成功)
-- [ ] `dotnet csharpier .` が実行されている
-- [ ] ハードコードされた文字列がない
-- [ ] リバートステップが適切に記録されている(該当する場合)
-- [ ] UI の変更にスクリーンショットが含まれている
+- [ ] 既存のパターンに従っている
+- [ ] ローカライズキーが `Translations.resx` に追加されている
+- [ ] `dotnet build` 成功
+- [ ] `dotnet test` 成功
+- [ ] `dotnet csharpier .` 実行済み
+- [ ] ハードコード文字列なし
+- [ ] リバートステップが記録されている(該当する場合)
+- [ ] UI 変更のスクリーンショットあり
---
<h1 id="issue-guidelines">Issue ガイドライン</h1>
-- **バグ報告**:バグ報告テンプレートを使用する。再現手順、期待される動作と実際の動作、`%localappdata%\optimizerDuck\optimizerDuck.log` のログ + システム仕様を含める。
-- **機能リクエスト**:ユースケース、解決する問題、動作の仕方を説明する。
-- **最適化の提案**:レジストリパス、サービス名、CLI コマンドを含める。ドキュメントや信頼できる情報源へのリンクを添える。
-- **質問**:GitHub Discussions を使用するか、[Discord サーバー](https://discord.gg/tDUBDCYw9Q) に参加する。
+- **バグ報告**:再現手順、期待/実際の動作、`%localappdata%\optimizerDuck\optimizerDuck.log` のログ + システム仕様
+- **機能リクエスト**:ユースケース、解決する問題、動作
+- **最適化の提案**:レジストリパス、サービス名、CLI コマンド、情報源へのリンク
+- **質問**:GitHub Discussions または [Discord](https://discord.gg/tDUBDCYw9Q)
---
<h1 id="faq--troubleshooting">FAQ とトラブルシューティング</h1>
-<h3 id="build-fails-ca1416">ビルドが「CA1416」エラーで失敗する</h3>
-
-`.editorconfig` が CA1416 を抑制します。まだ表示される場合は、master から最新の `.editorconfig` を取得していることを確認してください。本プロジェクトは Windows 専用です — `SupportedOSPlatform` ガードは追加しないでください。
-
-<h3 id="optimization-not-showing">最適化が UI に表示されない</h3>
+<h3>ビルドが CA1416 エラーで失敗する</h3>
+`.editorconfig` が CA1416 を抑制。最新の `.editorconfig` を確認。
-チェックリスト:
-- カテゴリクラス内の**ネストされた public クラス**になっているか?
-- カテゴリクラスは `IOptimizationCategory` を実装しているか?
-- 最適化クラスは `BaseOptimization` を継承しているか?
-- `[Optimization(Id = "...", ...)]` 属性があるか?
-- ローカライズキーが `Translations.resx` に追加されているか?
+<h3>最適化が UI に表示されない</h3>
+- カテゴリクラス内のネストされた public クラス?
+- カテゴリが `IOptimizationCategory` を実装?
+- `BaseOptimization` を継承?
+- `[Optimization(Id = "...")]` 属性?
+- ローカライズキーが `Translations.resx` に追加されている?
+- `OptimizationRegistry.IsPreloaded` を確認?
-<h3 id="customize-setting-not-showing">カスタマイズ設定が表示されない</h3>
+<h3>カスタマイズ設定が表示されない</h3>
+- `[CustomizeSetting(Section = ..., Icon = ...)]` 属性?
+- `Section` のスペルは正しい?
+- `[CustomizeCategory(PageType = ...)]` 属性?
-上記と同様のチェックを `ICustomizeCategory` / `BaseCustomizeSetting` について行う。
-- `[CustomizeSetting(Section = ..., Icon = ...)]` があるか?
-- `Section` 列挙型の値のスペルは正しいか?
+<h3>UI がフリーズする</h3>
+`async`/`await` を使用していることを確認。`.Result` / `.Wait()` はフリーズの原因。
-<h3 id="no-revert-data-after-testing">テスト後にリバートデータファイルがない</h3>
-
-リバートデータを確認するテストは `%localappdata%\optimizerDuck\Revert\` 内のファイルを期待します。テストのクリーンアップは `finally` ブロックで実行されます — アサーションがクリーンアップの前に実行されることを確認してください。
-
-<h3 id="ui-freezes">最適化の適用時に UI がフリーズする</h3>
-
-非同期のプロバイダー呼び出し(`ChangeServiceStartupTypeAsync`、`CMDAsync`、`PowerShellAsync`)には `ApplyAsync` で `async`/`await` を使用していることを確認してください。`Task.FromResult` を使用したり、`.Result` / `.Wait()` でブロックしたりすると、UI スレッドがフリーズします。
-
-<h3 id="generate-guid">GUID の生成方法</h3>
+<h3>GUID の生成</h3>
```powershell
-# PowerShell
[guid]::NewGuid()
```
-```bash
-# Command line (if uuidgen is available)
-uuidgen
-```
-
-<h3 id="translations-showing-key-names">UI に翻訳ではなくキー名が表示される</h3>
+<h3>翻訳がキー名として表示される</h3>
+`Translations.resx` へのローカライズキーの追加を忘れている。
-`Translations.resx` へのローカライズキーの追加を忘れています。期待されるキーパターンについては [ローカライズ](#localization) セクションを確認してください。
+<h3>「No revert data」エラー</h3>
+最適化の `Id` GUID が変更されていないことを確認。
-<h3 id="no-revert-data-error">リバート時に「No revert data」エラーが出る</h3>
+<h3>新しいリバートステップタイプの追加</h3>
+1. `Domain/Revert/Steps/` に `IRevertStep` を実装する新しいクラスを作成
+2. 静的な `FromData(JObject data)` メソッドを追加(デシリアライズ用)
+3. `RevertManager` のリフレクションベースの `_stepRegistry` が自動検出
+4. `ExecutionScope.RecordStep()` で記録
-最適化の `Id` GUID が変更されていないことを確認してください。リバートファイルは `Id` でキー付けされます。GUID を再生成すると、以前適用した最適化に一致するリバートファイルがなくなります。
+<h3>クラッシュセーフティ</h3>
+- リバートファイル:アトミック書き込み(`.tmp` + `File.Replace`)
+- クラッシュログ:`%localappdata%\optimizerDuck\Crashes\crash_*.log`
+- `WmiHelper.Initialize()` が起動時に異常終了クリーンアップを登録
+- App.xaml.cs に 3 つのグローバル例外ハンドラ
---
@@ -1003,7 +885,7 @@ uuidgen
<h2 id="credits">クレジット</h2>
-マージされた PR の貢献者はリリースノートに記載されます。モジュールに大きく貢献した場合は、ファイルヘッダーの上部に著者タグを追加できます。
+マージされた PR の貢献者はリリースノートに記載されます。
---
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index a438623..b70c311 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -87,7 +87,7 @@ publish.bat single --skip-tests # Skip tests for quick iteration
publish.bat portable --no-pause # Don't pause at the end (CI-friendly)
```
-Publish profiles are defined in `Properties/PublishProfiles/`.
+Publishing uses built-in dotnet publish profiles. The `publish.bat` script handles the workflow: it runs tests first (unless `--skip-tests`), then calls `dotnet publish` with the chosen profile.
### 5. Quick Start Checklist
@@ -95,7 +95,7 @@ Before your first contribution:
- [ ] Fork + clone the repo
- [ ] `dotnet build` succeeds (0 errors)
-- [ ] `dotnet test` passes (all 166+ tests green)
+- [ ] `dotnet test` passes (all tests green)
- [ ] `dotnet csharpier .` formats without errors
- [ ] Read the [Architecture Overview](#architecture-overview) below
@@ -110,59 +110,71 @@ optimizerDuck.slnx # Solution file (.slnx format)
├── optimizerDuck/ # Main WPF app (net10.0-windows)
│ ├── App.xaml.cs # DI registration, startup, theme, logging
│ ├── optimizerDuck.csproj # TFM: net10.0-windows10.0.17763.0, UseWPF=true
+│ ├── app.manifest # requireAdministrator UAC level
│ │
│ ├── Domain/ # Pure models, interfaces, attributes (no WPF deps)
-│ │ ├── Abstractions/ # IOptimization, ICustomizeSetting, IRevertStep, etc.
-│ │ ├── Attributes/ # [Optimization], [CustomizeSetting], [OptimizationCategory]
+│ │ ├── Abstractions/ # IOptimization, ICustomizeSetting, IRevertStep, IWindow, ICustomizeCategory, IOptimizationCategory
+│ │ ├── Attributes/ # [Optimization], [CustomizeSetting], [OptimizationCategory], [CustomizeCategory]
│ │ ├── Configuration/ # AppSettings model
│ │ ├── Execution/ # ExecutionScope — ambient step tracking via AsyncLocal
│ │ ├── Customize/ # Customize settings (Desktop, Gaming, Preferences, System)
│ │ │ ├── Categories/ # Category classes with nested setting classes
-│ │ │ └── Models/ # BaseCustomizeSetting, RegistryToggle, RefreshScope
+│ │ │ └── Models/ # BaseCustomizeSetting, RegistryToggle, RefreshScope, SettingOption, CustomizeControlType, RecommendationState
│ │ ├── Optimizations/ # Optimizations (Performance, Privacy, GPU, etc.)
│ │ │ ├── Categories/ # Category classes with nested optimization classes
-│ │ │ └── Models/ # BaseOptimization, ApplyResult, OptimizationContext
+│ │ │ └── Models/ # BaseOptimization, ApplyResult, OptimizationContext, ServiceItem, RegistryItem
+│ │ │ ├── Bloatware/ # AppXPackage model for preinstalled apps
+│ │ │ ├── Cleanup/ # CleanupItem for disk cleanup
+│ │ │ ├── ScheduledTask/ # ScheduledTaskModel
+│ │ │ ├── Services/ # RegistryItem, ServiceItem, ShellResult, ServiceStartupType
+│ │ │ └── StartupManager/ # StartupApp, StartupTask models
│ │ ├── Revert/ # RevertData, RevertResult, revert step types
-│ │ │ └── Steps/ # RegistryRevertStep, ServiceRevertStep, etc.
-│ │ └── UI/ # Enums: OptimizationRisk, OptimizationTags, CategoryOrder
+│ │ │ └── Steps/ # RegistryRevertStep, ServiceRevertStep, ScheduledTaskRevertStep, ShellRevertStep, UsbPowerRevertStep
+│ │ └── UI/ # Enums: OptimizationRisk, OptimizationTags, OptimizationCategoryOrder, CustomizeOrder, LanguageOption, OptimizationState, RiskVisual, ProcessingProgress
│ │
│ ├── Common/ # Shared helpers, extensions, converters
-│ │ ├── Extensions/ # StringExtensions, CustomizePageRegistryExtensions
-│ │ ├── Converters/ # WPF value converters
-│ │ └── Helpers/ # Shared.cs, ReflectionHelper.cs, SystemRefreshService.cs
+│ │ ├── Converters/ # 20+ WPF value converters (BooleanToVisibility, InverseBoolean, MBToGB, etc.)
+│ │ ├── Extensions/ # StringExtensions, CustomizePageRegistryExtensions, OptimizationPageRegistryExtensions, LanguageExtensions
+│ │ ├── Helpers/ # Shared.cs, ReflectionHelper.cs, SystemRefreshService.cs, EmbeddedResourceHelper.cs, GitHubSourceHelper.cs, WmiHelper.cs, ThemeResource.cs
+│ │ └── Native/ # Native interop helpers (currently available for future use)
│ │
-│ ├── Services/ # Business logic
+│ ├── Services/ # Business logic layer
│ │ ├── Configuration/ # ConfigManager, LanguageManager
-│ │ ├── Customize/ # CustomizeRegistry (discovery via reflection)
-│ │ ├── Managers/ # BloatwareService, DiskCleanupService,
-│ │ │ # StartupManagerService, SystemInfoService,
-│ │ │ # StreamService, UpdaterService
+│ │ ├── Customize/ # CustomizeRegistry (reflection-based discovery of customize settings)
│ │ ├── Optimization/ # OptimizationRegistry, OptimizationService
-│ │ │ └── Providers/ # Static: RegistryService, ShellService,
-│ │ │ # ScheduledTaskService, ServiceProcessService
-│ │ ├── Revert/ # RevertManager (writes/reads revert JSON files)
-│ │ ├── System/ # RegistryWatcher
-│ │ └── UI/ # ContentDialogService, etc.
+│ │ │ └── Providers/ # Static: RegistryService, ShellService, ScheduledTaskService, ServiceProcessService
+│ │ ├── Revert/ # RevertManager (atomic write/read of revert JSON files)
+│ │ ├── System/ # RegistryWatcher, StreamService, SystemInfoService, UpdaterService
+│ │ └── UI/ # BloatwareService, DiskCleanupService, StartupManagerService
│ │
│ ├── UI/ # WPF pages, ViewModels, controls, styles
-│ │ ├── Controls/ # Custom WPF controls
-│ │ ├── Dialogs/ # Dialog windows (ProcessingDialog, OptimizationResultDialog)
-│ │ ├── Pages/ # App pages + sub-folders (Optimize/, Customize/)
-│ │ ├── Styles/ # Fluent design styles
+│ │ ├── Behaviors/ # SmoothScrollBehavior
+│ │ ├── Controls/ # FilledNavigationViewItem (custom nav control)
+│ │ ├── Dialogs/ # ProcessingDialog, OptimizationDetailsDialog, OptimizationResultDialog, RestorePointDialog, LegalDialog, BloatwareConfirmationDialog, ScheduledTaskCreateDialog, ScheduledTaskDetailsDialog, StartupTaskDetailsPanel
+│ │ ├── Pages/ # App pages + sub-folders
+│ │ │ ├── Customize/ # CustomizePage + Categories/ (auto-registered category pages)
+│ │ │ ├── Optimize/ # OptimizePage + Categories/ (auto-registered category pages)
+│ │ │ ├── DashboardPage
+│ │ │ ├── SettingsPage
+│ │ │ ├── BloatwarePage
+│ │ │ ├── DiskCleanupPage
+│ │ │ ├── StartupManagerPage
+│ │ │ └── ScheduledTasksPage
+│ │ ├── Styles/ # FluentDesign.xaml, NavigationViewOverride.xaml, ToolTipOverride.xaml
│ │ ├── ViewModels/ # Page and dialog ViewModels
-│ │ │ ├── Customize/ # CustomizeItemViewModel, CustomizeGroupViewModel
-│ │ │ ├── Dialogs/ # ProcessingViewModel, OptimizationResultDialogViewModel
+│ │ │ ├── Customize/ # CustomizeItemViewModel, CustomizeCategoryViewModel
+│ │ │ ├── Dialogs/ # ProcessingViewModel, OptimizationDetailsViewModel, OptimizationResultDialogViewModel, BloatwareConfirmationDialogViewModel
│ │ │ ├── Optimizer/ # OptimizationCategoryViewModel
-│ │ │ ├── Pages/ # Dashboard, Optimize, Customize, Settings, etc.
+│ │ │ ├── Pages/ # DashboardViewModel, OptimizeViewModel, CustomizeViewModel, SettingsViewModel, BloatwareViewModel, DiskCleanupViewModel, StartupManagerViewModel, ScheduledTasksViewModel
│ │ │ └── Windows/ # MainWindowViewModel
│ │ └── Windows/ # MainWindow
│ │
│ └── Resources/ # Images, embedded assets, localization
-│ ├── Embedded/ # Power plans, icons
-│ ├── Images/ # Duck.png, logos
-│ └── Languages/ # Translations.resx + 7 locale variants
+│ ├── Embedded/ # Power plans (optimizerDuck.pow), Icons (blank.ico)
+│ ├── Images/ # Duck.png, GitHubLogo, DiscordLogo
+│ └── Languages/ # Translations.resx + 11 locale variants
│
-└── optimizerDuck.Test/ # xUnit v3 test project (166+ tests)
+└── optimizerDuck.Test/ # xUnit v3 test project
├── Common/Helpers/
├── Domain/
│ ├── Customize/
@@ -171,7 +183,8 @@ optimizerDuck.slnx # Solution file (.slnx format)
│ └── Revert/Steps/
└── Services/
├── Managers/
- └── OptimizationServices/
+ ├── OptimizationServices/
+ └── ApplyRevertComprehensiveTests.cs
```
### Key Design Decisions
@@ -183,6 +196,8 @@ optimizerDuck.slnx # Solution file (.slnx format)
| **File-based revert tracking** | Applied state = file exists on disk (`%localappdata%\optimizerDuck\Revert\{id}.json`). No database. Atomic writes via `File.Replace()`. |
| **Integration-style tests** | Real filesystem, real registry (under `HKCU\Software\TestOptimizerDuck*`), real process execution. No mocking libraries — hand-written test doubles only. |
| **Async service methods** | Provider methods that run external processes are async (`*Async` suffix). Optimization `ApplyAsync` methods should use `async`/`await` to keep the UI responsive. |
+| **Static WMI helper** | `WmiHelper.Initialize()` runs at startup to register WMI event cleanup handlers for abnormal process termination. |
+| **Pending changes tracking** | `App.HasPendingChanges` property tracks whether applied optimizations haven't been reverted. The app warns on close with options to restart PC/Explorer or exit. |
---
@@ -191,11 +206,12 @@ optimizerDuck.slnx # Solution file (.slnx format)
| Contribution Type | Description | Where to Start |
|---|---|---|
| **New Optimizations** | Registry tweaks, service changes, system tweaks | `Domain/Optimizations/Categories/*.cs` |
-| **New Customize Settings** | UI toggles for Windows settings (Game Mode, Mouse Acceleration, etc.) | `Domain/Customize/Categories/*.cs` |
+| **New Customize Settings** | UI toggles for Windows settings (Game Mode, Mouse Acceleration, Taskbar, etc.) | `Domain/Customize/Categories/*.cs` |
| **New App Features** | New pages, tools, or functionality | Open an issue first |
| **Bug Fixes** | Crash fixes, logic errors, UI issues | Anywhere |
| **Translations** | New languages or fixing existing translations | `Resources/Languages/Translations.*.resx` |
| **Documentation** | README, CONTRIBUTING, etc. | `*.md` files |
+| **Testing** | Adding/reviewing tests for existing or new optimizations | `optimizerDuck.Test/` |
---
@@ -209,6 +225,8 @@ At startup:
2. It finds every class implementing `IOptimizationCategory`
3. For each category, it scans **nested public classes** implementing `IOptimization`
4. All discovered optimizations are instantiated and `OwnerType` is assigned automatically
+5. `OptimizationService.UpdateOptimizationStateAsync` scans revert files on disk to mark each optimization as Applied or not
+6. `OptimizationRegistry.StartPreload()` runs this on a background thread at startup for non-blocking loading
**Your job**: Create a nested class inside a category, extend `BaseOptimization`, decorate with `[Optimization]`. That's it.
@@ -218,12 +236,12 @@ Current categories (in `Domain/Optimizations/Categories/`):
| File | Attribute | Focus |
|---|---|---|
-| `Performance.cs` | `[OptimizationCategory(typeof(PerformanceOptimizerPage))]` | RAM tuning, process priority, keyboard latency, multimedia scheduler |
-| `SecurityAndPrivacy.cs` | `[OptimizationCategory(typeof(SecurityAndPrivacyOptimizerPage))]` | Telemetry, error reporting, advertising ID, location, Cortana, Copilot |
-| `Gpu.cs` | `[OptimizationCategory(typeof(GpuOptimizerPage))]` | AMD/NVIDIA/Intel registry tweaks, power states, clock gating |
-| `PowerManagement.cs` | `[OptimizationCategory(typeof(PowerManagementOptimizerPage))]` | Hibernation, fast startup, USB selective suspend, custom power plans |
-| `BloatwareAndServices.cs` | `[OptimizationCategory(typeof(BloatwareAndServicesOptimizerPage))]` | OEM reinstall blocking, 200+ Windows service startup types |
-| `UserExperience.cs` | `[OptimizationCategory(typeof(UserExperienceOptimizerPage))]` | Menu delays, visual effects, taskbar animations, transparency |
+| `Performance.cs` | `[OptimizationCategory(typeof(PerformanceOptimizerPage))]` | RAM tuning, process priority, keyboard latency, multimedia scheduler, accessibility keyboard hotkeys |
+| `SecurityAndPrivacy.cs` | `[OptimizationCategory(typeof(SecurityAndPrivacyOptimizerPage))]` | Telemetry, error reporting, advertising ID, location, Cortana, Copilot, content delivery manager, activity history, auto-logger |
+| `Gpu.cs` | `[OptimizationCategory(typeof(GpuOptimizerPage))]` | AMD/NVIDIA/Intel registry tweaks, power states, clock gating, ASPM, async flips |
+| `PowerManagement.cs` | `[OptimizationCategory(typeof(PowerManagementOptimizerPage))]` | Hibernation, fast startup, USB selective suspend, custom power plan installation, power saving disable |
+| `BloatwareAndServices.cs` | `[OptimizationCategory(typeof(BloatwareAndServicesOptimizerPage))]` | OEM preinstalled app blocking, 170+ Windows service startup type optimization |
+| `UserExperience.cs` | `[OptimizationCategory(typeof(UserExperienceOptimizerPage))]` | Menu delays, visual effects, taskbar animations, transparency, Start Menu web search |
### Step-by-Step: Add to an Existing Category
@@ -274,6 +292,8 @@ public class Performance : IOptimizationCategory
| **Report progress** | Use `progress.Report(new ProcessingProgress { ... })` to update the UI dialog |
| **Don't catch all exceptions** | Let them bubble up. `ExecutionScope` tracks success/failure. The `OptimizationService` layer handles exceptions. |
| **Don't manually create revert steps** | Static provider services do this automatically via `ExecutionScope.RecordStep()` |
+| **Use `context.Logger`** | The optimization context provides a logger — use it for important diagnostic info |
+| **Check `context.Snapshot`** | `OptimizationContext.Snapshot` (a `SystemSnapshot`) gives you system info: RAM, GPU info, CPU. Use it for conditional logic (e.g., skip if insufficient RAM). |
### Available Service Providers
@@ -281,26 +301,64 @@ These **static** classes handle logging, error handling, and automatic revert st
| Service | Key Methods | Why It's Used |
|---|---|---|
-| **`RegistryService`** | `Write()`, `Read<T>()`, `DeleteValue()`, `CreateSubKey()`, `DeleteSubKeyTree()` | Read/write/delete registry keys. Backs up original values for revert. |
-| **`ShellService`** | `CMDAsync()`**, `PowerShellAsync()`** | Run CMD or PowerShell commands. Always use async variants. |
+| **`RegistryService`** | `Write()`, `Read<T>()`, `DeleteValue()`, `CreateSubKey()`, `DeleteSubKeyTree()`, `KeyExists()` | Read/write/delete registry keys. Backs up original values for revert. Supports writing multiple RegistryItem entries in one call via params array. |
+| **`ShellService`** | `CMDAsync()`, `PowerShellAsync()`, `CMD()` (sync), `PowerShell()` (sync) | Run CMD or PowerShell commands. Prefer async variants. Both sync and async methods accept an optional `revertCommand` parameter. |
| **`ScheduledTaskService`** | `DisableTask()`, `EnableTask()`, `IsTaskEnabled()`, `DeleteTask()` | Manage Windows Scheduled Tasks. |
-| **`ServiceProcessService`** | `ChangeServiceStartupTypeAsync()`**, `GetStartupTypeAsync()`** | Manage Windows Services. Always use async variants. |
+| **`ServiceProcessService`** | `ChangeServiceStartupTypeAsync()`, `GetStartupTypeAsync()` | Manage Windows Services. Always use async variants. Supports changing multiple services at once via params array. |
-> **Methods marked with `**` are async.** Call them with `await` inside your optimization's `ApplyAsync`.
+> **Methods accepting multiple items via params**: Most write/change methods accept a params array of items (e.g., `RegistryService.Write(item1, item2, item3)`). This is more efficient than multiple individual calls.
Example usage:
```csharp
-// Sync registry writes
-RegistryService.Write(new RegistryItem(@"HKLM\...", "Value", 1));
+// Sync registry writes — multiple items at once
+RegistryService.Write(
+ new RegistryItem(@"HKLM\...", "Value1", 1),
+ new RegistryItem(@"HKLM\...", "Value2", 0)
+);
RegistryService.DeleteValue(new RegistryItem(@"HKCU\...", "OldValue"));
-// Async service changes
+// Async service changes — multiple services at once
await ServiceProcessService.ChangeServiceStartupTypeAsync(
- new ServiceItem("DiagTrack", ServiceStartupType.Disabled));
+ new ServiceItem("DiagTrack", ServiceStartupType.Disabled),
+ new ServiceItem("dmwappushservice", ServiceStartupType.Disabled)
+);
+
+// Async shell commands with revert command
+var result = await ShellService.CMDAsync(
+ "powercfg /h off",
+ "powercfg /h on" // revert command stored for undo
+);
+
+// Async PowerShell
+var usbStates = await ShellService.PowerShellAsync(
+ "Get-CimInstance -Namespace root\\wmi -ClassName MSPower_DeviceEnable"
+);
+```
+
+### Handling Asynchronous Operations
+
+Not all optimizations need `async`/`await`. If your optimization only does synchronous registry writes (no async calls), you can return `Task.FromResult()`:
+
+```csharp
+public override Task<ApplyResult> ApplyAsync(
+ IProgress<ProcessingProgress> progress,
+ OptimizationContext context)
+{
+ RegistryService.Write(new RegistryItem(@"HKLM\...", "Value", 1));
+ context.Logger.LogInformation("Applied tweak");
+ return Task.FromResult(CompleteFromScope());
+}
+```
-// Async shell commands
-var result = await ShellService.PowerShellAsync("Some-Command");
+But if you use any async provider (service, shell, task), always `await` them:
+
+```csharp
+public override async Task<ApplyResult> ApplyAsync(...)
+{
+ await ServiceProcessService.ChangeServiceStartupTypeAsync(...);
+ return CompleteFromScope();
+}
```
### Create a New Category
@@ -313,6 +371,30 @@ Only if your optimizations don't fit any existing category. Avoid hyper-specific
4. Add a member to `OptimizationCategoryOrder` enum in `Domain/UI/OptimizationCategoryOrder.cs`
5. The XAML page auto-registers via `services.AddAllOptimizationPages()` in `App.xaml.cs`
+### Create an Optimization Helper Base Class
+
+If you have multiple optimizations that share the same structure (like GPU tweaks that all iterate over detected GPUs), create an abstract intermediate class:
+
+```csharp
+public abstract class GpuRegistryOptimization : BaseOptimization
+{
+ protected abstract GpuVendor Vendor { get; }
+ protected abstract IReadOnlyList<RegistryItem> CreateItems(string registryPath);
+
+ public override Task<ApplyResult> ApplyAsync(...)
+ {
+ foreach (var gpu in context.Snapshot.Gpus.Where(g => g.Vendor == Vendor))
+ {
+ var path = $@"HKLM\...\{index:D4}";
+ RegistryService.Write(CreateItems(path).ToArray());
+ }
+ return Task.FromResult(CompleteFromScope());
+ }
+}
+```
+
+See `Gpu.cs` for a real example with AMD, NVIDIA, and Intel subclasses.
+
### Localization Keys
Every optimization needs entries in `Translations.resx`. The keys follow a strict convention:
@@ -339,10 +421,10 @@ Customize settings are UI controls (toggle switches, dropdowns, number inputs) t
| File | Attribute | Focus |
|---|---|---|
-| `Desktop.cs` | `[CustomizeCategory(PageType = typeof(DesktopFeatureCategory))]` | Desktop icons (This PC, Recycle Bin, Network), shortcut overlays |
-| `Preferences.cs` | `[CustomizeCategory(PageType = typeof(PreferencesFeatureCategory))]` | Taskbar alignment, widgets, dark mode, file extensions, hidden files, etc. |
-| `Gaming.cs` | `[CustomizeCategory(PageType = typeof(GamingFeatureCategory))]` | Game Mode, Game Bar, mouse acceleration, fullscreen optimizations, GPU scheduling |
-| `SystemFeatures.cs` | `[CustomizeCategory(PageType = typeof(SystemFeatureCategory))]` | Num Lock on boot |
+| `Desktop.cs` | `[CustomizeCategory(PageType = typeof(DesktopFeatureCategory))]` | Desktop icons (This PC, Recycle Bin, Network, User Files, Control Panel), global show/hide icons, shortcut arrow visibility |
+| `Preferences.cs` | `[CustomizeCategory(PageType = typeof(PreferencesFeatureCategory))]` | Taskbar alignment, widgets, task view button, end task, dark mode, file extensions, hidden files, clipboard history, search mode, seconds in clock, Bing search, classic context menu |
+| `Gaming.cs` | `[CustomizeCategory(PageType = typeof(GamingFeatureCategory))]` | Game Mode, Game Bar, background recording, mouse acceleration, fullscreen optimizations, GPU scheduling |
+| `SystemFeatures.cs` | `[CustomizeCategory(PageType = typeof(SystemFeatureCategory))]` | Num Lock on boot, Developer Mode, allow all trusted apps, long paths enabled, battery percentage |
### Step-by-Step: Simple Registry Toggle
@@ -396,7 +478,7 @@ public class TaskbarAlignment : BaseCustomizeSetting
| Type | Rendered As | Used For |
|---|---|---|
| `Toggle` | On/off switch | Most settings (default) |
-| `Dropdown` | ComboBox | Multiple choice (e.g., power plan) |
+| `Dropdown` | ComboBox | Multiple choice (e.g., power plan, search box mode, taskbar alignment) |
| `Option` | Radio button group | Mutually exclusive visual options (e.g., left/center alignment) |
| `NumberInt` | Integer text input | Numeric values (e.g., seconds) |
| `NumberFloat` | Decimal text input | Precision values |
@@ -419,7 +501,7 @@ public override IReadOnlyList<SettingOption>? Options =>
[
Option("Never", 0), // Option() helper reads from Translations.resx:
Option("Battery", 1), // Customize.{Category}.{Feature}.Options.Never
- Option("Always", 2), // Customize.{Category}.{Feature}.Options.Battery
+ Option("Always", 2), // Customize.{Category}.{Feature}.Options.Always
];
public override async Task ApplyAsync(object? value)
@@ -430,6 +512,31 @@ public override async Task ApplyAsync(object? value)
}
```
+### Dynamic Options (Platform-Aware)
+
+You can conditionally show options based on the Windows version:
+
+```csharp
+public override IReadOnlyList<SettingOption>? Options
+{
+ get
+ {
+ if (Shared.IsWindows11OrGreater)
+ return [Option("Hidden", 0), Option("Icon", 1), Option("IconAndLabel", 2), Option("SearchBox", 3)];
+ return [Option("Hidden", 0), Option("Icon", 1), Option("SearchBox", 2)];
+ }
+}
+```
+
+### CurrentValue for Dropdowns
+
+For dropdowns and option-based controls, implement `CurrentValue` so the UI shows the current system state:
+
+```csharp
+public override object? CurrentValue =>
+ RegistryService.Read<object>(new RegistryItem(RegPath, RegName));
+```
+
### Custom Logic (Override GetStateAsync / ApplyAsync)
For settings that aren't simple registry toggles (e.g., mouse acceleration combines 3 registry values):
@@ -473,16 +580,72 @@ public class MouseAcceleration : BaseCustomizeSetting
}
```
+### State Detection with Retry
+
+After applying a value, the UI calls `GetStateWithRetryAsync()` (not `GetStateAsync()`). This method:
+1. Reads state up to `maxRetries` (default 3) times with `delayMs` (default 80ms) between attempts
+2. Returns when two consecutive reads agree on the same value (convergence check)
+3. Falls back to the last read value after exhausting retries
+
+This prevents the UI from showing stale values while the registry settles after a write.
+
+### Custom Logic with Non-Registry Dependencies
+
+For settings that involve embedded resource extraction (like replacing shortcut arrows with a blank icon):
+
+```csharp
+public override async Task ApplyAsync(object? value)
+{
+ var isOn = value is bool b && b;
+ if (isOn)
+ {
+ RegistryService.DeleteValue(new RegistryItem(Path, "29"));
+ }
+ else
+ {
+ var outputPath = Path.Combine(Shared.AssetsDirectory, nameof(Desktop), "blank.ico");
+ EmbeddedResourceHelper.TryExtract("Icons.blank.ico", outputPath);
+ RegistryService.Write(new RegistryItem(Path, "29", outputPath));
+ }
+ await ExecutePostActionAsync();
+}
+```
+
+Use `EmbeddedResourceHelper.TryExtract(resourceName, outputPath)` to extract embedded resources from the assembly to disk.
+
+### The Recommendation System
+
+Each customize setting can declare a recommendation:
+
+```csharp
+[CustomizeSetting(
+ ...,
+ Recommendation = RecommendationState.On // or Off, Depends, Experimental, None
+)]
+```
+
+Available states:
+- **`On`**: Recommended to turn ON — improves system
+- **`Off`**: Recommended to turn OFF — improves system
+- **`Depends`**: Depends on user's specific needs/configuration
+- **`Experimental`**: May be unstable, use with caution
+- **`None`** (default): No recommendation displayed
+
+You can also add a recommendation reason via localization key: `Customize.{Category}.{Feature}.Recommendation.Reason`.
+
### What to Override per Pattern
| Scenario | Override |
|---|---|
| Simple registry toggle | `RegistryToggles` + `RefreshScope` |
-| Multiple registry toggles | `RegistryToggles` (list them all) |
-| Dropdown/Options | `ControlType` → `Dropdown`, `Options`, custom `ApplyAsync` |
-| Multi-value logic (e.g., mouse accel) | `GetStateAsync()` + `ApplyAsync()` + `GetWatchedRegistryPaths()` |
+| Multiple registry toggles (e.g., Game Mode: 2 values) | `RegistryToggles` (list them all) |
+| Dropdown/Options | `ControlType` → `Dropdown`, `Options`, custom `ApplyAsync`, `CurrentValue` |
+| Multi-value logic (e.g., mouse accel: 3 registry values) | `GetStateAsync()` + `ApplyAsync()` + `GetWatchedRegistryPaths()` |
| Setting with no registry interaction | `GetStateAsync()` + `ApplyAsync()` (full custom) |
| Custom refresh behavior | `RefreshScope` (if only changing flags) or `ExecutePostActionAsync()` (full override) |
+| State detection with convergence | Use `GetStateWithRetryAsync()` (built-in — don't override) |
+| Dynamic options per Windows version | Override `Options` getter with conditional logic |
+| Embedded resource extraction | `EmbeddedResourceHelper.TryExtract()` in custom `ApplyAsync` |
### Create a New Category
@@ -555,7 +718,7 @@ If you want to add a new page or tool (e.g., a "Network Monitor"):
2. **Implementation order**:
```csharp
-// 1. Service layer in Services/Managers/YourService.cs
+// 1. Service layer in Services/UI or Services/System/YourService.cs
public class YourService(ILogger<YourService> logger) { ... }
// 2. ViewModel in UI/ViewModels/Pages/YourViewModel.cs
@@ -570,7 +733,7 @@ services.AddSingleton<YourPage>();
- ViewModels and Pages **must** be registered as singletons in `App.xaml.cs`
- Navigation is handled by WPF UI (`INavigationService`)
-- Follow the existing patterns — check `DashboardPage`, `OptimizePage`, etc.
+- Follow the existing patterns — check `DashboardPage`, `OptimizePage`, `BloatwarePage`, `DiskCleanupPage`, `ScheduledTasksPage`, `StartupManagerPage`, etc.
### DI Registration Pattern (from App.xaml.cs)
@@ -582,6 +745,29 @@ services.AddSingleton<DashboardPage>();
services.AddSingleton<OptimizeViewModel>();
services.AddSingleton<OptimizePage>();
+services.AddSingleton<SettingsViewModel>();
+services.AddSingleton<SettingsPage>();
+
+services.AddSingleton<BloatwareViewModel>();
+services.AddSingleton<BloatwarePage>();
+
+services.AddSingleton<DiskCleanupViewModel>();
+services.AddSingleton<DiskCleanupPage>();
+
+services.AddSingleton<StartupManagerViewModel>();
+services.AddSingleton<StartupManagerPage>();
+
+services.AddSingleton<ScheduledTasksViewModel>();
+services.AddSingleton<ScheduledTasksPage>();
+
+// Customize
+services.AddSingleton<CustomizeViewModel>();
+services.AddSingleton<CustomizePage>();
+
+// Automatic page registration (category pages using reflection)
+services.AddAllCustomizeCategoryPages(); // scans [CustomizeCategory] attributes
+services.AddAllOptimizationPages(); // scans [OptimizationCategory] attributes
+
// Managers
services.AddSingleton<ConfigManager>();
services.AddSingleton<RevertManager>();
@@ -590,14 +776,29 @@ services.AddSingleton<RevertManager>();
services.AddSingleton<OptimizationRegistry>();
services.AddSingleton<CustomizeRegistry>();
services.AddSingleton<OptimizationService>();
+services.AddSingleton<BloatwareService>();
+services.AddSingleton<DiskCleanupService>();
+services.AddSingleton<StartupManagerService>();
+services.AddSingleton<SystemInfoService>();
+services.AddSingleton<StreamService>();
services.AddSingleton<UpdaterService>();
services.AddSingleton<IRegistryWatcher, RegistryWatcher>();
-
-// Automatic page registration (category pages only)
-services.AddAllCustomizeCategoryPages(); // scans [CustomizeCategory] attributes
-services.AddAllOptimizationPages(); // scans [OptimizationCategory] attributes
```
+### System Services Reference
+
+Additional services available for feature development:
+
+| Service | Purpose |
+|---|---|
+| `SystemInfoService` | Provides `Snapshot` property (`SystemSnapshot`) with CPU, RAM, GPU info via WMI. Used in optimization context. |
+| `StreamService` | Downloads remote resources (e.g., updated power plan files). Used via `OptimizationContext.StreamService`. |
+| `UpdaterService` | Checks GitHub releases for updates. Shows update prompt on Dashboard. |
+| `RegistryWatcher` | Monitors registry keys for external changes and notifies the UI to refresh. Implements `IRegistryWatcher`. |
+| `BloatwareService` | Lists preinstalled AppX packages, categorizes them as Safe/Caution/Dangerous. |
+| `DiskCleanupService` | Scans disks for cleanup opportunities (temp files, caches, logs). |
+| `StartupManagerService` | Lists and manages startup applications and scheduled tasks. |
+
---
# Revert System
@@ -627,8 +828,17 @@ ApplyAsync()
| **`RegistryRevertStep`** | Original registry value before change | `RegistryService.Write()`, `RegistryService.DeleteValue()`, `RegistryService.CreateSubKey()`, `RegistryService.DeleteSubKeyTree()` |
| **`ServiceRevertStep`** | Original service startup type | `ServiceProcessService.ChangeServiceStartupTypeAsync()` |
| **`ScheduledTaskRevertStep`** | Original task state (enabled/disabled) | `ScheduledTaskService.DisableTask()`, `ScheduledTaskService.EnableTask()` |
-| **`ShellRevertStep`** | Shell command to reverse the change | `ShellService.CMDAsync()`, `ShellService.PowerShellAsync()` |
-| **`UsbPowerRevertStep`** | USB power settings | USB-related optimizations |
+| **`ShellRevertStep`** | Shell command to reverse the change | `ShellService.CMDAsync()`, `ShellService.PowerShellAsync()` — pass a `revertCommand` parameter |
+| **`UsbPowerRevertStep`** | USB power settings (per-device) | USB-related optimizations (manual via `ExecutionScope.RecordStep()`) |
+
+### Adding a Revert Command to Shell Calls
+
+When calling `CMDAsync` or `PowerShellAsync`, you can optionally pass a `revertCommand` parameter that gets saved for undo:
+
+```csharp
+// The revert command "powercfg /h on" will be stored to reverse this change
+await ShellService.CMDAsync("powercfg /h off", "powercfg /h on");
+```
### Revert Data Format
@@ -650,12 +860,16 @@ ApplyAsync()
- **Applied state** is inferred from file presence on disk (`RevertManager.IsAppliedAsync(id)`)
- **Atomic writes**: writes to `.tmp` then `File.Replace()` — crash-safe
+- **Concurrent access**: per-file `SemaphoreSlim` locks prevent race conditions; 30-second timeout
+- **File locking**: `_fileLocks` dictionary (`ConcurrentDictionary<Guid, SemaphoreSlim>`) protects each revert file
- **`ExecutionScope`** uses `AsyncLocal<ExecutionScope?>` for ambient step tracking. No need to pass context through parameters
- **Revert executes steps in reverse order** (last applied = first reverted)
- **Partial success**: revert continues even if some steps fail. Failed steps get retry actions recorded
- **Retry**: `OptimizationService.RetryFailedStepsAsync()` can retry individual failed steps
+- **Upsert**: `RevertManager.UpsertRevertStepAtIndexAsync()` can add/replace revert steps at specific indices (used during retry)
+- **Step registry**: Revert step deserialization uses reflection-based `_stepRegistry` — new step types auto-register by implementing `IRevertStep` with a static `FromData(JObject)` method
-> **Important**: When you call provider services (`RegistryService.Write`, `ShellService.CMDAsync`, etc.), revert steps are recorded automatically. Do NOT manually create revert steps.
+> **Important**: When you call provider services (`RegistryService.Write`, `ShellService.CMDAsync`, etc.), revert steps are recorded automatically. Do NOT manually create revert steps unless you're implementing a custom provider (like `UsbPowerRevertStep`).
---
@@ -686,11 +900,12 @@ optimizerDuck.Test/
│ ├── Exceptions/
│ │ └── StepExecutionExceptionTests.cs
│ ├── Optimizations/
-│ │ ├── PowerManagementTests.cs
-│ │ └── Models/Services/RegistryItemKindDetectionTests.cs
+│ │ ├── Models/
+│ │ │ └── Services/RegistryItemKindDetectionTests.cs
+│ │ └── PowerManagementTests.cs
│ └── Revert/Steps/
-│ ├── ScheduledTaskRevertStepTests.cs
-│ └── RevertStepSerializationTests.cs
+│ ├── RevertStepSerializationTests.cs
+│ └── ScheduledTaskRevertStepTests.cs
└── Services/
├── ApplyRevertComprehensiveTests.cs
├── OptimizationServiceTests.cs
@@ -698,6 +913,7 @@ optimizerDuck.Test/
├── OptimizationExecutionContextTests.cs
├── OptimizationServices/
│ ├── RegistryServiceTests.cs
+ │ ├── ServiceProcessServiceTests.cs
│ ├── ShellServiceTests.cs
│ └── ShellPolicyTests.cs
├── Managers/
@@ -716,6 +932,18 @@ dotnet test optimizerDuck.Test/optimizerDuck.Test.csproj --configuration Release
dotnet test optimizerDuck.Test/optimizerDuck.Test.csproj --configuration Release
```
+### CI Integration
+
+The CI pipeline (`ci.yml`) runs:
+
+```bash
+dotnet restore optimizerDuck.slnx
+dotnet build optimizerDuck.slnx --configuration Release --no-restore
+dotnet test optimizerDuck.Test/optimizerDuck.Test.csproj --configuration Release --no-build --blame-hang --blame-hang-timeout 30s
+```
+
+The `--blame-hang --blame-hang-timeout 30s` flags ensure tests don't hang longer than 30 seconds, which is critical for integration-style tests that interact with real Windows services.
+
### Writing Tests for Provider Services
```csharp
@@ -753,6 +981,10 @@ public class MyOptimizationTests
}
```
+### Registering New Tests
+
+When adding tests for a new optimization or service, follow the existing directory structure. Tests for `OptimizationServices/` go in `Services/OptimizationServices/`, and tests for domain models go in the matching `Domain/` subdirectory.
+
---
# Coding Standards
@@ -796,15 +1028,17 @@ public class MyOptimizationTests
- **No hardcoded strings** — always use `Translations.KeyName` or `Loc.Instance["Key"]`
- **Keep comments sparse** — existing code has almost none. Don't add unnecessary comments.
-- **No type error suppression** — no equivalent of `as any` / `@ts-ignore` in C#. Handle types properly.
+- **No type error suppression** — handle types properly.
- **Prefer existing libraries** over new dependencies.
- **Prefer small, focused changes** over large refactors.
+- **Use `@formatter:off` / `@formatter:on`** comments around large, structured registry write blocks when needed to suppress automatic reformatting.
+- **Never commit machine-specific paths or secrets.**
### Dependency Injection
- Services, ViewModels, and Pages are registered as singletons in `App.xaml.cs`
-- Use constructor injection: `public class Foo(Bar bar, Baz baz)`
-- Static provider services (`RegistryService`, `ShellService`, etc.) are NOT injected — access them directly
+- Use constructor injection: `public class Foo(Bar bar, Baz baz)` or `public class Foo(ILogger<Foo> logger)`
+- Static provider services (`RegistryService`, `ShellService`, `ScheduledTaskService`, `ServiceProcessService`) are NOT injected — access them directly
- Test doubles are hand-written (no mocking libraries like Moq)
### Error Handling
@@ -816,6 +1050,16 @@ public class MyOptimizationTests
| **ViewModels** | Catch exceptions in command handlers, show user-friendly snackbars. |
| **Don't** | Catch exceptions you can't handle. Don't silently swallow all exceptions. |
+### Global Error Handling
+
+The `App.xaml.cs` registers three global exception handlers:
+
+- `AppDomain.CurrentDomain.UnhandledException` — catches fatal exceptions
+- `TaskScheduler.UnobservedTaskException` — catches unobserved task exceptions
+- `DispatcherUnhandledException` — catches unhandled UI thread exceptions
+
+All crash details are logged to `%localappdata%\optimizerDuck\Crashes\crash_*.log`.
+
---
# Localization
@@ -835,6 +1079,7 @@ All user-facing strings live in `Resources/Languages/Translations.resx`. Use the
|---|---|
| English | `Translations.resx` (default) |
| Vietnamese | `Translations.vi-VN.resx` |
+| Spanish | `Translations.es-ES.resx` |
| French | `Translations.fr-FR.resx` |
| Traditional Chinese | `Translations.zh-TW.resx` |
| Simplified Chinese | `Translations.zh-CN.resx` |
@@ -842,14 +1087,18 @@ All user-facing strings live in `Resources/Languages/Translations.resx`. Use the
| Korean | `Translations.ko-KR.resx` |
| Japanese | `Translations.ja-JP.resx` |
| Polish | `Translations.pl-PL.resx` |
+| Turkish | `Translations.tr-TR.resx` |
+| Portuguese (Brazil) | `Translations.pt-BR.resx` |
+
+> **Note**: 11 locale variants total, plus English as the default fallback.
### Adding a New Language
-1. Create `Translations.{locale}.resx` (e.g., `Translations.ja-JP.resx`) with all the same keys as `Translations.resx`
+1. Create `Translations.{locale}.resx` (e.g., `Translations.de-DE.resx`) with all the same keys as `Translations.resx`
2. Register the language in `UI/ViewModels/Pages/SettingsViewModel.cs`:
```csharp
-new() { DisplayName = "日本語", Culture = new CultureInfo("ja-JP") },
+new() { DisplayName = "Deutsch", Culture = new CultureInfo("de-DE") },
```
### Hardcoded String Rule
@@ -962,12 +1211,14 @@ Checklist:
- Does the optimization class extend `BaseOptimization`?
- Does it have `[Optimization(Id = "...", ...)]` attribute?
- Are the localization keys added to `Translations.resx`?
+- Has the optimization category been preloaded? (Check `OptimizationRegistry.IsPreloaded`)
### My customize setting isn't showing up
Same checks as above but for `ICustomizeCategory` / `BaseCustomizeSetting`.
- Does it have `[CustomizeSetting(Section = ..., Icon = ...)]`?
- Is the `Section` enum value correctly spelled?
+- Does the category class use the correct `[CustomizeCategory(PageType = ...)]` attribute?
### No revert data file after testing
@@ -997,6 +1248,20 @@ You missed adding localization keys to `Translations.resx`. Check the [Localizat
Check that the optimization's `Id` GUID hasn't changed. Revert files are keyed by `Id`. If you regenerate the GUID, previously applied optimizations won't have matching revert files.
+### How do I add a new revert step type?
+
+1. Create a new class in `Domain/Revert/Steps/` that implements `IRevertStep`
+2. Add a static `FromData(JObject data)` method for deserialization
+3. The `RevertManager`'s reflection-based `_stepRegistry` will auto-discover it
+4. Record it via `ExecutionScope.RecordStep()` with your step as the `revertStep` parameter
+
+### How does the app handle crash safety?
+
+- Revert files use atomic writes (`.tmp` + `File.Replace`)
+- Crash logging writes to `%localappdata%\optimizerDuck\Crashes\crash_*.log`
+- `WmiHelper.Initialize()` at startup registers WMI cleanup for abnormal termination
+- App.xaml.cs registers 3 global exception handlers
+
---
<div align="center">
diff --git a/CONTRIBUTING.tr-TR.md b/CONTRIBUTING.tr-TR.md
index bce3689..384c8f4 100644
--- a/CONTRIBUTING.tr-TR.md
+++ b/CONTRIBUTING.tr-TR.md
@@ -15,11 +15,12 @@
.NET 10 üzerinde WPF ile oluşturulmuş ücretsiz, açık kaynaklı bir Windows optimizasyon aracı olan **optimizerDuck**'a katkıda bulunduğunuz için teşekkür ederiz.
Birçok şekilde yardımcı olabilirsiniz:
-- Açık yeniden üretme adımlarıyla hataları (bug) bildirmek
-- Yeni optimizasyonlar veya özellikler önermek (önce bir sorun (issue) açın)
+- Açık yeniden üretme adımlarıyla hataları bildirmek
+- Yeni optimizasyonlar veya özellikler önermek (önce bir sorun açın)
- Dokümantasyonu ve kılavuzları geliştirmek
- Çeviriler eklemek veya düzeltmek
- Kod katkısında bulunmak: optimizasyonlar, özelleştirme ayarları, hizmetler, kullanıcı arayüzü iyileştirmeleri
+- Test eklemek veya mevcut testleri gözden geçirmek
---
@@ -57,7 +58,7 @@ git checkout -b feature/sizin-ozellik-adiniz
### 3. Geri Yükleme, Derleme ve Test
-Çözüm (solution), `.slnx` formatını kullanır (XML tabanlı çözüm dosyası, `.sln` değil).
+Çözüm, `.slnx` formatını kullanır (XML tabanlı çözüm dosyası, `.sln` değil).
```bash
# Bağımlılıkları geri yükle
@@ -87,15 +88,13 @@ publish.bat single --skip-tests # Hızlı yineleme için testleri atlar
publish.bat portable --no-pause # Sonunda duraklamaz (CI dostu)
```
-Yayımlama profilleri `Properties/PublishProfiles/` içinde tanımlanmıştır.
-
### 5. Hızlı Başlangıç Kontrol Listesi
İlk katkınızdan önce:
- [ ] Depoyu forkladınız ve klonladınız
- [ ] `dotnet build` başarılı oldu (0 hata)
-- [ ] `dotnet test` geçer (166+ testin tamamı yeşil)
+- [ ] `dotnet test` geçer (tüm testler yeşil)
- [ ] `dotnet csharpier .` hatasız şekilde kodunuzu biçimlendiriyor
- [ ] Aşağıdaki [Mimariye Genel Bakış](#mimariye-genel-bakış) bölümünü okudunuz
@@ -110,70 +109,65 @@ optimizerDuck.slnx # Çözüm dosyası (.slnx formatı)
├── optimizerDuck/ # Ana WPF uygulaması (net10.0-windows)
│ ├── App.xaml.cs # DI kaydı, başlangıç, tema, loglama
│ ├── optimizerDuck.csproj # TFM: net10.0-windows10.0.17763.0, UseWPF=true
+│ ├── app.manifest # requireAdministrator UAC seviyesi
│ │
│ ├── Domain/ # Saf modeller, arayüzler, özellikler (WPF bağımlılığı yok)
-│ │ ├── Abstractions/ # IOptimization, ICustomizeSetting, IRevertStep, vs.
-│ │ ├── Attributes/ # [Optimization], [CustomizeSetting], [OptimizationCategory]
+│ │ ├── Abstractions/ # IOptimization, ICustomizeSetting, IRevertStep, IWindow, ICustomizeCategory, IOptimizationCategory
+│ │ ├── Attributes/ # [Optimization], [CustomizeSetting], [OptimizationCategory], [CustomizeCategory]
│ │ ├── Configuration/ # AppSettings modeli
-│ │ ├── Execution/ # ExecutionScope — AsyncLocal üzerinden çevresel (ambient) adım takibi
+│ │ ├── Execution/ # ExecutionScope — AsyncLocal ile çevresel adım takibi
│ │ ├── Customize/ # Özelleştirme ayarları (Desktop, Gaming, Preferences, System)
│ │ │ ├── Categories/ # İçi içe ayar sınıflarına sahip kategori sınıfları
-│ │ │ └── Models/ # BaseCustomizeSetting, RegistryToggle, RefreshScope
-│ │ ├── Optimizations/ # Optimizasyonlar (Performance, Privacy, GPU, vs.)
+│ │ │ └── Models/ # BaseCustomizeSetting, RegistryToggle, RefreshScope, SettingOption, RecommendationState
+│ │ ├── Optimizations/ # Optimizasyonlar (Performance, Privacy, GPU, vb.)
│ │ │ ├── Categories/ # İçi içe optimizasyon sınıflarına sahip kategori sınıfları
-│ │ │ └── Models/ # BaseOptimization, ApplyResult, OptimizationContext
+│ │ │ └── Models/ # BaseOptimization, ApplyResult, OptimizationContext, ServiceItem, RegistryItem
│ │ ├── Revert/ # RevertData, RevertResult, geri alma adımı türleri
-│ │ │ └── Steps/ # RegistryRevertStep, ServiceRevertStep, vs.
-│ │ └── UI/ # Enumlar: OptimizationRisk, OptimizationTags, CategoryOrder
+│ │ │ └── Steps/ # RegistryRevertStep, ServiceRevertStep, ScheduledTaskRevertStep, ShellRevertStep, UsbPowerRevertStep
+│ │ └── UI/ # Enumlar: OptimizationRisk, OptimizationTags, OptimizationCategoryOrder, CustomizeOrder, LanguageOption, OptimizationState
│ │
-│ ├── Common/ # Ortak yardımcılar, eklentiler (extensions), dönüştürücüler
-│ │ ├── Extensions/ # StringExtensions, CustomizePageRegistryExtensions
-│ │ ├── Converters/ # WPF veri dönüştürücüleri
-│ │ └── Helpers/ # Shared.cs, ReflectionHelper.cs, SystemRefreshService.cs
+│ ├── Common/ # Ortak yardımcılar, eklentiler, dönüştürücüler
+│ │ ├── Converters/ # 20+ WPF değer dönüştürücüsü
+│ │ ├── Extensions/ # StringExtensions, CustomizePageRegistryExtensions, OptimizationPageRegistryExtensions
+│ │ ├── Helpers/ # Shared.cs, ReflectionHelper.cs, SystemRefreshService.cs, EmbeddedResourceHelper.cs, WmiHelper.cs
+│ │ └── Native/ # Yerel işletim sistemi yardımcıları
│ │
-│ ├── Services/ # İş mantığı (Business logic)
+│ ├── Services/ # İş mantığı katmanı
│ │ ├── Configuration/ # ConfigManager, LanguageManager
-│ │ ├── Customize/ # CustomizeRegistry (Yansıma ile otomatik keşif)
-│ │ ├── Managers/ # BloatwareService, DiskCleanupService,
-│ │ │ # StartupManagerService, SystemInfoService,
-│ │ │ # StreamService, UpdaterService
+│ │ ├── Customize/ # CustomizeRegistry (yansıma tabanlı keşif)
│ │ ├── Optimization/ # OptimizationRegistry, OptimizationService
-│ │ │ └── Providers/ # Statik: RegistryService, ShellService,
-│ │ │ # ScheduledTaskService, ServiceProcessService
-│ │ ├── Revert/ # RevertManager (geri alma JSON dosyalarını okur/yazar)
-│ │ ├── System/ # RegistryWatcher
-│ │ └── UI/ # ContentDialogService, vs.
+│ │ │ └── Providers/ # Statik: RegistryService, ShellService, ScheduledTaskService, ServiceProcessService
+│ │ ├── Revert/ # RevertManager (atomik JSON okuma/yazma)
+│ │ ├── System/ # RegistryWatcher, StreamService, SystemInfoService, UpdaterService
+│ │ └── UI/ # BloatwareService, DiskCleanupService, StartupManagerService
│ │
-│ ├── UI/ # WPF sayfaları, ViewModels, kontroller, stiller
-│ │ ├── Controls/ # Özel WPF kontrolleri
-│ │ ├── Dialogs/ # Diyalog pencereleri (ProcessingDialog, OptimizationResultDialog)
-│ │ ├── Pages/ # Uygulama sayfaları + alt klasörler (Optimize/, Customize/)
-│ │ ├── Styles/ # Fluent tasarım stilleri
+│ ├── UI/ # WPF sayfaları, ViewModel'ler, kontroller, stiller
+│ │ ├── Behaviors/ # SmoothScrollBehavior
+│ │ ├── Controls/ # FilledNavigationViewItem
+│ │ ├── Dialogs/ # ProcessingDialog, OptimizationDetailsDialog, RestorePointDialog, LegalDialog, BloatwareConfirmationDialog, ScheduledTaskCreateDialog
+│ │ ├── Pages/ # Dashboard, Optimize, Customize, Settings, Bloatware, DiskCleanup, StartupManager, ScheduledTasks
+│ │ ├── Styles/ # FluentDesign.xaml, NavigationViewOverride.xaml
│ │ ├── ViewModels/ # Sayfa ve diyalog ViewModel'leri
-│ │ │ ├── Customize/ # CustomizeItemViewModel, CustomizeGroupViewModel
-│ │ │ ├── Dialogs/ # ProcessingViewModel, OptimizationResultDialogViewModel
-│ │ │ ├── Optimizer/ # OptimizationCategoryViewModel
-│ │ │ ├── Pages/ # Dashboard, Optimize, Customize, Settings, vs.
-│ │ │ └── Windows/ # MainWindowViewModel
│ │ └── Windows/ # MainWindow
│ │
│ └── Resources/ # Resimler, gömülü dosyalar, yerelleştirme
│ ├── Embedded/ # Güç planları, simgeler
│ ├── Images/ # Duck.png, logolar
-│ └── Languages/ # Translations.resx + dil varyantları
+│ └── Languages/ # Translations.resx + 11 dil varyantı
│
-└── optimizerDuck.Test/ # xUnit v3 test projesi (166+ test)
+└── optimizerDuck.Test/ # xUnit v3 test projesi
```
### Önemli Tasarım Kararları
| Karar | Gerekçesi |
|---|---|
-| **Yansıma tabanlı keşif (Reflection)** | Güncellenecek DI kayıt dizileri yoktur. `ReflectionHelper.FindImplementationsInLoadedAssemblies<T>()` başlangıçta `optimizerDuck.*` derlemelerini tarar. Yeni optimizasyonlar/ayarlar otomatik olarak keşfedilir. |
-| **Statik sağlayıcı hizmetler** | `RegistryService`, `ShellService`, `ScheduledTaskService`, `ServiceProcessService` statik sınıflardır. Geri alma adımlarını çevresel (ambient) `ExecutionScope`'a yakalarlar — enjekte etmeye veya bağlam aktarmaya gerek yoktur. |
-| **Dosya tabanlı geri alma takibi** | Uygulanan durum = diskte dosyanın var olmasıdır (`%localappdata%\optimizerDuck\Revert\{id}.json`). Veritabanı yoktur. Atomik yazmalar `File.Replace()` üzerinden yapılır. |
-| **Entegrasyon tarzı testler** | Gerçek dosya sistemi, gerçek kayıt defteri (Registry'de `HKCU\Software\TestOptimizerDuck*` altında), gerçek işlem yürütme. Mocking (taklit) kütüphanesi yok — sadece elle yazılmış test double'ları. |
-| **Zaman uyumsuz (Async) servis metotları** | Harici işlemleri yürüten sağlayıcı yöntemleri asenkrondur (`*Async` son eki). Optimizasyon `ApplyAsync` yöntemleri, kullanıcı arayüzünü duyarlı tutmak için `async`/`await` kullanmalıdır. |
+| **Yansıma tabanlı keşif** | Güncellenecek DI kayıt dizileri yok. `ReflectionHelper.FindImplementationsInLoadedAssemblies<T>()` başlangıçta `optimizerDuck.*` derlemelerini tarar. Yeni optimizasyonlar/ayarlar otomatik keşfedilir. |
+| **Statik sağlayıcı hizmetler** | `RegistryService`, `ShellService`, `ScheduledTaskService`, `ServiceProcessService` statik sınıflardır. Geri alma adımlarını `ExecutionScope`'a otomatik kaydederler. |
+| **Dosya tabanlı geri alma takibi** | Uygulanan durum = diskte dosyanın var olması (`%localappdata%\optimizerDuck\Revert\{id}.json`). Veritabanı yok. Atomik yazmalar `File.Replace()` ile yapılır. |
+| **Entegrasyon tarzı testler** | Gerçek dosya sistemi, gerçek kayıt defteri, gerçek işlem yürütme. Mock kütüphanesi yok — elle yazılmış test double'ları. |
+| **Zaman uyumsuz servis metotları** | Harici işlemleri yürüten yöntemler asenkrondur (`*Async` son eki). |
+| **Statik WMI yardımcısı** | `WmiHelper.Initialize()` başlangıçta çalışır, anormal sonlanma için WMI temizleme işleyicilerini kaydeder. |
---
@@ -183,10 +177,11 @@ optimizerDuck.slnx # Çözüm dosyası (.slnx formatı)
|---|---|---|
| **Yeni Optimizasyonlar** | Kayıt defteri ayarları, servis değişiklikleri, sistem ayarları | `Domain/Optimizations/Categories/*.cs` |
| **Yeni Özelleştirme Ayarları** | Windows ayarları için kullanıcı arayüzü anahtarları | `Domain/Customize/Categories/*.cs` |
-| **Yeni Uygulama Özellikleri** | Yeni sayfalar, araçlar veya işlevsellikler | Önce bir Issue (sorun) açın |
-| **Hata Düzeltmeleri (Bug Fixes)** | Çökme düzeltmeleri, mantık hataları, UI sorunları | Herhangi bir yer |
+| **Yeni Uygulama Özellikleri** | Yeni sayfalar, araçlar veya işlevsellikler | Önce bir sorun (Issue) açın |
+| **Hata Düzeltmeleri** | Çökme düzeltmeleri, mantık hataları, UI sorunları | Herhangi bir yer |
| **Çeviriler** | Yeni diller veya mevcut çevirileri düzeltme | `Resources/Languages/Translations.*.resx` |
| **Dokümantasyon** | README, CONTRIBUTING vb. | `*.md` dosyaları |
+| **Test** | Yeni/mevcut testleri ekleme veya gözden geçirme | `optimizerDuck.Test/` |
---
@@ -199,22 +194,24 @@ Başlangıçta:
1. `ReflectionHelper.FindImplementationsInLoadedAssemblies<IOptimizationCategory>()` tüm `optimizerDuck.*` derlemelerini tarar.
2. `IOptimizationCategory` uygulayan her sınıfı bulur.
3. Her kategori için, `IOptimization` uygulayan **iç içe geçmiş public sınıfları** tarar.
-4. Keşfedilen tüm optimizasyonların örneği oluşturulur ve `OwnerType` otomatik olarak atanır.
+4. Keşfedilen tüm optimizasyonlar örneklenir ve `OwnerType` otomatik olarak atanır.
+5. `OptimizationService.UpdateOptimizationStateAsync` diskteki geri alma dosyalarını tarar.
+6. `OptimizationRegistry.StartPreload()` bunu başlangıçta arka planda çalıştırır.
-**Sizin göreviniz**: Bir kategorinin içine yerleştirilmiş (nested) bir sınıf oluşturun, `BaseOptimization`'dan türetin ve `[Optimization]` ile işaretleyin. Hepsi bu kadar.
+**Sizin göreviniz**: Bir kategorinin içine yerleştirilmiş bir sınıf oluşturun, `BaseOptimization`'dan türetin ve `[Optimization]` ile işaretleyin. Hepsi bu kadar.
### Optimizasyon Kategorileri
Mevcut kategoriler (`Domain/Optimizations/Categories/` içinde):
-| Dosya | Öznitelik (Attribute) | Odak Noktası |
+| Dosya | Öznitelik | Odak Noktası |
|---|---|---|
-| `Performance.cs` | `[OptimizationCategory(typeof(PerformanceOptimizerPage))]` | RAM ayarı, süreç önceliği, klavye gecikmesi, multimedya zamanlayıcısı |
-| `SecurityAndPrivacy.cs` | `[OptimizationCategory(typeof(SecurityAndPrivacyOptimizerPage))]` | Telemetri, hata bildirimleri, reklam kimliği, konum, Cortana, Copilot |
-| `Gpu.cs` | `[OptimizationCategory(typeof(GpuOptimizerPage))]` | AMD/NVIDIA/Intel kayıt defteri ince ayarları, güç durumları, clock gating |
-| `PowerManagement.cs` | `[OptimizationCategory(typeof(PowerManagementOptimizerPage))]` | Hazırda bekletme, hızlı başlatma, USB seçmeli askıya alma, güç planları |
-| `BloatwareAndServices.cs` | `[OptimizationCategory(typeof(BloatwareAndServicesOptimizerPage))]` | OEM uygulama engellemesi, 200+ Windows servisi |
-| `UserExperience.cs` | `[OptimizationCategory(typeof(UserExperienceOptimizerPage))]` | Menü gecikmeleri, görsel efektler, görev çubuğu animasyonları, saydamlık |
+| `Performance.cs` | `[OptimizationCategory(typeof(PerformanceOptimizerPage))]` | RAM ayarı, süreç önceliği, klavye gecikmesi, multimedya zamanlayıcısı, erişilebilirlik kısayol tuşları |
+| `SecurityAndPrivacy.cs` | `[OptimizationCategory(typeof(SecurityAndPrivacyOptimizerPage))]` | Telemetri, hata bildirimleri, reklam kimliği, konum, Cortana, Copilot, içerik dağıtım yöneticisi, etkinlik geçmişi |
+| `Gpu.cs` | `[OptimizationCategory(typeof(GpuOptimizerPage))]` | AMD/NVIDIA/Intel kayıt defteri ayarları, güç durumları, clock gating, ASPM, async flips |
+| `PowerManagement.cs` | `[OptimizationCategory(typeof(PowerManagementOptimizerPage))]` | Hazırda bekletme, hızlı başlatma, USB seçmeli askıya alma, özel güç planı kurulumu |
+| `BloatwareAndServices.cs` | `[OptimizationCategory(typeof(BloatwareAndServicesOptimizerPage))]` | OEM uygulama engellemesi, 170+ Windows servis başlatma türü optimizasyonu |
+| `UserExperience.cs` | `[OptimizationCategory(typeof(UserExperienceOptimizerPage))]` | Menü gecikmeleri, görsel efektler, görev çubuğu animasyonları, şeffaflık, Başlat Menüsü web araması |
### Adım Adım: Mevcut Bir Kategoriye Ekleme
@@ -243,7 +240,7 @@ public class Performance : IOptimizationCategory
RegistryService.Write(new RegistryItem(
@"HKLM\SOFTWARE\Something", "ValueName", 1));
- // 2. Async işlemleri await ile bekleyin — bu UI iş parçacığını rahatlatır
+ // 2. Async işlemleri await ile bekleyin
await ServiceProcessService.ChangeServiceStartupTypeAsync(
new ServiceItem("SomeService", ServiceStartupType.Disabled));
@@ -258,54 +255,62 @@ public class Performance : IOptimizationCategory
| Kural | Detay |
|---|---|
-| **`Id` yeni bir GUID olmalıdır** | Geri alma dosyasının adlandırılmasında kullanılır. PowerShell'de `[guid]::NewGuid()` ile oluşturabilirsiniz. |
-| **`BaseOptimization`'ı genişletin** | `Name`, `ShortDescription`, `Prefix`, `RiskVisual`, `TagDisplays` gibi özellikleri öznitelik ve çeviri anahtarlarından otomatik sağlar. |
-| **`async Task<ApplyResult>` kullanın** | `Task.FromResult()` DEĞİL. Servis sağlayıcıları asenkrondur — arayüzün kilitlenmemesi için `await` kullanın. |
-| **`CompleteFromScope()` döndürün** | `ApplyResult` sonucunu, ortam `ExecutionScope`'una kaydedilen adımlardan türetir. |
-| **İlerlemeyi raporlayın** | İletişim kutusunu güncellemek için `progress.Report(new ProcessingProgress { ... })` kullanın. |
-| **Tüm istisnaları (exception) yakalamayın** | Yukarı fırlatılmasına izin verin. Başarı/başarısızlık durumunu `ExecutionScope` izler. |
-| **Manuel olarak geri alma adımları oluşturmayın** | Statik sağlayıcı hizmetler bunu `ExecutionScope.RecordStep()` ile otomatik yapar. |
-### Mevcut Servis Sağlayıcıları
+| **`Id` yeni bir GUID olmalıdır** | Geri alma dosyası adlandırmasında kullanılır. PowerShell'de `[guid]::NewGuid()` ile oluşturun. |
+| **`BaseOptimization`'ı genişletin** | `Name`, `ShortDescription`, `RiskVisual`, `TagDisplays`'i otomatik sağlar |
+| **`async Task<ApplyResult>` kullanın** | Servis sağlayıcıları asenkrondur — `await` kullanın |
+| **`CompleteFromScope()` döndürün** | `ApplyResult`'u kaydedilen adımlardan türetir |
+| **İlerlemeyi raporlayın** | `progress.Report(new ProcessingProgress { ... })` |
+| **Tüm istisnaları yakalamayın** | `ExecutionScope` başarı/başarısızlığı izler |
+| **Manuel geri alma adımı oluşturmayın** | Statik sağlayıcılar bunu `ExecutionScope.RecordStep()` ile otomatik yapar |
+| **`context.Logger` kullanın** | Tanılama bilgilerini kaydetmek için |
+| **`context.Snapshot`'ı kontrol edin** | `SystemSnapshot` RAM, GPU, CPU bilgisi sağlar |
-Bu **statik** sınıflar loglama, hata işleme ve geri alma adımlarının otomatik olarak kaydedilmesini yönetir.
+### Mevcut Servis Sağlayıcıları
-| Servis | Önemli Metotlar | Neden Kullanılır? |
+| Servis | Önemli Metotlar | Açıklama |
|---|---|---|
-| **`RegistryService`** | `Write()`, `Read<T>()`, `DeleteValue()`, `CreateSubKey()`, `DeleteSubKeyTree()` | Kayıt defteri okuma/yazma/silme işlemleri. Geri alma için orijinal değerleri yedekler. |
-| **`ShellService`** | `CMDAsync()`**, `PowerShellAsync()`** | CMD veya PowerShell komutları çalıştırmak için. Daima asenkron varyantları kullanın. |
-| **`ScheduledTaskService`** | `DisableTask()`, `EnableTask()`, `IsTaskEnabled()`, `DeleteTask()` | Windows Zamanlanmış Görevlerini (Scheduled Tasks) yönetir. |
-| **`ServiceProcessService`** | `ChangeServiceStartupTypeAsync()`**, `GetStartupTypeAsync()`** | Windows Hizmetlerini yönetir. Daima asenkron varyantları kullanın. |
-
-> **`**` ile işaretlenen yöntemler asenkrondur.** Optimizasyonunuzun `ApplyAsync` metodu içinde bunları `await` ile çağırın.
+| **`RegistryService`** | `Write()`, `Read<T>()`, `DeleteValue()`, `CreateSubKey()`, `DeleteSubKeyTree()`, `KeyExists()` | Kayıt defteri okuma/yazma/silme. Orijinal değerleri yedekler. |
+| **`ShellService`** | `CMDAsync()`, `PowerShellAsync()`, `CMD()`, `PowerShell()` | CMD/PowerShell komutları. `revertCommand` parametresi alabilir. |
+| **`ScheduledTaskService`** | `DisableTask()`, `EnableTask()`, `IsTaskEnabled()`, `DeleteTask()` | Windows Zamanlanmış Görevlerini yönetir. |
+| **`ServiceProcessService`** | `ChangeServiceStartupTypeAsync()`, `GetStartupTypeAsync()` | Windows Hizmetlerini yönetir. |
-Örnek kullanım:
+Kullanım örnekleri:
```csharp
-// Senkron kayıt defteri yazma
-RegistryService.Write(new RegistryItem(@"HKLM\...", "Value", 1));
-RegistryService.DeleteValue(new RegistryItem(@"HKCU\...", "OldValue"));
+// Çoklu kayıt defteri yazma
+RegistryService.Write(
+ new RegistryItem(@"HKLM\...", "Value1", 1),
+ new RegistryItem(@"HKLM\...", "Value2", 0)
+);
-// Asenkron servis değişiklikleri
+// Çoklu asenkron servis değişikliği
await ServiceProcessService.ChangeServiceStartupTypeAsync(
- new ServiceItem("DiagTrack", ServiceStartupType.Disabled));
-
-// Asenkron komut dosyası çalıştırma
-var result = await ShellService.PowerShellAsync("Some-Command");
+ new ServiceItem("DiagTrack", ServiceStartupType.Disabled),
+ new ServiceItem("dmwappushservice", ServiceStartupType.Disabled)
+);
+
+// Geri alma komutu ile shell komutu
+var result = await ShellService.CMDAsync(
+ "powercfg /h off",
+ "powercfg /h on" // geri alma için saklanır
+);
```
-### Yeni Bir Kategori Oluşturma
+### Yeni Kategori Oluşturma ve Yardımcı Sınıflar
+
+Yalnızca optimizasyonlarınız mevcut kategorilere uymuyorsa. Aşırı spesifik kategorilerden kaçının.
-Sadece optimizasyonlarınız mevcut kategorilerden hiçbirine uymuyorsa. Aşırı spesifik kategorilerden kaçının.
+1. `Domain/Optimizations/Categories/YourCategory.cs` oluşturun
+2. `IOptimizationCategory` uygulayın
+3. `[OptimizationCategory(PageType = typeof(YourPage))]` ekleyin
+4. `Domain/UI/OptimizationCategoryOrder.cs`'e yeni üye ekleyin
+5. XAML sayfası `App.xaml.cs`'deki `services.AddAllOptimizationPages()` ile otomatik kaydedilir
-1. `Domain/Optimizations/Categories/YourCategory.cs` dosyasını oluşturun.
-2. `IOptimizationCategory` arayüzünü (interface) uygulayın.
-3. `[OptimizationCategory(PageType = typeof(YourPage))]` ekleyin — aynı zamanda bir XAML sayfasına ihtiyacınız olacak.
-4. `Domain/UI/OptimizationCategoryOrder.cs` içindeki `OptimizationCategoryOrder` enum'una yeni bir üye ekleyin.
-5. XAML sayfası, `App.xaml.cs` dosyasındaki `services.AddAllOptimizationPages()` aracılığıyla otomatik olarak kaydedilir.
+Birden fazla optimizasyon aynı yapıyı paylaşıyorsa soyut bir ara sınıf oluşturun (örn. `Gpu.cs`'deki `GpuRegistryOptimization`).
-### Yerelleştirme Anahtarları (Localization Keys)
+### Yerelleştirme Anahtarları
-Her optimizasyon `Translations.resx` içinde yer alan girdilere ihtiyaç duyar. Anahtarlar (keys) katı bir standardı takip eder:
+Her optimizasyon `Translations.resx` içinde girdilere ihtiyaç duyar:
```
Optimizer.{KategoriAdı}.{OptimizasyonAnahtarı}.Name
@@ -314,115 +319,431 @@ Optimizer.{KategoriAdı}.{OptimizasyonAnahtarı}.Progress.{ÖzelAnahtar}
Optimizer.{KategoriAdı}.{OptimizasyonAnahtarı}.Error.{ÖzelAnahtar}
```
-Örneğin `KategoriAdı` = kategori sınıfının adı (`Performance`) ve `OptimizasyonAnahtarı` = içiçe sınıfın adı (`MyNewTweak`).
-
> [!IMPORTANT]
-> **Çeviriler zorunludur**. Eğer bu anahtarları eklemezseniz, uygulama ham anahtar adını görüntüler, örn. `"Optimizer.Performance.MyNewTweak.Name"`. En azından `Translations.resx` (İngilizce) dosyasına daima girdileri ekleyin.
+> **Çeviriler zorunludur**. En azından `Translations.resx`'e (İngilizce) giriş ekleyin.
---
# Özelleştirme Ayarı Oluşturma
-Özelleştirme ayarları, Windows ayarlarını AÇIK veya KAPALI olarak değiştiren kullanıcı arabirimi kontrolleridir (geçiş anahtarları, açılır menüler, sayı girişleri). `Domain/Customize/Categories/` dizininde bulunurlar.
+Özelleştirme ayarları, Windows ayarlarını AÇIK/KAPALI yapan UI kontrolleridir. `Domain/Customize/Categories/` dizininde bulunurlar.
### Özelleştirme Kategorileri
-| Dosya | Öznitelik (Attribute) | Odak Noktası |
+| Dosya | Öznitelik | Odak Noktası |
|---|---|---|
-| `Desktop.cs` | `[CustomizeCategory(PageType = typeof(DesktopFeatureCategory))]` | Masaüstü simgeleri (Bu Bilgisayar, Ağ vb.), kısayol okları |
-| `Preferences.cs` | `[CustomizeCategory(PageType = typeof(PreferencesFeatureCategory))]` | Görev çubuğu hizalaması, widget'lar, karanlık mod, gizli dosyalar |
+| `Desktop.cs` | `[CustomizeCategory(PageType = typeof(DesktopFeatureCategory))]` | Masaüstü simgeleri, kısayol okları |
+| `Preferences.cs` | `[CustomizeCategory(PageType = typeof(PreferencesFeatureCategory))]` | Görev çubuğu, widget'lar, karanlık mod, dosya uzantıları, gizli dosyalar, pano geçmişi |
| `Gaming.cs` | `[CustomizeCategory(PageType = typeof(GamingFeatureCategory))]` | Oyun Modu, Game Bar, fare ivmesi, GPU zamanlaması |
-| `SystemFeatures.cs` | `[CustomizeCategory(PageType = typeof(SystemFeatureCategory))]` | Önyükleme sırasında Num Lock durumu |
-
-### Adım Adım: Basit Bir Kayıt Defteri Anahtarı
+| `SystemFeatures.cs` | `[CustomizeCategory(PageType = typeof(SystemFeatureCategory))]` | Num Lock, Geliştirici Modu, Uzun Yollar, pil yüzdesi |
-Aç/kapat (toggle) şeklindeki basit bir kayıt defteri değişikliği için temel sınıf (base class) tüm işi yapar:
+### Basit Kayıt Defteri Anahtarı
```csharp
-private enum Sections { Taskbar, Widgets, Advanced }
-
[CustomizeSetting(
- Section = nameof(Sections.Taskbar), // Arayüzde ayarları gruplandırır
- Icon = SymbolRegular.AlignCenter24, // Wpf.Ui.Controls.SymbolRegular'dan
- Recommendation = RecommendationState.On // On / Off / Depends / Experimental / None
+ Section = nameof(Sections.Taskbar),
+ Icon = SymbolRegular.AlignCenter24,
+ Recommendation = RecommendationState.On
)]
public class TaskbarAlignment : BaseCustomizeSetting
{
protected override IEnumerable<RegistryToggle> RegistryToggles =>
- [
- new()
- {
- Path = @"HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced",
- Name = "TaskbarAl",
- OnValue = 0, // Anahtar AÇIK olduğunda değer
- OffValue = 1, // Anahtar KAPALI olduğunda değer
- DefaultValue = 1, // değer = varsayılan durum (anahtar yoksa)
- },
- ];
-
- // Bu ayar değiştiğinde nelerin yenilenmesi gerektiğini beyan edin
+ [new()
+ {
+ Path = @"HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced",
+ Name = "TaskbarAl",
+ OnValue = 0,
+ OffValue = 1,
+ DefaultValue = 1,
+ }];
+
protected override CustomizeRefreshScope RefreshScope =>
CustomizeRefreshScope.TaskbarSettings;
}
```
-*(Kalan kısımlar da yapısal olarak mevcuttur, katkıda bulunanlar GitHub üzerinden doğrudan rehberlere bakarak ilerleyebilirler.)*
+### RegistryToggle Özellikleri
+
+| Özellik | Tür | Varsayılan | Açıklama |
+|---|---|---|---|
+| `Path` | `string` | zorunlu | Tam kayıt defteri yolu |
+| `Name` | `string` | zorunlu | Kayıt defteri değer adı |
+| `OnValue` | `object?` | `1` | "Açık" durumu değeri |
+| `OffValue` | `object?` | `0` | "Kapalı" durumu değeri |
+| `DefaultValue` | `object?` | `0` | Anahtar yoksa kullanılacak değer |
+| `IsOptional` | `bool` | `false` | Durum tespiti için gerekli değilse `true` |
+| `ValueKind` | `RegistryValueKind` | `DWord` | Kayıt defteri değer türü |
+
+### Kontrol Türleri
+
+| Tür | Görüntü | Kullanım |
+|---|---|---|
+| `Toggle` | Aç/Kapat anahtarı | Çoğu ayar (varsayılan) |
+| `Dropdown` | Açılır menü | Çoklu seçim |
+| `Option` | Radyo düğmesi | Birbirini dışlayan seçenekler |
+| `NumberInt` | Sayı girişi | Tamsayı değerleri |
+| `NumberFloat` | Ondalık giriş | Hassas değerler |
+| `String` | Metin girişi | Serbest metin |
+
+### Özel Mantık (GetStateAsync / ApplyAsync)
+
+```csharp
+[CustomizeSetting(
+ Section = nameof(Sections.Input),
+ Icon = SymbolRegular.Cursor24,
+ Recommendation = RecommendationState.Off
+)]
+public class MouseAcceleration : BaseCustomizeSetting
+{
+ private const string Path = @"HKCU\Control Panel\Mouse";
+
+ protected override IReadOnlyList<string> GetWatchedRegistryPaths() => [Path];
+
+ public override Task<bool> GetStateAsync()
+ {
+ return Task.Run(() =>
+ {
+ var speed = RegistryService.Read<string>(new RegistryItem(Path, "MouseSpeed"));
+ var t1 = RegistryService.Read<string>(new RegistryItem(Path, "MouseThreshold1"));
+ var t2 = RegistryService.Read<string>(new RegistryItem(Path, "MouseThreshold2"));
+ return (int.TryParse(speed, out var s) && s != 0)
+ || (int.TryParse(t1, out var a) && a != 0)
+ || (int.TryParse(t2, out var b) && b != 0);
+ });
+ }
+
+ public override async Task ApplyAsync(object? value)
+ {
+ var isOn = value is bool b && b;
+ RegistryService.Write(new RegistryItem(Path, "MouseSpeed", isOn ? "1" : "0"));
+ RegistryService.Write(new RegistryItem(Path, "MouseThreshold1", isOn ? "6" : "0"));
+ RegistryService.Write(new RegistryItem(Path, "MouseThreshold2", isOn ? "10" : "0"));
+ await ExecutePostActionAsync();
+ }
+
+ protected override CustomizeRefreshScope RefreshScope => CustomizeRefreshScope.Default;
+}
+```
+
+### Öneri Sistemi
+
+Her özelleştirme ayarı bir öneri bildirebilir:
+
+```csharp
+[CustomizeSetting(
+ ...,
+ Recommendation = RecommendationState.On // On / Off / Depends / Experimental / None
+)]
+```
+
+| Durum | Anlamı |
+|---|---|
+| `On` | AÇILMASI önerilir — sistemi iyileştirir |
+| `Off` | KAPATILMASI önerilir — sistemi iyileştirir |
+| `Depends` | Kullanıcının ihtiyaçlarına bağlıdır |
+| `Experimental` | Kararsız olabilir, dikkatli kullanın |
+| `None` (varsayılan) | Öneri gösterilmez |
+
+### Ne Zaman Ne Geçersiz Kılınır
+
+| Senaryo | Geçersiz Kıl |
+|---|---|
+| Basit kayıt defteri anahtarı | `RegistryToggles` + `RefreshScope` |
+| Çoklu kayıt defteri | `RegistryToggles` (hepsini listele) |
+| Açılır menü/Seçenekler | `ControlType`, `Options`, `ApplyAsync`, `CurrentValue` |
+| Çoklu değer mantığı | `GetStateAsync()` + `ApplyAsync()` + `GetWatchedRegistryPaths()` |
+| Kayıt defteri olmayan ayar | `GetStateAsync()` + `ApplyAsync()` (tamamen özel) |
+| Dinamik seçenekler | `Options` getter'ını koşullu yap |
+| Yakınsama ile durum tespiti | `GetStateWithRetryAsync()` (yerleşik — geçersiz kılmayın) |
+| Gömülü kaynak çıkarma | `EmbeddedResourceHelper.TryExtract()` içinde `ApplyAsync` |
+
+### Yerelleştirme Anahtarları (Özelleştirme)
+
+```
+Customize.{KategoriAdı}.{AyarAnahtarı}.Name
+Customize.{KategoriAdı}.{AyarAnahtarı}.Description
+Customize.{KategoriAdı}.{AyarAnahtarı}.Options.{SeçenekAnahtarı}
+Customize.{KategoriAdı}.{AyarAnahtarı}.Recommendation.Reason
+Customize.{KategoriAdı}.Section.{BölümAdı}
+```
---
# Yenileme Kapsamı Sistemi
-Bir özelleştirme ayarı değiştiğinde, farklı Windows yüzeyleri farklı yenileme stratejilerine ihtiyaç duyar. `CustomizeRefreshScope` [Flags] enum'u bunu kontrol eder. Çoğu durumda `Default` (Varsayılan) kullanabilirsiniz.
+`CustomizeRefreshScope` [Flags] enum'u Windows yüzeylerinin nasıl yenileneceğini kontrol eder.
+
+| Üye | Değer | Etki |
+|---|---|---|
+| `None` | `0` | Yenileme yok |
+| `Settings` | `1 << 0` | `WM_SETTINGCHANGE` yayınla |
+| `Associations` | `1 << 1` | Dosya ilişkilendirme değişikliklerini bildir |
+| `Desktop` | `1 << 2` | Masaüstü simge listesini yenile |
+| `Taskbar` | `1 << 3` | Görev çubuğu `WM_SETTINGCHANGE` yayınla |
+| `PolicyUpdate` | `1 << 4` | `SystemParametersInfo` gönder |
+| `Theme` | `1 << 5` | `WM_THEMECHANGED` yayınla |
+| `DesktopIconCache` | `1 << 6` | Masaüstü simge önbelleğini yenile |
+
+**Bileşikler**: `Default` (`Settings | Associations`), `DesktopIcons` (`Settings | Desktop`), `TaskbarSettings` (`Settings | Taskbar`), `ExplorerView` (`Settings | Associations | PolicyUpdate`).
+
+`ApplyAsync`'i geçersiz kılarsanız, `await ExecutePostActionAsync()` çağırmayı unutmayın.
---
# Yeni Özellikler Geliştirme
-Yeni bir sayfa veya araç eklemek istiyorsanız (örneğin, bir "Ağ İzleyicisi"):
+1. **Önce GitHub Sorunu (Issue) açın**
+2. **Uygulama sırası**: Service → ViewModel → XAML Page → `App.xaml.cs`'e kaydet
-1. **Önce bir GitHub Sorunu (Issue) açın** — özelliği, kullanım durumunu ve tasarımı açıklayın. Geliştiriciden geri bildirim bekleyin.
-2. ViewModels ve Pages `App.xaml.cs` içinde singleton olarak kaydedilmelidir.
+```csharp
+// DI Kayıt Deseni
+services.AddSingleton<YourViewModel>();
+services.AddSingleton<YourPage>();
+services.AddSingleton<ConfigManager>();
+services.AddSingleton<RevertManager>();
+services.AddSingleton<OptimizationRegistry>();
+services.AddSingleton<OptimizationService>();
+services.AddSingleton<SystemInfoService>();
+services.AddSingleton<StreamService>();
+services.AddSingleton<UpdaterService>();
+```
+
+### Sistem Servisleri
+
+| Servis | Amaç |
+|---|---|
+| `SystemInfoService` | `SystemSnapshot` ile CPU, RAM, GPU bilgisi |
+| `StreamService` | Uzak kaynakları indirme |
+| `UpdaterService` | GitHub sürümlerini kontrol etme |
+| `RegistryWatcher` | Kayıt defteri değişikliklerini izleme |
+| `BloatwareService` | Ön yüklemeli AppX paketlerini listeleme |
+| `DiskCleanupService` | Disk temizlik taraması |
+| `StartupManagerService` | Başlangıç uygulamalarını yönetme |
---
# Geri Alma Sistemi
-Uygulanan her optimizasyon `%localappdata%\optimizerDuck\Revert\{optimizationId}.json` yolunda bir JSON dosyası oluşturur. Sistem, atomik değişiklikler yapar ve işlemleri hatasız geri almaya olanak sağlar. Statik sağlayıcıları kullanırsanız geri alma adımları otomatik olarak JSON'a kaydedilir, manuel olarak bir geri alma adımı oluşturmayın.
+Her uygulanan optimizasyon `%localappdata%\optimizerDuck\Revert\{optimizationId}.json` yolunda bir JSON dosyası oluşturur.
+
+### Nasıl Çalışır
+
+```
+ApplyAsync() → ExecutionScope.Begin() → Provider çağrıları otomatik adım kaydeder → CompleteFromScope() → RevertManager.SaveRevertDataAsync()
+```
+
+### Adım Türleri
+
+| Adım Türü | Kaydedilen | Otomatik Oluşturan |
+|---|---|---|
+| **`RegistryRevertStep`** | Orijinal kayıt defteri değeri | `RegistryService.Write()`, `DeleteValue()`, vb. |
+| **`ServiceRevertStep`** | Orijinal servis başlatma türü | `ServiceProcessService.ChangeServiceStartupTypeAsync()` |
+| **`ScheduledTaskRevertStep`** | Orijinal görev durumu | `ScheduledTaskService.DisableTask()`, `EnableTask()` |
+| **`ShellRevertStep`** | Geri alma komutu | `ShellService.CMDAsync()` — `revertCommand` parametresi |
+| **`UsbPowerRevertStep`** | USB güç ayarları | USB optimizasyonları (manuel `ExecutionScope.RecordStep()`) |
+
+Geri alma komutu ekleme:
+
+```csharp
+await ShellService.CMDAsync("powercfg /h off", "powercfg /h on"); // revertCommand
+```
+
+### Önemli Detaylar
+
+- **Uygulanma durumu**: Dosyanın diskteki varlığından çıkarılır
+- **Atomik yazma**: `.tmp` + `File.Replace()`
+- **Eşzamanlı erişim**: Dosya başına `SemaphoreSlim` kilitleri, 30 saniye zaman aşımı
+- **Ters sırada geri alma**: Son uygulanan = ilk geri alınan
+- **Kısmi başarı**: Bazı adımlar başarısız olsa bile devam eder
+- **Yeniden deneme**: `OptimizationService.RetryFailedStepsAsync()`
+- **Yeni adım türü ekleme**: `Domain/Revert/Steps/`'e `IRevertStep` uygulayan sınıf + `FromData(JObject)` metodu
---
# Test Etme
-Testler **xUnit v3** kullanır ve gerçek G/Ç ile entegrasyon tarzı bir yaklaşımı benimser. Hiçbir "mock" veya "fake" kütüphanesi kullanılmamıştır. Test çalıştırmak için:
-`dotnet test optimizerDuck.Test/optimizerDuck.Test.csproj --configuration Release`
+Testler **xUnit v3** kullanır ve gerçek G/Ç ile entegrasyon tarzı bir yaklaşım benimser.
+
+### Test Kalıpları
+
+| Kalıp | Detay |
+|---|---|
+| **Mock kütüphanesi yok** | Tüm test double'ları elle yazılmıştır |
+| **Gerçek G/Ç** | Gerçek dosya sistemi, kayıt defteri, süreç yürütme |
+| **Temizlik** | `try/finally` veya `IDisposable` |
+| **İsimlendirme** | `{Method}_{Scenario}_{ExpectedResult}` |
+| **Loglama** | `NullLogger<T>.Instance` |
+
+```bash
+dotnet test optimizerDuck.Test/optimizerDuck.Test.csproj --configuration Release
+```
+
+### Test Yapısı
+
+```
+optimizerDuck.Test/
+├── Common/Helpers/
+│ └── SystemRefreshServiceTests.cs
+├── Domain/
+│ ├── Customize/BaseCustomizeSettingTests.cs
+│ ├── Exceptions/StepExecutionExceptionTests.cs
+│ └── Revert/Steps/RevertStepSerializationTests.cs, ScheduledTaskRevertStepTests.cs
+└── Services/
+ ├── ApplyRevertComprehensiveTests.cs
+ ├── OptimizationServiceTests.cs, OptimizationServiceIntegrationTests.cs
+ ├── RevertManagerTests.cs
+ ├── RegistryServiceTests.cs, ServiceProcessServiceTests.cs, ShellServiceTests.cs
+ └── RegistryWatcherTests.cs, SystemInfoServiceTests.cs
+```
+
+### CI Entegrasyonu
+
+```bash
+dotnet test optimizerDuck.Test/optimizerDuck.Test.csproj --configuration Release --no-build --blame-hang --blame-hang-timeout 30s
+```
---
# Kodlama Standartları
-- `PascalCase` sınıf, enum, metot adları için.
-- `_camelCase` özel (private) alanlar için.
-- `camelCase` yerel değişkenler için.
-- Girinti: 4 boşluk, Maksimum satır uzunluğu 100 karakter. `dotnet csharpier .` komutu kodu otomatik formatlar.
-- Kesinlikle string (metin) ifadeleri hardcode yazmayın. Daima `Translations.KeyName` kullanın.
+| Kural | Değer |
+|---|---|
+| Sınıflar, metotlar, özellikler | `PascalCase` |
+| Private alanlar | `_camelCase` |
+| Yerel değişkenler | `camelCase` |
+| Async metotlar | `*Async` soneki |
+| Girinti | 4 boşluk |
+| Maksimum satır uzunluğu | 100 karakter |
+| Biçimlendirici | **CSharpier** — `dotnet csharpier .` |
+| **String'leri hardcode etmeyin** | `Translations.KeyName` veya `Loc.Instance["Key"]` kullanın |
+| **Yorumları minimumda tutun** | |
+| **Null yapılabilir referans türleri** | Etkin (`<Nullable>enable</Nullable>`) |
+
+### Hata Yönetimi
+
+| Katman | Uygulama |
+|---|---|
+| **Optimizasyonlar** | `ApplyResult.False("sebep")` döndürün, fırlatmayın |
+| **Sağlayıcı servisler** | try/catch + `ExecutionScope.LogError` |
+| **ViewModel'ler** | Komut işleyicilerinde yakalayın, snackbar gösterin |
+| **Genel** | App.xaml.cs'de 3 genel hata işleyici. Çökmeler `%localappdata%\optimizerDuck\Crashes\crash_*.log`'a kaydedilir |
---
# Yerelleştirme
-Uygulama metinleri `Resources/Languages/Translations.resx` içinde bulunur. Lütfen yeni bir dil eklerken `Translations.{locale}.resx` dosyası oluşturun ve `SettingsViewModel.cs` içinden dili uygulamaya ekleyin. Her zaman yerelleştirme (Localization) kurallarına sadık kalın.
+Tüm kullanıcı metinleri `Resources/Languages/Translations.resx` içindedir.
+
+### Mevcut Diller (11 dil + İngilizce)
+
+| Dil | Dosya |
+|---|---|
+| English | `Translations.resx` (varsayılan) |
+| Vietnamese | `Translations.vi-VN.resx` |
+| Spanish | `Translations.es-ES.resx` |
+| French | `Translations.fr-FR.resx` |
+| Geleneksel Çince | `Translations.zh-TW.resx` |
+| Basitleştirilmiş Çince | `Translations.zh-CN.resx` |
+| Russian | `Translations.ru-RU.resx` |
+| Korean | `Translations.ko-KR.resx` |
+| Japanese | `Translations.ja-JP.resx` |
+| Polish | `Translations.pl-PL.resx` |
+| Turkish | `Translations.tr-TR.resx` |
+| Portuguese (Brazil) | `Translations.pt-BR.resx` |
+
+### Yeni Dil Ekleme
+
+1. `Translations.{locale}.resx` dosyasını oluşturun (tüm anahtarlarla)
+2. `SettingsViewModel.cs`'e kaydedin:
+```csharp
+new() { DisplayName = "Deutsch", Culture = new CultureInfo("de-DE") },
+```
+
+XAML'de:
+```xml
+<ui:TextBlock Text="{ext:Loc Dashboard.Header.Title}" />
+```
---
# Çekme İsteği Süreci (Pull Request Process)
-1. Her zaman `master` üzerinden yeni bir dal (branch) açın: `feature/adiniz` veya `fix/issue-id`.
-2. Commit mesajlarınızı kurallara uygun (`feat:`, `fix:`, `docs:`) şekilde yazın.
-3. Kodu derleyin, testleri çalıştırın ve `csharpier` ile formatlayın.
-4. Yeni bir optimizasyon eklediyseniz, ekran görüntüsünü (screenshot) PR açıklamasına ekleyin.
-5. Yorumları takip edin ve takım arkadaşlarının geribildirimlerine açık olun.
+1. **`master`'dan dal açın**: `feature/adiniz` veya `fix/issue-id`
+2. **Conventional Commits**: `feat:` (yeni özellik), `fix:` (hata düzeltme), `refactor:` (yeniden düzenleme), `docs:` (dokümantasyon), `test:` (test), `i18n:` (çeviri), `chore:` (bakım)
+3. **Göndermeden önce doğrulayın**:
+
+```bash
+dotnet build optimizerDuck.slnx --configuration Release
+dotnet test optimizerDuck.Test/optimizerDuck.Test.csproj --configuration Release --no-build
+dotnet csharpier .
+```
+
+4. **PR açın**: Ne ve neden değişti? UI değişiklikleri varsa ekran görüntüsü ekleyin. İlgili Issue'ları `Closes #42` ile bağlayın.
+
+### PR Kontrol Listesi
+
+- [ ] Kod mevcut kalıpları takip ediyor
+- [ ] Yerelleştirme anahtarları `Translations.resx`'e eklendi
+- [ ] `dotnet build` başarılı (0 hata)
+- [ ] `dotnet test` başarılı
+- [ ] `dotnet csharpier .` çalıştırıldı
+- [ ] Hardcode string yok
+- [ ] Geri alma adımları kaydedildi (varsa)
+- [ ] UI değişiklikleri için ekran görüntüsü eklendi
+
+---
+
+# Sorun (Issue) Yönergeleri
+
+- **Hata raporları**: Yeniden üretme adımları, beklenen/gerçek davranış, `%localappdata%\optimizerDuck\optimizerDuck.log` + sistem özellikleri
+- **Özellik istekleri**: Kullanım durumu, çözdüğü sorun, nasıl çalışması gerektiği
+- **Optimizasyon önerileri**: Kayıt defteri yolları, servis adları, CLI komutları, güvenilir kaynaklar
+- **Sorular**: GitHub Discussions veya [Discord](https://discord.gg/tDUBDCYw9Q)
-*(Katkınız için tekrardan teşekkür ederiz!)*
+---
+
+# SSS ve Sorun Giderme
+
+### Derleme "CA1416" hatasıyla başarısız oluyor
+`.editorconfig` CA1416'yı susturur. Proje Windows'a özeldir.
+
+### Optimizasyon UI'da görünmüyor
+- Kategori içinde **iç içe public sınıf** mı?
+- Kategori `IOptimizationCategory` uyguluyor mu?
+- `BaseOptimization`'dan türetilmiş mi?
+- `[Optimization(Id = "...")]` özniteliği var mı?
+- Yerelleştirme anahtarları `Translations.resx`'e eklendi mi?
+
+### Özelleştirme ayarı görünmüyor
+- `[CustomizeSetting(Section = ..., Icon = ...)]` var mı?
+- `Section` yazımı doğru mu?
+- `[CustomizeCategory(PageType = ...)]` var mı?
+
+### UI donuyor
+`ApplyAsync`'te `async`/`await` kullandığınızdan emin olun. `.Result`/`.Wait()` UI'ı dondurur.
+
+### GUID nasıl oluşturulur?
+```powershell
+[guid]::NewGuid()
+```
+
+### Çeviriler anahtar adı olarak görünüyor
+`Translations.resx`'e yerelleştirme anahtarları eklemeyi unuttunuz.
+
+### "Geri alma verisi yok" hatası
+Optimizasyonun `Id` GUID'inin değişmediğinden emin olun.
+
+### Yeni geri alma adım türü ekleme
+1. `Domain/Revert/Steps/`'e `IRevertStep` uygulayan sınıf oluşturun
+2. Statik `FromData(JObject data)` metodu ekleyin
+3. `ExecutionScope.RecordStep()` ile kaydedin
+
+### Çökme güvenliği
+- Geri alma dosyaları atomik yazma kullanır (`.tmp` + `File.Replace`)
+- Çökme günlükleri: `%localappdata%\optimizerDuck\Crashes\crash_*.log`
+- App.xaml.cs'de 3 genel hata işleyici
+
+---
<div align="center">
diff --git a/optimizerDuck/Services/Optimization/Providers/ServiceProcessService.cs b/optimizerDuck/Services/Optimization/Providers/ServiceProcessService.cs
index ce11225..551868c 100644
--- a/optimizerDuck/Services/Optimization/Providers/ServiceProcessService.cs
+++ b/optimizerDuck/Services/Optimization/Providers/ServiceProcessService.cs
@@ -47,7 +47,7 @@ public static class ServiceProcessService
string stdout
)
{
- var lines = stdout.Split([ '\r', '\n' ], StringSplitOptions.RemoveEmptyEntries);
+ var lines = stdout.Split(['\r', '\n'], StringSplitOptions.RemoveEmptyEntries);
foreach (var line in lines)
{