Skip to content

armgit / orca

Public Imported from GitHub
0

Orca is the place for working with a fleet of agents (e.g. Grok Bot, Claude Code). Run any coding agent with your own subscription. Available on desktop, mobile and remote runtime.

plugins: warn before trusting non-official plugins and review access-growing updates one by one (#36218)

Neil65fec4617e7a
diff --git a/src/main/plugins/catalog/plugin-auto-updater.test.ts b/src/main/plugins/catalog/plugin-auto-updater.test.ts
index f81c7ab6bde..ad7e393e0b6 100644
--- a/src/main/plugins/catalog/plugin-auto-updater.test.ts
+++ b/src/main/plugins/catalog/plugin-auto-updater.test.ts
@@ -56,6 +56,7 @@ function discovered(m: PluginManifest, contentHash: string, isDev = false): Vali
function setup(
options: {
+ previous?: PluginManifest
next?: PluginManifest
officialCatalog?: boolean
repository?: string
@@ -73,7 +74,7 @@ function setup(
let now = 1_000_000
// Why first pass only: later refreshes hit warm caches and finish sooner.
let refreshMs = options.refreshMs ?? 0
- const previous = discovered(manifest('1.0.0'), 'sha-old', options.dev)
+ const previous = discovered(options.previous ?? manifest('1.0.0'), 'sha-old', options.dev)
const nextManifest = options.next ?? manifest('1.1.0')
const next = discovered(nextManifest, 'sha-new')
let current = previous
@@ -255,6 +256,42 @@ describe('plugin auto-update', () => {
expect(updater.getState().needsReview).toEqual({ [KEY]: '1.1.0' })
})
+ // Why every kind: each is a security boundary that must reach the user's own approval.
+ it.each([
+ [
+ 'a content-only plugin that becomes a worker',
+ {
+ previous: manifest('1.0.0', { main: undefined, capabilities: [] }),
+ next: manifest('1.1.0', { capabilities: [] })
+ }
+ ],
+ [
+ 'a content-only plugin that adds commands',
+ {
+ previous: manifest('1.0.0', { main: undefined, capabilities: [] }),
+ next: manifest('1.1.0', {
+ main: undefined,
+ capabilities: [],
+ contributes: pluginManifestSchema.parse({
+ ...manifest('1.1.0'),
+ contributes: { commands: [{ id: 'go', title: 'Go', action: 'sidebar.left.toggle' }] }
+ }).contributes
+ })
+ }
+ ],
+ [
+ 'a worker that widens a capability',
+ { next: manifest('1.1.0', { capabilities: [{ kind: 'secrets:own' }] }) }
+ ]
+ ])('never auto-installs %s, even from the official catalog', async (_label, change) => {
+ const { updater, install, consents } = setup({ officialCatalog: true, ...change })
+ const before = consents[KEY]
+ await updater.run()
+ expect(install).not.toHaveBeenCalled()
+ expect(consents[KEY]).toBe(before)
+ expect(updater.getState()).toEqual({ updated: {}, needsReview: { [KEY]: '1.1.0' } })
+ })
+
it('marks an update from a moved repository for review', async () => {
const { updater, install } = setup({
officialCatalog: true,
diff --git a/src/renderer/src/components/plugins/dialogs/PluginUpdateAllDialog.test.tsx b/src/renderer/src/components/plugins/dialogs/PluginUpdateAllDialog.test.tsx
index bf0e153b677..873663510ab 100644
--- a/src/renderer/src/components/plugins/dialogs/PluginUpdateAllDialog.test.tsx
+++ b/src/renderer/src/components/plugins/dialogs/PluginUpdateAllDialog.test.tsx
@@ -105,7 +105,30 @@ afterEach(() => {
})
function installApi(plugins: Record<string, unknown>): void {
- Object.defineProperty(window, 'api', { configurable: true, value: { plugins } })
+ Object.defineProperty(window, 'api', {
+ configurable: true,
+ value: {
+ plugins: {
+ getInstalledManifest: vi.fn().mockResolvedValue(null),
+ consent: vi.fn().mockResolvedValue([]),
+ ...plugins
+ }
+ }
+ })
+}
+
+function workerUpdate(pluginKey: string, official: boolean): PluginMarketplaceHostInstallPreview {
+ const next = preview(pluginKey, ['secrets:own'])
+ return {
+ ...next,
+ official,
+ manifest: { ...next.manifest, main: 'worker.js' },
+ accessGrowth: {
+ capabilities: ['secrets:own'],
+ execution: 'trusted-worker',
+ contributions: []
+ }
+ }
}
async function renderDialog(
@@ -129,6 +152,12 @@ async function renderDialog(
return container
}
+function reviewButton(container: HTMLElement, pluginKey: string): HTMLButtonElement | undefined {
+ return Array.from(
+ container.querySelectorAll<HTMLButtonElement>(`[data-plugin-update="${pluginKey}"] button`)
+ ).find((candidate) => candidate.textContent === 'Review')
+}
+
function button(container: HTMLElement, text: string): HTMLButtonElement | undefined {
return Array.from(container.querySelectorAll('button')).find(
(candidate) => candidate.textContent === text
@@ -147,7 +176,7 @@ describe('PluginUpdateAllDialog', () => {
)
})
- it('flags an update whose catalog moved it to another repository and leaves it unticked', async () => {
+ it('keeps an update whose catalog moved it to another repository out of Update all', async () => {
const installMarketplacePlugin = vi.fn()
installApi({
previewMarketplaceUpdate: vi.fn(({ pluginKey }: { pluginKey: string }) =>
@@ -178,8 +207,14 @@ describe('PluginUpdateAllDialog', () => {
expect(container.textContent).toContain(
'New source: https://example.com/acme/plugin.git (was [email protected]:acme/original.git)'
)
- expect(container.querySelector('#plugin-update-a')?.getAttribute('aria-checked')).toBe('false')
+ expect(container.querySelector('#plugin-update-a')).toBeNull()
+ expect(reviewButton(container, 'a')).toBeDefined()
expect(container.querySelector('#plugin-update-b')?.getAttribute('aria-checked')).toBe('true')
+ await act(async () => button(container, 'Update')?.click())
+ expect(installMarketplacePlugin).toHaveBeenCalledTimes(1)
+ expect(installMarketplacePlugin).toHaveBeenCalledWith(
+ expect.objectContaining({ pluginKey: 'b' })
+ )
})
it('trusts main on what grows, so a lower execution profile is not new access', async () => {
@@ -211,7 +246,7 @@ describe('PluginUpdateAllDialog', () => {
expect(container.textContent).toContain('See all access')
})
- it('reviews every update in one dialog and installs only the ticked ones', async () => {
+ it('lists every update in one dialog and bulk-installs only those asking for nothing new', async () => {
const installMarketplacePlugin = vi.fn().mockResolvedValue({ ok: true, pluginKey: 'b' })
Object.defineProperty(window, 'api', {
configurable: true,
@@ -220,7 +255,8 @@ describe('PluginUpdateAllDialog', () => {
previewMarketplaceUpdate: vi.fn(({ pluginKey }: { pluginKey: string }) =>
Promise.resolve(preview(pluginKey, pluginKey === 'a' ? ['secrets:own'] : []))
),
- installMarketplacePlugin
+ installMarketplacePlugin,
+ getInstalledManifest: vi.fn().mockResolvedValue(null)
}
}
})
@@ -242,8 +278,8 @@ describe('PluginUpdateAllDialog', () => {
expect(container.textContent).toContain('New: Store its own encrypted secrets')
expect(container.querySelector('[data-plugin-update="b"]')?.textContent).toBe('b1.0.0 → 1.1.0')
- const first = container.querySelector<HTMLButtonElement>('#plugin-update-a')
- await act(async () => first?.click())
+ // Why no checkbox: an update that grows access is never part of the bulk Update.
+ expect(container.querySelector('#plugin-update-a')).toBeNull()
const confirm = Array.from(container.querySelectorAll('button')).find(
(button) => button.textContent === 'Update'
)
@@ -329,4 +365,77 @@ describe('PluginUpdateAllDialog', () => {
expect(checkbox?.getAttribute('aria-checked')).toBe('false')
expect(button(container, 'Update')?.disabled).toBe(false)
})
+
+ it('approves an update that grows access only from its own before/after review', async () => {
+ const installMarketplacePlugin = vi.fn(({ pluginKey }: { pluginKey: string }) =>
+ Promise.resolve({ ok: true, pluginKey, consentFingerprint: 'f' })
+ )
+ const consent = vi.fn().mockResolvedValue([])
+ installApi({
+ previewMarketplaceUpdate: vi.fn(({ pluginKey }: { pluginKey: string }) =>
+ Promise.resolve(pluginKey === 'a' ? workerUpdate('a', false) : preview(pluginKey, []))
+ ),
+ installMarketplacePlugin,
+ consent
+ })
+ const onUpdated = vi.fn().mockResolvedValue(undefined)
+ const container = await renderDialog([entry('a', ['storage:own']), entry('b', [])], {
+ onUpdated
+ })
+
+ await act(async () => reviewButton(container, 'a')?.click())
+ expect(container.querySelector('h2')?.textContent).toBe('Review update to a')
+ const review = container.querySelector('[data-plugin-update-review="a"]')
+ expect(review?.textContent).toContain('BeforeContent onlyStore its own data')
+ expect(review?.textContent).toContain('New: Full access')
+ expect(review?.textContent).toContain('New: Store its own encrypted secrets')
+ expect(review?.textContent).toContain('Not an official plugin:')
+ expect(installMarketplacePlugin).not.toHaveBeenCalled()
+
+ await act(async () => button(container, 'Approve & update')?.click())
+ expect(installMarketplacePlugin).toHaveBeenCalledTimes(1)
+ expect(installMarketplacePlugin).toHaveBeenCalledWith(
+ expect.objectContaining({ pluginKey: 'a' })
+ )
+ expect(consent).toHaveBeenCalledWith({
+ pluginKey: 'a',
+ reviewedFingerprint: 'f',
+ decision: 'approve'
+ })
+ expect(onUpdated).toHaveBeenCalledWith(['a'])
+ // Why back to the list: "b" still waits for the bulk Update.
+ expect(container.querySelector('[data-plugin-update="a"]')?.textContent).toContain('Updated')
+ })
+
+ it('never approves bytes other than the ones it reviewed', async () => {
+ const consent = vi.fn().mockResolvedValue([])
+ installApi({
+ previewMarketplaceUpdate: vi.fn().mockResolvedValue(workerUpdate('a', false)),
+ installMarketplacePlugin: vi
+ .fn()
+ .mockResolvedValue({ ok: true, pluginKey: 'a', consentFingerprint: 'other' }),
+ consent
+ })
+ const onUpdated = vi.fn().mockResolvedValue(undefined)
+ const container = await renderDialog([entry('a', [])], { onUpdated })
+ await act(async () => button(container, 'Approve & update')?.click())
+ expect(consent).not.toHaveBeenCalled()
+ // Why: main left it for review, which the page opens after the reload.
+ expect(onUpdated).toHaveBeenCalledWith(['a'])
+ })
+
+ it('names the publisher only for a non-official update', async () => {
+ installApi({ previewMarketplaceUpdate: vi.fn().mockResolvedValue(workerUpdate('a', true)) })
+ const official = await renderDialog([entry('a', [])])
+ expect(official.querySelector('[data-plugin-update-review="a"]')).not.toBeNull()
+ expect(official.textContent).not.toContain('Not an official plugin')
+ act(() => root?.unmount())
+ document.body.innerHTML = ''
+
+ installApi({ previewMarketplaceUpdate: vi.fn().mockResolvedValue(workerUpdate('a', false)) })
+ const community = await renderDialog([entry('a', [])])
+ expect(community.textContent).toContain(
+ 'Not an official plugin: Make sure you trust acme before updating.'
+ )
+ })
})
diff --git a/src/renderer/src/components/plugins/dialogs/PluginUpdateAllDialog.tsx b/src/renderer/src/components/plugins/dialogs/PluginUpdateAllDialog.tsx
index 57395263ff1..4e48876791f 100644
--- a/src/renderer/src/components/plugins/dialogs/PluginUpdateAllDialog.tsx
+++ b/src/renderer/src/components/plugins/dialogs/PluginUpdateAllDialog.tsx
@@ -8,11 +8,17 @@ import { Dialog, DialogContent, DialogFooter, DialogHeader, DialogTitle } from '
import {
CandidateRow,
isCurrent,
- movedFromSource,
+ updateNeedsApproval,
type UpdateCandidate
} from '../review/PluginUpdateCandidate'
+import { PluginUpdateReview } from '../review/PluginUpdateReview'
import type { PluginListEntry } from '../list/plugin-list-entries'
+/** Updates that change access or repository; they land only through their own review. */
+function needsOwnApproval(candidate: UpdateCandidate): boolean {
+ return candidate.preview !== null && updateNeedsApproval(candidate.preview)
+}
+
/** The update's minimum Orca when this Orca can't run it; null when it can or either is unknown. */
function requiredNewerOrca(
preview: PluginMarketplaceHostInstallPreview,
@@ -40,8 +46,9 @@ function failureMessage(failed: readonly string[], updatedCount: number): string
}
/**
- * One review for every pending update. Plugins whose access grows show only what's new;
- * the rest are one line. Any can be unticked; nothing installs until Update.
+ * One review for every pending update. Updates that ask for nothing new are one ticked line;
+ * any can be unticked and nothing installs until Update. An update that grows access or moved
+ * repository never joins that bulk Update: its Review opens its own before/after approval.
* Why no reset effect: the parent mounts a fresh dialog per open (keyed), so state starts clean.
*/
export function PluginUpdateAllDialog({
@@ -62,6 +69,7 @@ export function PluginUpdateAllDialog({
const [updated, setUpdated] = useState<ReadonlySet<string>>(() => new Set())
const [busy, setBusy] = useState(false)
const [failure, setFailure] = useState<string | null>(null)
+ const [reviewKey, setReviewKey] = useState<string | null>(null)
// Why frozen: each update reloads the list mid-run; the rows belong to the set the user opened.
const [plugins] = useState(entries)
const orcaVersionRef = useRef(orcaVersion)
@@ -94,16 +102,11 @@ export function PluginUpdateAllDialog({
).then((next) => {
if (!stale) {
setCandidates(next)
- // Why unticked: a moved source is a different publisher's code until the user opts in.
- setSkipped(
- (current) =>
- new Set([
- ...current,
- ...next
- .filter(({ entry, preview }) => preview && movedFromSource(entry, preview) !== null)
- .map(({ entry }) => entry.pluginKey)
- ])
- )
+ // Why straight to review: a lone update that needs approval has nothing else to show.
+ const [only] = next
+ if (next.length === 1 && only.preview && needsOwnApproval(only)) {
+ setReviewKey(only.entry.pluginKey)
+ }
}
})
return () => {
@@ -118,8 +121,61 @@ export function PluginUpdateAllDialog({
!candidate.needsOrca &&
!updated.has(candidate.entry.pluginKey)
const chosen = (candidates ?? []).filter(
- (candidate) => installable(candidate) && !skipped.has(candidate.entry.pluginKey)
+ (candidate) =>
+ installable(candidate) &&
+ !needsOwnApproval(candidate) &&
+ !skipped.has(candidate.entry.pluginKey)
)
+ const reviewing =
+ candidates?.find(
+ (candidate) => candidate.entry.pluginKey === reviewKey && installable(candidate)
+ ) ?? null
+ const leaveReview = (): void => {
+ setFailure(null)
+ if (plugins.length === 1) {
+ onClose()
+ } else {
+ setReviewKey(null)
+ }
+ }
+ /** Installs the reviewed release, then approves exactly the fingerprint this dialog showed. */
+ const approveReviewed = async ({ entry, preview }: UpdateCandidate): Promise<void> => {
+ if (!preview) {
+ return
+ }
+ setBusy(true)
+ setFailure(null)
+ let ok = false
+ try {
+ const result = await window.api.plugins.installMarketplacePlugin({
+ marketplaceSourceId: preview.marketplaceSourceId,
+ marketplaceCommit: preview.marketplaceCommit,
+ pluginKey: preview.pluginKey,
+ resolvedCommit: preview.resolvedCommit
+ })
+ ok = result.ok
+ // Why only on a match: other bytes than the reviewed ones wait for review on the page.
+ if (result.ok && result.consentFingerprint === preview.consentFingerprint) {
+ await window.api.plugins.consent({
+ pluginKey: preview.pluginKey,
+ reviewedFingerprint: preview.consentFingerprint,
+ decision: 'approve'
+ })
+ }
+ } catch (cause) {
+ console.warn('[plugins] reviewed update failed:', cause)
+ }
+ if (ok) {
+ setUpdated((current) => new Set([...current, entry.pluginKey]))
+ await onUpdated([entry.pluginKey])
+ }
+ setBusy(false)
+ if (ok) {
+ leaveReview()
+ return
+ }
+ setFailure(failureMessage([entry.name], updated.size))
+ }
const update = async (): Promise<void> => {
setBusy(true)
setFailure(null)
@@ -164,20 +220,28 @@ export function PluginUpdateAllDialog({
<DialogContent surface="security" scrollable aria-describedby={undefined}>
<DialogHeader>
<DialogTitle>
- {plugins.length === 1
+ {reviewing
? translate(
- 'auto.components.settings.PluginUpdateAllDialog.updateOne',
- 'Update 1 plugin'
+ 'auto.components.settings.PluginUpdateReview.title',
+ 'Review update to {{value0}}',
+ { value0: reviewing.entry.name }
)
- : translate(
- 'auto.components.settings.PluginUpdateAllDialog.updateMany',
- 'Update {{value0}} plugins',
- { value0: plugins.length }
- )}
+ : plugins.length === 1
+ ? translate(
+ 'auto.components.settings.PluginUpdateAllDialog.updateOne',
+ 'Update 1 plugin'
+ )
+ : translate(
+ 'auto.components.settings.PluginUpdateAllDialog.updateMany',
+ 'Update {{value0}} plugins',
+ { value0: plugins.length }
+ )}
</DialogTitle>
</DialogHeader>
{candidates === null ? (
<Loader2 className="mx-auto my-4 size-4 animate-spin text-muted-foreground" />
+ ) : reviewing?.preview ? (
+ <PluginUpdateReview entry={reviewing.entry} preview={reviewing.preview} />
) : (
<ul className="divide-y divide-border">
{candidates.map((candidate) => (
@@ -187,6 +251,14 @@ export function PluginUpdateAllDialog({
done={updated.has(candidate.entry.pluginKey)}
checked={installable(candidate) && !skipped.has(candidate.entry.pluginKey)}
disabled={!installable(candidate) || busy}
+ onReview={
+ needsOwnApproval(candidate)
+ ? () => {
+ setFailure(null)
+ setReviewKey(candidate.entry.pluginKey)
+ }
+ : undefined
+ }
onCheckedChange={(checked) =>
setSkipped((current) => {
const next = new Set(current)
@@ -207,19 +279,33 @@ export function PluginUpdateAllDialog({
{failure}
</p>
) : null}
- <DialogFooter>
- <Button variant="ghost" disabled={busy} onClick={onClose}>
- {updated.size > 0
- ? translate('auto.components.settings.PluginUpdateAllDialog.close', 'Close')
- : translate('auto.components.settings.PluginUpdateAllDialog.cancel', 'Cancel')}
- </Button>
- <Button disabled={busy || chosen.length === 0} onClick={() => void update()}>
- {busy ? <Loader2 className="animate-spin" /> : null}
- {failure
- ? translate('auto.components.settings.PluginUpdateAllDialog.retry', 'Try again')
- : translate('auto.components.settings.PluginUpdateAllDialog.update', 'Update')}
- </Button>
- </DialogFooter>
+ {reviewing ? (
+ <DialogFooter>
+ <Button variant="ghost" disabled={busy} onClick={leaveReview}>
+ {plugins.length === 1
+ ? translate('auto.components.settings.PluginUpdateAllDialog.cancel', 'Cancel')
+ : translate('auto.components.settings.PluginUpdateReview.back', 'Back')}
+ </Button>
+ <Button disabled={busy} onClick={() => void approveReviewed(reviewing)}>
+ {busy ? <Loader2 className="animate-spin" /> : null}
+ {translate('auto.components.settings.PluginUpdateReview.approve', 'Approve & update')}
+ </Button>
+ </DialogFooter>
+ ) : (
+ <DialogFooter>
+ <Button variant="ghost" disabled={busy} onClick={onClose}>
+ {updated.size > 0
+ ? translate('auto.components.settings.PluginUpdateAllDialog.close', 'Close')
+ : translate('auto.components.settings.PluginUpdateAllDialog.cancel', 'Cancel')}
+ </Button>
+ <Button disabled={busy || chosen.length === 0} onClick={() => void update()}>
+ {busy ? <Loader2 className="animate-spin" /> : null}
+ {failure
+ ? translate('auto.components.settings.PluginUpdateAllDialog.retry', 'Try again')
+ : translate('auto.components.settings.PluginUpdateAllDialog.update', 'Update')}
+ </Button>
+ </DialogFooter>
+ )}
</DialogContent>
</Dialog>
)
diff --git a/src/renderer/src/components/plugins/list/PluginManager.catalog.test.tsx b/src/renderer/src/components/plugins/list/PluginManager.catalog.test.tsx
index 1701e4ea5bd..a7a09ab1a2f 100644
--- a/src/renderer/src/components/plugins/list/PluginManager.catalog.test.tsx
+++ b/src/renderer/src/components/plugins/list/PluginManager.catalog.test.tsx
@@ -389,7 +389,11 @@ describe('PluginManager catalog', () => {
it('uses the shared update review for a single plugin', async () => {
installApi({
- listMarketplacePlugins: vi.fn().mockResolvedValue([{ ...listing, version: '2.0.0' }])
+ listMarketplacePlugins: vi.fn().mockResolvedValue([{ ...listing, version: '2.0.0' }]),
+ previewMarketplaceUpdate: vi.fn().mockResolvedValue({
+ ...preview,
+ accessGrowth: { capabilities: [], execution: null, contributions: [] }
+ })
})
const { onInstalled } = await render([installedPlugin()])
await act(async () => button('Update 2.0.0').click())
diff --git a/src/renderer/src/components/plugins/list/PluginsAlphaNotice.tsx b/src/renderer/src/components/plugins/list/PluginsAlphaNotice.tsx
index 98851bd101c..2afeeadb727 100644
--- a/src/renderer/src/components/plugins/list/PluginsAlphaNotice.tsx
+++ b/src/renderer/src/components/plugins/list/PluginsAlphaNotice.tsx
@@ -1,7 +1,6 @@
-import { TriangleAlert, X } from 'lucide-react'
import { translate } from '@/i18n/i18n'
import { useAppStore } from '@/store'
-import { Button } from '../../ui/button'
+import { PluginWarningBanner } from '../review/PluginWarningBanner'
/** Dismissible Alpha notice at the top of Settings > Plugins; dismissal persists in UI state. */
export function PluginsAlphaNotice(): React.JSX.Element | null {
@@ -13,31 +12,17 @@ export function PluginsAlphaNotice(): React.JSX.Element | null {
return null
}
return (
- <div
- role="note"
- className="flex items-center gap-3 rounded-xl border border-status-warning-border bg-status-warning-background py-1.5 pr-1.5 pl-4"
- >
- <TriangleAlert className="size-4 shrink-0 text-status-warning" aria-hidden="true" />
- <p className="min-w-0 flex-1 text-sm text-foreground">
- <span className="font-semibold text-status-warning-text">
- {translate('auto.components.settings.PluginsAlphaNotice.label', 'Alpha:')}
- </span>{' '}
- {translate(
- 'auto.components.settings.PluginsAlphaNotice.body',
- 'The plugin interface may change. Expect nuances.'
- )}
- </p>
- <Button
- variant="ghost"
- size="icon-sm"
- aria-label={translate(
- 'auto.components.settings.PluginsAlphaNotice.dismiss',
- 'Dismiss Alpha notice'
- )}
- onClick={dismiss}
- >
- <X />
- </Button>
- </div>
+ <PluginWarningBanner
+ label={translate('auto.components.settings.PluginsAlphaNotice.label', 'Alpha:')}
+ body={translate(
+ 'auto.components.settings.PluginsAlphaNotice.body',
+ 'The plugin interface may change. Expect nuances.'
+ )}
+ dismissLabel={translate(
+ 'auto.components.settings.PluginsAlphaNotice.dismiss',
+ 'Dismiss Alpha notice'
+ )}
+ onDismiss={dismiss}
+ />
)
}
diff --git a/src/renderer/src/components/plugins/page/PluginDetailPage.test.tsx b/src/renderer/src/components/plugins/page/PluginDetailPage.test.tsx
index 296df67e9f7..c33626014c1 100644
--- a/src/renderer/src/components/plugins/page/PluginDetailPage.test.tsx
+++ b/src/renderer/src/components/plugins/page/PluginDetailPage.test.tsx
@@ -382,4 +382,70 @@ describe('PluginDetailPage', () => {
expect(container.textContent).toContain('Minimal Icons')
expect(container.textContent).toContain('File icon theme')
})
+
+ describe('not-official warning', () => {
+ const banner = (container: HTMLElement) => container.querySelector('[data-plugin-not-official]')
+
+ it.each([
+ ['official', true, 'data', false],
+ ['official', true, 'trusted-worker', false],
+ ['community theme', false, 'data', false],
+ ['community', false, 'declarative', true],
+ ['community', false, 'trusted-worker', true]
+ ] as const)(
+ 'on a %s catalog page with profile %s: shown %s',
+ async (_kind, official, execution, shown) => {
+ const page = { ...listing, official, release: { ...listing.release!, execution } }
+ // Why never resolved: the catalog's verified profile alone decides before the manifest is read.
+ const container = await render(
+ pluginListEntryFromListing(page),
+ () => new Promise(() => {})
+ )
+ expect(banner(container) !== null).toBe(shown)
+ if (shown) {
+ expect(banner(container)?.textContent).toBe(
+ 'Not an official plugin: Make sure you trust stablyai before installing. This plugin runs the publisher’s code inside Orca.'
+ )
+ expect(banner(container)?.querySelector('button')).toBeNull()
+ }
+ }
+ )
+
+ it('keeps a one-line translations note on a community language pack page', async () => {
+ const page = {
+ ...listing,
+ official: false,
+ release: { ...listing.release!, types: ['interface-language' as const] }
+ }
+ const container = await render(pluginListEntryFromListing(page), () => new Promise(() => {}))
+ expect(banner(container)?.getAttribute('data-plugin-not-official')).toBe('translations')
+ expect(banner(container)?.textContent).toBe(
+ 'Not an official plugin: Translations can change any text in Orca. Make sure you trust stablyai.'
+ )
+ })
+
+ it.each([
+ ['an official', { official: true, execution: 'trusted-worker' as const }, false],
+ ['a community theme', { execution: 'data' as const, types: ['app-theme' as const] }, false],
+ ['a community code', { execution: 'declarative' as const }, true],
+ ['a dev folder code', { isDev: true, execution: 'sandboxed-ui' as const }, true]
+ ])('on %s installed plugin: shown %s', async (_kind, change, shown) => {
+ const container = await render(
+ pluginListEntryFromInstalled({ ...installed, ...change }),
+ vi.fn()
+ )
+ expect(banner(container) !== null).toBe(shown)
+ })
+
+ it('shows for a data claim whose installed manifest carries commands', async () => {
+ vi.mocked(window.api.plugins.getInstalledManifest).mockResolvedValue(
+ pluginManifestSchema.parse({
+ ...manifest,
+ contributes: { commands: [{ id: 'go', title: 'Go', action: 'sidebar.left.toggle' }] }
+ })
+ )
+ const container = await render(pluginListEntryFromInstalled(installed), vi.fn())
+ expect(banner(container)).not.toBeNull()
+ })
+ })
})
diff --git a/src/renderer/src/components/plugins/page/PluginDetailPage.tsx b/src/renderer/src/components/plugins/page/PluginDetailPage.tsx
index 945a4c7623c..b367544fc4e 100644
--- a/src/renderer/src/components/plugins/page/PluginDetailPage.tsx
+++ b/src/renderer/src/components/plugins/page/PluginDetailPage.tsx
@@ -16,6 +16,8 @@ import { installedPluginControls, type InstalledRowHandlers } from '../list/Plug
import { PluginChips } from '../list/PluginChips'
import type { PluginPagePreview } from '../state/use-plugin-catalog'
import type { PluginLogsState } from '../state/use-plugin-logs'
+import { pluginPublisherNotice } from '../presentation/plugin-publisher-trust'
+import { PluginNotOfficialWarning } from '../review/PluginNotOfficialWarning'
type PluginDetailPageProps = {
entry: PluginListEntry
@@ -96,6 +98,14 @@ export function PluginDetailPage({
const version = plugin?.version ?? preview?.manifest.version ?? entry.version
const description = plugin?.description ?? preview?.manifest.description ?? entry.description
+ const publisherNotice = pluginPublisherNotice({
+ official: entry.official,
+ execution: model.execution,
+ manifest: model.manifest,
+ // Why null without a release or host types: an empty list would read as "no translations".
+ types: plugin ? (plugin.types ?? null) : listing?.release ? entry.types : null
+ })
+
let alert: React.ReactNode = null
if (plugin?.blockedByKillList) {
alert = (
@@ -257,6 +267,16 @@ export function PluginDetailPage({
{controls ? controls.more : null}
</div>
</div>
+ {publisherNotice !== 'none' ? (
+ // Why above the consent: it is part of the install decision, read before the access list.
+ <div className="mt-4">
+ <PluginNotOfficialWarning
+ notice={publisherNotice}
+ publisher={entry.publisher}
+ moment={plugin ? 'installed' : 'install'}
+ />
+ </div>
+ ) : null}
{action.body}
{description ? <p className="mt-4 max-w-prose text-sm leading-6">{description}</p> : null}
{alert}
diff --git a/src/renderer/src/components/plugins/presentation/plugin-publisher-trust.test.ts b/src/renderer/src/components/plugins/presentation/plugin-publisher-trust.test.ts
new file mode 100644
index 00000000000..47548d79c8e
--- /dev/null
+++ b/src/renderer/src/components/plugins/presentation/plugin-publisher-trust.test.ts
@@ -0,0 +1,91 @@
+import { describe, expect, it } from 'vitest'
+import { pluginManifestSchema } from '../../../../../shared/plugins/manifest/plugin-manifest'
+import { isSafeContentOnlyPlugin, pluginPublisherNotice } from './plugin-publisher-trust'
+
+function manifest(extra: Record<string, unknown>) {
+ return pluginManifestSchema.parse({
+ manifestVersion: 1,
+ id: 'demo',
+ publisher: 'someone',
+ name: 'Demo',
+ version: '1.0.0',
+ engines: { orca: '>=1.0.0' },
+ pluginApi: 1,
+ ...extra
+ })
+}
+
+const theme = manifest({
+ contributes: { themes: [{ id: 'dusk', label: 'Dusk', path: 'dusk.json' }] }
+})
+
+describe('isSafeContentOnlyPlugin', () => {
+ it('is safe only for the verified data profile', () => {
+ expect(isSafeContentOnlyPlugin({ execution: 'data' })).toBe(true)
+ expect(isSafeContentOnlyPlugin({ execution: 'data', manifest: theme })).toBe(true)
+ for (const execution of ['declarative', 'sandboxed-ui', 'trusted-worker'] as const) {
+ expect(isSafeContentOnlyPlugin({ execution, manifest: theme })).toBe(false)
+ }
+ })
+
+ it('is never safe while the profile is unknown', () => {
+ expect(isSafeContentOnlyPlugin({ execution: null, manifest: theme })).toBe(false)
+ })
+
+ it.each([
+ ['a worker', { main: 'worker.js' }],
+ ['a capability', { capabilities: [{ kind: 'storage:own' }] }],
+ [
+ 'commands',
+ { contributes: { commands: [{ id: 'go', title: 'Go', action: 'sidebar.left.toggle' }] } }
+ ]
+ ])('re-derives from the manifest, so a data claim carrying %s is not safe', (_label, extra) => {
+ expect(isSafeContentOnlyPlugin({ execution: 'data', manifest: manifest(extra) })).toBe(false)
+ })
+})
+
+const languagePack = manifest({
+ contributes: {
+ languagePacks: [{ locale: 'de', path: 'de.json' }]
+ }
+})
+
+describe('pluginPublisherNotice', () => {
+ it.each([
+ [true, 'data', 'none'],
+ [true, 'trusted-worker', 'none'],
+ [false, 'data', 'none'],
+ [false, 'declarative', 'code'],
+ [false, 'sandboxed-ui', 'code'],
+ [false, 'trusted-worker', 'code'],
+ [false, null, 'code']
+ ] as const)('official %s, profile %s: %s', (official, execution, notice) => {
+ expect(pluginPublisherNotice({ official, execution, types: ['app-theme'] })).toBe(notice)
+ })
+
+ it('keeps a one-line note for a community language pack, from its manifest or its types', () => {
+ const community = { official: false, execution: 'data' as const }
+ expect(pluginPublisherNotice({ ...community, manifest: languagePack, types: null })).toBe(
+ 'translations'
+ )
+ expect(pluginPublisherNotice({ ...community, types: ['interface-language'] })).toBe(
+ 'translations'
+ )
+ expect(pluginPublisherNotice({ ...community, manifest: theme, types: null })).toBe('none')
+ // Why: nothing verified says it carries no translations yet.
+ expect(pluginPublisherNotice({ ...community, types: null })).toBe('translations')
+ expect(
+ pluginPublisherNotice({ ...community, official: true, types: ['interface-language'] })
+ ).toBe('none')
+ })
+
+ it('warns about code for a theme that also carries a panel', () => {
+ expect(
+ pluginPublisherNotice({
+ official: false,
+ execution: 'sandboxed-ui',
+ types: ['app-theme', 'panel']
+ })
+ ).toBe('code')
+ })
+})
diff --git a/src/renderer/src/components/plugins/presentation/plugin-publisher-trust.ts b/src/renderer/src/components/plugins/presentation/plugin-publisher-trust.ts
new file mode 100644
index 00000000000..fa503ba6b3d
--- /dev/null
+++ b/src/renderer/src/components/plugins/presentation/plugin-publisher-trust.ts
@@ -0,0 +1,48 @@
+import type { PluginCatalogType } from '../../../../../shared/plugins/catalog/plugin-catalog-types'
+import {
+ derivePluginExecutionProfile,
+ type PluginExecutionProfile
+} from '../../../../../shared/plugins/contributions/plugin-execution-profile'
+import type { PluginManifest } from '../../../../../shared/plugins/manifest/plugin-manifest'
+
+type PluginSafetySubject = {
+ /** Orca's verified profile (installed list entry, catalog release or preview); null while unknown. */
+ execution: PluginExecutionProfile | null
+ /** The plugin's manifest once read; its contents must derive `data` too. */
+ manifest?: Pick<PluginManifest, 'main' | 'capabilities' | 'contributes'> | null
+}
+
+/**
+ * Whether nothing the plugin ships runs or acts for you (themes, icon themes, grammars, language
+ * packs, file templates). Unknown is never safe. Tighten here only.
+ */
+export function isSafeContentOnlyPlugin({ execution, manifest }: PluginSafetySubject): boolean {
+ if (execution !== 'data') {
+ return false
+ }
+ // Why derive as well: the verified profile can be a v2 manifest's own claim.
+ return !manifest || derivePluginExecutionProfile(manifest) === 'data'
+}
+
+/** What a non-official plugin's page and approvals must say about trusting its publisher. */
+export type PluginPublisherNotice = 'none' | 'translations' | 'code'
+
+export function pluginPublisherNotice(
+ subject: PluginSafetySubject & {
+ official: boolean
+ /** Its catalog types; null when nothing verified says yet. */
+ types: readonly PluginCatalogType[] | null
+ }
+): PluginPublisherNotice {
+ if (subject.official) {
+ return 'none'
+ }
+ if (!isSafeContentOnlyPlugin(subject)) {
+ return 'code'
+ }
+ // Why translations still warn: they speak with Orca's voice and can reword any text in it.
+ const translates = subject.manifest
+ ? subject.manifest.contributes.languagePacks.length > 0
+ : (subject.types?.includes('interface-language') ?? true)
+ return translates ? 'translations' : 'none'
+}
diff --git a/src/renderer/src/components/plugins/review/PluginNotOfficialWarning.tsx b/src/renderer/src/components/plugins/review/PluginNotOfficialWarning.tsx
new file mode 100644
index 00000000000..912cb9fef79
--- /dev/null
+++ b/src/renderer/src/components/plugins/review/PluginNotOfficialWarning.tsx
@@ -0,0 +1,58 @@
+import { translate } from '@/i18n/i18n'
+import { SecuritySurface } from '../../ui/security-surface'
+import { PluginWarningBanner } from './PluginWarningBanner'
+
+/** Why no dismiss: the publisher, not Orca, vouches for this plugin every time it is shown. */
+export function PluginNotOfficialWarning({
+ notice,
+ publisher,
+ moment
+}: {
+ notice: 'translations' | 'code'
+ publisher: string | null
+ /** What the reader is about to do, which the advice names. */
+ moment: 'install' | 'installed' | 'update'
+}): React.JSX.Element {
+ const value0 =
+ publisher?.trim() ||
+ translate('auto.components.settings.PluginNotOfficialWarning.unknownPublisher', 'its publisher')
+ let body: string
+ if (notice === 'translations') {
+ body = translate(
+ 'auto.components.settings.PluginNotOfficialWarning.translations',
+ 'Translations can change any text in Orca. Make sure you trust {{value0}}.',
+ { value0 }
+ )
+ } else if (moment === 'install') {
+ body = translate(
+ 'auto.components.settings.PluginNotOfficialWarning.install',
+ 'Make sure you trust {{value0}} before installing. This plugin runs the publisher’s code inside Orca.',
+ { value0 }
+ )
+ } else if (moment === 'update') {
+ body = translate(
+ 'auto.components.settings.PluginNotOfficialWarning.update',
+ 'Make sure you trust {{value0}} before updating. This plugin runs the publisher’s code inside Orca.',
+ { value0 }
+ )
+ } else {
+ body = translate(
+ 'auto.components.settings.PluginNotOfficialWarning.installed',
+ 'Make sure you trust {{value0}}. This plugin runs the publisher’s code inside Orca.',
+ { value0 }
+ )
+ }
+ return (
+ <SecuritySurface>
+ <div data-plugin-not-official={notice}>
+ <PluginWarningBanner
+ label={translate(
+ 'auto.components.settings.PluginNotOfficialWarning.label',
+ 'Not an official plugin:'
+ )}
+ body={body}
+ />
+ </div>
+ </SecuritySurface>
+ )
+}
diff --git a/src/renderer/src/components/plugins/review/PluginUpdateCandidate.tsx b/src/renderer/src/components/plugins/review/PluginUpdateCandidate.tsx
index 58752f58c1b..c272b3dd16d 100644
--- a/src/renderer/src/components/plugins/review/PluginUpdateCandidate.tsx
+++ b/src/renderer/src/components/plugins/review/PluginUpdateCandidate.tsx
@@ -6,6 +6,7 @@ import {
reachablePluginCapabilities
} from '../../../../../shared/plugins/capabilities/plugin-capability-reach'
import type { PluginContributionPoint } from '../../../../../shared/plugins/contributions/plugin-contribution-points'
+import { pluginUpdateGrowsAccess } from '../../../../../shared/plugins/approval/plugin-update-access-growth'
import { translate } from '@/i18n/i18n'
import type { PluginListEntry } from '../list/plugin-list-entries'
import { PluginRowArt } from '../list/PluginRowArt'
@@ -37,8 +38,21 @@ export function movedFromSource(
return installed?.kind === 'marketplace' ? installed.reference : ''
}
+/**
+ * Whether the update changes what the plugin may do or where it comes from. Such an update never
+ * joins a bulk Update; it lands only from its own review. Why unknown counts: main omits growth
+ * only when it could not compare against the installed version.
+ */
+export function updateNeedsApproval(preview: PluginMarketplaceHostInstallPreview): boolean {
+ return (
+ preview.repositoryMoved === true ||
+ !preview.accessGrowth ||
+ pluginUpdateGrowsAccess(preview.accessGrowth)
+ )
+}
+
// Why the same form as main's list projection: `movedFrom` is compared against it by eye.
-const sourceLabel = (source: { url: string; path?: string }): string =>
+export const sourceLabel = (source: { url: string; path?: string }): string =>
source.path ? `${source.url} (${source.path})` : source.url
const contributionGrowthLabel = (point: PluginContributionPoint): string => {
@@ -67,7 +81,7 @@ const contributionGrowthLabel = (point: PluginContributionPoint): string => {
}
/** What main found the update adds over the installed version, as review lines. */
-function updateChanges(preview: PluginMarketplaceHostInstallPreview): {
+export function updateChanges(preview: PluginMarketplaceHostInstallPreview): {
capabilities: string[]
warnings: string[]
} {
@@ -108,7 +122,7 @@ function NewLine({ children }: { children: string }): React.JSX.Element {
}
/** Everything the update can reach, for the rare reader who wants more than what's new. */
-function AllAccess({
+export function AllAccess({
preview,
execution
}: {
@@ -166,13 +180,16 @@ export function CandidateRow({
done,
checked,
disabled,
- onCheckedChange
+ onCheckedChange,
+ onReview
}: {
candidate: UpdateCandidate
done: boolean
checked: boolean
disabled: boolean
onCheckedChange: (checked: boolean) => void
+ /** Set when the update needs its own approval; it replaces the checkbox. */
+ onReview?: () => void
}): React.JSX.Element {
const { entry, preview, error, needsOrca } = candidate
const { capabilities: requestedAdded, warnings } = preview
@@ -259,12 +276,18 @@ export function CandidateRow({
{entry.installed?.version} → {preview?.manifest.version ?? entry.updateVersion}
</span>
</label>
- <Checkbox
- id={checkboxId}
- checked={checked}
- disabled={disabled}
- onCheckedChange={(next) => onCheckedChange(next === true)}
- />
+ {onReview ? (
+ <Button variant="outline" size="xs" disabled={disabled} onClick={onReview}>
+ {translate('auto.components.settings.PluginUpdateAllDialog.review', 'Review')}
+ </Button>
+ ) : (
+ <Checkbox
+ id={checkboxId}
+ checked={checked}
+ disabled={disabled}
+ onCheckedChange={(next) => onCheckedChange(next === true)}
+ />
+ )}
</div>
{note ? <div className="mt-1 ml-10">{note}</div> : null}
</li>
diff --git a/src/renderer/src/components/plugins/review/PluginUpdateReview.tsx b/src/renderer/src/components/plugins/review/PluginUpdateReview.tsx
new file mode 100644
index 00000000000..1a4065862fe
--- /dev/null
+++ b/src/renderer/src/components/plugins/review/PluginUpdateReview.tsx
@@ -0,0 +1,148 @@
+import { ArrowRight } from 'lucide-react'
+import type { PluginMarketplaceHostInstallPreview } from '../../../../../preload/api-types'
+import { pluginExecutionProfile } from '../../../../../shared/plugins/contributions/plugin-execution-profile'
+import { reachablePluginCapabilities } from '../../../../../shared/plugins/capabilities/plugin-capability-reach'
+import { translate } from '@/i18n/i18n'
+import type { PluginListEntry } from '../list/plugin-list-entries'
+import { PluginRowArt } from '../list/PluginRowArt'
+import {
+ installedPluginTrust,
+ pluginPointsFromManifest,
+ pluginTrust
+} from '../presentation/plugin-access-profile'
+import { pluginTrustLabel } from '../presentation/plugin-consent-copy'
+import { pluginCapabilityDescription } from '../presentation/plugin-capability-presentation'
+import { pluginPublisherNotice } from '../presentation/plugin-publisher-trust'
+import { useInstalledPluginManifest } from '../state/use-plugin-contribution-source'
+import { PluginNotOfficialWarning } from './PluginNotOfficialWarning'
+import { AllAccess, movedFromSource, sourceLabel, updateChanges } from './PluginUpdateCandidate'
+
+type AccessLine = { text: string; added: boolean }
+
+function AccessColumn({
+ title,
+ lines
+}: {
+ title: string
+ lines: readonly AccessLine[]
+}): React.JSX.Element {
+ return (
+ <div className="min-w-0 space-y-1">
+ <p className="text-xs font-medium text-muted-foreground">{title}</p>
+ <ul className="space-y-1 text-sm">
+ {lines.map((line) =>
+ line.added ? (
+ <li key={line.text} data-added="" className="text-status-warning-text">
+ {translate(
+ 'auto.components.settings.PluginUpdateAllDialog.newAccess',
+ 'New: {{value0}}',
+ {
+ value0: line.text
+ }
+ )}
+ </li>
+ ) : (
+ <li key={line.text}>{line.text}</li>
+ )
+ )}
+ </ul>
+ </div>
+ )
+}
+
+/**
+ * One update that asks for more than the installed version: what it could do before, what it
+ * could do after, with every addition marked. Approving here is the only way such an update lands.
+ */
+export function PluginUpdateReview({
+ entry,
+ preview
+}: {
+ entry: PluginListEntry
+ preview: PluginMarketplaceHostInstallPreview
+}): React.JSX.Element {
+ const installed = entry.installed
+ const installedManifest = useInstalledPluginManifest(installed)
+ const execution = pluginExecutionProfile(preview.manifest)
+ const afterTrust = pluginTrust({
+ execution,
+ points: pluginPointsFromManifest(preview.manifest),
+ hasWorker: preview.manifest.main !== undefined
+ })
+ const beforeTrust = installed ? installedPluginTrust(installed, installedManifest) : null
+ const beforeLabel = beforeTrust ? pluginTrustLabel(beforeTrust) : null
+ const afterLabel = pluginTrustLabel(afterTrust)
+ // Why main's list: it compares whole grants, so a wider scope of a held kind is new too.
+ const { capabilities: grown, warnings } = updateChanges(preview)
+ const movedFrom = movedFromSource(entry, preview)
+ const notice = pluginPublisherNotice({
+ official: preview.official,
+ execution,
+ manifest: preview.manifest,
+ types: null
+ })
+
+ const before: AccessLine[] = [
+ ...(beforeLabel ? [{ text: beforeLabel, added: false }] : []),
+ ...(installed?.capabilities ?? []).map((capability) => ({
+ text: pluginCapabilityDescription(capability.kind, capability.description),
+ added: false
+ }))
+ ]
+ const after: AccessLine[] = [
+ { text: afterLabel, added: beforeLabel !== null && beforeLabel !== afterLabel },
+ ...warnings.map((text) => ({ text, added: true })),
+ ...reachablePluginCapabilities(preview.manifest.capabilities, execution).map((capability) => ({
+ text: pluginCapabilityDescription(capability.kind, capability.kind),
+ added: grown.includes(capability.kind)
+ }))
+ ]
+
+ return (
+ <div data-plugin-update-review={entry.pluginKey} className="space-y-4">
+ {notice !== 'none' ? (
+ <PluginNotOfficialWarning
+ notice={notice}
+ publisher={preview.manifest.publisher}
+ moment="update"
+ />
+ ) : null}
+ <div className="flex items-center gap-3">
+ <PluginRowArt entry={entry} />
+ <p className="min-w-0 flex-1 truncate text-sm font-medium">
+ {entry.name}
+ <span className="ml-1.5 text-xs font-normal text-muted-foreground">
+ {installed?.version} → {preview.manifest.version}
+ </span>
+ </p>
+ </div>
+ <p className="text-sm text-muted-foreground">
+ {translate(
+ 'auto.components.settings.PluginUpdateReview.explain',
+ 'This update asks for more than the version you approved. It installs only if you approve it here.'
+ )}
+ </p>
+ {movedFrom !== null ? (
+ <p className="text-sm text-status-warning-text">
+ {translate(
+ 'auto.components.settings.PluginUpdateAllDialog.sourceMoved',
+ 'New source: {{value0}} (was {{value1}})',
+ { value0: sourceLabel(preview.source), value1: movedFrom }
+ )}
+ </p>
+ ) : null}
+ <div className="grid grid-cols-[minmax(0,1fr)_auto_minmax(0,1fr)] items-start gap-3 rounded-lg border border-border bg-muted/40 p-3">
+ <AccessColumn
+ title={translate('auto.components.settings.PluginUpdateReview.before', 'Before')}
+ lines={before}
+ />
+ <ArrowRight className="mt-6 size-4 text-muted-foreground" aria-hidden="true" />
+ <AccessColumn
+ title={translate('auto.components.settings.PluginUpdateReview.after', 'After')}
+ lines={after}
+ />
+ </div>
+ <AllAccess preview={preview} execution={execution} />
+ </div>
+ )
+}
diff --git a/src/renderer/src/components/plugins/review/PluginWarningBanner.tsx b/src/renderer/src/components/plugins/review/PluginWarningBanner.tsx
new file mode 100644
index 00000000000..1132933db58
--- /dev/null
+++ b/src/renderer/src/components/plugins/review/PluginWarningBanner.tsx
@@ -0,0 +1,33 @@
+import { TriangleAlert, X } from 'lucide-react'
+import { Button } from '../../ui/button'
+
+/** The amber plugin notice: a bold lead word, then the body. Without onDismiss it cannot close. */
+export function PluginWarningBanner({
+ label,
+ body,
+ dismissLabel,
+ onDismiss
+}: {
+ label: string
+ body: string
+ dismissLabel?: string
+ onDismiss?: () => void
+}): React.JSX.Element {
+ return (
+ <div
+ role="note"
+ data-dismissible={onDismiss ? '' : undefined}
+ className="flex items-center gap-3 rounded-xl border border-status-warning-border bg-status-warning-background px-4 py-2 data-[dismissible]:py-1.5 data-[dismissible]:pr-1.5"
+ >
+ <TriangleAlert className="size-4 shrink-0 text-status-warning" aria-hidden="true" />
+ <p className="min-w-0 flex-1 text-sm text-foreground">
+ <span className="font-semibold text-status-warning-text">{label}</span> {body}
+ </p>
+ {onDismiss ? (
+ <Button variant="ghost" size="icon-sm" aria-label={dismissLabel} onClick={onDismiss}>
+ <X />
+ </Button>
+ ) : null}
+ </div>
+ )
+}
diff --git a/src/renderer/src/components/plugins/state/use-plugin-page-model.ts b/src/renderer/src/components/plugins/state/use-plugin-page-model.ts
index f2e2300adbc..91e89bc92cd 100644
--- a/src/renderer/src/components/plugins/state/use-plugin-page-model.ts
+++ b/src/renderer/src/components/plugins/state/use-plugin-page-model.ts
@@ -179,6 +179,8 @@ export function usePluginPageModel({
stale,
disarmed,
execution,
+ /** The manifest the page describes, once read. */
+ manifest: plugin ? installedManifest : shownPreview?.manifest,
trust,
capabilities,
shortcuts,
diff --git a/src/renderer/src/i18n/locales/de.json b/src/renderer/src/i18n/locales/de.json
index 7604913534b..8322cdfaa09 100644
--- a/src/renderer/src/i18n/locales/de.json
+++ b/src/renderer/src/i18n/locales/de.json
@@ -12964,6 +12964,25 @@
"windowsFailureDescription": "Benachrichtigungen für Orca in „Windows Settings“ aktivieren."
}
}
+ },
+ "PluginUpdateAllDialog": {
+ "review": "Prüfen"
+ },
+ "PluginUpdateReview": {
+ "title": "Update für {{value0}} prüfen",
+ "back": "Zurück",
+ "approve": "Genehmigen & aktualisieren",
+ "explain": "Dieses Update verlangt mehr als die Version, die du genehmigt hast. Es wird nur installiert, wenn du es hier genehmigst.",
+ "before": "Vorher",
+ "after": "Nachher"
+ },
+ "PluginNotOfficialWarning": {
+ "unknownPublisher": "seinem Herausgeber",
+ "install": "Stelle sicher, dass du {{value0}} vertraust, bevor du es installierst. Dieses Plugin führt den Code des Herausgebers in Orca aus.",
+ "update": "Stelle sicher, dass du {{value0}} vertraust, bevor du es aktualisierst. Dieses Plugin führt den Code des Herausgebers in Orca aus.",
+ "installed": "Stelle sicher, dass du {{value0}} vertraust. Dieses Plugin führt den Code des Herausgebers in Orca aus.",
+ "label": "Kein offizielles Plugin:",
+ "translations": "Übersetzungen können jeden Text in Orca ändern. Stelle sicher, dass du {{value0}} vertraust."
}
},
"right": {
diff --git a/src/renderer/src/i18n/locales/en.json b/src/renderer/src/i18n/locales/en.json
index 5fc2d3c990b..13bf2023030 100644
--- a/src/renderer/src/i18n/locales/en.json
+++ b/src/renderer/src/i18n/locales/en.json
@@ -13216,7 +13216,8 @@
"newRecipes": "Machine recipes",
"newContributions": "Features that act for you",
"allAccess": "See all access",
- "update": "Update"
+ "update": "Update",
+ "review": "Review"
},
"PluginDetailInfo": {
"previous": "Previous",
@@ -13371,6 +13372,22 @@
},
"pluginTryAction": {
"incompleteLanguage": "This language pack is too incomplete to switch to."
+ },
+ "PluginUpdateReview": {
+ "title": "Review update to {{value0}}",
+ "back": "Back",
+ "approve": "Approve & update",
+ "explain": "This update asks for more than the version you approved. It installs only if you approve it here.",
+ "before": "Before",
+ "after": "After"
+ },
+ "PluginNotOfficialWarning": {
+ "unknownPublisher": "its publisher",
+ "install": "Make sure you trust {{value0}} before installing. This plugin runs the publisher’s code inside Orca.",
+ "update": "Make sure you trust {{value0}} before updating. This plugin runs the publisher’s code inside Orca.",
+ "installed": "Make sure you trust {{value0}}. This plugin runs the publisher’s code inside Orca.",
+ "label": "Not an official plugin:",
+ "translations": "Translations can change any text in Orca. Make sure you trust {{value0}}."
}
},
"right": {
diff --git a/src/renderer/src/i18n/locales/es.json b/src/renderer/src/i18n/locales/es.json
index cc165e8b7f9..1f2bacd027c 100644
--- a/src/renderer/src/i18n/locales/es.json
+++ b/src/renderer/src/i18n/locales/es.json
@@ -12807,7 +12807,8 @@
"newRecipes": "Recetas de máquina",
"newShortcuts": "Atajos de teclado",
"sourceMoved": "Nueva fuente: {{value0}} (antes {{value1}})",
- "update": "Actualizar"
+ "update": "Actualizar",
+ "review": "Revisar"
},
"PluginDetailInfo": {
"previous": "Anterior",
@@ -12904,6 +12905,22 @@
"mod": "mod",
"shortcut": "atajo"
}
+ },
+ "PluginUpdateReview": {
+ "title": "Revisar la actualización de {{value0}}",
+ "back": "Atrás",
+ "approve": "Aprobar y actualizar",
+ "explain": "Esta actualización pide más que la versión que aprobaste. Solo se instala si la apruebas aquí.",
+ "before": "Antes",
+ "after": "Después"
+ },
+ "PluginNotOfficialWarning": {
+ "unknownPublisher": "su editor",
+ "install": "Asegúrate de que confías en {{value0}} antes de instalarlo. Este plugin ejecuta el código del editor dentro de Orca.",
+ "update": "Asegúrate de que confías en {{value0}} antes de actualizarlo. Este plugin ejecuta el código del editor dentro de Orca.",
+ "installed": "Asegúrate de que confías en {{value0}}. Este plugin ejecuta el código del editor dentro de Orca.",
+ "label": "No es un plugin oficial:",
+ "translations": "Las traducciones pueden cambiar cualquier texto de Orca. Asegúrate de que confías en {{value0}}."
}
},
"right": {
diff --git a/src/renderer/src/i18n/locales/fr.json b/src/renderer/src/i18n/locales/fr.json
index 044d41346dc..3c5f99901ea 100644
--- a/src/renderer/src/i18n/locales/fr.json
+++ b/src/renderer/src/i18n/locales/fr.json
@@ -13031,7 +13031,8 @@
"newRecipes": "Recettes de machine",
"newShortcuts": "Raccourcis clavier",
"sourceMoved": "Nouvelle source : {{value0}} (avant {{value1}})",
- "update": "Mettre à jour"
+ "update": "Mettre à jour",
+ "review": "Examiner"
},
"PluginDetailInfo": {
"previous": "Précédente",
@@ -13128,6 +13129,22 @@
"mod": "mod",
"shortcut": "raccourci"
}
+ },
+ "PluginUpdateReview": {
+ "title": "Examiner la mise à jour de {{value0}}",
+ "back": "Retour",
+ "approve": "Approuver et mettre à jour",
+ "explain": "Cette mise à jour demande plus que la version que vous avez approuvée. Elle ne s’installe que si vous l’approuvez ici.",
+ "before": "Avant",
+ "after": "Après"
+ },
+ "PluginNotOfficialWarning": {
+ "unknownPublisher": "son éditeur",
+ "install": "Assurez-vous de faire confiance à {{value0}} avant de l’installer. Ce plugin exécute le code de l’éditeur dans Orca.",
+ "update": "Assurez-vous de faire confiance à {{value0}} avant de le mettre à jour. Ce plugin exécute le code de l’éditeur dans Orca.",
+ "installed": "Assurez-vous de faire confiance à {{value0}}. Ce plugin exécute le code de l’éditeur dans Orca.",
+ "label": "Plugin non officiel :",
+ "translations": "Les traductions peuvent modifier n’importe quel texte d’Orca. Assurez-vous de faire confiance à {{value0}}."
}
},
"right": {
diff --git a/src/renderer/src/i18n/locales/ja.json b/src/renderer/src/i18n/locales/ja.json
index a0bc875d6f7..85aa9609ba2 100644
--- a/src/renderer/src/i18n/locales/ja.json
+++ b/src/renderer/src/i18n/locales/ja.json
@@ -12521,7 +12521,8 @@
"newRecipes": "マシンレシピ",
"newShortcuts": "キーボードショートカット",
"sourceMoved": "新しいソース: {{value0}} (以前: {{value1}})",
- "update": "アップデート"
+ "update": "アップデート",
+ "review": "確認"
},
"PluginDetailInfo": {
"previous": "以前のバージョン",
@@ -12618,6 +12619,22 @@
"mod": "モッド",
"shortcut": "ショートカット"
}
+ },
+ "PluginUpdateReview": {
+ "title": "{{value0}} のアップデートを確認",
+ "back": "戻る",
+ "approve": "承認してアップデート",
+ "explain": "このアップデートは、承認済みのバージョンより多くのアクセスを求めています。ここで承認した場合にのみインストールされます。",
+ "before": "変更前",
+ "after": "変更後"
+ },
+ "PluginNotOfficialWarning": {
+ "unknownPublisher": "公開元",
+ "install": "インストールする前に、{{value0}} を信頼できることを確認してください。このプラグインは公開元のコードを Orca 内で実行します。",
+ "update": "アップデートする前に、{{value0}} を信頼できることを確認してください。このプラグインは公開元のコードを Orca 内で実行します。",
+ "installed": "{{value0}} を信頼できることを確認してください。このプラグインは公開元のコードを Orca 内で実行します。",
+ "label": "公式プラグインではありません:",
+ "translations": "翻訳は Orca 内のあらゆるテキストを変更できます。{{value0}} を信頼できることを確認してください。"
}
},
"right": {
diff --git a/src/renderer/src/i18n/locales/ko.json b/src/renderer/src/i18n/locales/ko.json
index b4967b1d246..260cb30d082 100644
--- a/src/renderer/src/i18n/locales/ko.json
+++ b/src/renderer/src/i18n/locales/ko.json
@@ -12521,7 +12521,8 @@
"newRecipes": "머신 레시피",
"newShortcuts": "키보드 단축키",
"sourceMoved": "새 소스: {{value0}} (이전 {{value1}})",
- "update": "업데이트"
+ "update": "업데이트",
+ "review": "검토"
},
"PluginDetailInfo": {
"previous": "이전 버전",
@@ -12618,6 +12619,22 @@
"mod": "모드",
"shortcut": "단축키"
}
+ },
+ "PluginUpdateReview": {
+ "title": "{{value0}} 업데이트 검토",
+ "back": "뒤로",
+ "approve": "승인 후 업데이트",
+ "explain": "이 업데이트는 승인한 버전보다 더 많은 권한을 요청합니다. 여기에서 승인해야만 설치됩니다.",
+ "before": "이전",
+ "after": "이후"
+ },
+ "PluginNotOfficialWarning": {
+ "unknownPublisher": "게시자",
+ "install": "설치하기 전에 {{value0}}을(를) 신뢰할 수 있는지 확인하세요. 이 플러그인은 게시자의 코드를 Orca 안에서 실행합니다.",
+ "update": "업데이트하기 전에 {{value0}}을(를) 신뢰할 수 있는지 확인하세요. 이 플러그인은 게시자의 코드를 Orca 안에서 실행합니다.",
+ "installed": "{{value0}}을(를) 신뢰할 수 있는지 확인하세요. 이 플러그인은 게시자의 코드를 Orca 안에서 실행합니다.",
+ "label": "공식 플러그인이 아닙니다:",
+ "translations": "번역은 Orca의 모든 텍스트를 바꿀 수 있습니다. {{value0}}을(를) 신뢰할 수 있는지 확인하세요."
}
},
"right": {
diff --git a/src/renderer/src/i18n/locales/pt.json b/src/renderer/src/i18n/locales/pt.json
index b6e93a8031d..98ed8b62534 100644
--- a/src/renderer/src/i18n/locales/pt.json
+++ b/src/renderer/src/i18n/locales/pt.json
@@ -9231,7 +9231,8 @@
"newShortcuts": "Atalhos de teclado",
"previewError": "Não foi possível ler esta atualização",
"sourceMoved": "Nova fonte: {{value0}} (antes {{value1}})",
- "update": "Atualizar"
+ "update": "Atualizar",
+ "review": "Revisar"
},
"PluginThemeUseNow": {
"useForLight": "Usar no claro:",
@@ -9304,6 +9305,22 @@
"mod": "mod",
"shortcut": "atalho"
}
+ },
+ "PluginUpdateReview": {
+ "title": "Revisar a atualização de {{value0}}",
+ "back": "Voltar",
+ "approve": "Aprovar e atualizar",
+ "explain": "Esta atualização pede mais do que a versão que você aprovou. Ela só é instalada se você aprová-la aqui.",
+ "before": "Antes",
+ "after": "Depois"
+ },
+ "PluginNotOfficialWarning": {
+ "unknownPublisher": "seu editor",
+ "install": "Confirme que você confia em {{value0}} antes de instalar. Este plugin executa o código do editor dentro do Orca.",
+ "update": "Confirme que você confia em {{value0}} antes de atualizar. Este plugin executa o código do editor dentro do Orca.",
+ "installed": "Confirme que você confia em {{value0}}. Este plugin executa o código do editor dentro do Orca.",
+ "label": "Não é um plugin oficial:",
+ "translations": "Traduções podem alterar qualquer texto do Orca. Confirme que você confia em {{value0}}."
}
},
"right": {
diff --git a/src/renderer/src/i18n/locales/ru.json b/src/renderer/src/i18n/locales/ru.json
index 3584629dd50..371707b69ce 100644
--- a/src/renderer/src/i18n/locales/ru.json
+++ b/src/renderer/src/i18n/locales/ru.json
@@ -13326,6 +13326,25 @@
"windowsFailureDescription": "Включите уведомления для Orca в настройках Windows."
}
}
+ },
+ "PluginUpdateAllDialog": {
+ "review": "Проверить"
+ },
+ "PluginUpdateReview": {
+ "title": "Проверка обновления {{value0}}",
+ "back": "Назад",
+ "approve": "Одобрить и обновить",
+ "explain": "Это обновление запрашивает больше, чем одобренная вами версия. Оно установится, только если вы одобрите его здесь.",
+ "before": "До",
+ "after": "После"
+ },
+ "PluginNotOfficialWarning": {
+ "unknownPublisher": "его издателю",
+ "install": "Перед установкой убедитесь, что доверяете {{value0}}. Этот плагин выполняет код издателя внутри Orca.",
+ "update": "Перед обновлением убедитесь, что доверяете {{value0}}. Этот плагин выполняет код издателя внутри Orca.",
+ "installed": "Убедитесь, что доверяете {{value0}}. Этот плагин выполняет код издателя внутри Orca.",
+ "label": "Неофициальный плагин:",
+ "translations": "Переводы могут изменить любой текст в Orca. Убедитесь, что доверяете {{value0}}."
}
},
"right": {
diff --git a/src/renderer/src/i18n/locales/tr.json b/src/renderer/src/i18n/locales/tr.json
index 5c7912478f2..39a4b945904 100644
--- a/src/renderer/src/i18n/locales/tr.json
+++ b/src/renderer/src/i18n/locales/tr.json
@@ -12950,6 +12950,25 @@
"windowsFailureDescription": "Windows Settings bölümünde Orca için bildirimleri etkinleştirin."
}
}
+ },
+ "PluginUpdateAllDialog": {
+ "review": "İncele"
+ },
+ "PluginUpdateReview": {
+ "title": "{{value0}} güncellemesini incele",
+ "back": "Geri",
+ "approve": "Onayla ve güncelle",
+ "explain": "Bu güncelleme, onayladığınız sürümden daha fazlasını istiyor. Yalnızca burada onaylarsanız yüklenir.",
+ "before": "Önce",
+ "after": "Sonra"
+ },
+ "PluginNotOfficialWarning": {
+ "unknownPublisher": "yayıncı",
+ "install": "Yüklemeden önce {{value0}} tarafına güvendiğinizden emin olun. Bu eklenti, yayıncının kodunu Orca içinde çalıştırır.",
+ "update": "Güncellemeden önce {{value0}} tarafına güvendiğinizden emin olun. Bu eklenti, yayıncının kodunu Orca içinde çalıştırır.",
+ "installed": "{{value0}} tarafına güvendiğinizden emin olun. Bu eklenti, yayıncının kodunu Orca içinde çalıştırır.",
+ "label": "Resmi bir eklenti değil:",
+ "translations": "Çeviriler Orca içindeki her metni değiştirebilir. {{value0}} tarafına güvendiğinizden emin olun."
}
},
"right": {
diff --git a/src/renderer/src/i18n/locales/zh-Hant.json b/src/renderer/src/i18n/locales/zh-Hant.json
index 33ef048e7b8..3a99cc52d6e 100644
--- a/src/renderer/src/i18n/locales/zh-Hant.json
+++ b/src/renderer/src/i18n/locales/zh-Hant.json
@@ -12787,6 +12787,25 @@
"windowsFailureDescription": "在 Windows 的「設定」中開啟 Orca 的通知。"
}
}
+ },
+ "PluginUpdateAllDialog": {
+ "review": "檢視"
+ },
+ "PluginUpdateReview": {
+ "title": "檢視 {{value0}} 的更新",
+ "back": "返回",
+ "approve": "核准並更新",
+ "explain": "此更新要求的權限超出你已核准的版本。只有在這裡核准後才會安裝。",
+ "before": "之前",
+ "after": "之後"
+ },
+ "PluginNotOfficialWarning": {
+ "unknownPublisher": "其發布者",
+ "install": "安裝前請確認你信任 {{value0}}。此外掛會在 Orca 中執行發布者的程式碼。",
+ "update": "更新前請確認你信任 {{value0}}。此外掛會在 Orca 中執行發布者的程式碼。",
+ "installed": "請確認你信任 {{value0}}。此外掛會在 Orca 中執行發布者的程式碼。",
+ "label": "非官方外掛:",
+ "translations": "翻譯可以變更 Orca 中的任何文字。請確認你信任 {{value0}}。"
}
},
"right": {
diff --git a/src/renderer/src/i18n/locales/zh.json b/src/renderer/src/i18n/locales/zh.json
index f6e387828fd..7e04cba9aaf 100644
--- a/src/renderer/src/i18n/locales/zh.json
+++ b/src/renderer/src/i18n/locales/zh.json
@@ -12554,7 +12554,8 @@
"newRecipes": "机器配方",
"newShortcuts": "键盘快捷键",
"sourceMoved": "新来源:{{value0}}(原为 {{value1}})",
- "update": "更新"
+ "update": "更新",
+ "review": "查看"
},
"PluginDetailInfo": {
"previous": "上一版本",
@@ -12618,6 +12619,22 @@
"windowsFailureDescription": "请在 Windows 设置中为 Orca 开启通知。"
}
}
+ },
+ "PluginUpdateReview": {
+ "title": "查看 {{value0}} 的更新",
+ "back": "返回",
+ "approve": "批准并更新",
+ "explain": "此更新请求的权限超出了你已批准的版本。只有在这里批准后才会安装。",
+ "before": "之前",
+ "after": "之后"
+ },
+ "PluginNotOfficialWarning": {
+ "unknownPublisher": "其发布者",
+ "install": "安装前请确认你信任 {{value0}}。此插件会在 Orca 中运行发布者的代码。",
+ "update": "更新前请确认你信任 {{value0}}。此插件会在 Orca 中运行发布者的代码。",
+ "installed": "请确认你信任 {{value0}}。此插件会在 Orca 中运行发布者的代码。",
+ "label": "非官方插件:",
+ "translations": "翻译可以更改 Orca 中的任何文字。请确认你信任 {{value0}}。"
}
},
"right": {