Skip to content

Take control over your live stream video by running it yourself. Streaming + chat out of the box.

Block Private URLs at `serverurl` API endpoint (#3295)

Shreyas23ad3f4e373f
diff --git a/controllers/admin/config.go b/controllers/admin/config.go
index feebd6d2c5..5fd78e7df2 100644
--- a/controllers/admin/config.go
+++ b/controllers/admin/config.go
@@ -5,6 +5,7 @@ import (
"fmt"
"net"
"net/http"
+ "net/netip"
"os"
"path/filepath"
"reflect"
@@ -406,6 +407,14 @@ func SetServerURL(w http.ResponseWriter, r *http.Request) {
return
}
+ // Block Private IP URLs
+ ipAddr, ipErr := netip.ParseAddr(utils.GetHostnameWithoutPortFromURLString(rawValue))
+
+ if ipErr == nil && ipAddr.IsPrivate() {
+ controllers.WriteSimpleResponse(w, false, "Server URL cannot be private")
+ return
+ }
+
// Trim any trailing slash
serverURL := strings.TrimRight(rawValue, "/")
diff --git a/utils/utils.go b/utils/utils.go
index b6f1b79ac4..2a51c367a5 100644
--- a/utils/utils.go
+++ b/utils/utils.go
@@ -379,6 +379,16 @@ func GetHostnameFromURLString(s string) string {
return u.Host
}
+// GetHostnameWithoutPortFromURLString will return the hostname component without the port from a URL object.
+func GetHostnameWithoutPortFromURLString(s string) string {
+ u, err := url.Parse(s)
+ if err != nil {
+ return ""
+ }
+
+ return u.Hostname()
+}
+
// GetHashtagsFromText returns all the #Hashtags from a string.
func GetHashtagsFromText(text string) []string {
re := regexp.MustCompile(`#[a-zA-Z0-9_]+`)