Skip to content

Take control over your live stream video by running it yourself. Streaming + chat out of the box.

fix: consolidate browser notification learn more text into single localized string (#4716)

John Costaa0a3d35a05dc
diff --git a/web/components/modals/BrowserNotifyModal/BrowserNotifyModal.tsx b/web/components/modals/BrowserNotifyModal/BrowserNotifyModal.tsx
index 6dd2f7160b..e9fb2621c5 100644
--- a/web/components/modals/BrowserNotifyModal/BrowserNotifyModal.tsx
+++ b/web/components/modals/BrowserNotifyModal/BrowserNotifyModal.tsx
@@ -282,15 +282,10 @@ export const BrowserNotifyModal = () => {
translationKey={Localization.Frontend.BrowserNotifyModal.mainDescription}
defaultText="Get notified right in the browser each time this stream goes live."
/>
- <span>
- <a href="https://owncast.online/docs/notifications/#browser-notifications">
- <Translation
- translationKey={Localization.Frontend.BrowserNotifyModal.learnMore}
- defaultText="Learn more"
- />
- </a>
- &nbsp; about Owncast browser notifications.
- </span>
+ <Translation
+ translationKey={Localization.Frontend.BrowserNotifyModal.learnMoreAboutNotifications}
+ defaultText="<a href='https://owncast.online/docs/notifications/#browser-notifications'>Learn more</a> about Owncast browser notifications."
+ />
</Row>
<Row>
{error && (
diff --git a/web/types/localization.ts b/web/types/localization.ts
index f30c9a3a38..b3a50c258f 100644
--- a/web/types/localization.ts
+++ b/web/types/localization.ts
@@ -68,7 +68,8 @@ export const Localization = {
deniedTitle: 'Frontend.BrowserNotifyModal.deniedTitle',
deniedDescription: 'Frontend.BrowserNotifyModal.deniedDescription',
mainDescription: 'Frontend.BrowserNotifyModal.mainDescription',
- learnMore: 'Frontend.BrowserNotifyModal.learnMore',
+ learnMoreAboutNotifications:
+ 'Frontend.BrowserNotifyModal.learnMoreAboutNotifications',
errorTitle: 'Frontend.BrowserNotifyModal.errorTitle',
errorMessage: 'Frontend.BrowserNotifyModal.errorMessage',
},