Skip to content

Take control over your live stream video by running it yourself. Streaming + chat out of the box.

chore: add shellcheck to pre-commit hooks

Gabe Kangasf3a1b175cd06
diff --git a/Makefile b/Makefile
index fdaf36587d..fe8469a2c2 100644
--- a/Makefile
+++ b/Makefile
@@ -7,11 +7,12 @@ GOLANGCI_LINT := $(GOBIN)/golangci-lint
GOFUMPT := $(GOBIN)/gofumpt
SQLC := $(GOBIN)/sqlc
OAPI_CODEGEN := $(GOBIN)/oapi-codegen
+SHELLCHECK := $(GOBIN)/shellcheck
.PHONY: install-tools install-hooks lint fmt sqlc api-generate build test clean
## Install all development tools to ./bin
-install-tools: $(LEFTHOOK) $(GOLANGCI_LINT) $(GOFUMPT) $(SQLC) $(OAPI_CODEGEN)
+install-tools: $(LEFTHOOK) $(GOLANGCI_LINT) $(GOFUMPT) $(SQLC) $(OAPI_CODEGEN) $(SHELLCHECK)
$(LEFTHOOK):
GOBIN=$(GOBIN) go install -C tools github.com/evilmartians/lefthook
@@ -28,6 +29,9 @@ $(SQLC):
$(OAPI_CODEGEN):
GOBIN=$(GOBIN) go install -C tools github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen
+$(SHELLCHECK):
+ GOBIN=$(GOBIN) go install -C tools github.com/wasilibs/go-shellcheck/cmd/shellcheck
+
## Install git hooks using lefthook
install-hooks: $(LEFTHOOK)
$(LEFTHOOK) install --force
diff --git a/lefthook.yml b/lefthook.yml
index bdd7bd8fa7..19929ebb37 100644
--- a/lefthook.yml
+++ b/lefthook.yml
@@ -56,6 +56,9 @@ pre-commit:
go-test:
glob: '*.go'
run: go test ./... > /dev/null
+ shellcheck:
+ glob: '*.sh'
+ run: ./bin/shellcheck {staged_files}
js-test:
glob: '*.{js,ts,jsx}'
root: web/
diff --git a/tools/go.mod b/tools/go.mod
index 044eb8ca14..d658803bec 100644
--- a/tools/go.mod
+++ b/tools/go.mod
@@ -258,6 +258,7 @@ require (
github.com/uudashr/iface v1.4.2 // indirect
github.com/vmware-labs/yaml-jsonpath v0.3.2 // indirect
github.com/wasilibs/go-pgquery v0.0.0-20250409022910-10ac41983c07 // indirect
+ github.com/wasilibs/go-shellcheck v0.11.1 // indirect
github.com/wasilibs/wazero-helpers v0.0.0-20240620070341-3dff1577cd52 // indirect
github.com/woodsbury/decimal128 v1.4.0 // indirect
github.com/xen0n/gosmopolitan v1.3.0 // indirect
diff --git a/tools/go.sum b/tools/go.sum
index 5dcfeb6894..9e336a24f1 100644
--- a/tools/go.sum
+++ b/tools/go.sum
@@ -767,6 +767,8 @@ github.com/vmware-labs/yaml-jsonpath v0.3.2 h1:/5QKeCBGdsInyDCyVNLbXyilb61MXGi9N
github.com/vmware-labs/yaml-jsonpath v0.3.2/go.mod h1:U6whw1z03QyqgWdgXxvVnQ90zN1BWz5V+51Ewf8k+rQ=
github.com/wasilibs/go-pgquery v0.0.0-20250409022910-10ac41983c07 h1:mJdDDPblDfPe7z7go8Dvv1AJQDI3eQ/5xith3q2mFlo=
github.com/wasilibs/go-pgquery v0.0.0-20250409022910-10ac41983c07/go.mod h1:Ak17IJ037caFp4jpCw/iQQ7/W74Sqpb1YuKJU6HTKfM=
+github.com/wasilibs/go-shellcheck v0.11.1 h1:NAjeqVHmbw/odOZEK5X+jfRDEi9PRF+LDRaFojG5WnE=
+github.com/wasilibs/go-shellcheck v0.11.1/go.mod h1:XPrw/7RvXwvcdDG55c5wj9xSWF7AGkZO2GBlBHyAULo=
github.com/wasilibs/wazero-helpers v0.0.0-20240620070341-3dff1577cd52 h1:OvLBa8SqJnZ6P+mjlzc2K7PM22rRUPE1x32G9DTPrC4=
github.com/wasilibs/wazero-helpers v0.0.0-20240620070341-3dff1577cd52/go.mod h1:jMeV4Vpbi8osrE/pKUxRZkVaA0EX7NZN0A9/oRzgpgY=
github.com/woodsbury/decimal128 v1.4.0 h1:xJATj7lLu4f2oObouMt2tgGiElE5gO6mSWUjQsBgUlc=
diff --git a/tools/tools.go b/tools/tools.go
index 2485672d3b..470f7680ff 100644
--- a/tools/tools.go
+++ b/tools/tools.go
@@ -21,5 +21,6 @@ import (
_ "github.com/golangci/golangci-lint/v2/cmd/golangci-lint"
_ "github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen"
_ "github.com/sqlc-dev/sqlc/cmd/sqlc"
+ _ "github.com/wasilibs/go-shellcheck/cmd/shellcheck"
_ "mvdan.cc/gofumpt"
)