The open-source app everyone uses to manage agents at work
TypeScript acpxagent-orchestrationagent-skillsagentic-aiai-agentsai-engineeringai-governanceai-toolsautonomous-agentsclaudeclaude-codeclaude-skillscodexhermesllmmcpmulti-agentopenclawproject-managementworkflow-automation
fix(ci): overlap preview migrator publication waits (#13454)
Devin Foley058c55bf8f9b
diff --git a/doc/preview-release-artifacts.md b/doc/preview-release-artifacts.mdindex d7a5fe5279..3ffec98887 100644--- a/doc/preview-release-artifacts.md+++ b/doc/preview-release-artifacts.md@@ -37,6 +37,12 @@ or existing package identity mismatches fail the workflow. Retries reuse matchinpublished artifacts, including a shared package published before a DB publishfailure. Allow npm's visibility polling to finish before retrying.+The publisher validates both package archives first, then submits each missing+package without waiting for the other to become visible. One visibility poll+checks both accepted packages, so their registry propagation delays overlap.+The publisher succeeds only after both packages pass the identity and+distribution-pin checks. A visibility timeout names the package still missing.+The final `stack-deploy-result` artifact contains `result.json` with contractversion 1, request ID, SHA, stage `build`, and status `ready`. It expires after30 days. This confirms artifact availability; it does not certify a tenant deploy.diff --git a/scripts/preview-artifacts.mjs b/scripts/preview-artifacts.mjsindex 6a6eff6fb2..3eeb68996e 100644--- a/scripts/preview-artifacts.mjs+++ b/scripts/preview-artifacts.mjs@@ -165,22 +165,35 @@ export function packPreview(source, output, sha, { exec = execFileSync } = {}) {}export async function publishPreview(dir, sha, { fetchImpl = fetch, exec = execFileSync, sleep = (ms) => new Promise((r) => setTimeout(r, ms)) } = {}) {- for (const short of ["shared", "db"]) {+ // Validate the entire pair before publishing either immutable package.+ const packages = ["shared", "db"].map((short) => {const name = `@paperclipai/${short}`;const file = path.resolve(dir, `${short}.tgz`);const bytes = readFileSync(file);assertMetadata(tarManifest(bytes), name, sha);+ return { name, file, bytes };+ });+ const pending = new Set();+ for (const { name, file, bytes } of packages) {if (await packageExists(name, sha, fetchImpl)) { console.log(`Reusing ${name}@${versionFor(sha)}`); continue; }console.log(`Publishing ${name}@${versionFor(sha)} (${createHash("sha256").update(bytes).digest("hex").slice(0, 12)})`);// No package checkout, lifecycle scripts, npmrc, or branch code runs here.exec("npm", ["publish", file, "--tag", "preview", "--access", "public", "--ignore-scripts", "--provenance", "--registry", "https://registry.npmjs.org"], { stdio: "inherit" });- let published = false;- for (let attempt = 0; attempt < 60; attempt++) {- if (await packageExists(name, sha, fetchImpl)) { published = true; break; }- await sleep(10_000);+ pending.add(name);+ }+ // npm accepts a package without resolving its dependencies. Submit both+ // packages before waiting so their registry propagation can overlap.+ for (let attempt = 0; pending.size && attempt < 60; attempt++) {+ const checks = await Promise.all([...pending].map(async (name) => ({ name, visible: await packageExists(name, sha, fetchImpl) })));+ for (const { name, visible } of checks) {+ if (visible) {+ pending.delete(name);+ console.log(`Visible ${name}@${versionFor(sha)}`);+ }}- if (!published) throw new Error("npm accepted the preview but it is not yet visible. Retry reuses published packages.");+ if (pending.size) await sleep(10_000);}+ if (pending.size) throw new Error(`npm accepted the preview but it is not yet visible: ${[...pending].join(", ")}. Retry reuses published packages.`);}if (process.argv[1] && import.meta.url === pathToFileURL(process.argv[1]).href) {diff --git a/scripts/preview-artifacts.test.mjs b/scripts/preview-artifacts.test.mjsindex ebdd9a6122..711423533f 100644--- a/scripts/preview-artifacts.test.mjs+++ b/scripts/preview-artifacts.test.mjs@@ -97,6 +97,59 @@ test("publishing reuses existing previews and never executes package lifecycle h} finally { rmSync(dir, { recursive: true, force: true }); }});+test("publishing submits both packages before waiting for either to propagate", async () => {+ const dir = mkdtempSync(path.join(tmpdir(), "preview-publish-overlap-"));+ const submitted = [];+ let polls = 0;+ try {+ for (const short of ["shared", "db"]) writeFileSync(path.join(dir, `${short}.tgz`), pack(manifest(`@paperclipai/${short}`)));+ await publishPreview(dir, sha, {+ exec: (_command, args) => submitted.push(path.basename(args[1], ".tgz")),+ fetchImpl: async (url) => {+ const name = decodeURIComponent(new URL(url).pathname.split("/")[1]);+ // Both packages become visible after the first shared visibility wait.+ return submitted.length === 2 && polls > 0+ ? json({ ...manifest(name), dist: { integrity: "test-integrity", tarball: "https://registry.npmjs.org/package.tgz" } })+ : json({}, 404);+ },+ sleep: async () => { assert.deepEqual(submitted, ["shared", "db"]); polls++; },+ });+ assert.deepEqual(submitted, ["shared", "db"]);+ assert.equal(polls, 1);+ } finally { rmSync(dir, { recursive: true, force: true }); }+});++test("a visibility timeout identifies the missing package after both were submitted", async () => {+ const dir = mkdtempSync(path.join(tmpdir(), "preview-publish-timeout-"));+ const submitted = [];+ try {+ for (const short of ["shared", "db"]) writeFileSync(path.join(dir, `${short}.tgz`), pack(manifest(`@paperclipai/${short}`)));+ await assert.rejects(publishPreview(dir, sha, {+ exec: (_command, args) => submitted.push(path.basename(args[1], ".tgz")),+ fetchImpl: async (url) => {+ const name = decodeURIComponent(new URL(url).pathname.split("/")[1]);+ return name === "@paperclipai/db" && submitted.includes("db")+ ? json({ ...manifest(name), dist: { integrity: "test-integrity", tarball: "https://registry.npmjs.org/package.tgz" } })+ : json({}, 404);+ },+ sleep: async () => {},+ }), /not yet visible: @paperclipai\/shared\./);+ assert.deepEqual(submitted, ["shared", "db"]);+ } finally { rmSync(dir, { recursive: true, force: true }); }+});++test("invalid DB package metadata prevents publication of either package", async () => {+ const dir = mkdtempSync(path.join(tmpdir(), "preview-publish-invalid-"));+ try {+ writeFileSync(path.join(dir, "shared.tgz"), pack(manifest("@paperclipai/shared")));+ writeFileSync(path.join(dir, "db.tgz"), pack({ ...manifest("@paperclipai/db"), gitHead: "b".repeat(40) }));+ await assert.rejects(publishPreview(dir, sha, {+ exec: () => assert.fail("Invalid package pairs must not be published"),+ fetchImpl: async () => assert.fail("Validate the pair before registry requests"),+ }), /identity or dependency pin mismatch/);+ } finally { rmSync(dir, { recursive: true, force: true }); }+});+test("preview workflow separates branch compilation from trusted publishing", () => {const workflow = readFileSync(new URL("../.github/workflows/release.yml", import.meta.url), "utf8");const builder = workflow.split(" package_preview:")[1].split(" publish_preview:")[0];