Skip to content

The open-source app everyone uses to manage agents at work

[codex] Fix sub-issue progress summary styling (#4588)

Dotta53396f272afb
diff --git a/ui/src/components/IssuesList.test.tsx b/ui/src/components/IssuesList.test.tsx
index 0d6d335896..ba615dc2b2 100644
--- a/ui/src/components/IssuesList.test.tsx
+++ b/ui/src/components/IssuesList.test.tsx
@@ -567,13 +567,14 @@ describe("IssuesList", () => {
});
});
- it("hides the sub-issue progress summary unless it is enabled and populated", async () => {
+ it("hides the sub-issue progress summary unless it is enabled with multiple sub-issues", async () => {
const { root } = renderWithQueryClient(
<IssuesList
issues={[createIssue()]}
agents={[]}
projects={[]}
viewStateKey="paperclip:test-issues"
+ showProgressSummary
onUpdateIssue={() => undefined}
/>,
container,
diff --git a/ui/src/components/IssuesList.tsx b/ui/src/components/IssuesList.tsx
index 48a413a75e..cce4e50273 100644
--- a/ui/src/components/IssuesList.tsx
+++ b/ui/src/components/IssuesList.tsx
@@ -390,7 +390,7 @@ function SubIssueProgressSummaryStrip({
.filter((entry) => entry.count > 0);
return (
- <div className="rounded-md border border-border bg-muted/20 p-3">
+ <div className="border border-border bg-background p-3">
<div className="flex flex-col gap-3 lg:flex-row lg:items-center lg:justify-between">
<div className="min-w-0 flex-1 space-y-2">
<div className="flex flex-wrap items-center gap-x-4 gap-y-1 text-sm">
@@ -424,7 +424,7 @@ function SubIssueProgressSummaryStrip({
</div>
</div>
- <div className="min-w-0 rounded-md border border-border bg-background px-3 py-2 text-sm lg:w-72">
+ <div className="min-w-0 border border-border bg-background px-3 py-2 text-sm lg:w-72">
{target && targetIssue ? (
<>
<div className="text-xs font-medium text-muted-foreground">
diff --git a/ui/src/lib/issue-detail-subissues.test.ts b/ui/src/lib/issue-detail-subissues.test.ts
index 586226ba89..611e677bd4 100644
--- a/ui/src/lib/issue-detail-subissues.test.ts
+++ b/ui/src/lib/issue-detail-subissues.test.ts
@@ -39,8 +39,9 @@ describe("shouldRenderRichSubIssuesSection", () => {
});
describe("shouldRenderSubIssueProgressSummary", () => {
- it("requires both the opt-in flag and child issues", () => {
- expect(shouldRenderSubIssueProgressSummary(true, 1)).toBe(true);
+ it("requires both the opt-in flag and multiple child issues", () => {
+ expect(shouldRenderSubIssueProgressSummary(true, 2)).toBe(true);
+ expect(shouldRenderSubIssueProgressSummary(true, 1)).toBe(false);
expect(shouldRenderSubIssueProgressSummary(false, 1)).toBe(false);
expect(shouldRenderSubIssueProgressSummary(true, 0)).toBe(false);
});
diff --git a/ui/src/lib/issue-detail-subissues.ts b/ui/src/lib/issue-detail-subissues.ts
index 3bd3174ad6..379ca8c1cd 100644
--- a/ui/src/lib/issue-detail-subissues.ts
+++ b/ui/src/lib/issue-detail-subissues.ts
@@ -21,8 +21,10 @@ export function shouldRenderRichSubIssuesSection(childIssuesLoading: boolean, ch
return childIssuesLoading || childIssueCount > 0;
}
+const MIN_CHILD_ISSUES_FOR_PROGRESS_SUMMARY = 2;
+
export function shouldRenderSubIssueProgressSummary(enabled: boolean | undefined, childIssueCount: number): boolean {
- return enabled === true && childIssueCount > 0;
+ return enabled === true && childIssueCount >= MIN_CHILD_ISSUES_FOR_PROGRESS_SUMMARY;
}
export function buildSubIssueProgressSummary(issues: Issue[]): SubIssueProgressSummary {