The open-source app everyone uses to manage agents at work
TypeScript acpxagent-orchestrationagent-skillsagentic-aiai-agentsai-engineeringai-governanceai-toolsautonomous-agentsclaudeclaude-codeclaude-skillscodexhermesllmmcpmulti-agentopenclawproject-managementworkflow-automation
Gate stale-run watchdog decisions by board access (#4446)
Dotta73fbdf36db15
diff --git a/packages/shared/src/types/heartbeat.ts b/packages/shared/src/types/heartbeat.tsindex 5aee87af5e..973d5d6c65 100644--- a/packages/shared/src/types/heartbeat.ts+++ b/packages/shared/src/types/heartbeat.ts@@ -77,6 +77,7 @@ export interface HeartbeatRunOutputSilence {snoozedUntil: Date | string | null;evaluationIssueId: string | null;evaluationIssueIdentifier: string | null;+ evaluationIssueAssigneeAgentId: string | null;}export interface AgentWakeupSkipped {diff --git a/server/src/routes/access.ts b/server/src/routes/access.tsindex 3df49fd6db..44acab90df 100644--- a/server/src/routes/access.ts+++ b/server/src/routes/access.ts@@ -2617,6 +2617,7 @@ export function accessRoutes(userId: req.actor.userId,isInstanceAdmin: accessSnapshot.isInstanceAdmin,companyIds: accessSnapshot.companyIds,+ memberships: accessSnapshot.memberships,source: req.actor.source ?? "none",keyId: req.actor.source === "board_key" ? req.actor.keyId ?? null : null,});diff --git a/server/src/services/recovery/service.ts b/server/src/services/recovery/service.tsindex f2c2f58d79..f20dd05915 100644--- a/server/src/services/recovery/service.ts+++ b/server/src/services/recovery/service.ts@@ -82,6 +82,7 @@ export type RunOutputSilenceSummary = {snoozedUntil: Date | null;evaluationIssueId: string | null;evaluationIssueIdentifier: string | null;+ evaluationIssueAssigneeAgentId: string | null;};function readNonEmptyString(value: unknown): string | null {@@ -590,6 +591,7 @@ export function recoveryService(db: Db, deps: { enqueueWakeup: RecoveryWakeup })snoozedUntil: quietUntilDecision?.snoozedUntil ?? null,evaluationIssueId: evaluation?.id ?? null,evaluationIssueIdentifier: evaluation?.identifier ?? null,+ evaluationIssueAssigneeAgentId: evaluation?.assigneeAgentId ?? null,};}diff --git a/ui/src/api/access.ts b/ui/src/api/access.tsindex c8f83134e7..b5b68946c0 100644--- a/ui/src/api/access.ts+++ b/ui/src/api/access.ts@@ -238,6 +238,11 @@ export type CurrentBoardAccess = {userId: string;isInstanceAdmin: boolean;companyIds: string[];+ memberships?: Array<{+ companyId: string;+ membershipRole: HumanCompanyRole | "member" | null;+ status: "pending" | "active" | "suspended" | "archived";+ }>;source: string;keyId: string | null;};diff --git a/ui/src/components/IssueRunLedger.test.tsx b/ui/src/components/IssueRunLedger.test.tsxindex adefcf4fd0..7ab4bf1c84 100644--- a/ui/src/components/IssueRunLedger.test.tsx+++ b/ui/src/components/IssueRunLedger.test.tsx@@ -124,6 +124,7 @@ function createActiveRun(overrides: Partial<ActiveRunForIssue> = {}): ActiveRunFsnoozedUntil: null,evaluationIssueId: "issue-eval-1",evaluationIssueIdentifier: "PAP-404",+ evaluationIssueAssigneeAgentId: "agent-owner",},...overrides,};@@ -139,6 +140,8 @@ function renderLedger(props: Partial<ComponentProps<typeof IssueRunLedgerContentchildIssues={props.childIssues ?? []}agentMap={props.agentMap ?? new Map([["agent-1", { name: "CodexCoder" }]])}pendingWatchdogDecision={props.pendingWatchdogDecision}+ canRecordWatchdogDecisions={props.canRecordWatchdogDecisions}+ watchdogDecisionError={props.watchdogDecisionError}onWatchdogDecision={props.onWatchdogDecision}/>,);@@ -366,4 +369,22 @@ describe("IssueRunLedger", () => {evaluationIssueId: "issue-eval-1",});});++ it("hides watchdog decision actions for known non-owner viewers", () => {+ const onWatchdogDecision = vi.fn();+ renderLedger({+ runs: [createRun({ runId: "run-live-1", status: "running", finishedAt: null })],+ activeRun: createActiveRun(),+ canRecordWatchdogDecisions: false,+ onWatchdogDecision,+ });++ expect(container.textContent).toContain("Stale-run watchdog alert");+ expect(container.textContent).toContain("PAP-404");+ expect(container.textContent).not.toContain("Continue monitoring");+ expect(container.textContent).not.toContain("Snooze 1h");+ expect(container.textContent).not.toContain("Mark false positive");+ expect(container.querySelectorAll("button")).toHaveLength(0);+ expect(onWatchdogDecision).not.toHaveBeenCalled();+ });});diff --git a/ui/src/components/IssueRunLedger.tsx b/ui/src/components/IssueRunLedger.tsxindex 54ceaf0a79..45f9bc2671 100644--- a/ui/src/components/IssueRunLedger.tsx+++ b/ui/src/components/IssueRunLedger.tsx@@ -1,14 +1,17 @@-import { useMemo } from "react";+import { useMemo, useState } from "react";import type { Issue, Agent } from "@paperclipai/shared";import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";import { Link } from "@/lib/router";+import { accessApi, type CurrentBoardAccess } from "../api/access";import { activityApi, type RunForIssue, type RunLivenessState } from "../api/activity";+import { ApiError } from "../api/client";import {heartbeatsApi,type ActiveRunForIssue,type LiveRunForIssue,type WatchdogDecisionInput,} from "../api/heartbeats";+import { useToastActions } from "../context/ToastContext";import { cn, relativeTime } from "../lib/utils";import { queryKeys } from "../lib/queryKeys";import { keepPreviousDataForSameQueryTail } from "../lib/query-placeholder-data";@@ -16,6 +19,7 @@ import { describeRunRetryState } from "../lib/runRetryState";type IssueRunLedgerProps = {issueId: string;+ companyId: string;issueStatus: Issue["status"];childIssues: Issue[];agentMap: ReadonlyMap<string, Agent>;@@ -30,6 +34,8 @@ type IssueRunLedgerContentProps = {childIssues: Issue[];agentMap: ReadonlyMap<string, Pick<Agent, "name">>;pendingWatchdogDecision?: WatchdogDecisionInput["decision"] | null;+ canRecordWatchdogDecisions?: boolean;+ watchdogDecisionError?: string | null;onWatchdogDecision?: (input: WatchdogDecisionInput) => void;};@@ -309,14 +315,45 @@ function formatSilenceAge(ms: number | null | undefined) {return `${hours}h ${minutes}m`;}+function canBoardRecordWatchdogDecision(+ companyId: string,+ boardAccess: CurrentBoardAccess | undefined,+) {+ if (!boardAccess) return false;+ if (boardAccess.source === "local_implicit" || boardAccess.isInstanceAdmin) return true;++ const membership = boardAccess.memberships?.find(+ (item) => item.companyId === companyId && item.status === "active",+ );+ if (!membership) return boardAccess.companyIds.includes(companyId) && !boardAccess.memberships;+ return membership.membershipRole !== "viewer" && membership.membershipRole !== null;+}++function watchdogDecisionErrorMessage(error: unknown) {+ if (error instanceof ApiError && error.status === 403) {+ return "Only the board or the assigned recovery owner can record watchdog decisions";+ }+ return error instanceof Error && error.message.trim().length > 0+ ? error.message+ : "Paperclip could not record the watchdog decision.";+}+export function IssueRunLedger({issueId,+ companyId,issueStatus,childIssues,agentMap,hasLiveRuns,}: IssueRunLedgerProps) {const queryClient = useQueryClient();+ const { pushToast } = useToastActions();+ const [watchdogDecisionError, setWatchdogDecisionError] = useState<string | null>(null);+ const { data: boardAccess } = useQuery({+ queryKey: queryKeys.access.currentBoardAccess,+ queryFn: () => accessApi.getCurrentBoardAccess(),+ retry: false,+ });const { data: runs } = useQuery({queryKey: queryKeys.issues.runs(issueId),queryFn: () => activityApi.runsForIssue(issueId),@@ -339,10 +376,25 @@ export function IssueRunLedger({});const watchdogDecision = useMutation({mutationFn: (input: WatchdogDecisionInput) => heartbeatsApi.recordWatchdogDecision(input),+ onMutate: () => {+ setWatchdogDecisionError(null);+ },onSuccess: () => {+ setWatchdogDecisionError(null);queryClient.invalidateQueries({ queryKey: queryKeys.issues.activeRun(issueId) });queryClient.invalidateQueries({ queryKey: queryKeys.issues.liveRuns(issueId) });},+ onError: (error) => {+ const message = watchdogDecisionErrorMessage(error);+ const dedupeSuffix = error instanceof ApiError ? String(error.status) : "error";+ setWatchdogDecisionError(message);+ pushToast({+ title: "Watchdog decision not recorded",+ body: message,+ tone: "error",+ dedupeKey: `watchdog-decision:${issueId}:${dedupeSuffix}`,+ });+ },});return (@@ -354,6 +406,8 @@ export function IssueRunLedger({childIssues={childIssues}agentMap={agentMap}pendingWatchdogDecision={watchdogDecision.variables?.decision ?? null}+ canRecordWatchdogDecisions={canBoardRecordWatchdogDecision(companyId, boardAccess)}+ watchdogDecisionError={watchdogDecisionError}onWatchdogDecision={(input) => watchdogDecision.mutate(input)}/>);@@ -367,6 +421,8 @@ export function IssueRunLedgerContent({childIssues,agentMap,pendingWatchdogDecision,+ canRecordWatchdogDecisions = true,+ watchdogDecisionError,onWatchdogDecision,}: IssueRunLedgerContentProps) {const ledgerRuns = useMemo(() => mergeRuns(runs, liveRuns, activeRun), [activeRun, liveRuns, runs]);@@ -468,7 +524,7 @@ export function IssueRunLedgerContent({</>) : null}</p>- {onWatchdogDecision ? (+ {onWatchdogDecision && canRecordWatchdogDecisions ? (<div className="mt-2 flex flex-wrap gap-1.5"><buttontype="button"@@ -514,6 +570,11 @@ export function IssueRunLedgerContent({</button></div>) : null}+ {watchdogDecisionError ? (+ <p className="mt-2 rounded-md border border-red-500/30 bg-red-500/10 px-2 py-1 text-[11px] text-red-900 dark:text-red-200">+ {watchdogDecisionError}+ </p>+ ) : null}</div>) : null}diff --git a/ui/src/pages/IssueDetail.tsx b/ui/src/pages/IssueDetail.tsxindex f35fa22b50..319cb7b75d 100644--- a/ui/src/pages/IssueDetail.tsx+++ b/ui/src/pages/IssueDetail.tsx@@ -837,6 +837,7 @@ const IssueDetailChatTab = memo(function IssueDetailChatTab({type IssueDetailActivityTabProps = {issueId: string;+ companyId: string;issueStatus: Issue["status"];childIssues: Issue[];agentMap: Map<string, Agent>;@@ -850,6 +851,7 @@ type IssueDetailActivityTabProps = {function IssueDetailActivityTab({issueId,+ companyId,issueStatus,childIssues,agentMap,@@ -941,6 +943,7 @@ function IssueDetailActivityTab({<div className="mb-3"><IssueRunLedgerissueId={issueId}+ companyId={companyId}issueStatus={issueStatus}childIssues={childIssues}agentMap={agentMap}@@ -3410,6 +3413,7 @@ export function IssueDetail() {{detailTab === "activity" ? (<IssueDetailActivityTabissueId={issue.id}+ companyId={issue.companyId}issueStatus={issue.status}childIssues={childIssues}agentMap={agentMap}