The open-source app everyone uses to manage agents at work
TypeScript acpxagent-orchestrationagent-skillsagentic-aiai-agentsai-engineeringai-governanceai-toolsautonomous-agentsclaudeclaude-codeclaude-skillscodexhermesllmmcpmulti-agentopenclawproject-managementworkflow-automation
feat(ui): use Lucide icons for task status glyphs (#9395)
scotttong7fd321d62293
diff --git a/ui/src/components/StatusGlyph.test.tsx b/ui/src/components/StatusGlyph.test.tsxindex da76ccf542..a7ff3fbbcd 100644--- a/ui/src/components/StatusGlyph.test.tsx+++ b/ui/src/components/StatusGlyph.test.tsx@@ -6,11 +6,24 @@ import { StatusGlyph } from "./StatusGlyph";import { taskStatusIconVar } from "../lib/status-colors";/**- * PAP-238 3b: the unified status glyph renders every status from ONE- * `viewBox="0 0 24 24"` SVG at a `sm 14 / md 16 / lg 20` scale, coloured from- * the AA-tuned `--status-task-icon-*` vars. These tests lock the geometry (the- * rev-4 spec hexes/paths), the size scale, the colour wiring and `in_queue`.+ * The unified status glyph renders every status from ONE Lucide icon per status+ * (all on a shared `viewBox="0 0 24 24"`, at a `sm 14 / md 16 / lg 20` scale),+ * coloured from the AA-tuned `--status-task-icon-*` vars. These tests lock the+ * icon mapping, the size scale, the colour wiring and `in_queue`.*/++/** Status → the Lucide class token its icon renders (`lucide-<kebab-name>`). */+const STATUS_ICON_CLASS: Record<string, string> = {+ backlog: "lucide-circle-dashed",+ todo: "lucide-circle",+ in_progress: "lucide-rotate-cw",+ in_review: "lucide-circle-dot",+ done: "lucide-circle-check",+ blocked: "lucide-circle-minus",+ cancelled: "lucide-ban",+ in_queue: "lucide-circle-minus",+};+describe("StatusGlyph", () => {it("renders one 24-unit viewBox for every status (proportional scaling)", () => {for (const status of Object.keys(taskStatusIconVar)) {@@ -35,59 +48,33 @@ describe("StatusGlyph", () => {}});- it("falls back to the backlog icon var for unknown statuses", () => {+ it("falls back to the backlog icon + var for unknown statuses", () => {const html = renderToStaticMarkup(<StatusGlyph status="mystery" />);expect(html).toContain("var(--status-task-icon-backlog)");+ expect(html).toContain("lucide-circle-dashed");});- it("gives backlog a uniform dashed ring (pathLength=100)", () => {- const html = renderToStaticMarkup(<StatusGlyph status="backlog" />);- expect(html).toContain('pathLength="100"');- expect(html).toContain('stroke-dasharray="6.25 6.25"');+ it("maps each status to its Lucide icon", () => {+ for (const [status, iconClass] of Object.entries(STATUS_ICON_CLASS)) {+ const html = renderToStaticMarkup(<StatusGlyph status={status} />);+ expect(html).toContain(iconClass);+ }});- it("gives todo a bare open ring (no inner shape)", () => {+ it("gives todo the plain circle (not a compound circle icon)", () => {const html = renderToStaticMarkup(<StatusGlyph status="todo" />);- expect(html).toContain('r="8.5"');- expect(html).not.toContain("<path");- expect(html).not.toContain("<rect");- });-- it("gives in_progress a half-filled ring (liveness)", () => {- const html = renderToStaticMarkup(<StatusGlyph status="in_progress" />);- expect(html).toContain("M12 3.5 A8.5 8.5 0 0 1 12 20.5 Z");- });-- it("gives in_review a ring + centre dot", () => {- const html = renderToStaticMarkup(<StatusGlyph status="in_review" />);- expect(html).toContain('r="3.6"');- });-- it("gives done a filled disc with a knocked-out check in the surface colour", () => {- const html = renderToStaticMarkup(<StatusGlyph status="done" />);- expect(html).toContain('r="9.5"');- expect(html).toContain("M7.5 12.2 10.6 15.2 16.5 8.8");- expect(html).toContain("stroke-background");- });-- it("gives blocked a ring + bar", () => {- const html = renderToStaticMarkup(<StatusGlyph status="blocked" />);- expect(html).toContain("<rect");- expect(html).toContain('width="10"');- });-- it("gives cancelled a ring + slash", () => {- const html = renderToStaticMarkup(<StatusGlyph status="cancelled" />);- expect(html).toContain("M6.5 17.5 17.5 6.5");+ expect(html).toContain("lucide-circle");+ for (const compound of ["circle-dashed", "circle-dot", "circle-check", "circle-minus"]) {+ expect(html).not.toContain(compound);+ }});- it("renders in_queue as the blocked shape recoloured blue (in_progress var)", () => {+ it("renders in_queue as the blocked icon recoloured blue (in_queue var)", () => {const queue = renderToStaticMarkup(<StatusGlyph status="in_queue" />);const blocked = renderToStaticMarkup(<StatusGlyph status="blocked" />);- // Same geometry as blocked (ring + bar)…- expect(queue).toContain("<rect");- expect(queue).toContain('width="10"');- // …but coloured from the in_progress (blue) icon var, not blocked's red.+ // Same icon as blocked (circle-minus)…+ expect(queue).toContain("lucide-circle-minus");+ // …but coloured from the in_queue (blue) icon var, not blocked's red.expect(queue).toContain("var(--status-task-icon-in_queue)");expect(queue).not.toContain("var(--status-task-icon-blocked)");expect(blocked).toContain("var(--status-task-icon-blocked)");diff --git a/ui/src/components/StatusGlyph.tsx b/ui/src/components/StatusGlyph.tsxindex 92138de2ae..3914d79ae9 100644--- a/ui/src/components/StatusGlyph.tsx+++ b/ui/src/components/StatusGlyph.tsx@@ -1,24 +1,32 @@import type { CSSProperties } from "react";+import {+ Ban,+ Circle,+ CircleCheck,+ CircleDashed,+ CircleDot,+ CircleMinus,+ RotateCw,+ type LucideIcon,+} from "lucide-react";import { cn } from "../lib/utils";import { taskStatusIconVar, taskStatusIconVarDefault } from "../lib/status-colors";/**- * Unified task status glyph (PAP-238 3b) — the single source-of-truth icon for- * every task/issue status. Rendered from ONE `viewBox="0 0 24 24"` SVG per- * status so it scales proportionally at any size (fixes "done" collapsing into- * a filled blob at small sizes). Geometry + AA hues are lifted verbatim from- * the rev-4 spec artifact.+ * Unified task status glyph — the single source-of-truth icon for every+ * task/issue status. Each status maps to one Lucide icon (all drawn on the same+ * `viewBox="0 0 24 24"` so they scale proportionally at any size), so the whole+ * set reads as one consistent icon family:*- * Distinct shapes: backlog dashed ring (uniform via `pathLength`), todo open- * ring, in_progress half-filled, in_review ring + dot, done disc + knockout- * check, blocked ring + bar, cancelled ring + slash, and `in_queue` = the- * blocked shape recoloured blue (replaces the bespoke teal "covered" state).+ * backlog → circle-dashed · todo → circle · in_progress → rotate-cw ·+ * in_review → circle-dot · done → circle-check · blocked → circle-minus ·+ * cancelled → ban · in_queue → circle-minus (blocked recoloured blue).*- * Colour comes from the `--status-task-icon-*` CSS vars (AA-tuned,- * mode-aware; see `index.css`). The glyph paints in `currentColor`, and the- * component defaults `color` to the status' icon var — so it renders correctly- * standalone, but a call site (3c) can recolour it by setting `color` on the- * SVG or any ancestor (e.g. a chip pointing it at its foreground hue).+ * Colour comes from the `--status-task-icon-*` CSS vars (AA-tuned, mode-aware;+ * see `index.css`). The glyph paints in `currentColor`, and the component+ * defaults `color` to the status' icon var — so it renders correctly+ * standalone, but a call site can recolour it by setting `color` on the SVG or+ * any ancestor (e.g. a chip pointing it at its foreground hue).*/export type StatusGlyphSize = "sm" | "md" | "lg";@@ -26,9 +34,6 @@ export type StatusGlyphSize = "sm" | "md" | "lg";/** sm 14 / md 16 / lg 20 — the only sizes the unified glyph ships at. */const SIZE_PX: Record<StatusGlyphSize, number> = { sm: 14, md: 16, lg: 20 };-/** Proportional stroke for the open-ring family (24-unit viewBox). */-const SW = 2.4;-export type StatusGlyphStatus =| "backlog"| "todo"@@ -39,6 +44,21 @@ export type StatusGlyphStatus =| "cancelled"| "in_queue";+/** Status → Lucide icon. `in_queue` borrows the blocked icon; its colour var resolves to blue. */+const STATUS_ICON: Record<string, LucideIcon> = {+ backlog: CircleDashed,+ todo: Circle,+ in_progress: RotateCw,+ in_review: CircleDot,+ done: CircleCheck,+ blocked: CircleMinus,+ cancelled: Ban,+ in_queue: CircleMinus,+};++/** Unknown statuses fall back to the backlog icon (matches the colour-var fallback). */+const STATUS_ICON_DEFAULT = CircleDashed;+interface StatusGlyphProps {status: string;/** sm 14 / md 16 / lg 20. Default `md`. */@@ -48,92 +68,21 @@ interface StatusGlyphProps {title?: string;}-/** Inner geometry per status (viewBox 0 0 24 24). `in_queue` reuses `blocked`. */-function glyphBody(status: string) {- // in_queue borrows the blocked shape; its colour var resolves to the blue.- const shape = status === "in_queue" ? "blocked" : status;- switch (shape) {- case "todo":- return <circle cx="12" cy="12" r="8.5" fill="none" stroke="currentColor" strokeWidth={SW} />;- case "in_progress":- return (- <>- <circle cx="12" cy="12" r="8.5" fill="none" stroke="currentColor" strokeWidth={SW} />- <path d="M12 3.5 A8.5 8.5 0 0 1 12 20.5 Z" fill="currentColor" />- </>- );- case "in_review":- return (- <>- <circle cx="12" cy="12" r="8.5" fill="none" stroke="currentColor" strokeWidth={SW} />- <circle cx="12" cy="12" r="3.6" fill="currentColor" />- </>- );- case "done":- return (- <>- <circle cx="12" cy="12" r="9.5" fill="currentColor" />- {/* Check knocked out in the surface colour so the disc reads at any size. */}- <path- d="M7.5 12.2 10.6 15.2 16.5 8.8"- fill="none"- className="stroke-background"- strokeWidth="2.4"- strokeLinecap="round"- strokeLinejoin="round"- />- </>- );- case "blocked":- return (- <>- <circle cx="12" cy="12" r="8.5" fill="none" stroke="currentColor" strokeWidth={SW} />- <rect x="7" y="10.7" width="10" height="2.6" rx="1" fill="currentColor" />- </>- );- case "cancelled":- return (- <>- <circle cx="12" cy="12" r="8.5" fill="none" stroke="currentColor" strokeWidth={SW} />- <path d="M6.5 17.5 17.5 6.5" stroke="currentColor" strokeWidth={SW} strokeLinecap="round" />- </>- );- case "backlog":- default:- // pathLength=100 makes the dash pattern resolution-independent: 100/12.5 =- // 8 exact dashes, so the ring is uniform with no overlap at the seam.- return (- <circle- cx="12"- cy="12"- r="8.5"- fill="none"- stroke="currentColor"- strokeWidth={SW}- pathLength={100}- strokeDasharray="6.25 6.25"- />- );- }-}-export function StatusGlyph({ status, size = "md", className, title }: StatusGlyphProps) {const px = SIZE_PX[size];+ const Icon = STATUS_ICON[status] ?? STATUS_ICON_DEFAULT;const cssVar = taskStatusIconVar[status] ?? taskStatusIconVarDefault;const a11y = title? ({ role: "img", "aria-label": title } as const): ({ "aria-hidden": true } as const);return (- <svg- width={px}- height={px}- viewBox="0 0 24 24"+ <Icon+ size={px}className={cn("inline-block shrink-0 align-middle", className)}style={{ color: `var(${cssVar})` } as CSSProperties}{...a11y}>{title ? <title>{title}</title> : null}- {glyphBody(status)}- </svg>+ </Icon>);}