The open-source app everyone uses to manage agents at work
TypeScript acpxagent-orchestrationagent-skillsagentic-aiai-agentsai-engineeringai-governanceai-toolsautonomous-agentsclaudeclaude-codeclaude-skillscodexhermesllmmcpmulti-agentopenclawproject-managementworkflow-automation
feat(ui): theme toggle on unauthenticated auth page (supersedes part of #3732) (#5874)
Jannes Stubbemann8ddd735a7ad0
diff --git a/ui/src/components/SidebarAccountMenu.tsx b/ui/src/components/SidebarAccountMenu.tsxindex 593feecdc8..f151cb163a 100644--- a/ui/src/components/SidebarAccountMenu.tsx+++ b/ui/src/components/SidebarAccountMenu.tsx@@ -5,9 +5,7 @@ import {LogOut,Megaphone,type LucideIcon,- Moon,UserRound,- Sun,UserRoundPen,} from "lucide-react";import type { DeploymentMode } from "@paperclipai/shared";@@ -15,10 +13,10 @@ import { Link } from "@/lib/router";import { authApi } from "@/api/auth";import { queryKeys } from "@/lib/queryKeys";import { useSidebar } from "../context/SidebarContext";-import { useTheme } from "../context/ThemeContext";import { Popover, PopoverContent, PopoverTrigger } from "@/components/ui/popover";import { Avatar, AvatarFallback, AvatarImage } from "@/components/ui/avatar";import { cn, SIDEBAR_RAIL_HIDDEN_LABEL } from "../lib/utils";+import { ThemeToggle } from "./ThemeToggle";const PROFILE_SETTINGS_PATH = "/company/settings/instance/profile";const DOCS_URL = "https://docs.paperclip.ing/";@@ -111,7 +109,6 @@ export function SidebarAccountMenu({const queryClient = useQueryClient();const { isMobile, setSidebarOpen, collapsed, peeking } = useSidebar();const rail = collapsed && !peeking;- const { theme, toggleTheme } = useTheme();const open = controlledOpen ?? internalOpen;const setOpen = onOpenChange ?? setInternalOpen;const { data: session } = useQuery({@@ -216,15 +213,7 @@ export function SidebarAccountMenu({externalonClick={() => setOpen(false)}/>- <MenuAction- label={theme === "dark" ? "Switch to light mode" : "Switch to dark mode"}- description="Toggle the app appearance."- icon={theme === "dark" ? Sun : Moon}- onClick={() => {- toggleTheme();- setOpen(false);- }}- />+ <ThemeToggle variant="menu-action" onAfterToggle={() => setOpen(false)} />{deploymentMode === "authenticated" ? (<buttontype="button"diff --git a/ui/src/components/ThemeToggle.test.tsx b/ui/src/components/ThemeToggle.test.tsxnew file mode 100644index 0000000000..959f6a1f92--- /dev/null+++ b/ui/src/components/ThemeToggle.test.tsx@@ -0,0 +1,107 @@+// @vitest-environment jsdom++import { act } from "react";+import { createRoot } from "react-dom/client";+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";+import { ThemeToggle } from "./ThemeToggle";++const mockToggleTheme = vi.hoisted(() => vi.fn());+const mockTheme = vi.hoisted(() => ({ value: "dark" as "dark" | "light" }));++vi.mock("../context/ThemeContext", () => ({+ useTheme: () => ({+ theme: mockTheme.value,+ toggleTheme: mockToggleTheme,+ }),+}));++// eslint-disable-next-line @typescript-eslint/no-explicit-any+(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;++async function flushReact() {+ await act(async () => {+ await Promise.resolve();+ });+}++describe("ThemeToggle", () => {+ let container: HTMLDivElement;++ beforeEach(() => {+ container = document.createElement("div");+ document.body.appendChild(container);+ mockTheme.value = "dark";+ });++ afterEach(() => {+ container.remove();+ document.body.innerHTML = "";+ vi.clearAllMocks();+ });++ it("renders an icon button by default with the 'switch to light' label when current theme is dark", async () => {+ const root = createRoot(container);+ await act(async () => {+ root.render(<ThemeToggle />);+ });+ await flushReact();++ const button = container.querySelector("button");+ expect(button).not.toBeNull();+ expect(button?.getAttribute("aria-label")).toBe("Switch to light mode");+ expect(button?.getAttribute("title")).toBe("Switch to light mode");++ await act(async () => {+ button?.click();+ });+ expect(mockToggleTheme).toHaveBeenCalledTimes(1);++ await act(async () => root.unmount());+ });++ it("renders a menu-action row when variant='menu-action' and includes the description text", async () => {+ const root = createRoot(container);+ await act(async () => {+ root.render(<ThemeToggle variant="menu-action" />);+ });+ await flushReact();++ expect(container.textContent).toContain("Switch to light mode");+ expect(container.textContent).toContain("Toggle the app appearance.");++ await act(async () => root.unmount());+ });++ it("calls onAfterToggle after toggling (used by SidebarAccountMenu to close the popover)", async () => {+ const onAfterToggle = vi.fn();+ const root = createRoot(container);+ await act(async () => {+ root.render(<ThemeToggle variant="menu-action" onAfterToggle={onAfterToggle} />);+ });+ await flushReact();++ const button = container.querySelector("button");+ await act(async () => {+ button?.click();+ });++ expect(mockToggleTheme).toHaveBeenCalledTimes(1);+ expect(onAfterToggle).toHaveBeenCalledTimes(1);++ await act(async () => root.unmount());+ });++ it("flips label and icon when current theme is light", async () => {+ mockTheme.value = "light";+ const root = createRoot(container);+ await act(async () => {+ root.render(<ThemeToggle />);+ });+ await flushReact();++ const button = container.querySelector("button");+ expect(button?.getAttribute("aria-label")).toBe("Switch to dark mode");++ await act(async () => root.unmount());+ });+});diff --git a/ui/src/components/ThemeToggle.tsx b/ui/src/components/ThemeToggle.tsxnew file mode 100644index 0000000000..43bd24503b--- /dev/null+++ b/ui/src/components/ThemeToggle.tsx@@ -0,0 +1,80 @@+import { Moon, Sun } from "lucide-react";++import { Button } from "@/components/ui/button";+import { cn } from "@/lib/utils";+import { useTheme } from "../context/ThemeContext";++type ThemeToggleVariant = "icon" | "menu-action";++interface ThemeToggleProps {+ className?: string;+ /**+ * `icon` (default): compact icon button — suitable for headers,+ * floating chrome (e.g. the unauthenticated `/auth` page), and any+ * other surface that just wants a toggle affordance.+ *+ * `menu-action`: full-width row with label + description + icon —+ * matches the surrounding `MenuAction` rows in `SidebarAccountMenu`.+ */+ variant?: ThemeToggleVariant;+ /**+ * Called after `toggleTheme` runs. Surfaces like a popover menu use+ * this to dismiss the menu once the user has acted.+ */+ onAfterToggle?: () => void;+}++const MENU_ACTION_DESCRIPTION = "Toggle the app appearance.";++/**+ * Canonical theme-toggle widget. Both the signed-out `/auth` chrome and+ * the in-app account menu render through this component so the label,+ * icon, and toggle behaviour stay in sync as the theme model evolves.+ */+export function ThemeToggle({ className, variant = "icon", onAfterToggle }: ThemeToggleProps) {+ const { theme, toggleTheme } = useTheme();+ const isDark = theme === "dark";+ const label = isDark ? "Switch to light mode" : "Switch to dark mode";+ const Icon = isDark ? Sun : Moon;++ function handleClick() {+ toggleTheme();+ onAfterToggle?.();+ }++ if (variant === "menu-action") {+ return (+ <button+ type="button"+ className={cn(+ "flex w-full items-start gap-3 rounded-xl px-3 py-3 text-left transition-colors hover:bg-accent/60",+ className,+ )}+ onClick={handleClick}+ aria-label={label}+ >+ <span className="mt-0.5 rounded-lg border border-border bg-background/70 p-2 text-muted-foreground">+ <Icon className="size-4" />+ </span>+ <span className="min-w-0 flex-1">+ <span className="block text-sm font-medium text-foreground">{label}</span>+ <span className="block text-xs text-muted-foreground">{MENU_ACTION_DESCRIPTION}</span>+ </span>+ </button>+ );+ }++ return (+ <Button+ type="button"+ variant="ghost"+ size="icon-sm"+ onClick={handleClick}+ aria-label={label}+ title={label}+ className={cn("text-muted-foreground", className)}+ >+ <Icon />+ </Button>+ );+}diff --git a/ui/src/pages/Auth.test.tsx b/ui/src/pages/Auth.test.tsxindex 39682c34c3..47be067637 100644--- a/ui/src/pages/Auth.test.tsx+++ b/ui/src/pages/Auth.test.tsx@@ -25,6 +25,17 @@ vi.mock("@/components/AsciiArtAnimation", () => ({AsciiArtAnimation: () => null,}));+// The auth page renders a ThemeToggle, which reads ThemeContext. The provider+// lives in main.tsx (above the router), so mock the hook here the same way+// SidebarAccountMenu.test.tsx does.+vi.mock("../context/ThemeContext", () => ({+ useTheme: () => ({+ theme: "dark",+ setTheme: vi.fn(),+ toggleTheme: vi.fn(),+ }),+}));+// The router's navigate wrapper reads the active company prefix from context.vi.mock("@/context/CompanyContext", () => ({useCompany: () => ({diff --git a/ui/src/pages/Auth.tsx b/ui/src/pages/Auth.tsxindex fc2f7a84fb..20a8c542db 100644--- a/ui/src/pages/Auth.tsx+++ b/ui/src/pages/Auth.tsx@@ -6,6 +6,7 @@ import { queryKeys } from "../lib/queryKeys";import { getRememberedInvitePath } from "../lib/invite-memory";import { Button } from "@/components/ui/button";import { AsciiArtAnimation } from "@/components/AsciiArtAnimation";+import { ThemeToggle } from "@/components/ThemeToggle";import { Sparkles } from "lucide-react";type AuthMode = "sign_in" | "sign_up";@@ -75,6 +76,9 @@ export function AuthPage() {return (<div className="fixed inset-0 flex bg-background">+ <div className="absolute top-4 right-4 z-10">+ <ThemeToggle />+ </div>{/* Left half — form */}<div className="w-full md:w-1/2 flex flex-col overflow-y-auto"><div className="w-full max-w-md mx-auto my-auto px-8 py-12">