The open-source app everyone uses to manage agents at work
TypeScript acpxagent-orchestrationagent-skillsagentic-aiai-agentsai-engineeringai-governanceai-toolsautonomous-agentsclaudeclaude-codeclaude-skillscodexhermesllmmcpmulti-agentopenclawproject-managementworkflow-automation
fix(server): treat a scheme-less public base URL as absent instead of crashing startup (#13727)
SkilLab HR and Tech92bedaac4aed
diff --git a/server/src/__tests__/runtime-api.test.ts b/server/src/__tests__/runtime-api.test.tsindex 5e46bbb06f..6640af4d00 100644--- a/server/src/__tests__/runtime-api.test.ts+++ b/server/src/__tests__/runtime-api.test.ts@@ -155,4 +155,27 @@ describe("runtime API discovery", () => {"fd7a:115c:a1e0::8a3a:a11d",]);});++ it("ignores a public base URL that has no scheme instead of returning the string \"null\"", () => {+ expect(+ choosePrimaryRuntimeApiUrl({+ authPublicBaseUrl: "runtime-host.example.test:3100",+ allowedHostnames: ["runtime-host.example.test"],+ bindHost: "0.0.0.0",+ port: 3102,+ }),+ ).toBe("http://runtime-host.example.test:3102");+ });++ it("builds candidates without throwing when the public base URL has no scheme", () => {+ expect(+ buildRuntimeApiCandidateUrls({+ authPublicBaseUrl: "runtime-host.example.test:3100",+ allowedHostnames: ["runtime-host.example.test"],+ bindHost: "0.0.0.0",+ port: 3102,+ networkInterfacesMap: {},+ }),+ ).toEqual(["http://runtime-host.example.test:3102"]);+ });});diff --git a/server/src/runtime-api.ts b/server/src/runtime-api.tsindex bf4caf36eb..6efa34ca14 100644--- a/server/src/runtime-api.ts+++ b/server/src/runtime-api.ts@@ -46,20 +46,31 @@ function pushCandidate(}}+// A base URL written as `host:port` (no `//`) is a VALID URL with an opaque+// scheme, and the origin of an opaque-scheme URL serializes to the *string*+// "null". That string is truthy, so it escapes every `if (origin)` guard and is+// then handed to `new URL(origin)`, which throws `TypeError: Invalid URL`.+// Treat it as absent config, exactly like input that fails to parse at all.+function parsePublicOrigin(rawUrl: string | null | undefined): string | null {+ const trimmed = rawUrl?.trim();+ if (!trimmed) return null;+ let origin: string;+ try {+ origin = new URL(trimmed).origin;+ } catch {+ return null;+ }+ return origin === "null" ? null : origin;+}+export function choosePrimaryRuntimeApiUrl(input: {authPublicBaseUrl?: string | null;allowedHostnames: string[];bindHost: string;port: number;}): string {- const explicitPublicBaseUrl = input.authPublicBaseUrl?.trim();- if (explicitPublicBaseUrl) {- try {- return new URL(explicitPublicBaseUrl).origin;- } catch {- // Fall through to derived candidates if config parsing drifted.- }- }+ const explicitOrigin = parsePublicOrigin(input.authPublicBaseUrl);+ if (explicitOrigin) return explicitOrigin;const bindHost = normalizeHost(input.bindHost);if (bindHost && !isWildcardHost(bindHost) && isLoopbackHost(bindHost)) {@@ -118,15 +129,7 @@ export function buildRuntimeApiCandidateUrls(input: {}): string[] {const candidates: string[] = [];const seen = new Set<string>();- const explicitPublicBaseUrl = input.authPublicBaseUrl?.trim() ?? "";- const explicitOrigin = (() => {- if (!explicitPublicBaseUrl) return null;- try {- return new URL(explicitPublicBaseUrl).origin;- } catch {- return null;- }- })();+ const explicitOrigin = parsePublicOrigin(input.authPublicBaseUrl);const protocol = explicitOrigin ? new URL(explicitOrigin).protocol : "http:";pushCandidate(candidates, seen, input.preferredApiUrl);