The open-source app everyone uses to manage agents at work
TypeScript acpxagent-orchestrationagent-skillsagentic-aiai-agentsai-engineeringai-governanceai-toolsautonomous-agentsclaudeclaude-codeclaude-skillscodexhermesllmmcpmulti-agentopenclawproject-managementworkflow-automation
fix(adapter-utils): tar sandbox workspace by entry, not '.', to avoid EPERM on unowned target dir (#7836)
Jannes Stubbemann93cdc5c1cea9
diff --git a/packages/adapter-utils/src/sandbox-managed-runtime.test.ts b/packages/adapter-utils/src/sandbox-managed-runtime.test.tsindex 5f51faaab1..bd3be7008b 100644--- a/packages/adapter-utils/src/sandbox-managed-runtime.test.ts+++ b/packages/adapter-utils/src/sandbox-managed-runtime.test.ts@@ -130,4 +130,112 @@ describe("sandbox managed runtime", () => {await expect(readFile(path.join(localWorkspaceDir, ".claude", "settings.json"), "utf8")).resolves.toBe("{\"local\":true}\n");await expect(readFile(path.join(localWorkspaceDir, ".paperclip-runtime", "state.json"), "utf8")).resolves.toBe("{}\n");});++ it("builds workspace/asset tarballs without a './' self-entry (so untar does not chmod/utime an unowned target dir)", async () => {+ const rootDir = await mkdtemp(path.join(os.tmpdir(), "paperclip-sandbox-tarself-"));+ cleanupDirs.push(rootDir);+ const localWorkspaceDir = path.join(rootDir, "local-workspace");+ const remoteWorkspaceDir = path.join(rootDir, "remote-workspace");+ const localAssetsDir = path.join(rootDir, "local-assets");+ await mkdir(path.join(localWorkspaceDir, "src"), { recursive: true });+ await mkdir(localAssetsDir, { recursive: true });+ await writeFile(path.join(localWorkspaceDir, "README.md"), "ws\n", "utf8");+ await writeFile(path.join(localWorkspaceDir, "src", "main.ts"), "x\n", "utf8");+ await writeFile(path.join(localAssetsDir, "asset.txt"), "a\n", "utf8");++ // Capture every tar uploaded to the sandbox so we can inspect its members.+ const uploadedTars: { remotePath: string; bytes: Buffer }[] = [];+ const client: SandboxManagedRuntimeClient = {+ makeDir: async (remotePath) => {+ await mkdir(remotePath, { recursive: true });+ },+ writeFile: async (remotePath, bytes) => {+ await mkdir(path.dirname(remotePath), { recursive: true });+ const buffer = Buffer.from(bytes);+ if (remotePath.endsWith("-upload.tar")) uploadedTars.push({ remotePath, bytes: buffer });+ await writeFile(remotePath, buffer);+ },+ readFile: async (remotePath) => await readFile(remotePath),+ listFiles: async () => [],+ remove: async (remotePath) => {+ await rm(remotePath, { recursive: true, force: true });+ },+ run: async (command) => {+ await execFile("sh", ["-c", command], { maxBuffer: 32 * 1024 * 1024 });+ },+ };++ await prepareSandboxManagedRuntime({+ spec: {+ transport: "sandbox",+ provider: "test",+ sandboxId: "sandbox-1",+ remoteCwd: remoteWorkspaceDir,+ timeoutMs: 30_000,+ apiKey: null,+ },+ adapterKey: "test-adapter",+ client,+ workspaceLocalDir: localWorkspaceDir,+ assets: [{ key: "skills", localDir: localAssetsDir }],+ });++ expect(uploadedTars.length).toBeGreaterThanOrEqual(2);+ for (const { remotePath, bytes } of uploadedTars) {+ const listPath = path.join(rootDir, `list-${path.basename(remotePath)}`);+ await writeFile(listPath, bytes);+ const { stdout } = await execFile("tar", ["-tf", listPath], { maxBuffer: 32 * 1024 * 1024 });+ const members = stdout.split("\n").map((line) => line.trim()).filter(Boolean);+ // The archive must NOT contain a self-entry for the root directory; that is+ // what makes tar try to mutate the (possibly unowned) extraction target.+ expect(members).not.toContain(".");+ expect(members).not.toContain("./");+ }++ // And the workspace still extracts correctly into an existing target dir.+ await expect(readFile(path.join(remoteWorkspaceDir, "README.md"), "utf8")).resolves.toBe("ws\n");+ await expect(readFile(path.join(remoteWorkspaceDir, "src", "main.ts"), "utf8")).resolves.toBe("x\n");+ });++ it("creates a valid empty workspace tarball when the local workspace is empty", async () => {+ const rootDir = await mkdtemp(path.join(os.tmpdir(), "paperclip-sandbox-empty-"));+ cleanupDirs.push(rootDir);+ const localWorkspaceDir = path.join(rootDir, "local-workspace");+ const remoteWorkspaceDir = path.join(rootDir, "remote-workspace");+ await mkdir(localWorkspaceDir, { recursive: true });++ const client: SandboxManagedRuntimeClient = {+ makeDir: async (remotePath) => {+ await mkdir(remotePath, { recursive: true });+ },+ writeFile: async (remotePath, bytes) => {+ await mkdir(path.dirname(remotePath), { recursive: true });+ await writeFile(remotePath, Buffer.from(bytes));+ },+ readFile: async (remotePath) => await readFile(remotePath),+ listFiles: async () => [],+ remove: async (remotePath) => {+ await rm(remotePath, { recursive: true, force: true });+ },+ run: async (command) => {+ await execFile("sh", ["-c", command], { maxBuffer: 32 * 1024 * 1024 });+ },+ };++ await expect(+ prepareSandboxManagedRuntime({+ spec: {+ transport: "sandbox",+ provider: "test",+ sandboxId: "sandbox-1",+ remoteCwd: remoteWorkspaceDir,+ timeoutMs: 30_000,+ apiKey: null,+ },+ adapterKey: "test-adapter",+ client,+ workspaceLocalDir: localWorkspaceDir,+ }),+ ).resolves.toBeDefined();+ });});diff --git a/packages/adapter-utils/src/sandbox-managed-runtime.ts b/packages/adapter-utils/src/sandbox-managed-runtime.tsindex 13e9e9120d..81bd90b9c6 100644--- a/packages/adapter-utils/src/sandbox-managed-runtime.ts+++ b/packages/adapter-utils/src/sandbox-managed-runtime.ts@@ -136,6 +136,22 @@ async function createTarballFromDirectory(input: {followSymlinks?: boolean;}): Promise<void> {const excludeArgs = ["._*", ...(input.exclude ?? [])].flatMap((entry) => ["--exclude", entry]);+ // Archive the directory's top-level entries BY NAME rather than ".". Archiving+ // "." embeds a "./" self-entry whose mode/mtime tar then tries to restore onto+ // the extraction target directory; that chmod/utime fails with "Operation not+ // permitted" when the target is a directory the extracting (non-root) user does+ // not own, e.g. an emptyDir mount in a hardened/gVisor sandbox pod. Enumerating+ // entries avoids the self-entry entirely and is portable across GNU/BSD/busybox+ // tar (no GNU-only --no-overwrite-dir needed). --exclude still filters nested+ // matches and any named entry it matches.+ const entries = (await fs.readdir(input.localDir)).sort((left, right) => left.localeCompare(right));+ if (entries.length === 0) {+ // A workspace can legitimately be empty (blank-workspace agent runs). Write a+ // valid empty tar archive (1024-byte all-zero EOF marker) so extraction is a+ // clean no-op rather than tar refusing to create an empty archive.+ await fs.writeFile(input.archivePath, Buffer.alloc(1024));+ return;+ }await execTar(["-c",// Prevent macOS bsdtar from embedding LIBARCHIVE.xattr.* PAX extended@@ -151,7 +167,8 @@ async function createTarballFromDirectory(input: {"-C",input.localDir,...excludeArgs,- ".",+ "--",+ ...entries,]);}