The open-source app everyone uses to manage agents at work
TypeScript acpxagent-orchestrationagent-skillsagentic-aiai-agentsai-engineeringai-governanceai-toolsautonomous-agentsclaudeclaude-codeclaude-skillscodexhermesllmmcpmulti-agentopenclawproject-managementworkflow-automation
fix(server): redact secret-sourced env vars in run logs by provenance
Matt Van Horn977f5570be14
diff --git a/server/src/routes/agents.ts b/server/src/routes/agents.tsindex 008d909454..2724a6e28f 100644--- a/server/src/routes/agents.ts+++ b/server/src/routes/agents.ts@@ -211,7 +211,7 @@ export function agentRoutes(db: Db) {adapterConfig: Record<string, unknown>,) {if (adapterType !== "opencode_local") return;- const runtimeConfig = await secretsSvc.resolveAdapterConfigForRuntime(companyId, adapterConfig);+ const { config: runtimeConfig } = await secretsSvc.resolveAdapterConfigForRuntime(companyId, adapterConfig);const runtimeEnv = asRecord(runtimeConfig.env) ?? {};try {await ensureOpenCodeModelConfiguredAndAvailable({@@ -386,7 +386,7 @@ export function agentRoutes(db: Db) {inputAdapterConfig,{ strictMode: strictSecretsMode },);- const runtimeAdapterConfig = await secretsSvc.resolveAdapterConfigForRuntime(+ const { config: runtimeAdapterConfig } = await secretsSvc.resolveAdapterConfigForRuntime(companyId,normalizedAdapterConfig,);@@ -1226,7 +1226,7 @@ export function agentRoutes(db: Db) {}const config = asRecord(agent.adapterConfig) ?? {};- const runtimeConfig = await secretsSvc.resolveAdapterConfigForRuntime(agent.companyId, config);+ const { config: runtimeConfig } = await secretsSvc.resolveAdapterConfigForRuntime(agent.companyId, config);const result = await runClaudeLogin({runId: `claude-login-${randomUUID()}`,agent: {diff --git a/server/src/services/heartbeat.ts b/server/src/services/heartbeat.tsindex 0fb575d78b..dbba40b2e1 100644--- a/server/src/services/heartbeat.ts+++ b/server/src/services/heartbeat.ts@@ -1240,11 +1240,16 @@ export function heartbeatService(db: Db) {const mergedConfig = issueAssigneeOverrides?.adapterConfig? { ...config, ...issueAssigneeOverrides.adapterConfig }: config;- const resolvedConfig = await secretsSvc.resolveAdapterConfigForRuntime(+ const { config: resolvedConfig, secretKeys } = await secretsSvc.resolveAdapterConfigForRuntime(agent.companyId,mergedConfig,);const onAdapterMeta = async (meta: AdapterInvocationMeta) => {+ if (meta.env && secretKeys.size > 0) {+ for (const key of secretKeys) {+ if (key in meta.env) meta.env[key] = "***REDACTED***";+ }+ }await appendRunEvent(currentRun, seq++, {eventType: "adapter.invoke",stream: "system",diff --git a/server/src/services/secrets.ts b/server/src/services/secrets.tsindex 8a3595b437..9e65543fa5 100644--- a/server/src/services/secrets.ts+++ b/server/src/services/secrets.ts@@ -331,15 +331,16 @@ export function secretService(db: Db) {return resolved;},- resolveAdapterConfigForRuntime: async (companyId: string, adapterConfig: Record<string, unknown>) => {+ resolveAdapterConfigForRuntime: async (companyId: string, adapterConfig: Record<string, unknown>): Promise<{ config: Record<string, unknown>; secretKeys: Set<string> }> => {const resolved = { ...adapterConfig };+ const secretKeys = new Set<string>();if (!Object.prototype.hasOwnProperty.call(adapterConfig, "env")) {- return resolved;+ return { config: resolved, secretKeys };}const record = asRecord(adapterConfig.env);if (!record) {resolved.env = {};- return resolved;+ return { config: resolved, secretKeys };}const env: Record<string, string> = {};for (const [key, rawBinding] of Object.entries(record)) {@@ -355,10 +356,11 @@ export function secretService(db: Db) {env[key] = binding.value;} else {env[key] = await resolveSecretValue(companyId, binding.secretId, binding.version);+ secretKeys.add(key);}}resolved.env = env;- return resolved;+ return { config: resolved, secretKeys };},};}