Skip to content

The open-source app everyone uses to manage agents at work

fix(ui): fetch the web app manifest with credentials (#11245)

Devin Foley9adeb4a9d0f4
diff --git a/ui/index.html b/ui/index.html
index 6a5781e711..8c2cbaa6f5 100644
--- a/ui/index.html
+++ b/ui/index.html
@@ -15,7 +15,7 @@
<link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png" />
<!-- PAPERCLIP_FAVICON_END -->
<link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png" />
- <link rel="manifest" href="/site.webmanifest" />
+ <link rel="manifest" href="/site.webmanifest" crossorigin="use-credentials" />
<script>
(() => {
const key = "paperclip.theme";
diff --git a/ui/src/lib/pwa-install-mode.test.ts b/ui/src/lib/pwa-install-mode.test.ts
index fff52295d2..5607852617 100644
--- a/ui/src/lib/pwa-install-mode.test.ts
+++ b/ui/src/lib/pwa-install-mode.test.ts
@@ -17,4 +17,14 @@ describe("PWA install mode", () => {
expect(html).not.toContain('name="apple-mobile-web-app-capable"');
expect(html).not.toContain('name="apple-mobile-web-app-status-bar-style"');
});
+
+ it("fetches the manifest with credentials so authenticating proxies can serve it", () => {
+ const html = readFileSync(resolve(uiRoot, "index.html"), "utf8");
+
+ // Browsers fetch <link rel="manifest"> in "omit credentials" mode unless
+ // the link opts in. Behind an authenticating reverse proxy (e.g. a
+ // managed-hosting front door), the cookie-less request is rejected on
+ // every page load.
+ expect(html).toContain('rel="manifest" href="/site.webmanifest" crossorigin="use-credentials"');
+ });
});