Skip to content

The open-source app everyone uses to manage agents at work

fix(ui): gate built-in agent sidebar query (#10116)

Constantineb42efe206376
diff --git a/ui/src/components/SidebarAgents.test.tsx b/ui/src/components/SidebarAgents.test.tsx
index 89941d58f8..63b0fa1c94 100644
--- a/ui/src/components/SidebarAgents.test.tsx
+++ b/ui/src/components/SidebarAgents.test.tsx
@@ -16,6 +16,14 @@ const mockAgentsApi = vi.hoisted(() => ({
resume: vi.fn(),
}));
+const mockBuiltInAgentsApi = vi.hoisted(() => ({
+ list: vi.fn(),
+}));
+
+const mockInstanceSettingsApi = vi.hoisted(() => ({
+ getExperimental: vi.fn(),
+}));
+
const mockAuthApi = vi.hoisted(() => ({
getSession: vi.fn(),
}));
@@ -93,6 +101,14 @@ vi.mock("../api/agents", () => ({
agentsApi: mockAgentsApi,
}));
+vi.mock("../api/builtInAgents", () => ({
+ builtInAgentsApi: mockBuiltInAgentsApi,
+}));
+
+vi.mock("../api/instanceSettings", () => ({
+ instanceSettingsApi: mockInstanceSettingsApi,
+}));
+
vi.mock("../api/auth", () => ({
authApi: mockAuthApi,
}));
@@ -222,6 +238,8 @@ describe("SidebarAgents", () => {
mockAgentsApi.list.mockResolvedValue([makeAgent({})]);
mockAgentsApi.pause.mockResolvedValue(makeAgent({ status: "paused" }));
mockAgentsApi.resume.mockResolvedValue(makeAgent({}));
+ mockBuiltInAgentsApi.list.mockResolvedValue([]);
+ mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableBuiltInAgents: false });
mockAuthApi.getSession.mockResolvedValue({
session: { id: "session-1", userId: "user-1" },
user: { id: "user-1" },
@@ -340,6 +358,34 @@ describe("SidebarAgents", () => {
await flushReact();
}
+ it("does not query built-in agents when the experimental feature is disabled", async () => {
+ queryClient.setQueryData(queryKeys.builtInAgents.list("company-1"), [
+ { agentId: "agent-1", status: "needs_setup" },
+ ]);
+
+ await renderSidebarAgents();
+
+ expect(mockBuiltInAgentsApi.list).not.toHaveBeenCalled();
+ expect(container.textContent).not.toContain("Needs setup");
+ });
+
+ it("does not query built-in agents while the experimental setting is unresolved", async () => {
+ mockInstanceSettingsApi.getExperimental.mockReturnValue(new Promise(() => {}));
+
+ await renderSidebarAgents();
+
+ expect(mockBuiltInAgentsApi.list).not.toHaveBeenCalled();
+ });
+
+ it("queries built-in agents when the experimental feature is enabled", async () => {
+ mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableBuiltInAgents: true });
+
+ await renderSidebarAgents();
+ await flushReact();
+
+ expect(mockBuiltInAgentsApi.list).toHaveBeenCalledWith("company-1");
+ });
+
it("renders icon-only agent rows with tooltips and no row actions in the rail", async () => {
mockAgentsApi.list.mockResolvedValue([makeAgent({ id: "agent-a", name: "Alpha", urlKey: "alpha" })]);
diff --git a/ui/src/components/SidebarAgents.tsx b/ui/src/components/SidebarAgents.tsx
index 07178ab6f2..14eca32d88 100644
--- a/ui/src/components/SidebarAgents.tsx
+++ b/ui/src/components/SidebarAgents.tsx
@@ -22,6 +22,7 @@ import { builtInAgentsApi, type BuiltInAgentStatus } from "../api/builtInAgents"
import { BuiltInLifecycleChip } from "./BuiltInAgentBadges";
import { authApi } from "../api/auth";
import { heartbeatsApi } from "../api/heartbeats";
+import { instanceSettingsApi } from "../api/instanceSettings";
import { SIDEBAR_SCROLL_RESET_STATE } from "../lib/navigation-scroll";
import { queryKeys } from "../lib/queryKeys";
import { cn, agentRouteRef, agentUrl, SIDEBAR_RAIL_HIDDEN_LABEL } from "../lib/utils";
@@ -310,18 +311,25 @@ export function SidebarAgents({ streamlined = false }: { streamlined?: boolean }
queryFn: () => agentsApi.list(selectedCompanyId!),
enabled: !!selectedCompanyId,
});
+ const { data: experimentalSettings } = useQuery({
+ queryKey: queryKeys.instance.experimentalSettings,
+ queryFn: () => instanceSettingsApi.getExperimental(),
+ enabled: !!selectedCompanyId,
+ });
+ const builtInAgentsEnabled = experimentalSettings?.enableBuiltInAgents === true;
const { data: builtInAgents } = useQuery({
queryKey: queryKeys.builtInAgents.list(selectedCompanyId!),
queryFn: () => builtInAgentsApi.list(selectedCompanyId!),
- enabled: !!selectedCompanyId,
+ enabled: !!selectedCompanyId && builtInAgentsEnabled,
});
const builtInStatusByAgentId = useMemo(() => {
const map = new Map<string, BuiltInAgentStatus>();
+ if (!builtInAgentsEnabled) return map;
for (const entry of builtInAgents ?? []) {
if (entry.agentId) map.set(entry.agentId, entry.status);
}
return map;
- }, [builtInAgents]);
+ }, [builtInAgents, builtInAgentsEnabled]);
const { data: session } = useQuery({
queryKey: queryKeys.auth.session,
queryFn: () => authApi.getSession(),