The open-source app everyone uses to manage agents at work
TypeScript acpxagent-orchestrationagent-skillsagentic-aiai-agentsai-engineeringai-governanceai-toolsautonomous-agentsclaudeclaude-codeclaude-skillscodexhermesllmmcpmulti-agentopenclawproject-managementworkflow-automation
fix(issues): quiet missing-disposition warnings while a live continuation is running (#10899)
Dottac2b41bb7cde7
diff --git a/server/src/__tests__/issue-blocker-attention.test.ts b/server/src/__tests__/issue-blocker-attention.test.tsindex 66247ae4a1..5635320dd4 100644--- a/server/src/__tests__/issue-blocker-attention.test.ts+++ b/server/src/__tests__/issue-blocker-attention.test.ts@@ -834,6 +834,33 @@ describeEmbeddedPostgres("issue blocker attention", () => {state: "missing_disposition",reason: "missing_successful_run_disposition",});++ await db.insert(activityLog).values({+ companyId,+ actorType: "system",+ actorId: "system",+ action: "issue.successful_run_handoff_escalated",+ entityType: "issue",+ entityId: handoffId,+ agentId,+ details: { sourceRunId: randomUUID() },+ });+ const escalatedRows = await svc.list(companyId, { attention: "blocked" });+ expect(escalatedRows.find((row) => row.id === handoffId)?.blockedInboxAttention).toMatchObject({+ state: "missing_disposition",+ reason: "missing_successful_run_disposition",+ });++ const escalatedLiveRunId = await activeRun({ companyId, agentId, issueId: handoffId, current: false });+ const escalatedLiveRows = await svc.list(companyId, { attention: "blocked" });+ expect(escalatedLiveRows.some((row) => row.id === handoffId)).toBe(false);++ await db.update(heartbeatRuns).set({ status: "succeeded" }).where(eq(heartbeatRuns.id, escalatedLiveRunId));+ const escalatedStoppedRows = await svc.list(companyId, { attention: "blocked" });+ expect(escalatedStoppedRows.find((row) => row.id === handoffId)?.blockedInboxAttention).toMatchObject({+ state: "missing_disposition",+ reason: "missing_successful_run_disposition",+ });});it("applies assigneeAgentId='null' as an IS NULL filter on the blocked-inbox path", async () => {diff --git a/server/src/__tests__/issue-list-assignee-filter-routes.test.ts b/server/src/__tests__/issue-list-assignee-filter-routes.test.tsindex ab348695be..1b09113950 100644--- a/server/src/__tests__/issue-list-assignee-filter-routes.test.ts+++ b/server/src/__tests__/issue-list-assignee-filter-routes.test.ts@@ -309,6 +309,70 @@ describeEmbeddedPostgres("issue list routes assigneeAgentId filter", () => {});});+ it("marks an escalated successful-run handoff live while a run targets the issue", async () => {+ const companyId = randomUUID();+ const agentId = randomUUID();+ const issueId = randomUUID();+ const runId = randomUUID();++ await db.insert(companies).values({+ id: companyId,+ name: "Paperclip",+ issuePrefix: uniqueIssuePrefix(),+ requireBoardApprovalForNewAgents: false,+ });+ await seedCloudTenantMember(companyId);+ await db.insert(agents).values({+ id: agentId,+ companyId,+ name: "Assignee",+ role: "engineer",+ status: "active",+ adapterType: "codex_local",+ adapterConfig: {},+ runtimeConfig: {},+ permissions: {},+ });+ await db.insert(issues).values({+ id: issueId,+ companyId,+ title: "Escalated handoff issue",+ status: "in_progress",+ priority: "medium",+ assigneeAgentId: agentId,+ });+ await db.insert(activityLog).values({+ companyId,+ actorType: "system",+ actorId: "system",+ action: "issue.successful_run_handoff_escalated",+ entityType: "issue",+ entityId: issueId,+ agentId,+ details: { sourceRunId: randomUUID() },+ });+ await db.insert(heartbeatRuns).values({+ id: runId,+ companyId,+ agentId,+ status: "running",+ contextSnapshot: { taskId: issueId },+ });++ const app = createApp(companyId);+ const res = await request(app)+ .get(`/api/companies/${companyId}/issues`)+ .query({ view: "compact", limit: "20" });++ expect(res.status, JSON.stringify(res.body)).toBe(200);+ expect(res.body[0]?.successfulRunHandoff).toMatchObject({+ state: "escalated",+ required: false,+ hasLiveContinuation: true,+ liveRunId: runId,+ });+ });+it("logs resolved when a valid-path skip closes a stale required handoff", async () => {const companyId = randomUUID();const agentId = randomUUID();diff --git a/server/src/services/issues.ts b/server/src/services/issues.tsindex b39da59610..917a941a58 100644--- a/server/src/services/issues.ts+++ b/server/src/services/issues.ts@@ -3891,7 +3891,7 @@ async function listIssueBlockedInboxAttentionMap(const source = issueRef(row);const handoff = handoffMap.get(row.id);const hasLiveHandoffContinuation = Boolean(- handoff?.state === "required"+ (handoff?.state === "required" || handoff?.state === "escalated")&& (liveHandoffRunIssueIds.has(row.id) || liveHandoffWakeIssueIds.has(row.id)));if (handoff && !hasLiveHandoffContinuation && (handoff.required || handoff.state === "escalated")) {diff --git a/server/src/services/successful-run-handoff-state.ts b/server/src/services/successful-run-handoff-state.tsindex 3bfc1effe6..ea48539765 100644--- a/server/src/services/successful-run-handoff-state.ts+++ b/server/src/services/successful-run-handoff-state.ts@@ -24,10 +24,10 @@ export async function hydrateSuccessfulRunHandoffLiveness(companyId: string,states: Map<string, SuccessfulRunHandoffState>,) {- const requiredIssueIds = [...states.entries()]- .filter(([, state]) => state.state === "required")+ const unresolvedIssueIds = [...states.entries()]+ .filter(([, state]) => state.state === "required" || state.state === "escalated").map(([issueId]) => issueId);- if (requiredIssueIds.length === 0) return states;+ if (unresolvedIssueIds.length === 0) return states;const [activeRuns, activeWakes] = await Promise.all([dbOrTx@@ -36,7 +36,7 @@ export async function hydrateSuccessfulRunHandoffLiveness(.where(and(eq(heartbeatRuns.companyId, companyId),inArray(heartbeatRuns.status, [...SUCCESSFUL_RUN_HANDOFF_LIVE_RUN_STATUSES]),- inArray(heartbeatRunIssueId, requiredIssueIds),+ inArray(heartbeatRunIssueId, unresolvedIssueIds),)),dbOrTx.select({ issueId: wakeRequestIssueId })@@ -44,7 +44,7 @@ export async function hydrateSuccessfulRunHandoffLiveness(.where(and(eq(agentWakeupRequests.companyId, companyId),inArray(agentWakeupRequests.status, [...SUCCESSFUL_RUN_HANDOFF_LIVE_WAKE_STATUSES]),- inArray(wakeRequestIssueId, requiredIssueIds),+ inArray(wakeRequestIssueId, unresolvedIssueIds),)),]);@@ -58,7 +58,7 @@ export async function hydrateSuccessfulRunHandoffLiveness(.filter((issueId): issueId is string => Boolean(issueId)),);- for (const issueId of requiredIssueIds) {+ for (const issueId of unresolvedIssueIds) {const state = states.get(issueId);if (!state) continue;const liveRunId = liveRunByIssueId.get(issueId);diff --git a/ui/src/components/IssueBlockedNotice.test.tsx b/ui/src/components/IssueBlockedNotice.test.tsxindex 0ac990446e..70fc802709 100644--- a/ui/src/components/IssueBlockedNotice.test.tsx+++ b/ui/src/components/IssueBlockedNotice.test.tsx@@ -187,6 +187,80 @@ describe("IssueBlockedNotice", () => {});});+ it("hides the next-step notice while a live continuation is running the issue", () => {+ const node = render(+ <IssueBlockedNotice+ issueStatus="in_progress"+ blockers={[]}+ agentName="CodexCoder"+ successfulRunHandoff={{+ state: "required",+ required: true,+ hasLiveContinuation: true,+ liveRunId: "87654321-dddd-eeee-ffff-123456789abc",+ sourceRunId: "12345678-aaaa-bbbb-cccc-123456789abc",+ correctiveRunId: null,+ assigneeAgentId: "agent-1",+ detectedProgressSummary: "Updated the plan and left follow-up work.",+ createdAt: "2026-05-01T00:00:00.000Z",+ }}+ />,+ );++ expect(node.querySelector('[data-successful-run-handoff="required"]')).toBeNull();+ expect(node.textContent).toBe("");+ });++ it("hides the next-step notice when the live-run set includes this issue", () => {+ const node = render(+ <IssueBlockedNotice+ issueId="issue-1"+ issueStatus="in_progress"+ blockers={[]}+ liveIssueIds={new Set(["issue-1"])}+ agentName="CodexCoder"+ successfulRunHandoff={{+ state: "required",+ required: true,+ hasLiveContinuation: false,+ sourceRunId: "12345678-aaaa-bbbb-cccc-123456789abc",+ correctiveRunId: null,+ assigneeAgentId: "agent-1",+ detectedProgressSummary: null,+ createdAt: "2026-05-01T00:00:00.000Z",+ }}+ />,+ );++ expect(node.querySelector('[data-successful-run-handoff="required"]')).toBeNull();+ expect(node.textContent).toBe("");+ });++ it("keeps the next-step notice and retry-now when the only continuation is an unpromoted scheduled retry", () => {+ const node = render(+ <IssueBlockedNotice+ issueId="issue-1"+ issueStatus="in_progress"+ blockers={[]}+ agentName="CodexCoder"+ scheduledRetry={baseRetry}+ successfulRunHandoff={{+ state: "required",+ required: true,+ hasLiveContinuation: true,+ sourceRunId: "12345678-aaaa-bbbb-cccc-123456789abc",+ correctiveRunId: null,+ assigneeAgentId: "agent-1",+ detectedProgressSummary: null,+ createdAt: "2026-05-01T00:00:00.000Z",+ }}+ />,+ );++ expect(node.querySelector('[data-successful-run-handoff="required"]')).not.toBeNull();+ expect(node.querySelector('[data-testid="issue-next-step-retry-now"]')).not.toBeNull();+ });+it("does not render when the issue is done even if a stale handoff state is required", () => {const node = render(<IssueBlockedNoticediff --git a/ui/src/components/IssueBlockedNotice.tsx b/ui/src/components/IssueBlockedNotice.tsxindex 3454e50b33..83e766a13a 100644--- a/ui/src/components/IssueBlockedNotice.tsx+++ b/ui/src/components/IssueBlockedNotice.tsx@@ -16,6 +16,7 @@ import { useRetryNowMutation } from "../hooks/useRetryNowMutation";import { IssueLinkQuicklook } from "./IssueLinkQuicklook";import { RetryErrorBand } from "./IssueScheduledRetryCard";import { isAssignedBacklogBlocker } from "../lib/issue-blockers";+import { isSuccessfulRunHandoffRequired } from "../lib/successful-run-handoff";import { Badge } from "@/components/ui/badge";import {deriveActiveRecoveryDisplayState,@@ -379,7 +380,14 @@ export function IssueBlockedNotice({agentName?: string | null;}) {if (issueStatus === "done" || issueStatus === "cancelled") return null;- const showSuccessfulRunHandoff = successfulRunHandoff?.required === true;+ // A live run on this issue means an agent is already handling it — the+ // missing-disposition complaint only applies when the issue is stuck.+ // `hasLiveContinuation` is the server's view; `liveIssueIds` catches runs+ // that started after the issue payload was fetched.+ const showSuccessfulRunHandoff =+ successfulRunHandoff != null+ && isSuccessfulRunHandoffRequired({ successfulRunHandoff, scheduledRetry })+ && !(issueId && liveIssueIds?.has(issueId));if (!showSuccessfulRunHandoff && blockers.length === 0 && issueStatus !== "blocked") return null;const successfulRunRetryNow = showSuccessfulRunHandoff&& issueIddiff --git a/ui/src/components/IssueChatThread.tsx b/ui/src/components/IssueChatThread.tsxindex af884ca0c4..c540cab21a 100644--- a/ui/src/components/IssueChatThread.tsx+++ b/ui/src/components/IssueChatThread.tsx@@ -2411,6 +2411,10 @@ function isStaleSuccessfulRunHandoffNotice(input: {const currentHandoff = input.successfulRunHandoff ?? null;if (currentHandoff?.state === "resolved") return true;if (issueStatusIsTerminalDisposition(input.issueStatus)) return true;+ // A live continuation (running/queued run or queued wake) means an agent is+ // already handling the issue — fold the warning until the issue is actually+ // stuck again.+ if (currentHandoff?.hasLiveContinuation) return true;const noticeSourceRunId = sourceRunIdFromSuccessfulRunHandoffMetadata(input.metadata) ?? input.runId ?? null;if (@@ -4476,6 +4480,16 @@ export function IssueChatThread({() => displayLiveRuns.some((run) => run.status === "running") || activeRun?.status === "running",[displayLiveRuns, activeRun],);+ // Real-time view of the handoff: a run that starts after the issue payload+ // was fetched must quiet the missing-disposition warnings without waiting+ // for a refetch to update `hasLiveContinuation`.+ const successfulRunHandoffWithLiveness = useMemo(() => {+ if (!successfulRunHandoff || successfulRunHandoff.hasLiveContinuation) {+ return successfulRunHandoff ?? null;+ }+ const liveNow = activeRunIds.size > 0 || Boolean(issueId && liveIssueIds?.has(issueId));+ return liveNow ? { ...successfulRunHandoff, hasLiveContinuation: true } : successfulRunHandoff;+ }, [successfulRunHandoff, activeRunIds, issueId, liveIssueIds]);const clearLatestSettleTimeouts = useCallback(() => {for (const timeout of latestSettleTimeoutsRef.current) {window.clearTimeout(timeout);@@ -4954,7 +4968,7 @@ export function IssueChatThread({onUploadImage: stableOnUploadImage,issueStatus,issueAssigneeAgentId,- successfulRunHandoff,+ successfulRunHandoff: successfulRunHandoffWithLiveness,externalReferences,linkCaseReferences,}),@@ -4983,7 +4997,7 @@ export function IssueChatThread({stableOnUploadImage,issueStatus,issueAssigneeAgentId,- successfulRunHandoff,+ successfulRunHandoffWithLiveness,externalReferences,linkCaseReferences,],@@ -5126,7 +5140,7 @@ export function IssueChatThread({allBlockers={blockedBy}liveIssueIds={liveIssueIds}blockerAttention={blockerAttention}- successfulRunHandoff={recoveryAction ? null : successfulRunHandoff}+ successfulRunHandoff={recoveryAction ? null : successfulRunHandoffWithLiveness}scheduledRetry={scheduledRetry}agentName={successfulRunHandoff?.assigneeAgentIddiff --git a/ui/src/components/IssueChatThreadSystemNotice.test.tsx b/ui/src/components/IssueChatThreadSystemNotice.test.tsxindex a3799deccb..410d6b3068 100644--- a/ui/src/components/IssueChatThreadSystemNotice.test.tsx+++ b/ui/src/components/IssueChatThreadSystemNotice.test.tsx@@ -7,6 +7,7 @@ import { MemoryRouter } from "react-router-dom";import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";import { IssueChatThread } from "./IssueChatThread";import type { IssueChatComment } from "../lib/issue-chat-messages";+import type { LiveRunForIssue } from "../api/heartbeats";import type { Agent, SuccessfulRunHandoffState } from "@paperclipai/shared";vi.mock("@assistant-ui/react", () => ({@@ -76,6 +77,7 @@ function renderThread(agentMap?: Map<string, Agent>;issueStatus?: string;successfulRunHandoff?: SuccessfulRunHandoffState | null;+ liveRuns?: LiveRunForIssue[];} = {},) {act(() => {@@ -85,7 +87,7 @@ function renderThread(comments={comments}linkedRuns={[]}timelineEvents={[]}- liveRuns={[]}+ liveRuns={options.liveRuns ?? []}onAdd={async () => {}}showComposer={false}enableLiveTranscriptPolling={false}@@ -652,4 +654,152 @@ describe("IssueChatThread system notice routing", () => {expect(details).toHaveProperty("hidden", false);expect(container.textContent).toContain("run-stale");});++ it("folds a required disposition warning while a live continuation is running the issue", () => {+ const comment: IssueChatComment = {+ id: "comment-live-disposition-warning",+ companyId: "company-1",+ issueId: "issue-1",+ authorType: "system",+ authorAgentId: null,+ authorUserId: null,+ runId: "run-source",+ runAgentId: "agent-codex",+ body: "Paperclip needs a disposition before this issue can continue.",+ presentation: {+ kind: "system_notice",+ tone: "warning",+ title: "Missing issue disposition",+ detailsDefaultOpen: false,+ },+ metadata: {+ version: 1,+ sourceRunId: "run-source",+ sections: [],+ },+ ...baseTimestamps,+ };++ renderThread([comment], {+ issueStatus: "in_progress",+ successfulRunHandoff: {+ state: "required",+ required: true,+ hasLiveContinuation: true,+ liveRunId: "run-live",+ sourceRunId: "run-source",+ correctiveRunId: null,+ assigneeAgentId: "agent-codex",+ detectedProgressSummary: null,+ createdAt: new Date("2026-05-04T17:00:00.000Z"),+ },+ });++ const row = container.querySelector('[data-testid="stale-disposition-warning"]');+ expect(row).not.toBeNull();+ expect(row?.textContent).not.toContain("Paperclip needs a disposition before this issue can continue.");+ });++ it("keeps the required disposition warning loud when no live continuation exists", () => {+ const comment: IssueChatComment = {+ id: "comment-stuck-disposition-warning",+ companyId: "company-1",+ issueId: "issue-1",+ authorType: "system",+ authorAgentId: null,+ authorUserId: null,+ runId: "run-source",+ runAgentId: "agent-codex",+ body: "Paperclip needs a disposition before this issue can continue.",+ presentation: {+ kind: "system_notice",+ tone: "warning",+ title: "Missing issue disposition",+ detailsDefaultOpen: false,+ },+ metadata: {+ version: 1,+ sourceRunId: "run-source",+ sections: [],+ },+ ...baseTimestamps,+ };++ renderThread([comment], {+ issueStatus: "in_progress",+ successfulRunHandoff: {+ state: "required",+ required: true,+ hasLiveContinuation: false,+ sourceRunId: "run-source",+ correctiveRunId: null,+ assigneeAgentId: "agent-codex",+ detectedProgressSummary: null,+ createdAt: new Date("2026-05-04T17:00:00.000Z"),+ },+ });++ expect(container.querySelector('[data-testid="stale-disposition-warning"]')).toBeNull();+ expect(container.textContent).toContain("Paperclip needs a disposition before this issue can continue.");+ });++ it("folds a required disposition warning when a live run starts after the issue payload was fetched", () => {+ const comment: IssueChatComment = {+ id: "comment-realtime-disposition-warning",+ companyId: "company-1",+ issueId: "issue-1",+ authorType: "system",+ authorAgentId: null,+ authorUserId: null,+ runId: "run-source",+ runAgentId: "agent-codex",+ body: "Paperclip needs a disposition before this issue can continue.",+ presentation: {+ kind: "system_notice",+ tone: "warning",+ title: "Missing issue disposition",+ detailsDefaultOpen: false,+ },+ metadata: {+ version: 1,+ sourceRunId: "run-source",+ sections: [],+ },+ ...baseTimestamps,+ };++ renderThread([comment], {+ issueStatus: "in_progress",+ liveRuns: [+ {+ id: "run-live",+ status: "running",+ invocationSource: "wakeup",+ triggerDetail: null,+ startedAt: "2026-05-04T17:05:00.000Z",+ finishedAt: null,+ createdAt: "2026-05-04T17:05:00.000Z",+ agentId: "agent-codex",+ agentName: "CodexCoder",+ adapterType: "codex_local",+ issueId: "issue-1",+ },+ ],+ successfulRunHandoff: {+ state: "required",+ required: true,+ // Stale server view: the payload was fetched before run-live started.+ hasLiveContinuation: false,+ sourceRunId: "run-source",+ correctiveRunId: null,+ assigneeAgentId: "agent-codex",+ detectedProgressSummary: null,+ createdAt: new Date("2026-05-04T17:00:00.000Z"),+ },+ });++ const row = container.querySelector('[data-testid="stale-disposition-warning"]');+ expect(row).not.toBeNull();+ expect(row?.textContent).not.toContain("Paperclip needs a disposition before this issue can continue.");+ });});diff --git a/ui/src/lib/successful-run-handoff.ts b/ui/src/lib/successful-run-handoff.tsindex 8246861f56..1f54db8b81 100644--- a/ui/src/lib/successful-run-handoff.ts+++ b/ui/src/lib/successful-run-handoff.ts@@ -14,8 +14,17 @@ export function isSuccessfulRunHandoffActivity(action: string) {|| action === SUCCESSFUL_RUN_HANDOFF_ESCALATED_ACTION;}-export function isSuccessfulRunHandoffRequired(issue: Pick<Issue, "successfulRunHandoff">) {- return issue.successfulRunHandoff?.required === true;+export function isSuccessfulRunHandoffRequired(+ issue: Pick<Issue, "successfulRunHandoff"> & Partial<Pick<Issue, "scheduledRetry">>,+) {+ const handoff = issue.successfulRunHandoff;+ if (handoff?.required !== true) return false;+ // A live continuation (running/queued run or queued wake) means an agent is+ // already on the issue — only complain when nothing is moving. The one+ // carve-out is a not-yet-promoted scheduled retry: the notice stays visible+ // there so the "Retry now" control remains reachable.+ if (!handoff.hasLiveContinuation) return true;+ return issue.scheduledRetry?.status === "scheduled_retry";}function readString(value: unknown) {