Skip to content

The open-source app everyone uses to manage agents at work

fix(routines): include cronExpression and timezone in list trigger response (#3209)

Lempkeyd0a8d4e08a5a
diff --git a/packages/shared/src/types/routine.ts b/packages/shared/src/types/routine.ts
index 4efdc748c6..c25ecb358e 100644
--- a/packages/shared/src/types/routine.ts
+++ b/packages/shared/src/types/routine.ts
@@ -129,7 +129,7 @@ export interface RoutineExecutionIssueOrigin {
}
export interface RoutineListItem extends Routine {
- triggers: Pick<RoutineTrigger, "id" | "kind" | "label" | "enabled" | "nextRunAt" | "lastFiredAt" | "lastResult">[];
+ triggers: Pick<RoutineTrigger, "id" | "kind" | "label" | "enabled" | "cronExpression" | "timezone" | "nextRunAt" | "lastFiredAt" | "lastResult">[];
lastRun: RoutineRunSummary | null;
activeIssue: RoutineIssueSummary | null;
}
diff --git a/server/src/__tests__/routines-e2e.test.ts b/server/src/__tests__/routines-e2e.test.ts
index dbc9801cd8..5af5c4dfc1 100644
--- a/server/src/__tests__/routines-e2e.test.ts
+++ b/server/src/__tests__/routines-e2e.test.ts
@@ -267,6 +267,14 @@ describeEmbeddedPostgres("routine routes end-to-end", () => {
expect(runRes.body.source).toBe("manual");
expect(runRes.body.linkedIssueId).toBeTruthy();
+ const listRes = await request(app).get(`/api/companies/${companyId}/routines`);
+ expect(listRes.status).toBe(200);
+ const listed = listRes.body.find((r: { id: string }) => r.id === routineId);
+ expect(listed).toBeDefined();
+ expect(listed.triggers).toHaveLength(1);
+ expect(listed.triggers[0].cronExpression).toBe("0 10 * * 1-5");
+ expect(listed.triggers[0].timezone).toBe("UTC");
+
const detailRes = await request(app).get(`/api/routines/${routineId}`);
expect(detailRes.status).toBe(200);
expect(detailRes.body.triggers).toHaveLength(1);
diff --git a/server/src/services/routines.ts b/server/src/services/routines.ts
index db117653b0..80dfd33a8f 100644
--- a/server/src/services/routines.ts
+++ b/server/src/services/routines.ts
@@ -921,6 +921,8 @@ export function routineService(db: Db, deps: { heartbeat?: IssueAssignmentWakeup
kind: trigger.kind as RoutineListItem["triggers"][number]["kind"],
label: trigger.label,
enabled: trigger.enabled,
+ cronExpression: trigger.cronExpression,
+ timezone: trigger.timezone,
nextRunAt: trigger.nextRunAt,
lastFiredAt: trigger.lastFiredAt,
lastResult: trigger.lastResult,