Skip to content

The open-source app everyone uses to manage agents at work

Merge public/master into pap-1239-server-test-isolation

dottada251e5eab53
diff --cc server/src/__tests__/agent-permissions-routes.test.ts
index 876b398137,e553d0acdd..6ef45db164
--- a/server/src/__tests__/agent-permissions-routes.test.ts
+++ b/server/src/__tests__/agent-permissions-routes.test.ts
@@@ -230,6 -213,80 +230,80 @@@ describe("agent permission routes", ()
);
});
+ it("normalizes direct agent creation to disable timer heartbeats by default", async () => {
- const app = createApp({
++ const app = await createApp({
+ type: "board",
+ userId: "board-user",
+ source: "local_implicit",
+ isInstanceAdmin: true,
+ companyIds: [companyId],
+ });
+
+ const res = await request(app)
+ .post(`/api/companies/${companyId}/agents`)
+ .send({
+ name: "Builder",
+ role: "engineer",
+ adapterType: "process",
+ adapterConfig: {},
+ runtimeConfig: {
+ heartbeat: {
+ intervalSec: 3600,
+ },
+ },
+ });
+
+ expect(res.status).toBe(201);
+ expect(mockAgentService.create).toHaveBeenCalledWith(
+ companyId,
+ expect.objectContaining({
+ runtimeConfig: {
+ heartbeat: {
+ enabled: false,
+ intervalSec: 3600,
+ },
+ },
+ }),
+ );
+ });
+
+ it("normalizes hire requests to disable timer heartbeats by default", async () => {
- const app = createApp({
++ const app = await createApp({
+ type: "board",
+ userId: "board-user",
+ source: "local_implicit",
+ isInstanceAdmin: true,
+ companyIds: [companyId],
+ });
+
+ const res = await request(app)
+ .post(`/api/companies/${companyId}/agent-hires`)
+ .send({
+ name: "Builder",
+ role: "engineer",
+ adapterType: "process",
+ adapterConfig: {},
+ runtimeConfig: {
+ heartbeat: {
+ intervalSec: 3600,
+ },
+ },
+ });
+
+ expect(res.status).toBe(201);
+ expect(mockAgentService.create).toHaveBeenCalledWith(
+ companyId,
+ expect.objectContaining({
+ runtimeConfig: {
+ heartbeat: {
+ enabled: false,
+ intervalSec: 3600,
+ },
+ },
+ }),
+ );
+ });
+
it("exposes explicit task assignment access on agent detail", async () => {
mockAccessService.listPrincipalGrants.mockResolvedValue([
{
diff --cc server/src/__tests__/issue-comment-reopen-routes.test.ts
index 336c95cd89,135d80662c..ed2a68859e
--- a/server/src/__tests__/issue-comment-reopen-routes.test.ts
+++ b/server/src/__tests__/issue-comment-reopen-routes.test.ts
@@@ -87,13 -79,9 +87,13 @@@ function createApp()
return app;
}
-function installActor(app: express.Express, actor?: Record<string, unknown>) {
+async function installActor(app: express.Express, actor?: Record<string, unknown>) {
+ const [{ issueRoutes }, { errorHandler }] = await Promise.all([
+ import("../routes/issues.js"),
+ import("../middleware/index.js"),
+ ]);
app.use((req, _res, next) => {
- (req as any).actor = {
+ (req as any).actor = actor ?? {
type: "board",
userId: "local-board",
companyIds: ["company-1"],
@@@ -343,4 -303,146 +347,146 @@@ describe("issue comment reopen routes"
}),
);
});
+
+ it("coerces executor handoff patches into workflow-controlled review wakes", async () => {
- const policy = normalizeIssueExecutionPolicy({
++ const policy = await normalizePolicy({
+ stages: [
+ {
+ id: "aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa",
+ type: "review",
+ participants: [{ type: "agent", agentId: "33333333-3333-4333-8333-333333333333" }],
+ },
+ ],
+ })!;
+ const issue = {
+ ...makeIssue("todo"),
+ status: "in_progress",
+ assigneeAgentId: "22222222-2222-4222-8222-222222222222",
+ executionPolicy: policy,
+ executionState: null,
+ };
+ mockIssueService.getById.mockResolvedValue(issue);
+ mockIssueService.update.mockImplementation(async (_id: string, patch: Record<string, unknown>) => ({
+ ...issue,
+ ...patch,
+ updatedAt: new Date(),
+ }));
+
+ const res = await request(
- installActor(createApp(), {
++ await installActor(createApp(), {
+ type: "agent",
+ agentId: "22222222-2222-4222-8222-222222222222",
+ companyId: "company-1",
+ runId: "run-1",
+ }),
+ )
+ .patch("/api/issues/11111111-1111-4111-8111-111111111111")
+ .send({
+ status: "in_review",
+ assigneeAgentId: null,
+ assigneeUserId: "local-board",
+ });
+
+ expect(res.status).toBe(200);
+ expect(mockIssueService.update).toHaveBeenCalledWith(
+ "11111111-1111-4111-8111-111111111111",
+ expect.objectContaining({
+ status: "in_review",
+ assigneeAgentId: "33333333-3333-4333-8333-333333333333",
+ assigneeUserId: null,
+ executionState: expect.objectContaining({
+ status: "pending",
+ currentStageType: "review",
+ currentParticipant: expect.objectContaining({
+ type: "agent",
+ agentId: "33333333-3333-4333-8333-333333333333",
+ }),
+ returnAssignee: expect.objectContaining({
+ type: "agent",
+ agentId: "22222222-2222-4222-8222-222222222222",
+ }),
+ }),
+ }),
+ );
+ expect(mockHeartbeatService.wakeup).toHaveBeenCalledWith(
+ "33333333-3333-4333-8333-333333333333",
+ expect.objectContaining({
+ reason: "execution_review_requested",
+ payload: expect.objectContaining({
+ issueId: "11111111-1111-4111-8111-111111111111",
+ executionStage: expect.objectContaining({
+ wakeRole: "reviewer",
+ stageType: "review",
+ allowedActions: ["approve", "request_changes"],
+ }),
+ }),
+ }),
+ );
+ });
+
+ it("wakes the return assignee with execution_changes_requested", async () => {
- const policy = normalizeIssueExecutionPolicy({
++ const policy = await normalizePolicy({
+ stages: [
+ {
+ id: "aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa",
+ type: "review",
+ participants: [{ type: "agent", agentId: "33333333-3333-4333-8333-333333333333" }],
+ },
+ ],
+ })!;
+ const issue = {
+ ...makeIssue("todo"),
+ status: "in_review",
+ assigneeAgentId: "33333333-3333-4333-8333-333333333333",
+ executionPolicy: policy,
+ executionState: {
+ status: "pending",
+ currentStageId: policy.stages[0].id,
+ currentStageIndex: 0,
+ currentStageType: "review",
+ currentParticipant: { type: "agent", agentId: "33333333-3333-4333-8333-333333333333" },
+ returnAssignee: { type: "agent", agentId: "22222222-2222-4222-8222-222222222222" },
+ completedStageIds: [],
+ lastDecisionId: null,
+ lastDecisionOutcome: null,
+ },
+ };
+ mockIssueService.getById.mockResolvedValue(issue);
+ mockIssueService.update.mockImplementation(async (_id: string, patch: Record<string, unknown>) => ({
+ ...issue,
+ ...patch,
+ updatedAt: new Date(),
+ }));
+
+ const res = await request(
- installActor(createApp(), {
++ await installActor(createApp(), {
+ type: "agent",
+ agentId: "33333333-3333-4333-8333-333333333333",
+ companyId: "company-1",
+ runId: "run-2",
+ }),
+ )
+ .patch("/api/issues/11111111-1111-4111-8111-111111111111")
+ .send({
+ status: "in_progress",
+ comment: "Needs another pass",
+ });
+
+ expect(res.status).toBe(200);
+ expect(mockHeartbeatService.wakeup).toHaveBeenCalledWith(
+ "22222222-2222-4222-8222-222222222222",
+ expect.objectContaining({
+ reason: "execution_changes_requested",
+ payload: expect.objectContaining({
+ issueId: "11111111-1111-4111-8111-111111111111",
+ executionStage: expect.objectContaining({
+ wakeRole: "executor",
+ stageType: "review",
+ lastDecisionOutcome: "changes_requested",
+ allowedActions: ["address_changes", "resubmit"],
+ }),
+ }),
+ }),
+ );
+ });
});