The open-source app everyone uses to manage agents at work
TypeScript acpxagent-orchestrationagent-skillsagentic-aiai-agentsai-engineeringai-governanceai-toolsautonomous-agentsclaudeclaude-codeclaude-skillscodexhermesllmmcpmulti-agentopenclawproject-managementworkflow-automation
fix(interactions): don't supersede decision cards on machine-authored comments (#9015)
Nicholas Sollazzodf0e5bd0212c
diff --git a/server/src/__tests__/issue-thread-interactions-service.test.ts b/server/src/__tests__/issue-thread-interactions-service.test.tsindex 8a957a6b4e..eae6dbc28d 100644--- a/server/src/__tests__/issue-thread-interactions-service.test.ts+++ b/server/src/__tests__/issue-thread-interactions-service.test.ts@@ -1627,6 +1627,43 @@ describeEmbeddedPostgres("issueThreadInteractionService", () => {expect(rows[0]?.status).toBe("pending");});+ it("does not supersede request confirmations for run-originated comments even under user auth", async () => {+ // Local-CLI agents post under user auth, so authorUserId is set nondeterministically.+ // A comment carrying createdByRunId is machine-originated and must never expire a+ // pending decision card.+ const { companyId, issueId } = await seedConfirmationIssue("Run-originated comment supersede exclusion");++ const created = await interactionsSvc.create({+ id: issueId,+ companyId,+ }, {+ kind: "request_confirmation",+ payload: {+ version: 1,+ prompt: "Proceed with the current draft?",+ },+ }, {+ userId: "local-board",+ });++ const expired = await interactionsSvc.expireRequestConfirmationsSupersededByComment({+ id: issueId,+ companyId,+ }, {+ id: randomUUID(),+ createdAt: new Date(new Date(created.createdAt).getTime() + 1_000),+ authorUserId: "local-board",+ createdByRunId: randomUUID(),+ }, {+ userId: "local-board",+ });++ expect(expired).toHaveLength(0);+ const rows = await db.select().from(issueThreadInteractions);+ expect(rows).toHaveLength(1);+ expect(rows[0]?.status).toBe("pending");+ });+it("repairs historical request confirmations superseded by later user comments idempotently", async () => {const { companyId, issueId } = await seedConfirmationIssue("Historical comment supersede");const commentId = randomUUID();@@ -1693,6 +1730,69 @@ describeEmbeddedPostgres("issueThreadInteractionService", () => {})).resolves.toEqual([]);});+ it("does not repair historical confirmations from run-originated comments", async () => {+ // The repair sweep must ignore machine-originated comments (createdByRunId set) even+ // when authorUserId is present under user auth.+ const { companyId, issueId } = await seedConfirmationIssue("Historical run-originated exclusion");+ const agentId = randomUUID();+ const runId = randomUUID();+ const createdAt = new Date("2026-05-18T12:00:00.000Z");++ const created = await interactionsSvc.create({+ id: issueId,+ companyId,+ }, {+ kind: "request_confirmation",+ payload: {+ version: 1,+ prompt: "Proceed with the current draft?",+ },+ }, {+ userId: "local-board",+ });+ await db+ .update(issueThreadInteractions)+ .set({ createdAt, updatedAt: createdAt })+ .where(eq(issueThreadInteractions.id, created.id));++ await db.insert(agents).values({+ id: agentId,+ companyId,+ name: "GiskardCoder",+ role: "engineer",+ status: "active",+ adapterType: "claude_local",+ adapterConfig: {},+ runtimeConfig: {},+ permissions: {},+ });+ await db.insert(heartbeatRuns).values({+ id: runId,+ companyId,+ agentId,+ status: "running",+ });+ await db.insert(issueComments).values({+ id: randomUUID(),+ companyId,+ issueId,+ authorUserId: "local-board",+ authorType: "user",+ createdByRunId: runId,+ body: "SLA escalation relay posted from a heartbeat run.",+ createdAt: new Date("2026-05-18T12:01:00.000Z"),+ updatedAt: new Date("2026-05-18T12:01:00.000Z"),+ });++ await expect(interactionsSvc.expireRequestConfirmationsSupersededByHistoricalComments({+ id: issueId,+ companyId,+ })).resolves.toEqual([]);+ const rows = await db.select().from(issueThreadInteractions);+ expect(rows).toHaveLength(1);+ expect(rows[0]?.status).toBe("pending");+ });+it("expires request confirmations when the watched issue document revision changes", async () => {const companyId = randomUUID();const goalId = randomUUID();diff --git a/server/src/services/issue-thread-interactions.ts b/server/src/services/issue-thread-interactions.tsindex 5a2a3ae19d..a5c74a5eea 100644--- a/server/src/services/issue-thread-interactions.ts+++ b/server/src/services/issue-thread-interactions.ts@@ -1,5 +1,5 @@import { isDeepStrictEqual } from "node:util";-import { and, asc, eq, inArray, isNotNull } from "drizzle-orm";+import { and, asc, eq, inArray, isNotNull, isNull } from "drizzle-orm";import type { Db } from "@paperclipai/db";import {agents,@@ -1572,10 +1572,13 @@ export function issueThreadInteractionService(db: Db) {expireRequestConfirmationsSupersededByComment: async (issue: { id: string; companyId: string },- comment: { id: string; createdAt: Date | string; authorUserId?: string | null },+ comment: { id: string; createdAt: Date | string; authorUserId?: string | null; createdByRunId?: string | null },actor: InteractionActor,) => {if (!comment.authorUserId) return [];+ // Local-CLI adapters post under user auth, so authorUserId can't tell a human from a+ // machine; createdByRunId can. Only genuine human comments (no run context) supersede.+ if (comment.createdByRunId) return [];const rows = await db.select()@@ -1649,6 +1652,8 @@ export function issueThreadInteractionService(db: Db) {eq(issueComments.companyId, issue.companyId),eq(issueComments.issueId, issue.id),isNotNull(issueComments.authorUserId),+ // Only genuine human comments supersede; machine-originated ones carry createdByRunId.+ isNull(issueComments.createdByRunId),)).orderBy(asc(issueComments.createdAt)),]);