The open-source app everyone uses to manage agents at work
TypeScript acpxagent-orchestrationagent-skillsagentic-aiai-agentsai-engineeringai-governanceai-toolsautonomous-agentsclaudeclaude-codeclaude-skillscodexhermesllmmcpmulti-agentopenclawproject-managementworkflow-automation
fix(onboard): preserve env-derived secrets defaults and report ignored exposure env in local_trusted mode
zvictore1d4e37776f0
diff --git a/cli/src/commands/onboard.ts b/cli/src/commands/onboard.tsindex e0c8a2bf0b..0e70d9cf17 100644--- a/cli/src/commands/onboard.ts+++ b/cli/src/commands/onboard.ts@@ -99,7 +99,11 @@ function resolvePathFromEnv(rawValue: string | undefined): string | null {return path.resolve(expandHomePrefix(rawValue.trim()));}-function quickstartDefaultsFromEnv(): { defaults: OnboardDefaults; usedEnvKeys: string[] } {+function quickstartDefaultsFromEnv(): {+ defaults: OnboardDefaults;+ usedEnvKeys: string[];+ ignoredEnvKeys: Array<{ key: string; reason: string }>;+} {const instanceId = resolvePaperclipInstanceId();const defaultStorage = defaultStorageConfig();const defaultSecrets = defaultSecretsConfig();@@ -209,8 +213,19 @@ function quickstartDefaultsFromEnv(): { defaults: OnboardDefaults; usedEnvKeys:},},};- const usedEnvKeys = ONBOARD_ENV_KEYS.filter((key) => process.env[key] !== undefined);- return { defaults, usedEnvKeys };+ const ignoredEnvKeys: Array<{ key: string; reason: string }> = [];+ if (deploymentMode === "local_trusted" && process.env.PAPERCLIP_DEPLOYMENT_EXPOSURE !== undefined) {+ ignoredEnvKeys.push({+ key: "PAPERCLIP_DEPLOYMENT_EXPOSURE",+ reason: "Ignored because deployment mode local_trusted always forces private exposure",+ });+ }++ const ignoredKeySet = new Set(ignoredEnvKeys.map((entry) => entry.key));+ const usedEnvKeys = ONBOARD_ENV_KEYS.filter(+ (key) => process.env[key] !== undefined && !ignoredKeySet.has(key),+ );+ return { defaults, usedEnvKeys, ignoredEnvKeys };}export async function onboard(opts: OnboardOptions): Promise<void> {@@ -266,7 +281,7 @@ export async function onboard(opts: OnboardOptions): Promise<void> {}let llm: PaperclipConfig["llm"] | undefined;- const { defaults: derivedDefaults, usedEnvKeys } = quickstartDefaultsFromEnv();+ const { defaults: derivedDefaults, usedEnvKeys, ignoredEnvKeys } = quickstartDefaultsFromEnv();let {database,logging,@@ -348,7 +363,14 @@ export async function onboard(opts: OnboardOptions): Promise<void> {storage = await promptStorage(storage);p.log.step(pc.bold("Secrets"));- secrets = defaultSecretsConfig();+ const secretsDefaults = defaultSecretsConfig();+ secrets = {+ provider: secrets.provider ?? secretsDefaults.provider,+ strictMode: secrets.strictMode ?? secretsDefaults.strictMode,+ localEncrypted: {+ keyFilePath: secrets.localEncrypted?.keyFilePath ?? secretsDefaults.localEncrypted.keyFilePath,+ },+ };p.log.message(pc.dim(`Using defaults: provider=${secrets.provider}, strictMode=${secrets.strictMode}, keyFile=${secrets.localEncrypted.keyFilePath}`,@@ -364,6 +386,9 @@ export async function onboard(opts: OnboardOptions): Promise<void> {pc.dim("No environment overrides detected: embedded database, file storage, local encrypted secrets."),);}+ for (const ignored of ignoredEnvKeys) {+ p.log.message(pc.dim(`Ignored ${ignored.key}: ${ignored.reason}`));+ }}const jwtSecret = ensureAgentJwtSecret(configPath);