Skip to content

The open-source app everyone uses to manage agents at work

Expire confirmations after user comments

Dottaf360fcbbb35a
diff --git a/server/src/__tests__/issue-thread-interactions-service.test.ts b/server/src/__tests__/issue-thread-interactions-service.test.ts
index 7bf9dfed3a..286bf59091 100644
--- a/server/src/__tests__/issue-thread-interactions-service.test.ts
+++ b/server/src/__tests__/issue-thread-interactions-service.test.ts
@@ -824,7 +824,7 @@ describeEmbeddedPostgres("issueThreadInteractionService", () => {
});
});
- it("expires request confirmations opted into user-comment supersede after creation", async () => {
+ it("expires request confirmations by default when a user comments after creation", async () => {
const { companyId, issueId } = await seedConfirmationIssue();
const commentId = randomUUID();
@@ -836,7 +836,6 @@ describeEmbeddedPostgres("issueThreadInteractionService", () => {
payload: {
version: 1,
prompt: "Proceed with the current draft?",
- supersedeOnUserComment: true,
},
}, {
userId: "local-board",
@@ -866,7 +865,7 @@ describeEmbeddedPostgres("issueThreadInteractionService", () => {
});
});
- it("keeps request confirmations pending unless user-comment supersede is explicitly enabled", async () => {
+ it("keeps request confirmations pending when user-comment supersede is explicitly disabled", async () => {
const { companyId, issueId } = await seedConfirmationIssue("Comment supersede opt-out");
await interactionsSvc.create({
@@ -877,6 +876,7 @@ describeEmbeddedPostgres("issueThreadInteractionService", () => {
payload: {
version: 1,
prompt: "Proceed with the current draft?",
+ supersedeOnUserComment: false,
},
}, {
userId: "local-board",
@@ -910,7 +910,6 @@ describeEmbeddedPostgres("issueThreadInteractionService", () => {
payload: {
version: 1,
prompt: "Proceed with the current draft?",
- supersedeOnUserComment: true,
},
}, {
userId: "local-board",
@@ -966,7 +965,6 @@ describeEmbeddedPostgres("issueThreadInteractionService", () => {
payload: {
version: 1,
prompt: "Proceed with the current draft?",
- supersedeOnUserComment: true,
},
}, {
userId: "local-board",
diff --git a/server/src/services/issue-thread-interactions.ts b/server/src/services/issue-thread-interactions.ts
index 73999e009b..533d3a2ed8 100644
--- a/server/src/services/issue-thread-interactions.ts
+++ b/server/src/services/issue-thread-interactions.ts
@@ -159,7 +159,7 @@ function shouldReturnAcceptedConfirmationToCreatorAgent(args: {
}
function shouldSupersedeRequestConfirmationOnUserComment(interaction: RequestConfirmationInteraction) {
- return interaction.payload.supersedeOnUserComment === true;
+ return interaction.payload.supersedeOnUserComment !== false;
}
function isCommentAtOrAfterInteraction(args: {