A community-supported supercharged document management system: scan, index and archive all your documents
Python aiangulararchivingdjangodmsdocument-managementdocument-management-systemllmmachine-learningocroptical-character-recognitionpdf
Fix: only cache remote version for version checking (#11320)
shamoon44f0191bfbab
diff --git a/src/documents/views.py b/src/documents/views.pyindex c007a4cee..822647fdb 100644--- a/src/documents/views.py+++ b/src/documents/views.py@@ -23,6 +23,7 @@ from django.conf import settingsfrom django.contrib.auth.models import Groupfrom django.contrib.auth.models import Userfrom django.contrib.contenttypes.models import ContentType+from django.core.cache import cachefrom django.db import connectionsfrom django.db.migrations.loader import MigrationLoaderfrom django.db.migrations.recorder import MigrationRecorder@@ -51,7 +52,6 @@ from django.utils.timezone import make_awarefrom django.utils.translation import get_languagefrom django.views import Viewfrom django.views.decorators.cache import cache_control-from django.views.decorators.cache import cache_pagefrom django.views.decorators.http import conditionfrom django.views.decorators.http import last_modifiedfrom django.views.generic import TemplateView@@ -2426,7 +2426,6 @@ class UiSettingsView(GenericAPIView):)-@method_decorator(cache_page(60 * 15), name="dispatch")@extend_schema_view(get=extend_schema(description="Get the current version of the Paperless-NGX server",@@ -2436,31 +2435,34 @@ class UiSettingsView(GenericAPIView):),)class RemoteVersionView(GenericAPIView):+ cache_key = "remote_version_view_latest_release"+def get(self, request, format=None):- remote_version = "0.0.0"- is_greater_than_current = Falsecurrent_version = packaging_version.parse(version.__full_version_str__)- try:- resp = httpx.get(- "https://api.github.com/repos/paperless-ngx/paperless-ngx/releases/latest",- headers={"Accept": "application/json"},- )- resp.raise_for_status()+ remote_version = cache.get(self.cache_key)+ if remote_version is None:try:+ resp = httpx.get(+ "https://api.github.com/repos/paperless-ngx/paperless-ngx/releases/latest",+ headers={"Accept": "application/json"},+ )+ resp.raise_for_status()data = resp.json()remote_version = data["tag_name"]# Some early tags used ngx-x.y.zremote_version = remote_version.removeprefix("ngx-")except ValueError as e:logger.debug(f"An error occurred parsing remote version json: {e}")- except httpx.HTTPError as e:- logger.debug(f"An error occurred checking for available updates: {e}")+ except httpx.HTTPError as e:+ logger.debug(f"An error occurred checking for available updates: {e}")++ if remote_version:+ cache.set(self.cache_key, remote_version, 60 * 15)+ else:+ remote_version = "0.0.0"is_greater_than_current = (- packaging_version.parse(- remote_version,- )- > current_version+ packaging_version.parse(remote_version) > current_version)return Response(