A community-supported supercharged document management system: scan, index and archive all your documents
Python aiangulararchivingdjangodmsdocument-managementdocument-management-systemllmmachine-learningocroptical-character-recognitionpdf
Fix: align bulk edit perms with document model (#13757)
shamoon7e4a644714df
diff --git a/src/documents/tests/test_api_permissions.py b/src/documents/tests/test_api_permissions.pyindex e693886a2..29eb8f496 100644--- a/src/documents/tests/test_api_permissions.py+++ b/src/documents/tests/test_api_permissions.py@@ -1360,6 +1360,145 @@ class TestBulkEditObjectPermissions(APITestCase):self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)self.assertEqual(response.content, b"Insufficient permissions")+ def test_bulk_edit_object_permissions_shared_object_not_owner(self) -> None:+ """+ GIVEN:+ - Object owned by another user, shared with the logged in user with+ change permissions+ WHEN:+ - bulk_edit_objects API endpoint is called with set_permissions operation+ THEN:+ - User is not able to take ownership or change permissions, consistent+ with the single object API+ """+ self.t1.owner = self.user2+ self.t1.save()+ assign_perm("view_tag", self.user1, self.t1)+ assign_perm("change_tag", self.user1, self.t1)+ self.user1.user_permissions.add(+ *Permission.objects.filter(+ codename__in=["view_tag", "change_tag"],+ ),+ )+ user1 = User.objects.get(pk=self.user1.pk)+ self.client.force_authenticate(user=user1)++ response = self.client.post(+ "/api/bulk_edit_objects/",+ json.dumps(+ {+ "objects": [self.t1.id],+ "object_type": "tags",+ "operation": "set_permissions",+ "owner": user1.id,+ "permissions": {+ "view": {"users": [user1.id], "groups": []},+ "change": {"users": [user1.id], "groups": []},+ },+ "merge": False,+ },+ ),+ content_type="application/json",+ )++ self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)+ self.assertEqual(Tag.objects.get(pk=self.t1.id).owner, self.user2)++ # the single object endpoint refuses the same request+ response = self.client.patch(+ f"/api/tags/{self.t1.id}/",+ {"owner": user1.id},+ format="json",+ )+ self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)+ self.assertEqual(Tag.objects.get(pk=self.t1.id).owner, self.user2)++ def test_bulk_edit_object_permissions_all_with_shared_objects(self) -> None:+ """+ GIVEN:+ - Objects owned by the logged in user, unowned objects and objects owned+ by another user but shared with the logged in user+ WHEN:+ - bulk_edit_objects API endpoint is called with set_permissions operation+ and all = True+ THEN:+ - The request is refused and no objects are changed+ """+ owned = Tag.objects.create(name="owned", owner=self.user1)+ shared = Tag.objects.create(name="shared", owner=self.user2)+ assign_perm("view_tag", self.user1, shared)+ assign_perm("change_tag", self.user1, shared)+ self.user1.user_permissions.add(+ *Permission.objects.filter(+ codename__in=["view_tag", "change_tag"],+ ),+ )+ user1 = User.objects.get(pk=self.user1.pk)+ self.client.force_authenticate(user=user1)++ response = self.client.post(+ "/api/bulk_edit_objects/",+ json.dumps(+ {+ "objects": [],+ "all": True,+ "object_type": "tags",+ "operation": "set_permissions",+ "permissions": {+ "view": {"users": [self.user3.id], "groups": []},+ "change": {"users": [self.user3.id], "groups": []},+ },+ "merge": False,+ },+ ),+ content_type="application/json",+ )++ self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)+ # nothing was changed, including the objects the user does own+ self.assertNotIn(self.user3, get_users_with_perms(owned))+ self.assertNotIn(self.user3, get_users_with_perms(self.t1))+ self.assertNotIn(self.user3, get_users_with_perms(shared))+ self.assertEqual(Tag.objects.get(pk=shared.pk).owner, self.user2)++ def test_bulk_edit_object_delete_shared_object_not_owner(self) -> None:+ """+ GIVEN:+ - Object owned by another user, shared with the logged in user with+ change and delete permissions+ WHEN:+ - bulk_edit_objects API endpoint is called with delete operation+ THEN:+ - User is not able to delete the object, consistent with documents+ """+ self.t1.owner = self.user2+ self.t1.save()+ assign_perm("view_tag", self.user1, self.t1)+ assign_perm("change_tag", self.user1, self.t1)+ assign_perm("delete_tag", self.user1, self.t1)+ self.user1.user_permissions.add(+ *Permission.objects.filter(+ codename__in=["view_tag", "change_tag", "delete_tag"],+ ),+ )+ user1 = User.objects.get(pk=self.user1.pk)+ self.client.force_authenticate(user=user1)++ response = self.client.post(+ "/api/bulk_edit_objects/",+ json.dumps(+ {+ "objects": [self.t1.id],+ "object_type": "tags",+ "operation": "delete",+ },+ ),+ content_type="application/json",+ )++ self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)+ self.assertTrue(Tag.objects.filter(pk=self.t1.id).exists())+def test_bulk_edit_object_permissions_validation(self) -> None:"""GIVEN:diff --git a/src/documents/tests/test_permission_filtering_security.py b/src/documents/tests/test_permission_filtering_security.pyindex 282e25420..6065d55a1 100644--- a/src/documents/tests/test_permission_filtering_security.py+++ b/src/documents/tests/test_permission_filtering_security.py@@ -677,16 +677,15 @@ class TestBulkEditObjectsApplyToAllPermissionBoundary:def test_apply_to_all_tags_excludes_unpermitted_tag(self, rest_api_client):owner = User.objects.create_user(username="tags_owner")requester = User.objects.create_user(username="tags_requester")+ new_owner = User.objects.create_user(username="tags_new_owner")# grant the global change_tag permission so the object-level# filtering (not the global has_perm check) is what's under testrequester.user_permissions.add(Permission.objects.get(codename="change_tag"),)rest_api_client.force_authenticate(user=requester)- visible = TagFactory(owner=owner)+ visible = TagFactory(owner=requester)hidden = TagFactory(owner=owner)- assign_perm("view_tag", requester, visible)- assign_perm("change_tag", requester, visible)response = rest_api_client.post("/api/bulk_edit_objects/",@@ -695,21 +694,56 @@ class TestBulkEditObjectsApplyToAllPermissionBoundary:"operation": "set_permissions","all": True,"filters": {},- "owner": requester.pk,+ "owner": new_owner.pk,},format="json",)assert response.status_code == HTTPStatus.OK# The apply_to_all dispatch must resolve permitted objects up front:- # the visible tag (object-level change_tag granted) gets its owner- # reassigned, while the hidden tag (no object-level grant) is- # excluded entirely and keeps its original owner.+ # the requester's own tag gets its owner reassigned, while the tag+ # owned by someone else is excluded entirely and keeps its owner.visible.refresh_from_db()hidden.refresh_from_db()- assert visible.owner == requester+ assert visible.owner == new_ownerassert hidden.owner == owner+ def test_apply_to_all_tags_refuses_shared_but_unowned_tag(self, rest_api_client):+ """+ A tag owned by someone else but shared with the requester is inside the+ permitted set, so it reaches the ownership gate and fails the whole+ request rather than being silently skipped. Editing permissions is+ limited to the owner, same as documents.+ """+ owner = User.objects.create_user(username="shared_tags_owner")+ requester = User.objects.create_user(username="shared_tags_requester")+ requester.user_permissions.add(+ Permission.objects.get(codename="change_tag"),+ )+ rest_api_client.force_authenticate(user=requester)+ owned = TagFactory(owner=requester)+ shared = TagFactory(owner=owner)+ assign_perm("view_tag", requester, shared)+ assign_perm("change_tag", requester, shared)++ response = rest_api_client.post(+ "/api/bulk_edit_objects/",+ {+ "object_type": "tags",+ "operation": "set_permissions",+ "all": True,+ "filters": {},+ "owner": requester.pk,+ },+ format="json",+ )+ assert response.status_code == HTTPStatus.FORBIDDEN++ owned.refresh_from_db()+ shared.refresh_from_db()+ assert shared.owner == owner+ assert owned.owner == requester+@pytest.mark.django_dbclass TestBulkEditObjectsTagDescendantPartialPermission:@@ -720,8 +754,8 @@ class TestBulkEditObjectsTagDescendantPartialPermission:"""GIVEN:- A tag hierarchy (parent -> permitted_child, unpermitted_child)- - A non-superuser requester with object-level change_tag granted- on the parent and on only ONE of the two children+ - A non-superuser requester who owns the parent and only ONE of+ the two childrenWHEN:- bulk_edit_objects is called with all=True and a filter thatmatches only the root (parent) tag, engaging the@@ -743,6 +777,7 @@ class TestBulkEditObjectsTagDescendantPartialPermission:"""owner = User.objects.create_user(username="tag_hierarchy_owner")requester = User.objects.create_user(username="tag_hierarchy_requester")+ new_owner = User.objects.create_user(username="tag_hierarchy_new_owner")# global change_tag permission so the has_perm() gate passes and the# object-level permitted_object_ids filtering is what's under testrequester.user_permissions.add(@@ -750,9 +785,9 @@ class TestBulkEditObjectsTagDescendantPartialPermission:)rest_api_client.force_authenticate(user=requester)- parent = TagFactory(owner=owner, name="parent-tag")+ parent = TagFactory(owner=requester, name="parent-tag")permitted_child = TagFactory(- owner=owner,+ owner=requester,name="permitted-child-tag",tn_parent=parent,)@@ -761,9 +796,6 @@ class TestBulkEditObjectsTagDescendantPartialPermission:name="unpermitted-child-tag",tn_parent=parent,)- assign_perm("change_tag", requester, parent)- assign_perm("change_tag", requester, permitted_child)- # unpermitted_child is intentionally NOT granted change_tagresponse = rest_api_client.post("/api/bulk_edit_objects/",@@ -772,7 +804,7 @@ class TestBulkEditObjectsTagDescendantPartialPermission:"operation": "set_permissions","all": True,"filters": {"is_root": True},- "owner": requester.pk,+ "owner": new_owner.pk,},format="json",)@@ -781,8 +813,8 @@ class TestBulkEditObjectsTagDescendantPartialPermission:parent.refresh_from_db()permitted_child.refresh_from_db()unpermitted_child.refresh_from_db()- assert parent.owner == requester- assert permitted_child.owner == requester+ assert parent.owner == new_owner+ assert permitted_child.owner == new_ownerassert unpermitted_child.owner == ownerdiff --git a/src/documents/views.py b/src/documents/views.pyindex ec43b3c3b..80232cd73 100644--- a/src/documents/views.py+++ b/src/documents/views.py@@ -4879,10 +4879,11 @@ class BulkEditObjectsView(PassUserMixin):if not user.is_superuser:perm = f"documents.{perm_codename}"+ # Limited to the owner (or unowned), same as documents, see BulkEditViewhas_perms = (user.has_perm(perm)and not objs.exclude(- pk__in=permitted_object_ids(user, object_class, perm_codename),+ Q(owner=user) | Q(owner__isnull=True),).exists())