A community-supported supercharged document management system: scan, index and archive all your documents
Python aiangulararchivingdjangodmsdocument-managementdocument-management-systemllmmachine-learningocroptical-character-recognitionpdf
Chore: reject absurd max age values (#10243)
shamoondbf3721ec25c
diff --git a/src/paperless_mail/serialisers.py b/src/paperless_mail/serialisers.pyindex 402a53c3b..fa025fcbe 100644--- a/src/paperless_mail/serialisers.py+++ b/src/paperless_mail/serialisers.py@@ -125,3 +125,8 @@ class MailRuleSerializer(OwnedObjectSerializer):raise serializers.ValidationError("An action parameter is required.")return attrs++ def validate_maximum_age(self, value):+ if value > 36500: # ~100 years+ raise serializers.ValidationError("Maximum mail age is unreasonably large.")+ return valuediff --git a/src/paperless_mail/tests/test_api.py b/src/paperless_mail/tests/test_api.pyindex 985ed006b..3ba06a746 100644--- a/src/paperless_mail/tests/test_api.py+++ b/src/paperless_mail/tests/test_api.py@@ -680,3 +680,44 @@ class TestAPIMailRules(DirectoriesMixin, APITestCase):self.assertEqual(response.data["results"][0]["name"], rule1.name)self.assertEqual(response.data["results"][1]["name"], rule2.name)self.assertEqual(response.data["results"][2]["name"], rule4.name)++ def test_mailrule_maxage_validation(self):+ """+ GIVEN:+ - An existing mail account+ WHEN:+ - The user submits a mail rule with an excessively large maximum_age+ THEN:+ - The API should reject the request+ """+ account = MailAccount.objects.create(+ name="Email1",+ username="username1",+ password="password1",+ imap_server="server.example.com",+ imap_port=443,+ imap_security=MailAccount.ImapSecurity.SSL,+ character_set="UTF-8",+ )++ rule_data = {+ "name": "Rule1",+ "account": account.pk,+ "folder": "INBOX",+ "filter_from": "[email protected]",+ "filter_to": "[email protected]",+ "filter_subject": "subject",+ "filter_body": "body",+ "filter_attachment_filename_include": "file.pdf",+ "maximum_age": 9000000,+ "action": MailRule.MailAction.MARK_READ,+ "assign_title_from": MailRule.TitleSource.FROM_SUBJECT,+ "assign_correspondent_from": MailRule.CorrespondentSource.FROM_NOTHING,+ "order": 0,+ "attachment_type": MailRule.AttachmentProcessing.ATTACHMENTS_ONLY,+ }++ response = self.client.post(self.ENDPOINT, data=rule_data, format="json")++ self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)+ self.assertIn("maximum_age", response.data)