Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.
fix: scope upload notification runs by viewer to avoid cancelling other visitors' notifications
Cursor Agent2d4d6ef2f4e6
diff --git a/app/(ee)/api/links/[id]/upload/route.ts b/app/(ee)/api/links/[id]/upload/route.tsindex da89e83a..86b6f947 100644--- a/app/(ee)/api/links/[id]/upload/route.ts+++ b/app/(ee)/api/links/[id]/upload/route.ts@@ -156,10 +156,14 @@ export async function POST(// 4. Send upload notification to team if enabledif (link.enableNotification) {try {- // Cancel any existing pending notification runs for this dataroom+link+ // Cancel any existing pending notification runs for this viewer+dataroom+linkconst allRuns = await runs.list({taskIdentifier: ["send-dataroom-upload-notification"],- tag: [`dataroom_${dataroomId}`, `link_${linkId}`],+ tag: [+ `dataroom_${dataroomId}`,+ `link_${linkId}`,+ `viewer_${viewerId}`,+ ],status: ["DELAYED", "QUEUED"],period: "10m",});@@ -172,14 +176,16 @@ export async function POST({dataroomId,linkId,+ viewerId,teamId: link.teamId,},{- idempotencyKey: `upload-notification-${link.teamId}-${dataroomId}-${linkId}-${newDataroomDocument.id}`,+ idempotencyKey: `upload-notification-${link.teamId}-${dataroomId}-${linkId}-${viewerId}-${newDataroomDocument.id}`,tags: [`team_${link.teamId}`,`dataroom_${dataroomId}`,`link_${linkId}`,+ `viewer_${viewerId}`,],delay: new Date(Date.now() + 5 * 60 * 1000), // 5 minute delay},diff --git a/lib/trigger/dataroom-upload-notification.ts b/lib/trigger/dataroom-upload-notification.tsindex 69580232..4cd70e62 100644--- a/lib/trigger/dataroom-upload-notification.ts+++ b/lib/trigger/dataroom-upload-notification.ts@@ -5,6 +5,7 @@ import prisma from "@/lib/prisma";type UploadNotificationPayload = {dataroomId: string;linkId: string;+ viewerId: string;teamId: string;};@@ -14,11 +15,12 @@ export const sendDataroomUploadNotificationTask = task({run: async (payload: UploadNotificationPayload) => {const fiveMinutesAgo = new Date(Date.now() - 5 * 60 * 1000);- // Get all recent uploads for this dataroom via this link+ // Get all recent uploads for this dataroom via this link by this viewerconst recentUploads = await prisma.documentUpload.findMany({where: {dataroomId: payload.dataroomId,linkId: payload.linkId,+ viewerId: payload.viewerId,uploadedAt: {gte: fiveMinutesAgo,},