Skip to content

Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.

feat: cleanup notification settings

Marc Seitz3235bae46570
diff --git a/components/datarooms/dataroom-header.tsx b/components/datarooms/dataroom-header.tsx
index 8d718f33..3ab9deae 100644
--- a/components/datarooms/dataroom-header.tsx
+++ b/components/datarooms/dataroom-header.tsx
@@ -1,9 +1,20 @@
+import Link from "next/link";
+
import { useState } from "react";
+import { BellRingIcon } from "lucide-react";
+
+import { useDataroom, useDataroomLinks } from "@/lib/swr/use-dataroom";
+
import LinkSheet from "@/components/links/link-sheet";
import { Button } from "@/components/ui/button";
-import { useDataroomLinks } from "@/lib/swr/use-dataroom";
+import {
+ Tooltip,
+ TooltipContent,
+ TooltipPortal,
+ TooltipTrigger,
+} from "../ui/tooltip";
export const DataroomHeader = ({
title,
@@ -15,6 +26,7 @@ export const DataroomHeader = ({
actions?: React.ReactNode[];
}) => {
const [isLinkSheetOpen, setIsLinkSheetOpen] = useState<boolean>(false);
+ const { dataroom } = useDataroom();
const { links } = useDataroomLinks();
const actionRows: React.ReactNode[][] = [];
@@ -27,10 +39,31 @@ export const DataroomHeader = ({
return (
<section className="mb-4">
<div className="flex items-center justify-between">
- <div className="flex min-h-10 items-center space-y-1">
+ <div className="flex min-h-10 items-center gap-x-2 space-y-1">
<h1 className="text-xl font-semibold tracking-tight text-foreground sm:text-2xl">
{title}
</h1>
+ {dataroom?.enableChangeNotifications ? (
+ <Tooltip>
+ <TooltipTrigger asChild>
+ <Link
+ href={`/datarooms/${dataroom?.id}/settings/notifications`}
+ >
+ <Button variant="ghost" size="icon" className="size-8">
+ <BellRingIcon className="inline-block !size-4 text-[#fb7a00]" />
+ </Button>
+ </Link>
+ </TooltipTrigger>
+ <TooltipPortal>
+ <TooltipContent
+ side="right"
+ className="text-center text-muted-foreground"
+ >
+ <p>Change notifications are enabled</p>
+ </TooltipContent>
+ </TooltipPortal>
+ </Tooltip>
+ ) : null}
</div>
<div>
<Button onClick={() => setIsLinkSheetOpen(true)} key={1}>
diff --git a/components/datarooms/settings/notification-settings.tsx b/components/datarooms/settings/notification-settings.tsx
index ed954edf..3e5c583d 100644
--- a/components/datarooms/settings/notification-settings.tsx
+++ b/components/datarooms/settings/notification-settings.tsx
@@ -1,13 +1,17 @@
import { useTeam } from "@/context/team-context";
+import { BadgeCheckIcon } from "lucide-react";
import { toast } from "sonner";
import useSWR from "swr";
+import { usePlan } from "@/lib/swr/use-billing";
import { fetcher } from "@/lib/utils";
+import PlanBadge from "@/components/billing/plan-badge";
import {
Card,
CardContent,
CardDescription,
+ CardFooter,
CardHeader,
CardTitle,
} from "@/components/ui/card";
@@ -24,26 +28,32 @@ export default function NotificationSettings({
const teamInfo = useTeam();
const teamId = teamInfo?.currentTeam?.id;
- const { data: features } = useSWR<{ roomChangeNotifications: boolean }>(
- teamInfo?.currentTeam?.id
- ? `/api/feature-flags?teamId=${teamInfo.currentTeam.id}`
- : null,
- fetcher,
- );
-
const { data: dataroomData, mutate: mutateDataroom } = useSWR<{
id: string;
name: string;
pId: string;
- notifyOnNewDocument: boolean;
+ enableChangeNotifications: boolean;
}>(
dataroomId ? `/api/teams/${teamId}/datarooms/${dataroomId}` : null,
fetcher,
);
+ const { isDataroomsPlus } = usePlan();
+ const { data: features } = useSWR<{ roomChangeNotifications: boolean }>(
+ teamInfo?.currentTeam?.id
+ ? `/api/feature-flags?teamId=${teamInfo.currentTeam.id}`
+ : null,
+ fetcher,
+ );
+
const handleNotificationToggle = async (checked: boolean) => {
if (!dataroomId || !teamId) return;
+ if (!isDataroomsPlus && !features?.roomChangeNotifications) {
+ toast.error("This feature is not available in your plan");
+ return;
+ }
+
toast.promise(
fetch(`/api/teams/${teamId}/datarooms/${dataroomId}`, {
method: "PATCH",
@@ -51,7 +61,7 @@ export default function NotificationSettings({
"Content-Type": "application/json",
},
body: JSON.stringify({
- notifyOnNewDocument: checked,
+ enableChangeNotifications: checked,
}),
}).then(async (res) => {
if (!res.ok) {
@@ -67,34 +77,40 @@ export default function NotificationSettings({
);
};
- if (!features?.roomChangeNotifications) {
- return null;
- }
-
return (
- <Card>
+ <Card className="bg-transparent">
<CardHeader>
- <CardTitle>Notifications</CardTitle>
+ <CardTitle>
+ Notifications{" "}
+ {!isDataroomsPlus && !features?.roomChangeNotifications ? (
+ <PlanBadge plan="datarooms-plus" />
+ ) : null}
+ </CardTitle>
<CardDescription>
- Configure notification settings for this dataroom.
+ {!dataroomData?.enableChangeNotifications ? "Enable" : "Disable"}{" "}
+ change notification for this dataroom.
</CardDescription>
</CardHeader>
- <CardContent>
- <div className="flex items-center space-x-4">
- <Switch
- id="notify-on-new-document"
- checked={dataroomData?.notifyOnNewDocument ?? true}
- onCheckedChange={handleNotificationToggle}
- />
- <Label htmlFor="notify-on-new-document">
- Notify verified visitors when new documents are added
- </Label>
- </div>
- <p className="mt-2 text-sm text-muted-foreground">
- When enabled, verified visitors will receive an email notification
- when new documents are added to this dataroom.
- </p>
+ <CardContent className="flex items-center justify-between">
+ <Label htmlFor="notification-toggle">
+ Notify visitors when new documents are added
+ </Label>
+ <Switch
+ id="notification-toggle"
+ checked={dataroomData?.enableChangeNotifications ?? false}
+ onCheckedChange={handleNotificationToggle}
+ />
</CardContent>
+ <CardFooter className="flex items-center justify-between rounded-b-lg border-t bg-muted px-6 py-6">
+ <p className="text-sm text-muted-foreground transition-colors">
+ When enabled,{" "}
+ <span className="inline-flex items-center gap-x-1 font-bold">
+ verified visitors <BadgeCheckIcon className="h-4 w-4 font-normal" />
+ </span>{" "}
+ will automatically receive an email notification when new documents
+ are added to this dataroom.
+ </p>
+ </CardFooter>
</Card>
);
}
diff --git a/pages/api/teams/[teamId]/datarooms/[id]/documents/index.ts b/pages/api/teams/[teamId]/datarooms/[id]/documents/index.ts
index 062b2749..a35199f1 100644
--- a/pages/api/teams/[teamId]/datarooms/[id]/documents/index.ts
+++ b/pages/api/teams/[teamId]/datarooms/[id]/documents/index.ts
@@ -154,7 +154,7 @@ export default async function handle(
include: {
dataroom: {
select: {
- notifyOnNewDocument: true,
+ enableChangeNotifications: true,
links: {
select: { id: true },
orderBy: { createdAt: "desc" },
@@ -166,10 +166,8 @@ export default async function handle(
},
});
- // Check if the team has the change notification feature flag enabled and dataroom notifications are enabled
- const featureFlags = await getFeatureFlags({ teamId });
-
- if (featureFlags.roomChangeNotifications && document.dataroom.notifyOnNewDocument) {
+ // Check if the team has the dataroom change notification enabled
+ if (document.dataroom.enableChangeNotifications) {
// Get all delayed and queued runs for this dataroom
const allRuns = await runs.list({
taskIdentifier: ["send-dataroom-change-notification"],
diff --git a/pages/api/teams/[teamId]/datarooms/[id]/index.ts b/pages/api/teams/[teamId]/datarooms/[id]/index.ts
index 208badf3..0d2b5686 100644
--- a/pages/api/teams/[teamId]/datarooms/[id]/index.ts
+++ b/pages/api/teams/[teamId]/datarooms/[id]/index.ts
@@ -4,6 +4,7 @@ import { authOptions } from "@/pages/api/auth/[...nextauth]";
import { getServerSession } from "next-auth/next";
import { errorhandler } from "@/lib/errorHandler";
+import { getFeatureFlags } from "@/lib/featureFlags";
import prisma from "@/lib/prisma";
import { CustomUser } from "@/lib/types";
@@ -78,15 +79,28 @@ export default async function handle(
},
},
},
+ select: {
+ id: true,
+ plan: true,
+ },
});
if (!team) {
return res.status(401).end("Unauthorized");
}
- const { name, notifyOnNewDocument } = req.body as {
+ const featureFlags = await getFeatureFlags({ teamId: team.id });
+ const isDataroomsPlus = team.plan.includes("datarooms-plus");
+
+ if (!isDataroomsPlus && !featureFlags.roomChangeNotifications) {
+ return res.status(403).json({
+ message: "This feature is not available in your plan",
+ });
+ }
+
+ const { name, enableChangeNotifications } = req.body as {
name?: string;
- notifyOnNewDocument?: boolean;
+ enableChangeNotifications?: boolean;
};
const dataroom = await prisma.dataroom.update({
@@ -95,8 +109,8 @@ export default async function handle(
},
data: {
...(name && { name }),
- ...(typeof notifyOnNewDocument === "boolean" && {
- notifyOnNewDocument,
+ ...(typeof enableChangeNotifications === "boolean" && {
+ enableChangeNotifications,
}),
},
});
diff --git a/pages/datarooms/[id]/analytics/index.tsx b/pages/datarooms/[id]/analytics/index.tsx
index 24e79aa1..202f7968 100644
--- a/pages/datarooms/[id]/analytics/index.tsx
+++ b/pages/datarooms/[id]/analytics/index.tsx
@@ -1,26 +1,13 @@
-import { useTeam } from "@/context/team-context";
-import { AlertCircleIcon } from "lucide-react";
-import useSWR from "swr";
-
import { useDataroom } from "@/lib/swr/use-dataroom";
-import { fetcher } from "@/lib/utils";
import { DataroomHeader } from "@/components/datarooms/dataroom-header";
import { DataroomNavigation } from "@/components/datarooms/dataroom-navigation";
import StatsCard from "@/components/datarooms/stats-card";
import AppLayout from "@/components/layouts/app";
-import { Alert, AlertDescription, AlertTitle } from "@/components/ui/alert";
import DataroomVisitorsTable from "@/components/visitors/dataroom-visitors-table";
export default function DataroomAnalyticsPage() {
- const teamInfo = useTeam();
const { dataroom } = useDataroom();
- const { data: features } = useSWR<{ roomChangeNotifications: boolean }>(
- teamInfo?.currentTeam?.id
- ? `/api/feature-flags?teamId=${teamInfo.currentTeam.id}`
- : null,
- fetcher,
- );
if (!dataroom) {
return <div>Loading...</div>;
@@ -38,17 +25,6 @@ export default function DataroomAnalyticsPage() {
<DataroomNavigation dataroomId={dataroom.id} />
</header>
- {features?.roomChangeNotifications && (
- <Alert>
- <AlertCircleIcon className="h-4 w-4" />
- <AlertTitle>Dataroom Change Notifications</AlertTitle>
- <AlertDescription>
- Verified visitors will be automatically notified by email when new
- documents are added to this dataroom.
- </AlertDescription>
- </Alert>
- )}
-
<div className="space-y-8">
<StatsCard />
<DataroomVisitorsTable dataroomId={dataroom.id} />
diff --git a/prisma/migrations/20250511192249_added_notify_on_new_document/migration.sql b/prisma/migrations/20250511192249_added_notify_on_new_document/migration.sql
deleted file mode 100644
index 3ce725e3..00000000
--- a/prisma/migrations/20250511192249_added_notify_on_new_document/migration.sql
+++ /dev/null
@@ -1,2 +0,0 @@
--- AlterTable
-ALTER TABLE "Dataroom" ADD COLUMN "notifyOnNewDocument" BOOLEAN NOT NULL DEFAULT true;
diff --git a/prisma/migrations/20250513000000_add_notification_to_dataroom/migration.sql b/prisma/migrations/20250513000000_add_notification_to_dataroom/migration.sql
new file mode 100644
index 00000000..74b394f8
--- /dev/null
+++ b/prisma/migrations/20250513000000_add_notification_to_dataroom/migration.sql
@@ -0,0 +1,3 @@
+-- AlterTable
+ALTER TABLE "Dataroom" ADD COLUMN "enableChangeNotifications" BOOLEAN NOT NULL DEFAULT false;
+
diff --git a/prisma/schema/dataroom.prisma b/prisma/schema/dataroom.prisma
index 32edf25f..f0dfa1b0 100644
--- a/prisma/schema/dataroom.prisma
+++ b/prisma/schema/dataroom.prisma
@@ -24,7 +24,7 @@ model Dataroom {
tags TagItem[]
// notification settings
- notifyOnNewDocument Boolean @default(true)
+ enableChangeNotifications Boolean @default(false)
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt