Skip to content

Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.

refactor: make subpage navbar better for datarooms

Marc Seitz390d76df2eb3
diff --git a/components/NotionPage.tsx b/components/NotionPage.tsx
index 0f14f66c..775c3282 100644
--- a/components/NotionPage.tsx
+++ b/components/NotionPage.tsx
@@ -329,35 +329,40 @@ export const NotionPage = ({
viewId={viewId}
/>
- <Portal containerId="view-breadcrump-portal">
- <Breadcrumb>
- <BreadcrumbList>
- <BreadcrumbItem>
- <BreadcrumbLink
- className="cursor-pointer underline underline-offset-4 hover:font-medium"
- onClick={() => setSubPageId(null)}
- style={{
- color: determineTextColor(brand?.brandColor),
- }}
- >
- {title}
- </BreadcrumbLink>
- </BreadcrumbItem>
- <BreadcrumbSeparator>
- <Slash />
- </BreadcrumbSeparator>
- <BreadcrumbItem>
- <BreadcrumbPage
- className="font-medium"
- style={{
- color: determineTextColor(brand?.brandColor),
- }}
- >
- {subTitle}
- </BreadcrumbPage>
- </BreadcrumbItem>
- </BreadcrumbList>
- </Breadcrumb>
+ <Portal
+ containerId="view-breadcrump-portal"
+ className="flex items-center gap-1.5"
+ >
+ <>
+ <BreadcrumbItem>
+ <BreadcrumbLink
+ className="cursor-pointer underline underline-offset-4"
+ onClick={() => setSubPageId(null)}
+ style={{
+ color: determineTextColor(brand?.brandColor),
+ }}
+ >
+ {title}
+ </BreadcrumbLink>
+ </BreadcrumbItem>
+ {subPageId ? (
+ <>
+ <BreadcrumbSeparator>
+ <Slash />
+ </BreadcrumbSeparator>
+ <BreadcrumbItem>
+ <BreadcrumbPage
+ className="font-medium"
+ style={{
+ color: determineTextColor(brand?.brandColor),
+ }}
+ >
+ {subTitle}
+ </BreadcrumbPage>
+ </BreadcrumbItem>
+ </>
+ ) : null}
+ </>
</Portal>
{loading && <div>Loading...</div>}
diff --git a/components/ui/portal.tsx b/components/ui/portal.tsx
index b42d18a3..d74f0de7 100644
--- a/components/ui/portal.tsx
+++ b/components/ui/portal.tsx
@@ -4,16 +4,19 @@ import * as PortalPrimitive from "@radix-ui/react-portal";
const Portal = ({
containerId,
+ className,
children,
}: {
containerId?: string | null;
children: React.ReactElement;
+ className?: string;
}) => {
const [mounted, setMounted] = React.useState(false);
React.useEffect(() => setMounted(true), []);
return (
<PortalPrimitive.Root
+ className={className}
container={
containerId && mounted
? document.getElementById(containerId)
diff --git a/components/view/nav.tsx b/components/view/nav.tsx
index f3a3d338..2196f9dd 100644
--- a/components/view/nav.tsx
+++ b/components/view/nav.tsx
@@ -164,7 +164,6 @@ export default function Nav({
</Link>
)}
</div>
- <div id="view-breadcrump-portal"></div>
{isDataroom ? (
<Breadcrumb>
<BreadcrumbList>
@@ -179,19 +178,20 @@ export default function Nav({
Home
</BreadcrumbLink>
</BreadcrumbItem>
- {/* <BreadcrumbSeparator>
- <Slash />
- </BreadcrumbSeparator>
- <BreadcrumbItem>
- <BreadcrumbPage
- className="font-medium"
- style={{
- color: determineTextColor(brand?.brandColor),
- }}
- >
- {documentName ?? "Document"}
- </BreadcrumbPage>
- </BreadcrumbItem> */}
+ {type === "notion" ? (
+ <>
+ <BreadcrumbSeparator>
+ <Slash />
+ </BreadcrumbSeparator>
+ <div id="view-breadcrump-portal"></div>
+ </>
+ ) : null}
+ </BreadcrumbList>
+ </Breadcrumb>
+ ) : type === "notion" ? (
+ <Breadcrumb>
+ <BreadcrumbList>
+ <div id="view-breadcrump-portal"></div>
</BreadcrumbList>
</Breadcrumb>
) : null}