Skip to content

Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.

refactor: remove tab content from permissions

Marc Seitz397ed4e0e914
diff --git a/pages/datarooms/[id]/groups/index.tsx b/pages/datarooms/[id]/groups/index.tsx
index 50442f57..2066a9b7 100644
--- a/pages/datarooms/[id]/groups/index.tsx
+++ b/pages/datarooms/[id]/groups/index.tsx
@@ -13,6 +13,7 @@ import GroupCard from "@/components/datarooms/groups/group-card";
import { GroupCardPlaceholder } from "@/components/datarooms/groups/group-card-placeholder";
import AppLayout from "@/components/layouts/app";
import { Button } from "@/components/ui/button";
+import { Tabs, TabsList, TabsTrigger } from "@/components/ui/tabs";
import { BadgeTooltip } from "@/components/ui/tooltip";
import { usePlan } from "@/lib/swr/use-billing";
@@ -58,6 +59,15 @@ export default function DataroomGroupPage() {
<DataroomNavigation dataroomId={dataroom.id} />
</header>
+ <Tabs defaultValue="groups" className="!mt-4 space-y-4">
+ <TabsList>
+ <TabsTrigger value="links" asChild>
+ <Link href={`/datarooms/${dataroom.id}/permissions`}>Links</Link>
+ </TabsTrigger>
+ <TabsTrigger value="groups">Groups</TabsTrigger>
+ </TabsList>
+ </Tabs>
+
<div className="space-y-4">
{/* Groups */}
<div className="grid gap-5">
diff --git a/pages/datarooms/[id]/permissions/index.tsx b/pages/datarooms/[id]/permissions/index.tsx
index e07527f1..7fd77408 100644
--- a/pages/datarooms/[id]/permissions/index.tsx
+++ b/pages/datarooms/[id]/permissions/index.tsx
@@ -2,15 +2,10 @@ import Link from "next/link";
import { useState } from "react";
-import { PlanEnum } from "@/ee/stripe/constants";
-import { CircleHelpIcon, UsersIcon } from "lucide-react";
+import { CircleHelpIcon } from "lucide-react";
-import { UpgradePlanModal } from "@/components/billing/upgrade-plan-modal";
import { DataroomHeader } from "@/components/datarooms/dataroom-header";
import { DataroomNavigation } from "@/components/datarooms/dataroom-navigation";
-import { AddGroupModal } from "@/components/datarooms/groups/add-group-modal";
-import GroupCard from "@/components/datarooms/groups/group-card";
-import { GroupCardPlaceholder } from "@/components/datarooms/groups/group-card-placeholder";
import AppLayout from "@/components/layouts/app";
import LinkSheet from "@/components/links/link-sheet";
import LinksTable from "@/components/links/links-table";
@@ -18,38 +13,18 @@ import { Button } from "@/components/ui/button";
import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs";
import { BadgeTooltip } from "@/components/ui/tooltip";
-import { usePlan } from "@/lib/swr/use-billing";
import { useDataroom, useDataroomLinks } from "@/lib/swr/use-dataroom";
-import useDataroomGroups from "@/lib/swr/use-dataroom-groups";
-import { cn } from "@/lib/utils";
export default function DataroomAnalyticsPage() {
const { dataroom } = useDataroom();
const { links } = useDataroomLinks();
- const { viewerGroups, loading } = useDataroomGroups();
- const { plan, trial } = usePlan();
const [isLinkSheetOpen, setIsLinkSheetOpen] = useState<boolean>(false);
- const [modalOpen, setModalOpen] = useState<boolean>(false);
if (!dataroom) {
return <div>Loading...</div>;
}
- const GroupButtonComponent = () => {
- if (plan === "datarooms" || trial) {
- return <Button onClick={() => setModalOpen(true)}>Create group</Button>;
- }
- return (
- <UpgradePlanModal
- clickedPlan={PlanEnum.DataRooms}
- trigger="create_group_button"
- >
- <Button>Upgrade to create group</Button>
- </UpgradePlanModal>
- );
- };
-
return (
<AppLayout>
<div className="relative mx-2 mb-10 mt-4 space-y-8 overflow-hidden px-1 sm:mx-3 md:mx-5 md:mt-5 lg:mx-7 lg:mt-8 xl:mx-10">
@@ -66,13 +41,33 @@ export default function DataroomAnalyticsPage() {
<DataroomNavigation dataroomId={dataroom.id} />
</header>
- <Tabs defaultValue="links" className="space-y-4">
+ <Tabs defaultValue="links" className="!mt-4 space-y-4">
<TabsList>
<TabsTrigger value="links">Links</TabsTrigger>
- <TabsTrigger value="groups">Groups</TabsTrigger>
+ <TabsTrigger value="groups" asChild>
+ <Link href={`/datarooms/${dataroom.id}/groups`}>Groups</Link>
+ </TabsTrigger>
</TabsList>
<TabsContent value="links" className="space-y-4">
+ <div className="!mt-8 flex items-center gap-x-2">
+ <div className="space-y-1">
+ <h3 className="text-lg font-semibold tracking-tight text-foreground">
+ Links
+ </h3>
+ <p className="flex flex-row items-center gap-2 text-sm text-muted-foreground">
+ Share data room with strong access controls using links.
+ <BadgeTooltip
+ linkText="Learn more"
+ content="Configure access controls for data room links."
+ key="links"
+ link="https://www.papermark.io/help/category/links"
+ >
+ <CircleHelpIcon className="h-4 w-4 shrink-0 text-muted-foreground hover:text-foreground" />
+ </BadgeTooltip>
+ </p>
+ </div>
+ </div>
<LinksTable links={links} targetType={"DATAROOM"} />
<LinkSheet
linkType={"DATAROOM_LINK"}
@@ -81,79 +76,6 @@ export default function DataroomAnalyticsPage() {
existingLinks={links}
/>
</TabsContent>
-
- <TabsContent value="groups">
- <div className="grid gap-5">
- <div className="flex flex-wrap justify-between gap-6">
- <div className="flex items-center gap-x-2">
- <div className="space-y-1">
- <h3 className="text-2xl font-semibold tracking-tight text-foreground">
- Groups
- </h3>
- <p className="flex flex-row items-center gap-2 text-sm text-muted-foreground">
- Control document access with granular permissions through
- groups.{" "}
- <BadgeTooltip
- linkText="Learn more"
- content="Manage Access with Granular Permissions for Data Room Groups"
- key="groups"
- link="https://www.papermark.io/help/article/granular-permissions"
- >
- <CircleHelpIcon className="h-4 w-4 shrink-0 text-muted-foreground hover:text-foreground" />
- </BadgeTooltip>
- </p>
- </div>
- </div>
- <div className="flex w-full flex-wrap items-center gap-3 sm:w-auto">
- <GroupButtonComponent />
- </div>
- </div>
- <div className="animate-fade-in">
- {!loading ? (
- viewerGroups && viewerGroups.length > 0 ? (
- <ul className="grid grid-cols-1 gap-3">
- {viewerGroups.map((group) => (
- <li key={group.id}>
- <Link
- href={`/datarooms/${dataroom.id}/groups/${group.id}`}
- >
- <GroupCard group={group} />
- </Link>
- </li>
- ))}
- </ul>
- ) : (
- <div className="flex flex-col items-center gap-4 rounded-xl border border-gray-200 py-10">
- <div className="hidden rounded-full border border-gray-200 sm:block">
- <div
- className={cn(
- "rounded-full border border-white bg-gradient-to-t from-gray-100 p-1 md:p-3",
- )}
- >
- <UsersIcon className="size-6" />
- </div>
- </div>
- <p>No groups found for this dataroom</p>
- <GroupButtonComponent />
- </div>
- )
- ) : (
- <ul className="grid grid-cols-1 gap-3">
- {Array.from({ length: 3 }).map((_, idx) => (
- <li key={idx}>
- <GroupCardPlaceholder />
- </li>
- ))}
- </ul>
- )}
- </div>
- </div>
- <AddGroupModal
- dataroomId={dataroom.id}
- open={modalOpen}
- setOpen={setModalOpen}
- />
- </TabsContent>
</Tabs>
</div>
</AppLayout>