Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.
fix: large O(n x m) document folder matching
Marc Seitz447b1b31d3ab
diff --git a/pages/api/links/download/bulk.ts b/pages/api/links/download/bulk.tsindex fc367b0a..131aefd0 100644--- a/pages/api/links/download/bulk.ts+++ b/pages/api/links/download/bulk.ts@@ -353,13 +353,21 @@ export default async function handle();});+ // Pre-index documents by folderId for O(1) lookup per folder+ const docsByFolderId = new Map<string, typeof downloadDocuments>();+ for (const doc of downloadDocuments) {+ if (!doc.folderId) continue;+ const list = docsByFolderId.get(doc.folderId) ?? [];+ list.push(doc);+ docsByFolderId.set(doc.folderId, list);+ }+// Add documents in foldersdownloadFolders.forEach((folder) => {// Use the computed path from parentId hierarchy instead of the stored pathconst folderPath = computedPathMap.get(folder.id) ?? folder.path;- const folderDocs = downloadDocuments- .filter((doc) => doc.folderId === folder.id)+ const folderDocs = (docsByFolderId.get(folder.id) ?? []).filter((doc) => doc.document.versions[0].type !== "notion").filter((doc) => doc.document.versions[0].storageType !== "VERCEL_BLOB",diff --git a/pages/api/links/download/dataroom-folder.ts b/pages/api/links/download/dataroom-folder.tsindex 025927f1..dcd2be08 100644--- a/pages/api/links/download/dataroom-folder.ts+++ b/pages/api/links/download/dataroom-folder.ts@@ -297,9 +297,18 @@ export default async function handler(const rootFolderInfo = { name: rootFolder.name, computedPath: computedRootPath };+ // Pre-index documents by folderId for O(1) lookup per folder+ const docsByFolderId = new Map<string, typeof allDocuments>();+ for (const doc of allDocuments) {+ if (!doc.folderId) continue;+ const list = docsByFolderId.get(doc.folderId) ?? [];+ list.push(doc);+ docsByFolderId.set(doc.folderId, list);+ }+for (const folder of allFolders) {const folderPath = computedPathMap.get(folder.id) ?? folder.path;- const docs = allDocuments.filter((doc) => doc.folderId === folder.id);+ const docs = docsByFolderId.get(folder.id) ?? [];if (docs.length === 0) {addFileToStructure(diff --git a/pages/api/teams/[teamId]/datarooms/[id]/download/bulk.ts b/pages/api/teams/[teamId]/datarooms/[id]/download/bulk.tsindex 0c8c941b..464062e2 100644--- a/pages/api/teams/[teamId]/datarooms/[id]/download/bulk.ts+++ b/pages/api/teams/[teamId]/datarooms/[id]/download/bulk.ts@@ -172,12 +172,20 @@ export default async function handler(),);+ // Pre-index documents by folderId for O(1) lookup per folder+ const docsByFolderId = new Map<string, typeof downloadDocuments>();+ for (const doc of downloadDocuments) {+ if (!doc.folderId) continue;+ const list = docsByFolderId.get(doc.folderId) ?? [];+ list.push(doc);+ docsByFolderId.set(doc.folderId, list);+ }+downloadFolders.forEach((folder) => {// Use the computed path from parentId hierarchy instead of the stored pathconst folderPath = computedPathMap.get(folder.id) ?? folder.path;- const folderDocs = downloadDocuments- .filter((doc) => doc.folderId === folder.id)+ const folderDocs = (docsByFolderId.get(folder.id) ?? []).filter((doc) => doc.document.versions[0].type !== "notion").filter((doc) => doc.document.versions[0].storageType !== "VERCEL_BLOB",