Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.
fix: replace strict IP validation with browser fingerprint for dataroom sessions
Cursor Agent4acbeb8b488d
diff --git a/app/(ee)/api/workflow-entry/domains/[...domainSlug]/route.ts b/app/(ee)/api/workflow-entry/domains/[...domainSlug]/route.tsindex 685d3ad0..36ddc4bb 100644--- a/app/(ee)/api/workflow-entry/domains/[...domainSlug]/route.ts+++ b/app/(ee)/api/workflow-entry/domains/[...domainSlug]/route.ts@@ -9,7 +9,10 @@ import {import { ipAddress, waitUntil } from "@vercel/functions";import { z } from "zod";-import { createDataroomSession } from "@/lib/auth/dataroom-auth";+import {+ createDataroomSession,+ generateSessionFingerprint,+} from "@/lib/auth/dataroom-auth";import { createLinkSession } from "@/lib/auth/link-session";import { sendOtpVerificationEmail } from "@/lib/emails/send-email-otp-verification";import prisma from "@/lib/prisma";@@ -355,6 +358,10 @@ async function handleAccess(req: NextRequest, link: any) {executionResult.targetDataroomId &&viewer) {+ const fingerprint = generateSessionFingerprint(+ userAgent,+ req.headers.get("accept-language") ?? undefined,+ );const dataroomSession = await createDataroomSession(executionResult.targetDataroomId,executionResult.targetLinkId!,@@ -362,6 +369,7 @@ async function handleAccess(req: NextRequest, link: any) {ipAddressValue,true, // verifiedviewer.id,+ fingerprint,);cookies().set(diff --git a/app/(ee)/api/workflow-entry/link/[entryLinkId]/access/route.ts b/app/(ee)/api/workflow-entry/link/[entryLinkId]/access/route.tsindex f3156310..23b85824 100644--- a/app/(ee)/api/workflow-entry/link/[entryLinkId]/access/route.ts+++ b/app/(ee)/api/workflow-entry/link/[entryLinkId]/access/route.ts@@ -6,7 +6,10 @@ import { AccessRequestSchema } from "@/ee/features/workflows/lib/types";import { ipAddress } from "@vercel/functions";import { z } from "zod";-import { createDataroomSession } from "@/lib/auth/dataroom-auth";+import {+ createDataroomSession,+ generateSessionFingerprint,+} from "@/lib/auth/dataroom-auth";import { createLinkSession } from "@/lib/auth/link-session";import prisma from "@/lib/prisma";import { ratelimit } from "@/lib/redis";@@ -237,6 +240,10 @@ export async function POST(executionResult.targetDataroomId &&viewer) {+ const fingerprint = generateSessionFingerprint(+ userAgent,+ req.headers.get("accept-language") ?? undefined,+ );const dataroomSession = await createDataroomSession(executionResult.targetDataroomId,executionResult.targetLinkId!,@@ -244,6 +251,7 @@ export async function POST(ipAddressValue,true, // verifiedviewer.id,+ fingerprint,);cookies().set(diff --git a/app/api/views-dataroom/route.ts b/app/api/views-dataroom/route.tsindex e787a7c6..07e1b883 100644--- a/app/api/views-dataroom/route.ts+++ b/app/api/views-dataroom/route.ts@@ -11,6 +11,7 @@ import { hashToken } from "@/lib/api/auth/token";import {DataroomSession,createDataroomSession,+ generateSessionFingerprint,} from "@/lib/auth/dataroom-auth";import { verifyDataroomSession } from "@/lib/auth/dataroom-auth";import { PreviewSession, verifyPreviewSession } from "@/lib/auth/preview-auth";@@ -753,6 +754,10 @@ export async function POST(request: NextRequest) {// Create a dataroom session token if a dataroom session doesn't exist yetif (!dataroomSession && !isPreview) {+ const fingerprint = generateSessionFingerprint(+ request.headers.get("user-agent") ?? "unknown",+ request.headers.get("accept-language") ?? undefined,+ );const newDataroomSession = await createDataroomSession(link.dataroomId!,linkId,@@ -760,6 +765,7 @@ export async function POST(request: NextRequest) {ipAddress(request) ?? LOCALHOST_IP,isEmailVerified,viewer?.id,+ fingerprint,);let basePath = `/view/${linkId}`;@@ -1067,6 +1073,10 @@ export async function POST(request: NextRequest) {// Create a dataroom session token if a dataroom session doesn't exist yetif (!dataroomSession && !isPreview) {+ const fingerprint = generateSessionFingerprint(+ request.headers.get("user-agent") ?? "unknown",+ request.headers.get("accept-language") ?? undefined,+ );const newDataroomSession = await createDataroomSession(link.dataroomId!,linkId,@@ -1074,6 +1084,7 @@ export async function POST(request: NextRequest) {ipAddress(request) ?? LOCALHOST_IP,isEmailVerified,viewer?.id,+ fingerprint,);let basePath = `/view/${linkId}`;diff --git a/lib/auth/dataroom-auth.ts b/lib/auth/dataroom-auth.tsindex deae5689..3ef76619 100644--- a/lib/auth/dataroom-auth.ts+++ b/lib/auth/dataroom-auth.ts@@ -21,17 +21,46 @@ const COOKIE_EXPIRATION_TIME = 23 * 60 * 60 * 1000; // 23 hours*/function normalizeIp(ip: string): string {const trimmed = ip.trim();- // Treat all localhost variants as 127.0.0.1if (trimmed === "::1" || trimmed === "::ffff:127.0.0.1") {return LOCALHOST_IP;}- // Strip ::ffff: prefix from IPv4-mapped IPv6 addressesif (trimmed.startsWith("::ffff:")) {return trimmed.slice(7);}return trimmed;}+/**+ * Generate a stable browser fingerprint from request headers.+ * Uses User-Agent and Accept-Language which remain constant across IP changes+ * but differ between browsers/devices, preventing session sharing.+ */+export function generateSessionFingerprint(+ userAgent: string,+ acceptLanguage?: string,+): string {+ const raw = `${userAgent}|${acceptLanguage ?? ""}`;+ return crypto.createHash("sha256").update(raw).digest("hex");+}++function getFingerprintFromNextRequest(request: NextRequest): string {+ const ua = request.headers.get("user-agent") ?? "unknown";+ const lang = request.headers.get("accept-language") ?? undefined;+ return generateSessionFingerprint(ua, lang);+}++function getFingerprintFromPagesRequest(req: NextApiRequest): string {+ const ua =+ (Array.isArray(req.headers["user-agent"])+ ? req.headers["user-agent"][0]+ : req.headers["user-agent"]) ?? "unknown";+ const lang =+ (Array.isArray(req.headers["accept-language"])+ ? req.headers["accept-language"][0]+ : req.headers["accept-language"]) ?? undefined;+ return generateSessionFingerprint(ua, lang);+}+// Define the Zod schema for session dataexport const DataroomSessionSchema = z.object({linkId: z.string(),@@ -40,6 +69,7 @@ export const DataroomSessionSchema = z.object({viewerId: z.string().optional(),expiresAt: z.number(),ipAddress: z.string(),+ fingerprint: z.string().optional(),verified: z.boolean(),});@@ -53,6 +83,7 @@ async function createDataroomSession(ipAddress: string,verified: boolean,viewerId?: string,+ fingerprint?: string,): Promise<{ token: string; expiresAt: number }> {const sessionToken = crypto.randomBytes(32).toString("hex");const expiresAt = Date.now() + COOKIE_EXPIRATION_TIME;@@ -64,13 +95,12 @@ async function createDataroomSession(viewerId,expiresAt,ipAddress: normalizeIp(ipAddress),+ fingerprint,verified,};- // Validate session data before storingDataroomSessionSchema.parse(sessionData);- // Store session in Redisawait redis.set(`dataroom_session:${sessionToken}`,JSON.stringify(sessionData),@@ -99,20 +129,28 @@ async function verifyDataroomSession(try {const sessionData = DataroomSessionSchema.parse(session);- // Check if session is expiredif (sessionData.expiresAt < Date.now()) {await redis.del(`dataroom_session:${sessionToken}`);return null;}- const ipAddressValue = normalizeIp(ipAddress(request) ?? LOCALHOST_IP);-- if (ipAddressValue !== sessionData.ipAddress) {- await redis.del(`dataroom_session:${sessionToken}`);- return null;+ // Validate browser fingerprint instead of IP to handle VPN/network changes.+ // Sessions created before this change won't have a fingerprint; for those+ // we fall back to the legacy IP check for a smooth rollout.+ if (sessionData.fingerprint) {+ const currentFingerprint = getFingerprintFromNextRequest(request);+ if (currentFingerprint !== sessionData.fingerprint) {+ await redis.del(`dataroom_session:${sessionToken}`);+ return null;+ }+ } else {+ const ipAddressValue = normalizeIp(ipAddress(request) ?? LOCALHOST_IP);+ if (ipAddressValue !== sessionData.ipAddress) {+ await redis.del(`dataroom_session:${sessionToken}`);+ return null;+ }}- // Check if the session is for the correct link and dataroomif (sessionData.linkId !== linkId ||sessionData.dataroomId !== dataroomId@@ -123,7 +161,6 @@ async function verifyDataroomSession(return sessionData;} catch (error) {- // If validation fails, delete invalid session and return nullawait redis.del(`dataroom_session:${sessionToken}`);return null;}@@ -165,17 +202,25 @@ export async function getDataroomSessionByLinkIdInPagesRouter(try {const sessionData = DataroomSessionSchema.parse(session);- // Check if session is expiredif (sessionData.expiresAt < Date.now()) {await redis.del(`dataroom_session:${sessionToken}`);return null;}- // Get IP address from request- const ipAddressValue = normalizeIp(getIpAddress(req.headers) ?? LOCALHOST_IP);- if (ipAddressValue !== sessionData.ipAddress) {- await redis.del(`dataroom_session:${sessionToken}`);- return null;+ if (sessionData.fingerprint) {+ const currentFingerprint = getFingerprintFromPagesRequest(req);+ if (currentFingerprint !== sessionData.fingerprint) {+ await redis.del(`dataroom_session:${sessionToken}`);+ return null;+ }+ } else {+ const ipAddressValue = normalizeIp(+ getIpAddress(req.headers) ?? LOCALHOST_IP,+ );+ if (ipAddressValue !== sessionData.ipAddress) {+ await redis.del(`dataroom_session:${sessionToken}`);+ return null;+ }}if (sessionData.linkId !== linkId) {@@ -185,7 +230,6 @@ export async function getDataroomSessionByLinkIdInPagesRouter(return sessionData;} catch (error) {- // If validation fails, delete invalid session and return nullawait redis.del(`dataroom_session:${sessionToken}`);return null;}diff --git a/lib/auth/link-session.ts b/lib/auth/link-session.tsindex 42f596d1..28c425f6 100644--- a/lib/auth/link-session.ts+++ b/lib/auth/link-session.ts@@ -2,12 +2,10 @@import { cookies } from "next/headers";import { NextRequest } from "next/server";-import { ipAddress } from "@vercel/functions";import crypto from "crypto";import { z } from "zod";import { redis } from "@/lib/redis";-import { LOCALHOST_IP } from "@/lib/utils/geo";const COOKIE_EXPIRATION_TIME = 23 * 60 * 60 * 1000; // 23 hours@@ -105,14 +103,7 @@ export async function verifyLinkSession(return null;}- // Verify IP address- const currentIp = ipAddress(request) ?? LOCALHOST_IP;- if (currentIp !== sessionData.ipAddress) {- await deleteLinkSession(sessionToken, sessionData.viewerId);- return null;- }-- // Verify User Agent+ // Verify User Agent (stable across IP changes, prevents session sharing)const currentUserAgent = request.headers.get("user-agent") ?? "unknown";if (currentUserAgent !== sessionData.userAgent) {await deleteLinkSession(sessionToken, sessionData.viewerId);diff --git a/pages/api/links/download/verify.ts b/pages/api/links/download/verify.tsindex dfb82fab..42aa94d1 100644--- a/pages/api/links/download/verify.ts+++ b/pages/api/links/download/verify.ts@@ -4,6 +4,7 @@ import { parse } from "cookie";import {createDataroomSession,+ generateSessionFingerprint,getDataroomSessionByLinkIdInPagesRouter,updateDataroomSessionVerified,} from "@/lib/auth/dataroom-auth";@@ -185,6 +186,15 @@ export default async function handler(const needNewSession = async () => {if (!view.dataroomId) return;const ipAddressValue = getIpAddress(req.headers) ?? "unknown";+ const ua =+ (Array.isArray(req.headers["user-agent"])+ ? req.headers["user-agent"][0]+ : req.headers["user-agent"]) ?? "unknown";+ const lang =+ (Array.isArray(req.headers["accept-language"])+ ? req.headers["accept-language"][0]+ : req.headers["accept-language"]) ?? undefined;+ const fingerprint = generateSessionFingerprint(ua, lang);const { token, expiresAt } = await createDataroomSession(view.dataroomId,linkId,@@ -192,6 +202,7 @@ export default async function handler(ipAddressValue,true,view.viewerId ?? undefined,+ fingerprint,);sessionToken = token;const maxAge = Math.floor((expiresAt - Date.now()) / 1000);