Skip to content

Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.

feat: improve dataroom view lookup

Marc Seitz4eb8b7fce5a0
diff --git a/lib/trigger/export-visits.ts b/lib/trigger/export-visits.ts
index 5bd773b6..640e46ee 100644
--- a/lib/trigger/export-visits.ts
+++ b/lib/trigger/export-visits.ts
@@ -636,6 +636,7 @@ async function exportDataroomVisits(
}
exportData.push({
+ dataroomViewId: dataroomView.id, // Add the unique view ID for direct matching
dataroomViewedAt: dataroomView.viewedAt.toISOString(),
dataroomDownloadedAt: dataroomView.downloadedAt?.toISOString() || "NaN",
viewerName: dataroomView.viewerName || "NaN",
@@ -652,6 +653,12 @@ async function exportDataroomVisits(
});
}
+ // Create a map for efficient dataroom view lookups by ID
+ const dataroomViewMap = new Map();
+ dataroomViews.forEach((view) => {
+ dataroomViewMap.set(view.id, view);
+ });
+
// Get user agent data for all document views at once with rate limiting
const userAgentDataMap = new Map();
for (const docView of documentViews) {
@@ -731,13 +738,8 @@ async function exportDataroomVisits(
"NaN",
];
- // Add custom field values for this dataroom view
- const dataroomView = dataroomViews.find(
- (dv) =>
- dv.viewedAt.toISOString() === view.dataroomViewedAt &&
- (dv.viewerName || "NaN") === view.viewerName &&
- (dv.viewerEmail || "NaN") === view.viewerEmail,
- );
+ // Add custom field values for this dataroom view using direct ID lookup
+ const dataroomView = dataroomViewMap.get(view.dataroomViewId);
rowData.push(
...extractCustomFieldValues(dataroomView, uniqueCustomFields),
);
@@ -771,13 +773,8 @@ async function exportDataroomVisits(
userAgentData?.data[0]?.city || "NaN",
];
- // Add custom field values for this dataroom view
- const dataroomView = dataroomViews.find(
- (dv) =>
- dv.viewedAt.toISOString() === view.dataroomViewedAt &&
- (dv.viewerName || "NaN") === view.viewerName &&
- (dv.viewerEmail || "NaN") === view.viewerEmail,
- );
+ // Add custom field values for this dataroom view using direct ID lookup
+ const dataroomView = dataroomViewMap.get(view.dataroomViewId);
rowData.push(
...extractCustomFieldValues(dataroomView, uniqueCustomFields),
);