Skip to content

Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.

fix: O(n^2) issue

Marc Seitz63f1a2114941
diff --git a/pages/api/links/download/bulk.ts b/pages/api/links/download/bulk.ts
index 131aefd0..ea0411e6 100644
--- a/pages/api/links/download/bulk.ts
+++ b/pages/api/links/download/bulk.ts
@@ -202,22 +202,26 @@ export default async function handle(
});
}
- const permittedFolderIds = groupPermissions
- .filter(
- (permission) => permission.itemType === ItemType.DATAROOM_FOLDER,
- )
- .map((permission) => permission.itemId);
- const permittedDocumentIds = groupPermissions
- .filter(
- (permission) => permission.itemType === ItemType.DATAROOM_DOCUMENT,
- )
- .map((permission) => permission.itemId);
+ const permittedFolderIds = new Set(
+ groupPermissions
+ .filter(
+ (permission) => permission.itemType === ItemType.DATAROOM_FOLDER,
+ )
+ .map((permission) => permission.itemId),
+ );
+ const permittedDocumentIds = new Set(
+ groupPermissions
+ .filter(
+ (permission) => permission.itemType === ItemType.DATAROOM_DOCUMENT,
+ )
+ .map((permission) => permission.itemId),
+ );
downloadFolders = downloadFolders.filter((folder) =>
- permittedFolderIds.includes(folder.id),
+ permittedFolderIds.has(folder.id),
);
downloadDocuments = downloadDocuments.filter((doc) =>
- permittedDocumentIds.includes(doc.id),
+ permittedDocumentIds.has(doc.id),
);
}
diff --git a/pages/api/links/download/dataroom-folder.ts b/pages/api/links/download/dataroom-folder.ts
index dcd2be08..9923daf5 100644
--- a/pages/api/links/download/dataroom-folder.ts
+++ b/pages/api/links/download/dataroom-folder.ts
@@ -201,22 +201,26 @@ export default async function handler(
});
}
- const permittedFolderIds = groupPermissions
- .filter(
- (permission) => permission.itemType === ItemType.DATAROOM_FOLDER,
- )
- .map((permission) => permission.itemId);
- const permittedDocumentIds = groupPermissions
- .filter(
- (permission) => permission.itemType === ItemType.DATAROOM_DOCUMENT,
- )
- .map((permission) => permission.itemId);
+ const permittedFolderIds = new Set(
+ groupPermissions
+ .filter(
+ (permission) => permission.itemType === ItemType.DATAROOM_FOLDER,
+ )
+ .map((permission) => permission.itemId),
+ );
+ const permittedDocumentIds = new Set(
+ groupPermissions
+ .filter(
+ (permission) => permission.itemType === ItemType.DATAROOM_DOCUMENT,
+ )
+ .map((permission) => permission.itemId),
+ );
allFolders = allFolders.filter((folder) =>
- permittedFolderIds.includes(folder.id),
+ permittedFolderIds.has(folder.id),
);
allDocuments = allDocuments.filter((doc) =>
- permittedDocumentIds.includes(doc.id),
+ permittedDocumentIds.has(doc.id),
);
}