Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.
fix: scope folder delete/rename to authorized teamId
Marc Seitz6b66eb1fd31b
diff --git a/pages/api/teams/[teamId]/datarooms/[id]/reorder.ts b/pages/api/teams/[teamId]/datarooms/[id]/reorder.tsindex 365dd479..4d3c2e16 100644--- a/pages/api/teams/[teamId]/datarooms/[id]/reorder.ts+++ b/pages/api/teams/[teamId]/datarooms/[id]/reorder.ts@@ -3,6 +3,7 @@ import type { NextApiRequest, NextApiResponse } from "next";import { authOptions } from "@/pages/api/auth/[...nextauth]";import { getServerSession } from "next-auth/next";+import { enforceDataroomMemberScope } from "@/lib/api/rbac/guard";import prisma from "@/lib/prisma";import { CustomUser } from "@/lib/types";@@ -72,22 +73,21 @@ export default async function handler(}try {+ // Scoped members may only reorder within their assigned rooms.+ if (await enforceDataroomMemberScope({ userId, teamId, dataroomId, res })) {+ return;+ }+const team = await prisma.team.findUnique({- where: { id: teamId },- include: {- datarooms: {- where: { id: dataroomId },- },- users: {- where: {- role: { in: ["ADMIN", "MANAGER"] },- userId: userId,- },- },+ where: {+ id: teamId,+ users: { some: { userId } },+ datarooms: { some: { id: dataroomId } },},+ select: { id: true },});- if (!team || team.users.length === 0 || team.datarooms.length === 0) {+ if (!team) {return res.status(403).end("Forbidden");}diff --git a/pages/api/teams/[teamId]/folders/manage/[folderId]/index.ts b/pages/api/teams/[teamId]/folders/manage/[folderId]/index.tsindex 940a8528..acf412f1 100644--- a/pages/api/teams/[teamId]/folders/manage/[folderId]/index.ts+++ b/pages/api/teams/[teamId]/folders/manage/[folderId]/index.ts@@ -50,17 +50,13 @@ export default async function handle(});}- const folder = await prisma.folder.findUnique({+ const folder = await prisma.folder.findFirst({where: {id: folderId,+ teamId,},select: {- _count: {- select: {- documents: true,- childFolders: true,- },- },+ id: true,},});@@ -70,8 +66,7 @@ export default async function handle(});}- // Delete the folder and its contents- await deleteFolderAndContents(folderId, teamId);+ await deleteFolderAndContents(folder.id, teamId);return res.status(204).end(); // 204 No Content response for successful deletes} catch (error) {@@ -90,6 +85,10 @@ async function deleteFolderAndContents(folderId: string, teamId: string) {const childFoldersToDelete = await prisma.folder.findMany({where: {parentId: folderId,+ teamId,+ },+ select: {+ id: true,},});@@ -103,6 +102,7 @@ async function deleteFolderAndContents(folderId: string, teamId: string) {const documents = await prisma.document.findMany({where: {folderId: folderId,+ teamId,type: {notIn: ["notion", "link"],},@@ -119,7 +119,7 @@ async function deleteFolderAndContents(folderId: string, teamId: string) {},});- documents.map(async (documentVersions: { versions: any }) => {+ for (const documentVersions of documents) {for (const version of documentVersions.versions) {await deleteFile({type: version.storageType,@@ -127,18 +127,19 @@ async function deleteFolderAndContents(folderId: string, teamId: string) {teamId,});}- });+ }await prisma.document.deleteMany({where: {folderId: folderId,+ teamId,},});- // Delete the folder itself- await prisma.folder.delete({+ await prisma.folder.deleteMany({where: {id: folderId,+ teamId,},});}diff --git a/pages/api/teams/[teamId]/folders/manage/index.ts b/pages/api/teams/[teamId]/folders/manage/index.tsindex cd46c8e3..46721e7b 100644--- a/pages/api/teams/[teamId]/folders/manage/index.ts+++ b/pages/api/teams/[teamId]/folders/manage/index.ts@@ -67,11 +67,13 @@ export default async function handle(return res.status(401).end("Unauthorized");}- const folder = await prisma.folder.findUnique({+ const folder = await prisma.folder.findFirst({where: {id: folderId,+ teamId,},select: {+ id: true,name: true,path: true,icon: true,@@ -146,7 +148,7 @@ export default async function handle(// Now update the renamed folder itselfreturn tx.folder.update({where: {- id: folderId,+ id: folder.id,},data: updateData,});