Skip to content

Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.

Form-input space issue

Ashish Viradiya7f518e7aaae2
diff --git a/components/ui/form.tsx b/components/ui/form.tsx
index 469fd196..a4e4a84b 100644
--- a/components/ui/form.tsx
+++ b/components/ui/form.tsx
@@ -31,6 +31,7 @@ export function Form({
disabledTooltip,
handleSubmit,
validate,
+ defaultValue,
}: {
title: string;
description: string;
@@ -40,17 +41,18 @@ export function Form({
disabledTooltip?: string | ReactNode;
handleSubmit: (data: any) => Promise<any>;
validate?: (data: string) => boolean;
+ defaultValue?: string;
}) {
const [saving, setSaving] = useState(false);
- const [value, setValue] = useState(inputAttrs.defaultValue);
+ const [value, setValue] = useState(defaultValue);
useEffect(() => {
- if (inputAttrs.defaultValue) setValue(inputAttrs.defaultValue);
- }, [inputAttrs.defaultValue]);
+ if (defaultValue) setValue(defaultValue);
+ }, [defaultValue]);
const saveDisabled = useMemo(() => {
- return saving || !value || value === inputAttrs.defaultValue;
- }, [saving, value, inputAttrs.defaultValue]);
+ return saving || !value || value === defaultValue;
+ }, [saving, value, defaultValue]);
return (
<form
@@ -74,7 +76,7 @@ export function Form({
<CardDescription>{description}</CardDescription>
</CardHeader>
<CardContent>
- {typeof inputAttrs.defaultValue === "string" ? (
+ {typeof defaultValue === "string" ? (
<Input
{...inputAttrs}
value={value}
@@ -83,6 +85,11 @@ export function Form({
disabled={!!disabledTooltip}
onChange={(e) => setValue(e.target.value)}
onBlur={(e) => setValue(e.target.value.trim())}
+ onKeyDown={(e) =>
+ inputAttrs.type === "email" &&
+ e.key === " " &&
+ e.preventDefault()
+ }
className={cn(
"w-full max-w-md focus:border-gray-500 focus:outline-none focus:ring-gray-500",
{
diff --git a/pages/account/general.tsx b/pages/account/general.tsx
index b1aa5d0a..382f7536 100644
--- a/pages/account/general.tsx
+++ b/pages/account/general.tsx
@@ -23,10 +23,10 @@ const ProfilePage: NextPage = () => {
description="This will be your display name on Papermark.io."
inputAttrs={{
name: "name",
- defaultValue: session?.user?.name ?? "",
placeholder: "Dino Hems",
maxLength: 32,
}}
+ defaultValue={session?.user?.name ?? ""}
helpText="Max 32 characters."
handleSubmit={(data) =>
fetch("/api/account", {
@@ -51,11 +51,11 @@ const ProfilePage: NextPage = () => {
description="This will be the email you use to log in to Papermark.io and receive notification. A confirmation is required for changes."
inputAttrs={{
name: "email",
- defaultValue: session?.user?.email ?? undefined,
placeholder: "[email protected]",
maxLength: 52,
type: "email",
}}
+ defaultValue={session?.user?.email ?? ""}
// TODO: MAIL SUBSCRIPTION
// helpText={<UpdateMailSubscribe />}
validate={validateEmail}
diff --git a/pages/datarooms/[id]/groups/[groupId]/index.tsx b/pages/datarooms/[id]/groups/[groupId]/index.tsx
index b5f0307b..31f2a66d 100644
--- a/pages/datarooms/[id]/groups/[groupId]/index.tsx
+++ b/pages/datarooms/[id]/groups/[groupId]/index.tsx
@@ -48,10 +48,10 @@ export default function DataroomGroupPage() {
description="This is the name of your data room group on Papermark."
inputAttrs={{
name: "name",
- defaultValue: viewerGroup?.name,
placeholder: "e.g. Management Team",
maxLength: 32,
}}
+ defaultValue={viewerGroup?.name ?? ""}
helpText="Max 32 characters"
handleSubmit={(updateData) =>
fetch(
diff --git a/pages/datarooms/[id]/permissions/[groupId]/index.tsx b/pages/datarooms/[id]/permissions/[groupId]/index.tsx
index b5f0307b..31f2a66d 100644
--- a/pages/datarooms/[id]/permissions/[groupId]/index.tsx
+++ b/pages/datarooms/[id]/permissions/[groupId]/index.tsx
@@ -48,10 +48,10 @@ export default function DataroomGroupPage() {
description="This is the name of your data room group on Papermark."
inputAttrs={{
name: "name",
- defaultValue: viewerGroup?.name,
placeholder: "e.g. Management Team",
maxLength: 32,
}}
+ defaultValue={viewerGroup?.name ?? ""}
helpText="Max 32 characters"
handleSubmit={(updateData) =>
fetch(
diff --git a/pages/datarooms/[id]/settings/index.tsx b/pages/datarooms/[id]/settings/index.tsx
index 33be77aa..195b9679 100644
--- a/pages/datarooms/[id]/settings/index.tsx
+++ b/pages/datarooms/[id]/settings/index.tsx
@@ -58,10 +58,10 @@ export default function Settings() {
description="This is the name of your data room on Papermark."
inputAttrs={{
name: "name",
- defaultValue: dataroom.name,
placeholder: "My Dataroom",
maxLength: 32,
}}
+ defaultValue={dataroom.name}
helpText="Max 32 characters"
handleSubmit={(updateData) =>
fetch(`/api/teams/${teamId}/datarooms/${dataroom.id}`, {
diff --git a/pages/settings/general.tsx b/pages/settings/general.tsx
index 62d531bd..1c57e36e 100644
--- a/pages/settings/general.tsx
+++ b/pages/settings/general.tsx
@@ -29,10 +29,10 @@ export default function General() {
description="This is the name of your team on Papermark."
inputAttrs={{
name: "name",
- defaultValue: teamInfo?.currentTeam?.name,
placeholder: "My Personal Team",
maxLength: 32,
}}
+ defaultValue={teamInfo?.currentTeam?.name ?? ""}
helpText="Max 32 characters."
handleSubmit={(updateData) =>
fetch(`/api/teams/${teamInfo?.currentTeam?.id}/update-name`, {