Skip to content

Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.

fix: ignore allowlist/denylist from group links via presets

Marc Seitz81a3d139a247
diff --git a/components/links/link-sheet/index.tsx b/components/links/link-sheet/index.tsx
index 06987bf1..987a92f8 100644
--- a/components/links/link-sheet/index.tsx
+++ b/components/links/link-sheet/index.tsx
@@ -235,6 +235,8 @@ export default function LinkSheet({
if (!preset) return;
setData((prev) => {
+ const isGroupLink = prev.audienceType === LinkAudienceType.GROUP;
+
return {
...prev,
name: prev.name, // Keep existing name
@@ -243,8 +245,13 @@ export default function LinkSheet({
emailProtected: preset.emailProtected ?? prev.emailProtected,
emailAuthenticated:
preset.emailAuthenticated ?? prev.emailAuthenticated,
- allowList: preset.allowList || prev.allowList,
- denyList: preset.denyList || prev.denyList,
+ // For group links, ignore allow/deny lists from presets as access is controlled by group membership
+ allowList: isGroupLink
+ ? prev.allowList
+ : preset.allowList || prev.allowList,
+ denyList: isGroupLink
+ ? prev.denyList
+ : preset.denyList || prev.denyList,
password: preset.password || prev.password,
enableCustomMetatag:
preset.enableCustomMetaTag ?? prev.enableCustomMetatag,
diff --git a/ee/features/permissions/components/dataroom-link-sheet.tsx b/ee/features/permissions/components/dataroom-link-sheet.tsx
index 5ac03c01..e2396be0 100644
--- a/ee/features/permissions/components/dataroom-link-sheet.tsx
+++ b/ee/features/permissions/components/dataroom-link-sheet.tsx
@@ -187,6 +187,8 @@ export function DataroomLinkSheet({
if (!preset) return;
setData((prev) => {
+ const isGroupLink = prev.audienceType === LinkAudienceType.GROUP;
+
return {
...prev,
name: prev.name, // Keep existing name
@@ -195,8 +197,13 @@ export function DataroomLinkSheet({
emailProtected: preset.emailProtected ?? prev.emailProtected,
emailAuthenticated:
preset.emailAuthenticated ?? prev.emailAuthenticated,
- allowList: preset.allowList || prev.allowList,
- denyList: preset.denyList || prev.denyList,
+ // For group links, ignore allow/deny lists from presets as access is controlled by group membership
+ allowList: isGroupLink
+ ? prev.allowList
+ : preset.allowList || prev.allowList,
+ denyList: isGroupLink
+ ? prev.denyList
+ : preset.denyList || prev.denyList,
password: preset.password || prev.password,
enableCustomMetatag:
preset.enableCustomMetaTag ?? prev.enableCustomMetatag,
diff --git a/pages/api/webhooks/services/[...path]/index.ts b/pages/api/webhooks/services/[...path]/index.ts
index 170df98b..d41131ef 100644
--- a/pages/api/webhooks/services/[...path]/index.ts
+++ b/pages/api/webhooks/services/[...path]/index.ts
@@ -446,8 +446,13 @@ async function handleDocumentCreate(
enableScreenshotProtection: link.enableScreenshotProtection,
audienceType: link.audienceType,
groupId: isGroupAudience ? link.groupId : null,
- allowList: link.allowList || preset?.allowList,
- denyList: link.denyList || preset?.denyList,
+ // For group links, ignore allow/deny lists from presets as access is controlled by group membership
+ allowList: isGroupAudience
+ ? link.allowList
+ : link.allowList || preset?.allowList,
+ denyList: isGroupAudience
+ ? link.denyList
+ : link.denyList || preset?.denyList,
...(preset?.enableCustomMetaTag && {
enableCustomMetatag: preset?.enableCustomMetaTag,
metaTitle: preset?.metaTitle,
@@ -652,8 +657,13 @@ async function handleLinkCreate(
enableScreenshotProtection: link.enableScreenshotProtection,
audienceType: link.audienceType,
groupId: isGroupAudience ? link.groupId : null,
- allowList: link.allowList || preset?.allowList,
- denyList: link.denyList || preset?.denyList,
+ // For group links, ignore allow/deny lists from presets as access is controlled by group membership
+ allowList: isGroupAudience
+ ? link.allowList
+ : link.allowList || preset?.allowList,
+ denyList: isGroupAudience
+ ? link.denyList
+ : link.denyList || preset?.denyList,
...(preset?.enableCustomMetaTag && {
enableCustomMetatag: preset?.enableCustomMetaTag,
metaTitle: preset?.metaTitle,