Skip to content

Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.

fix(documents): upload new version against correct document id in dataroom view

Marc Seitz8dc80f7ed650
diff --git a/components/documents/add-document-modal.tsx b/components/documents/add-document-modal.tsx
index 3cfab3cc..74cb8a59 100644
--- a/components/documents/add-document-modal.tsx
+++ b/components/documents/add-document-modal.tsx
@@ -59,6 +59,7 @@ export function AddDocumentModal({
children,
isDataroom,
dataroomId,
+ documentId: documentIdProp,
setAddDocumentModalOpen,
openModal,
defaultTab = "document",
@@ -69,6 +70,13 @@ export function AddDocumentModal({
isDataroom?: boolean;
openModal?: boolean;
dataroomId?: string;
+ /**
+ * Explicit document id to upload a new version against. Required on routes
+ * where `router.query.id` is not the document id (e.g. the dataroom document
+ * view at `/datarooms/[id]/document/[documentId]`, where it is the dataroom
+ * id). Falls back to `router.query.id` when omitted.
+ */
+ documentId?: string;
setAddDocumentModalOpen?: (isOpen: boolean) => void;
/** Initial tab shown when the modal opens. */
defaultTab?: "document" | "notion";
@@ -354,7 +362,7 @@ export function AddDocumentModal({
});
} else {
// create a new version for existing document in the database
- const documentId = router.query.id as string;
+ const documentId = documentIdProp ?? (router.query.id as string);
response = await createNewDocumentVersion({
documentData,
documentId,
diff --git a/components/documents/document-header.tsx b/components/documents/document-header.tsx
index c910637d..cbb9b708 100644
--- a/components/documents/document-header.tsx
+++ b/components/documents/document-header.tsx
@@ -662,6 +662,7 @@ export default function DocumentHeader({
primaryVersion.type !== "link" && (
<AddDocumentModal
newVersion
+ documentId={prismaDocument.id}
openModal={openAddDocModal}
setAddDocumentModalOpen={setOpenAddDocModal}
>
@@ -751,6 +752,7 @@ export default function DocumentHeader({
<DropdownMenuItem>
<AddDocumentModal
newVersion
+ documentId={prismaDocument.id}
setAddDocumentModalOpen={setAddDocumentVersion}
>
<button