Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.
refactor(trigger): throw errors where necessary
Marc Seitz95ff50d54913
diff --git a/jobs/convert-pdf-to-image.ts b/jobs/convert-pdf-to-image.tsindex 1e1c2138..741f7708 100644--- a/jobs/convert-pdf-to-image.ts+++ b/jobs/convert-pdf-to-image.ts@@ -3,6 +3,7 @@ import { eventTrigger, retry } from "@trigger.dev/sdk";import { z } from "zod";import prisma from "@/lib/prisma";import { getFile } from "@/lib/files/get-file";+import { error } from "console";client.defineJob({id: "convert-pdf-to-image",@@ -40,11 +41,24 @@ client.defineJob({return;}+ // 2. get signed url from file+ const signedUrl = await io.runTask("get-signed-url", async () => {+ return await getFile({+ type: documentUrl.storageType,+ data: documentUrl.file,+ });+ });++ if (!signedUrl) {+ await io.logger.error("Failed to get signed url", { payload });+ return;+ }+let numPages = documentUrl.numPages;// skip if the numPages are already definedif (!numPages) {- // 2. send file to api/convert endpoint in a task and get back number of pages+ // 3. send file to api/convert endpoint in a task and get back number of pagesconst muDocument = await io.runTask("get-number-of-pages", async () => {const response = await fetch(`${process.env.NEXT_PUBLIC_BASE_URL}/api/mupdf/get-pages`,@@ -70,23 +84,14 @@ client.defineJob({numPages = muDocument.numPages;}- // 3. get signed url from file- const signedUrl = await io.runTask("get-signed-url", async () => {- return await getFile({- type: documentUrl.storageType,- data: documentUrl.file,- });- });-- if (!signedUrl) {- await io.logger.error("Failed to get signed url", { payload });- return;- }-// 4. iterate through pages and upload to blob in a tasklet currentPage = 0;+ let conversionWithoutError = true;for (var i = 0; i < numPages; ++i) {currentPage = i + 1;+ if (!conversionWithoutError) {+ break;+ }await io.runTask(`upload-page-${currentPage}`,async () => {@@ -127,9 +132,18 @@ client.defineJob({return { documentPageId, payload };},{ retry: retry.standardBackoff },+ (error) => {+ conversionWithoutError = false;+ return { error: error as Error };+ },);}+ if (!conversionWithoutError) {+ await io.logger.error("Failed to process pages", { payload });+ return { success: false, message: "Failed to process pages" };+ }+// 5. after all pages are uploaded, update document version to hasPages = trueawait io.runTask("enable-pages", async () => {return prisma.documentVersion.update({diff --git a/pages/api/mupdf/convert-page.ts b/pages/api/mupdf/convert-page.tsindex 503e279c..a0854d8a 100644--- a/pages/api/mupdf/convert-page.ts+++ b/pages/api/mupdf/convert-page.ts@@ -8,6 +8,7 @@ import { log } from "@/lib/utils";// This function can run for a maximum of 60 secondsexport const config = {maxDuration: 120,+ memory: 2048,};export default async (req: NextApiRequest, res: NextApiResponse) => {@@ -45,9 +46,7 @@ export default async (req: NextApiRequest, res: NextApiResponse) => {type: "error",mention: true,});- return res- .status(500)- .json({ error: `Failed to upload document page ${pageNumber}` });+ throw new Error(`Failed to fetch pdf on document page ${pageNumber}`);}// Convert the response to an ArrayBuffer@@ -88,10 +87,7 @@ export default async (req: NextApiRequest, res: NextApiResponse) => {});if (!data || !type) {- res- .status(500)- .json({ error: `Failed to upload document page ${pageNumber}` });- return;+ throw new Error(`Failed to upload document page ${pageNumber}`);}const documentPage = await prisma.documentPage.create({@@ -111,12 +107,13 @@ export default async (req: NextApiRequest, res: NextApiResponse) => {// Send the images as a responseres.status(200).json({ documentPageId: documentPage.id });+ return;} catch (error) {log({message: `Failed to convert page with error: \n\n Error: ${error} \n\n \`Metadata: {teamId: ${teamId}, documentVersionId: ${documentVersionId}, pageNumber: ${pageNumber}}\``,type: "error",mention: true,});- res.status(500).json({ error: "Internal Server Error" });+ throw error;}};