Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.
faet: improve API key validation with timing-safe comparison
Marc Seitza0a1541090d9
diff --git a/ee/features/billing/cancellation/api/automatic-unpause-route.ts b/ee/features/billing/cancellation/api/automatic-unpause-route.tsindex afb8d898..abf75e56 100644--- a/ee/features/billing/cancellation/api/automatic-unpause-route.ts+++ b/ee/features/billing/cancellation/api/automatic-unpause-route.ts@@ -3,6 +3,7 @@ import { NextApiRequest, NextApiResponse } from "next";import { stripeInstance } from "@/ee/stripe";import { isOldAccount } from "@/ee/stripe/utils";import { waitUntil } from "@vercel/functions";+import { timingSafeEqual } from "crypto";import prisma from "@/lib/prisma";import { log } from "@/lib/utils";@@ -19,12 +20,36 @@ export async function handleRoute(req: NextApiRequest, res: NextApiResponse) {return;}- // Extract the API Key from the Authorization header+ // Extract the API Key from the Authorization header with strict Bearer parsingconst authHeader = req.headers.authorization;- const token = authHeader?.split(" ")[1]; // Assuming the format is "Bearer [token]"- // Check if the API Key matches- if (token !== process.env.INTERNAL_API_KEY) {+ // Verify Authorization header exists and starts with "Bearer "+ if (!authHeader || !authHeader.startsWith("Bearer ")) {+ res.status(401).json({ message: "Unauthorized" });+ return;+ }++ // Extract token after "Bearer " prefix+ const token = authHeader.substring(7); // "Bearer ".length === 7+ const envKey = process.env.INTERNAL_API_KEY;++ // Verify both token and environment key are present and have equal length+ if (!token || !envKey || token.length !== envKey.length) {+ res.status(401).json({ message: "Unauthorized" });+ return;+ }++ // Perform timing-safe comparison using Buffers+ try {+ const tokenBuffer = Buffer.from(token, "utf8");+ const envKeyBuffer = Buffer.from(envKey, "utf8");++ if (!timingSafeEqual(tokenBuffer, envKeyBuffer)) {+ res.status(401).json({ message: "Unauthorized" });+ return;+ }+ } catch (error) {+ // Handle any Buffer creation errorsres.status(401).json({ message: "Unauthorized" });return;}