Skip to content

Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.

fix: avoid double renders

Marc Seitzbe7a2fb5873f
diff --git a/components/datarooms/export-visits-modal.tsx b/components/datarooms/export-visits-modal.tsx
index 55997755..309901ad 100644
--- a/components/datarooms/export-visits-modal.tsx
+++ b/components/datarooms/export-visits-modal.tsx
@@ -16,7 +16,6 @@ interface ExportVisitsModalProps {
dataroomName: string;
groupId?: string;
groupName?: string;
- // Remove isVisible - if component is rendered, it should start
onClose: () => void;
}
@@ -26,7 +25,6 @@ export function ExportVisitsModal({
dataroomName,
groupId,
groupName,
- // Remove isVisible parameter
onClose,
}: ExportVisitsModalProps) {
const { data: session } = useSession();
@@ -34,6 +32,7 @@ export function ExportVisitsModal({
const [showModal, setShowModal] = useState(false);
const [viewCount, setViewCount] = useState<number | null>(null);
const pollIntervalRef = useRef<NodeJS.Timeout | null>(null);
+ const exportStartedRef = useRef<boolean>(false);
// Cleanup interval on component unmount
useEffect(() => {
@@ -45,6 +44,13 @@ export function ExportVisitsModal({
}, []);
const startExport = useCallback(async () => {
+ // Prevent double triggering
+ if (exportStartedRef.current) {
+ console.warn("Export already started, skipping duplicate request");
+ return;
+ }
+ exportStartedRef.current = true;
+
try {
// Show modal immediately
setShowModal(true);
@@ -164,9 +170,9 @@ export function ExportVisitsModal({
toast.error(
"An error occurred while starting the export. Please try again.",
);
- onClose();
+ handleClose();
}
- }, [teamId, dataroomId, groupId, dataroomName, groupName, onClose]);
+ }, [teamId, dataroomId, groupId, dataroomName, groupName]);
// Start export immediately when component mounts
useEffect(() => {
@@ -203,6 +209,7 @@ export function ExportVisitsModal({
}
setShowModal(false);
setExportStatus(null);
+ exportStartedRef.current = false; // Reset for potential reuse
onClose();
};
diff --git a/components/documents/export-visits-modal.tsx b/components/documents/export-visits-modal.tsx
index 665f216c..1d7dd0c7 100644
--- a/components/documents/export-visits-modal.tsx
+++ b/components/documents/export-visits-modal.tsx
@@ -14,14 +14,12 @@ interface ExportStatus {
interface ExportVisitsModalProps {
document: Document;
teamId: string;
- // Remove isVisible - if component is rendered, it should start
onClose: () => void;
}
export function ExportVisitsModal({
document,
teamId,
- // Remove isVisible parameter
onClose,
}: ExportVisitsModalProps) {
const { data: session } = useSession();
@@ -29,6 +27,7 @@ export function ExportVisitsModal({
const [showModal, setShowModal] = useState(false);
const [viewCount, setViewCount] = useState<number | null>(null);
const pollIntervalRef = useRef<NodeJS.Timeout | null>(null);
+ const exportStartedRef = useRef<boolean>(false);
// Cleanup interval on component unmount
useEffect(() => {
@@ -40,6 +39,13 @@ export function ExportVisitsModal({
}, []);
const startExport = useCallback(async () => {
+ // Prevent double triggering
+ if (exportStartedRef.current) {
+ console.warn("Export already started, skipping duplicate request");
+ return;
+ }
+ exportStartedRef.current = true;
+
try {
// Show modal immediately
setShowModal(true);
@@ -159,9 +165,9 @@ export function ExportVisitsModal({
toast.error(
"An error occurred while starting the export. Please try again.",
);
- onClose();
+ handleClose();
}
- }, [document.id, teamId, onClose]);
+ }, [document.id, teamId]);
// Start export immediately when component mounts
useEffect(() => {
@@ -198,6 +204,7 @@ export function ExportVisitsModal({
}
setShowModal(false);
setExportStatus(null);
+ exportStartedRef.current = false; // Reset for potential reuse
onClose();
};