Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.
refactor: improve prisma queries across the board
Marc Seitzca071cdfd67d
diff --git a/pages/api/teams/[teamId]/documents/search.ts b/pages/api/teams/[teamId]/documents/search.tsindex 2db23d26..69bd0018 100644--- a/pages/api/teams/[teamId]/documents/search.ts+++ b/pages/api/teams/[teamId]/documents/search.ts@@ -21,21 +21,20 @@ export default async function handle(const userId = (session.user as CustomUser).id;try {- const team = await prisma.team.findUnique({+ const teamAccess = await prisma.userTeam.findUnique({where: {- id: teamId,- users: {- some: {- userId: userId,- },+ userId_teamId: {+ userId: userId,+ teamId: teamId,},},});- if (!team) {- return res.status(404).end("Team not found");+ if (!teamAccess) {+ return res.status(401).end("Unauthorized");}+ // First, get documents without expensive countsconst documents = await prisma.document.findMany({where: {teamId: teamId,@@ -47,14 +46,57 @@ export default async function handle(orderBy: {createdAt: "desc",},- include: {- _count: {- select: { links: true, views: true, versions: true },+ });++ // Then, get counts efficiently with separate GROUP BY queries+ const documentIds = documents.map((d) => d.id);++ const [linkCounts, viewCounts, versionCounts] = await Promise.all([+ prisma.link.groupBy({+ by: ["documentId"],+ where: {+ documentId: { in: documentIds },+ },+ _count: { id: true },+ }),+ prisma.view.groupBy({+ by: ["documentId"],+ where: {+ documentId: { in: documentIds },},+ _count: { id: true },+ }),+ prisma.documentVersion.groupBy({+ by: ["documentId"],+ where: {+ documentId: { in: documentIds },+ },+ _count: { id: true },+ }),+ ]);++ // Create lookup maps for counts+ const linkCountMap = new Map(+ linkCounts.map((lc) => [lc.documentId, lc._count.id]),+ );+ const viewCountMap = new Map(+ viewCounts.map((vc) => [vc.documentId, vc._count.id]),+ );+ const versionCountMap = new Map(+ versionCounts.map((vsc) => [vsc.documentId, vsc._count.id]),+ );++ // Combine documents with their counts+ const documentsWithCounts = documents.map((document) => ({+ ...document,+ _count: {+ links: linkCountMap.get(document.id) || 0,+ views: viewCountMap.get(document.id) || 0,+ versions: versionCountMap.get(document.id) || 0,},- });+ }));- return res.status(200).json(documents);+ return res.status(200).json(documentsWithCounts);} catch (error) {errorhandler(error, res);}diff --git a/pages/api/teams/[teamId]/folders/[...name].ts b/pages/api/teams/[teamId]/folders/[...name].tsindex 7ed955b1..84c26305 100644--- a/pages/api/teams/[teamId]/folders/[...name].ts+++ b/pages/api/teams/[teamId]/folders/[...name].ts@@ -35,18 +35,16 @@ export default async function handle(try {// Check if the user is part of the team- const team = await prisma.team.findUnique({+ const teamAccess = await prisma.userTeam.findUnique({where: {- id: teamId,- users: {- some: {- userId: userId,- },+ userId_teamId: {+ userId: userId,+ teamId: teamId,},},});- if (!team) {+ if (!teamAccess) {return res.status(401).end("Unauthorized");}diff --git a/pages/api/teams/[teamId]/folders/documents/[...name].ts b/pages/api/teams/[teamId]/folders/documents/[...name].tsindex bba258c3..6aaf1723 100644--- a/pages/api/teams/[teamId]/folders/documents/[...name].ts+++ b/pages/api/teams/[teamId]/folders/documents/[...name].ts@@ -74,12 +74,6 @@ export default async function handle(orderBy: {createdAt: "desc",},- include: {- links: {- take: 1,- select: { id: true },- },- },});// Then, get counts efficiently with separate GROUP BY queriesdiff --git a/pages/api/teams/[teamId]/folders/index.ts b/pages/api/teams/[teamId]/folders/index.tsindex 93af3533..7a21291f 100644--- a/pages/api/teams/[teamId]/folders/index.ts+++ b/pages/api/teams/[teamId]/folders/index.ts@@ -23,18 +23,16 @@ export default async function handle(try {// Check if the user is part of the team- const team = await prisma.team.findUnique({+ const teamAccess = await prisma.userTeam.findUnique({where: {- id: teamId,- users: {- some: {- userId: userId,- },+ userId_teamId: {+ userId: userId,+ teamId: teamId,},},});- if (!team) {+ if (!teamAccess) {return res.status(401).end("Unauthorized");}@@ -109,18 +107,16 @@ export default async function handle(try {// Check if the user is part of the team- const team = await prisma.team.findUnique({+ const teamAccess = await prisma.userTeam.findUnique({where: {- id: teamId,- users: {- some: {- userId: userId,- },+ userId_teamId: {+ userId: userId,+ teamId: teamId,},},});- if (!team) {+ if (!teamAccess) {return res.status(401).end("Unauthorized");}diff --git a/pages/api/teams/[teamId]/folders/move.ts b/pages/api/teams/[teamId]/folders/move.tsindex 9c424f42..b4e25a78 100644--- a/pages/api/teams/[teamId]/folders/move.ts+++ b/pages/api/teams/[teamId]/folders/move.ts@@ -27,18 +27,16 @@ export default async function handle(};// Ensure the user is an admin of the team- const team = await prisma.team.findUnique({- where: { id: teamId },- include: {- users: {- where: {- userId: userId,- },+ const teamAccess = await prisma.userTeam.findUnique({+ where: {+ userId_teamId: {+ userId: userId,+ teamId: teamId,},},});- if (!team || team.users.length === 0) {+ if (!teamAccess) {return res.status(403).end("Forbidden");}diff --git a/pages/api/teams/[teamId]/folders/parents/[...name].ts b/pages/api/teams/[teamId]/folders/parents/[...name].tsindex 9226f7dc..3e28b2d1 100644--- a/pages/api/teams/[teamId]/folders/parents/[...name].ts+++ b/pages/api/teams/[teamId]/folders/parents/[...name].ts@@ -35,18 +35,16 @@ export default async function handle(try {// Check if the user is part of the team- const team = await prisma.team.findUnique({+ const teamAccess = await prisma.userTeam.findUnique({where: {- id: teamId,- users: {- some: {- userId: userId,- },+ userId_teamId: {+ userId: userId,+ teamId: teamId,},},});- if (!team) {+ if (!teamAccess) {return res.status(401).end("Unauthorized");}